🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
chore(eslint): Extend `@repo/no-abstracted-overlay-trigger` (#16548)
Ben Bachem68fc51d05e50
diff --git a/packages/config-eslint/next.js b/packages/config-eslint/next.jsindex 287974a1cf..ef57cb87c0 100644--- a/packages/config-eslint/next.js+++ b/packages/config-eslint/next.js@@ -169,4 +169,15 @@ export default ["react/no-unused-prop-types": "warn",},},+ {+ name: "langfuse/next/tests-and-stories",+ files: [+ "**/*.test.{ts,tsx}",+ "**/*.story.{ts,tsx}",+ "**/*.stories.{ts,tsx}",+ ],+ rules: {+ "@repo/no-abstracted-overlay-trigger": "off",+ },+ },];diff --git a/packages/eslint-plugin/src/rules/no-abstracted-overlay-trigger.test.ts b/packages/eslint-plugin/src/rules/no-abstracted-overlay-trigger.test.tsindex 600595d93e..97d99c5ec8 100644--- a/packages/eslint-plugin/src/rules/no-abstracted-overlay-trigger.test.ts+++ b/packages/eslint-plugin/src/rules/no-abstracted-overlay-trigger.test.ts@@ -193,6 +193,30 @@ ruleTester.run("no-abstracted-overlay-trigger", rule, {`,],invalid: [+ {+ code: `+ import {+ Drawer,+ DrawerContent,+ DrawerTrigger,+ } from "@/src/components/ui/drawer";++ export function AnnotateDrawer() {+ return (+ <Drawer>+ <DrawerTrigger />+ <DrawerContent />+ </Drawer>+ );+ }+ `,+ errors: [+ {+ messageId: "abstractedTrigger",+ data: { overlay: "Drawer" },+ },+ ],+ },{code: `import {diff --git a/packages/eslint-plugin/src/rules/no-abstracted-overlay-trigger.ts b/packages/eslint-plugin/src/rules/no-abstracted-overlay-trigger.tsindex dd32d70c0e..ae9f3ccf82 100644--- a/packages/eslint-plugin/src/rules/no-abstracted-overlay-trigger.ts+++ b/packages/eslint-plugin/src/rules/no-abstracted-overlay-trigger.ts@@ -22,6 +22,12 @@ const OVERLAY_FAMILIES = [trigger: "DropdownMenuTrigger",contents: ["DropdownMenuContent", "DropdownMenuSubContent"],},+ {+ module: "@/src/components/ui/drawer",+ root: "Drawer",+ trigger: "DrawerTrigger",+ contents: ["DrawerContent"],+ },{module: "@/src/components/ui/popover",root: "Popover",diff --git a/web/src/features/comments/CommentDrawerButton.tsx b/web/src/features/comments/CommentDrawerButton.tsxindex bb133ea6df..4b80d36af9 100644--- a/web/src/features/comments/CommentDrawerButton.tsx+++ b/web/src/features/comments/CommentDrawerButton.tsx@@ -1,4 +1,4 @@-/* eslint-disable @repo/no-style-props */+/* eslint-disable @repo/no-style-props, @repo/no-abstracted-overlay-trigger */import Header from "@/src/components/layouts/header";import { ActionButtonCountBadge } from "@/src/components/ui/action-button-count-badge";import { Button, type ButtonProps } from "@/src/components/ui/button";diff --git a/web/src/features/scores/components/AnnotateDrawer.tsx b/web/src/features/scores/components/AnnotateDrawer.tsxindex 7157279be0..1baee58f5d 100644--- a/web/src/features/scores/components/AnnotateDrawer.tsx+++ b/web/src/features/scores/components/AnnotateDrawer.tsx@@ -1,3 +1,4 @@+/* eslint-disable @repo/no-abstracted-overlay-trigger */import React from "react";import { ActionButtonCountBadge } from "@/src/components/ui/action-button-count-badge";import { Button } from "@/src/components/ui/button";