🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(worker): log batch retention outcomes (#19166)
Valery Meleshkin69e68ab29ae2
diff --git a/worker/src/features/batch-data-retention-cleaner/index.ts b/worker/src/features/batch-data-retention-cleaner/index.tsindex 501a317b9e..72ffb275ed 100644--- a/worker/src/features/batch-data-retention-cleaner/index.ts+++ b/worker/src/features/batch-data-retention-cleaner/index.ts@@ -33,7 +33,8 @@ export const BATCH_DATA_RETENTION_TABLES = [export type BatchDataRetentionTable =(typeof BATCH_DATA_RETENTION_TABLES)[number];-const METRIC_PREFIX = "langfuse.batch_data_retention_cleaner";+const RUNNER_NAME = "batch_data_retention_cleaner";+const METRIC_PREFIX = `langfuse.${RUNNER_NAME}`;const BATCH_DATA_RETENTION_CLEANER_LOCK_PREFIX ="langfuse:batch-data-retention-cleaner";@@ -156,6 +157,7 @@ function buildRetentionConditions(export class BatchDataRetentionCleaner extends PeriodicExclusiveRunner {private readonly tableName: BatchDataRetentionTable;private readonly candidateQueryHttpTimeoutSeconds: number;+ private runOutcome: "success" | "failed" | "skipped" = "success";protected get defaultIntervalMs(): number {return env.LANGFUSE_BATCH_DATA_RETENTION_CLEANER_INTERVAL_MS;@@ -176,7 +178,7 @@ export class BatchDataRetentionCleaner extends PeriodicExclusiveRunner {super({name: `BatchDataRetentionCleaner(${tableName})`,- metricName: "batch_data_retention_cleaner",+ metricName: RUNNER_NAME,metricScope: tableName,lockKey: `${BATCH_DATA_RETENTION_CLEANER_LOCK_PREFIX}:${tableName}`,lockTtlSeconds,@@ -210,6 +212,31 @@ export class BatchDataRetentionCleaner extends PeriodicExclusiveRunner {* Preflight and deletion are both under lock to avoid redundant expensive queries.*/protected async execute(): Promise<void> {+ this.runOutcome = "success";+ const startedAt = Date.now();+ try {+ await this.executeRetentionBatch();+ } catch (error) {+ this.runOutcome = "failed";+ throw error;+ } finally {+ this.logCompletion(Date.now() - startedAt);+ }+ }++ protected override markRunFailed(error: unknown): void {+ this.runOutcome = "failed";+ super.markRunFailed(error);+ }++ protected override markRunSkipped(): void {+ if (this.runOutcome === "success") {+ this.runOutcome = "skipped";+ }+ super.markRunSkipped();+ }++ private async executeRetentionBatch(): Promise<void> {// Data retention is an enterprise feature. Without a license the setting// cannot be viewed or changed, so stored policies must not be enforced// either: a deployment that loses its license would otherwise keep@@ -313,6 +340,20 @@ export class BatchDataRetentionCleaner extends PeriodicExclusiveRunner {);}+ private logCompletion(durationMs: number): void {+ try {+ logger.info(`${this.instanceName}: Retention run completed`, {+ event: "periodic_runner.completed",+ runner: RUNNER_NAME,+ scope: this.tableName,+ outcome: this.runOutcome,+ durationMs,+ });+ } catch {+ /** Best-effort logging preserves the cleanup outcome. */+ }+ }+/*** Get project workloads using bounded candidate discovery:* 1. PostgreSQL: Get all projects with retention enabled