🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(saved-views): copy session-detail permalinks from the current path (#16736)
cursor[bot]6dd490393a40
diff --git a/packages/shared/src/server/services/TableViewService/TableViewService.test.ts b/packages/shared/src/server/services/TableViewService/TableViewService.test.tsnew file mode 100644index 0000000000..002b75b3f8--- /dev/null+++ b/packages/shared/src/server/services/TableViewService/TableViewService.test.ts@@ -0,0 +1,41 @@+import { describe, expect, it } from "vitest";+import { TableViewPresetTableName } from "../../../domain/table-view-presets";+import { InvalidRequestError } from "../../../errors";+import { TableViewService } from "./TableViewService";++describe("TableViewService.generatePermalink", () => {+ it("builds a list-page permalink for tables in the URL map", async () => {+ await expect(+ TableViewService.generatePermalink(+ "https://us.cloud.langfuse.com",+ "view_1",+ TableViewPresetTableName.Sessions,+ "proj_1",+ ),+ ).resolves.toBe(+ "https://us.cloud.langfuse.com/project/proj_1/sessions?viewId=view_1",+ );+ });++ it("rejects session-detail with InvalidRequestError instead of a 500", async () => {+ await expect(+ TableViewService.generatePermalink(+ "https://us.cloud.langfuse.com",+ "view_1",+ TableViewPresetTableName.SessionDetail,+ "proj_1",+ ),+ ).rejects.toThrow(InvalidRequestError);+ });++ it("rejects unknown system-preset ids with InvalidRequestError", async () => {+ await expect(+ TableViewService.generatePermalink(+ "https://us.cloud.langfuse.com",+ "__langfuse_with_io__",+ TableViewPresetTableName.SessionDetail,+ "proj_1",+ ),+ ).rejects.toThrow(InvalidRequestError);+ });+});diff --git a/packages/shared/src/server/services/TableViewService/TableViewService.ts b/packages/shared/src/server/services/TableViewService/TableViewService.tsindex 2828713d72..04abb6848c 100644--- a/packages/shared/src/server/services/TableViewService/TableViewService.ts+++ b/packages/shared/src/server/services/TableViewService/TableViewService.ts@@ -4,7 +4,11 @@ import {TableViewPresetTableName,type TableViewPresetDomain,} from "../../../domain/table-view-presets";-import { LangfuseConflictError, LangfuseNotFoundError } from "../../../errors";+import {+ InvalidRequestError,+ LangfuseConflictError,+ LangfuseNotFoundError,+} from "../../../errors";import {TableViewPresetsNamesCreatorList,TableViewPresetsNamesCreatorListSchema,@@ -338,14 +342,16 @@ export class TableViewService {isSystemTableViewPresetId(TableViewPresetsId) &&!getSystemTableViewPresetByTableAndId(tableName, TableViewPresetsId)) {- throw new Error(+ throw new InvalidRequestError(`Permalinks are not supported for preset ${TableViewPresetsId}`,);}const page = TABLE_NAME_TO_URL_MAP[tableName];if (!page) {- throw new Error(`Permalinks are not supported for table ${tableName}`);+ throw new InvalidRequestError(+ `Permalinks are not supported for table ${tableName}`,+ );}return `${baseUrl}/project/${projectId}/${page}?viewId=${TableViewPresetsId}`;}diff --git a/packages/shared/src/utils/productUrl.test.ts b/packages/shared/src/utils/productUrl.test.tsnew file mode 100644index 0000000000..56b4b417ee--- /dev/null+++ b/packages/shared/src/utils/productUrl.test.ts@@ -0,0 +1,44 @@+import { describe, expect, it } from "vitest";+import { TableViewPresetTableName } from "../domain/table-view-presets";+import {+ buildCurrentPageSavedViewPermalink,+ parseSavedViewFromURL,+ tableViewPresetPermalinkUsesCurrentPath,+} from "./productUrl";++describe("tableViewPresetPermalinkUsesCurrentPath", () => {+ it("is true only for session detail, which embeds a session id in the path", () => {+ expect(+ tableViewPresetPermalinkUsesCurrentPath(+ TableViewPresetTableName.SessionDetail,+ ),+ ).toBe(true);+ expect(+ tableViewPresetPermalinkUsesCurrentPath(+ TableViewPresetTableName.Sessions,+ ),+ ).toBe(false);+ expect(+ tableViewPresetPermalinkUsesCurrentPath(TableViewPresetTableName.Traces),+ ).toBe(false);+ });+});++describe("buildCurrentPageSavedViewPermalink", () => {+ it("keeps the session path and sets viewId, dropping other query/hash state", () => {+ const href = buildCurrentPageSavedViewPermalink({+ origin: "https://us.cloud.langfuse.com",+ pathname:+ "/project/proj_1/sessions/e2e_dt_sup_15%3A950e5c49-03b5-49c6-a602-a8d76119d343",+ viewId: "view_saved_1",+ });++ expect(href).toBe(+ "https://us.cloud.langfuse.com/project/proj_1/sessions/e2e_dt_sup_15%3A950e5c49-03b5-49c6-a602-a8d76119d343?viewId=view_saved_1",+ );+ expect(parseSavedViewFromURL(href, false)).toEqual({+ viewId: "view_saved_1",+ tableName: TableViewPresetTableName.SessionDetail,+ });+ });+});diff --git a/packages/shared/src/utils/productUrl.ts b/packages/shared/src/utils/productUrl.tsindex c8153ecf1e..def6915796 100644--- a/packages/shared/src/utils/productUrl.ts+++ b/packages/shared/src/utils/productUrl.ts@@ -73,6 +73,34 @@ export function parseSavedViewFromURL(return undefined;}+/**+ * Tables whose permalink includes a resource id already present in the+ * current path (e.g. `/sessions/[sessionId]`). The server+ * `generatePermalink` helper only knows project + table, so these must be+ * built from `window.location` on the client.+ */+export const tableViewPresetPermalinkUsesCurrentPath = (+ tableName: TableViewPresetTableName,+): boolean => tableName === TableViewPresetTableName.SessionDetail;++/**+ * Permalink for a saved view that cannot be expressed as+ * `/project/:id/<table>?viewId=…` because the page also needs a resource+ * id (session detail). Drops existing query/hash so a non-active view+ * shares its stored state, not the page's in-progress filters.+ */+export function buildCurrentPageSavedViewPermalink(params: {+ origin: string;+ pathname: string;+ viewId: string;+}): string {+ const url = new URL(params.pathname, params.origin);+ url.search = "";+ url.hash = "";+ url.searchParams.set("viewId", params.viewId);+ return url.toString();+}+type TracesPathTimeRange =| { preset: (typeof TABLE_AGGREGATION_OPTIONS)[number] }| { from: string; to: string };diff --git a/web/src/components/table/table-view-presets/components/data-table-view-presets-drawer.tsx b/web/src/components/table/table-view-presets/components/data-table-view-presets-drawer.tsxindex 79acbaf105..c91b7df341 100644--- a/web/src/components/table/table-view-presets/components/data-table-view-presets-drawer.tsx+++ b/web/src/components/table/table-view-presets/components/data-table-view-presets-drawer.tsx@@ -53,6 +53,8 @@ import {type FilterState,type TableViewPresetTableName,type TableViewPresetState,+ buildCurrentPageSavedViewPermalink,+ tableViewPresetPermalinkUsesCurrentPath,} from "@langfuse/shared";import { type ReactNode, useCallback, useMemo, useState } from "react";import {@@ -101,6 +103,23 @@ const SYSTEM_PRESET_ID_PREFIX = "__langfuse_";export const isSystemPresetId = (id: string | undefined | null): boolean =>!!id?.startsWith(SYSTEM_PRESET_ID_PREFIX);+const copyPermalinkAndToast = (href: string) => {+ copyTextToClipboard(href)+ .then(() =>+ showSuccessToast({+ title: "Permalink copied to clipboard",+ description: "You can now share the permalink with others",+ }),+ )+ .catch(() =>+ showErrorToast(+ "Failed to copy permalink",+ "Could not write to the clipboard. Please copy the page URL manually.",+ "WARNING",+ ),+ );+};+/** Recursively remove undefined values for consistent comparison */function normalizeForComparison<T>(obj: T): T {if (Array.isArray(obj)) {@@ -520,20 +539,27 @@ function TableViewPresetsDrawerContentBody({) {// Toast on the clipboard write's resolution: a permission failure must// surface an error instead of falsely reporting success.- copyTextToClipboard(window.location.href)- .then(() =>- showSuccessToast({- title: "Permalink copied to clipboard",- description: "You can now share the permalink with others",- }),- )- .catch(() =>- showErrorToast(- "Failed to copy permalink",- "Could not write to the clipboard. Please copy the page URL manually.",- "WARNING",- ),- );+ copyPermalinkAndToast(window.location.href);+ return;+ }++ // Session detail (and any future resource-scoped table) cannot be+ // expressed as `/project/:id/<table>?viewId=…` — the session id lives+ // in the path. Build that on the client instead of hitting the server,+ // which would 400 (and previously 500'd as a generic Error).+ if (+ tableViewPresetPermalinkUsesCurrentPath(tableName) &&+ typeof window !== "undefined" &&+ window.location?.origin &&+ window.location?.pathname+ ) {+ copyPermalinkAndToast(+ buildCurrentPageSavedViewPermalink({+ origin: window.location.origin,+ pathname: window.location.pathname,+ viewId,+ }),+ );return;}