Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

feat(evals): polish evaluator controls and version history (#17315)

Tobias Wochinger6fe243c69447
diff --git a/web/src/components/design-system/Tabs/Tabs.stories.tsx b/web/src/components/design-system/Tabs/Tabs.stories.tsx
index b24baf606a..69a6918106 100644
--- a/web/src/components/design-system/Tabs/Tabs.stories.tsx
+++ b/web/src/components/design-system/Tabs/Tabs.stories.tsx
@@ -1,6 +1,6 @@
import React from "react";
import { KeyRound, User } from "lucide-react";
-import { expect, userEvent, within } from "storybook/test";
+import { expect, userEvent, waitFor, within } from "storybook/test";
import preview from "../../../../.storybook/preview";
import { Tabs } from "./Tabs";
@@ -53,6 +53,26 @@ const fullWidthChildren = (
</>
);
+function ResizableSlidingTabs() {
+ const [expanded, setExpanded] = React.useState(false);
+
+ return (
+ <div className="[&_[role=tablist]]:w-80 [&_[role=tablist]]:justify-start">
+ <button type="button" onClick={() => setExpanded(true)}>
+ Expand active tab
+ </button>
+ <Tabs defaultValue="first">
+ <Tabs.List variant="outline">
+ <span className={expanded ? "w-40" : "w-20"}>
+ <Tabs.Trigger value="first" label="First" />
+ </span>
+ <Tabs.Trigger value="second" label="Second" />
+ </Tabs.List>
+ </Tabs>
+ </div>
+ );
+}
+
export const Default = meta.story({
args: {
defaultValue: "account",
@@ -250,3 +270,121 @@ export const TruncatesLabel = meta.story({
await expect(label.scrollWidth).toBeGreaterThan(label.clientWidth);
},
});
+
+export const SlidesIndicator = meta.story({
+ name: "(Test) Slides Indicator",
+ args: {
+ defaultValue: "short",
+ children: (
+ <Tabs.List variant="outline">
+ <Tabs.Trigger value="short" label="Python" />
+ <Tabs.Trigger value="long" label="TypeScript" />
+ </Tabs.List>
+ ),
+ },
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const indicator = canvasElement.querySelector("[data-tabs-indicator]");
+
+ await expect(indicator).toBeInTheDocument();
+ const initialRect = indicator!.getBoundingClientRect();
+
+ const typeScriptTab = canvas.getByRole("tab", { name: "TypeScript" });
+ await userEvent.click(typeScriptTab);
+ await waitFor(() => {
+ const nextRect = indicator!.getBoundingClientRect();
+ const tabRect = typeScriptTab.getBoundingClientRect();
+ expect(nextRect.left).toBeGreaterThan(initialRect.left);
+ expect(nextRect.width).toBeGreaterThan(initialRect.width);
+ expect(Math.abs(nextRect.left - tabRect.left)).toBeLessThan(0.5);
+ expect(Math.abs(nextRect.width - tabRect.width)).toBeLessThan(0.5);
+ });
+ },
+});
+
+export const AlignsSlidingIndicatorInScaledContainer = meta.story({
+ name: "(Test) Aligns Sliding Indicator In Scaled Container",
+ args: {
+ defaultValue: "short",
+ children: (
+ <Tabs.List variant="outline">
+ <Tabs.Trigger value="short" label="Python" />
+ <Tabs.Trigger value="long" label="TypeScript" />
+ </Tabs.List>
+ ),
+ },
+ render: (args) => (
+ <div className="origin-top-left scale-75">
+ <Tabs {...args} />
+ </div>
+ ),
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const activeTab = canvas.getByRole("tab", { name: "Python" });
+ const indicator = canvasElement.querySelector("[data-tabs-indicator]");
+
+ await expect(indicator).toBeInTheDocument();
+ await waitFor(() => {
+ const indicatorRect = indicator!.getBoundingClientRect();
+ const tabRect = activeTab.getBoundingClientRect();
+ expect(Math.abs(indicatorRect.left - tabRect.left)).toBeLessThan(0.5);
+ expect(Math.abs(indicatorRect.width - tabRect.width)).toBeLessThan(0.5);
+ });
+ },
+});
+
+export const KeepsUnderlineStyle = meta.story({
+ name: "(Test) Keeps Underline Style",
+ args: {
+ defaultValue: "first",
+ children: (
+ <Tabs.List variant="underline">
+ <Tabs.Trigger value="first" variant="underline" label="First" />
+ <Tabs.Trigger value="second" variant="underline" label="Second" />
+ </Tabs.List>
+ ),
+ },
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+
+ await expect(canvas.getByRole("tab", { name: "First" })).toHaveAttribute(
+ "aria-selected",
+ "true",
+ );
+ await expect(
+ canvasElement.querySelector("[data-tabs-indicator]"),
+ ).not.toBeInTheDocument();
+ },
+});
+
+export const TracksTriggerResize = meta.story({
+ name: "(Test) Tracks Trigger Resize",
+ render: () => <ResizableSlidingTabs />,
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const activeTab = canvas.getByRole("tab", { name: "First" });
+ const indicator = canvasElement.querySelector("[data-tabs-indicator]");
+
+ await expect(indicator).toBeInTheDocument();
+ await waitFor(() => {
+ expect(
+ Math.abs(
+ indicator!.getBoundingClientRect().width -
+ activeTab.getBoundingClientRect().width,
+ ),
+ ).toBeLessThan(0.5);
+ });
+ const initialWidth = activeTab.getBoundingClientRect().width;
+ await new Promise((resolve) => setTimeout(resolve, 100));
+
+ await userEvent.click(
+ canvas.getByRole("button", { name: "Expand active tab" }),
+ );
+ await waitFor(() => {
+ const indicatorRect = indicator!.getBoundingClientRect();
+ const tabRect = activeTab.getBoundingClientRect();
+ expect(tabRect.width).toBeGreaterThan(initialWidth);
+ expect(Math.abs(indicatorRect.width - tabRect.width)).toBeLessThan(0.5);
+ });
+ },
+});
diff --git a/web/src/components/design-system/Tabs/Tabs.tsx b/web/src/components/design-system/Tabs/Tabs.tsx
index 0d5d816eed..efe3cd0bfd 100644
--- a/web/src/components/design-system/Tabs/Tabs.tsx
+++ b/web/src/components/design-system/Tabs/Tabs.tsx
@@ -5,6 +5,8 @@ import * as TabsPrimitive from "@radix-ui/react-tabs";
import { cva, type VariantProps } from "class-variance-authority";
import { type LucideIcon } from "lucide-react";
+import { cn } from "@/src/utils/tailwind";
+
const tabsListVariants = cva(
"text-muted-foreground items-center justify-center [&>:not([role=tab])]:flex [&>:not([role=tab])>[role=tab]]:w-full",
{
@@ -12,8 +14,7 @@ const tabsListVariants = cva(
variant: {
default: "bg-muted rounded-md",
underline: "rounded-none border-b bg-transparent",
- outline:
- "bg-background rounded-md border **:data-[state=active]:bg-muted",
+ outline: "bg-background rounded-md border",
},
size: {
default: "",
@@ -113,6 +114,8 @@ function TabsRoot({
);
}
+const TabsIndicatorContext = React.createContext(false);
+
function TabsList({
"aria-label": ariaLabel,
children,
@@ -121,13 +124,119 @@ function TabsList({
size,
variant,
}: TabsListProps) {
+ const listRef = React.useRef<HTMLDivElement>(null);
+ const indicatorRef = React.useRef<HTMLSpanElement>(null);
+ const hasSlidingIndicator = variant !== "underline";
+
+ React.useLayoutEffect(() => {
+ if (!hasSlidingIndicator) return;
+
+ const list = listRef.current;
+ const indicator = indicatorRef.current;
+ if (!list || !indicator) return;
+
+ let frame: number | undefined;
+ let readyFrame: number | undefined;
+ const updateIndicator = () => {
+ if (frame !== undefined) cancelAnimationFrame(frame);
+ frame = requestAnimationFrame(() => {
+ const activeTrigger = list.querySelector<HTMLElement>(
+ '[role="tab"][data-state="active"]',
+ );
+ if (!activeTrigger) {
+ indicator.style.opacity = "0";
+ return;
+ }
+
+ let triggerOffset = 0;
+ let offsetElement: HTMLElement | null = activeTrigger;
+ while (offsetElement && offsetElement !== list) {
+ triggerOffset += offsetElement.offsetLeft;
+ offsetElement = offsetElement.offsetParent as HTMLElement | null;
+ }
+ if (offsetElement !== list) return;
+
+ indicator.style.width = `${activeTrigger.offsetWidth}px`;
+ indicator.style.transform = `translateX(${triggerOffset}px)`;
+ indicator.style.opacity = "1";
+
+ if (indicator.dataset.ready !== "true") {
+ readyFrame = requestAnimationFrame(() => {
+ indicator.dataset.ready = "true";
+ });
+ }
+ });
+ };
+
+ const resizeObserver =
+ typeof ResizeObserver === "undefined"
+ ? null
+ : new ResizeObserver(updateIndicator);
+ const observedTriggers = new Set<HTMLElement>();
+ const syncObservedTriggers = () => {
+ const triggers = new Set(
+ list.querySelectorAll<HTMLElement>('[role="tab"]'),
+ );
+
+ for (const trigger of observedTriggers) {
+ if (!triggers.has(trigger)) {
+ resizeObserver?.unobserve(trigger);
+ observedTriggers.delete(trigger);
+ }
+ }
+ for (const trigger of triggers) {
+ if (!observedTriggers.has(trigger)) {
+ resizeObserver?.observe(trigger);
+ observedTriggers.add(trigger);
+ }
+ }
+ };
+ const mutationObserver = new MutationObserver(() => {
+ syncObservedTriggers();
+ updateIndicator();
+ });
+ resizeObserver?.observe(list);
+ syncObservedTriggers();
+ mutationObserver.observe(list, {
+ attributes: true,
+ attributeFilter: ["data-state"],
+ childList: true,
+ subtree: true,
+ });
+ updateIndicator();
+
+ return () => {
+ if (frame !== undefined) cancelAnimationFrame(frame);
+ if (readyFrame !== undefined) cancelAnimationFrame(readyFrame);
+ resizeObserver?.disconnect();
+ mutationObserver.disconnect();
+ };
+ }, [hasSlidingIndicator]);
+
return (
- <TabsPrimitive.List
- aria-label={ariaLabel}
- className={tabsListVariants({ gap, layout, size, variant })}
- >
- {children}
- </TabsPrimitive.List>
+ <TabsIndicatorContext value={hasSlidingIndicator}>
+ <TabsPrimitive.List
+ ref={listRef}
+ aria-label={ariaLabel}
+ className={cn(
+ tabsListVariants({ gap, layout, size, variant }),
+ hasSlidingIndicator && "relative isolate",
+ )}
+ >
+ {hasSlidingIndicator ? (
+ <span
+ ref={indicatorRef}
+ data-tabs-indicator=""
+ aria-hidden="true"
+ className={cn(
+ "pointer-events-none absolute inset-y-1 left-0 z-0 rounded-sm opacity-0 data-[ready=true]:transition-[width,transform] data-[ready=true]:duration-200 data-[ready=true]:ease-out motion-reduce:transition-none",
+ variant === "outline" ? "bg-muted" : "bg-background shadow-xs",
+ )}
+ />
+ ) : null}
+ {children}
+ </TabsPrimitive.List>
+ </TabsIndicatorContext>
);
}
@@ -161,12 +270,18 @@ function TabsTrigger({
value,
variant,
}: TabsTriggerProps) {
+ const slidingIndicator = React.use(TabsIndicatorContext);
+
return (
<TabsPrimitive.Trigger
value={value}
disabled={disabled}
title={label ?? title}
- className={tabsTriggerVariants({ size, variant })}
+ className={cn(
+ tabsTriggerVariants({ size, variant }),
+ slidingIndicator &&
+ "relative z-1 data-[state=active]:bg-transparent data-[state=active]:shadow-none",
+ )}
>
{Icon ? <Icon aria-hidden="true" className="size-3.5 shrink-0" /> : null}
{label !== undefined ? (
diff --git a/web/src/features/evals/v2/components/Evaluators/EvaluatorVersionHistorySheet/components/EvaluatorDefinitionView/EvaluatorDefinitionView.tsx b/web/src/features/evals/v2/components/Evaluators/EvaluatorVersionHistorySheet/components/EvaluatorDefinitionView/EvaluatorDefinitionView.tsx
index a5c915da97..5f66a24162 100644
--- a/web/src/features/evals/v2/components/Evaluators/EvaluatorVersionHistorySheet/components/EvaluatorDefinitionView/EvaluatorDefinitionView.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/EvaluatorVersionHistorySheet/components/EvaluatorDefinitionView/EvaluatorDefinitionView.tsx
@@ -145,24 +145,26 @@ function LlmEvaluatorDefinitionView({
<section className="flex min-w-0 flex-col gap-2">
<Label>Prompt</Label>
{promptMessages.map((message, index) => (
- <div key={index} className="flex min-w-0 flex-col gap-1">
- <Badge variant="outline" className="w-fit capitalize">
- {message.role}
- </Badge>
- <PromptVariableEditor
- value={message.content}
- onChange={noop}
- variableMappings={variableLabels}
- readOnly
- validateVariableMappings={false}
- previewEnabled
- preview={{
- status: "ready",
- fragments: [{ type: "text", text: message.content }],
- }}
- renderPreviewText={renderMediaAwareText}
- />
- </div>
+ <PromptVariableEditor
+ key={index}
+ value={message.content}
+ onChange={noop}
+ variableMappings={variableLabels}
+ readOnly
+ validateVariableMappings={false}
+ toolbarStart={
+ <span className="text-muted-foreground px-1.5 text-xs capitalize">
+ {message.role}
+ </span>
+ }
+ previewEnabled
+ preview={{
+ status: "ready",
+ fragments: [{ type: "text", text: message.content }],
+ }}
+ previewSurface="muted"
+ renderPreviewText={renderMediaAwareText}
+ />
))}
</section>
{variableMappings.state === "visible" ? (
diff --git a/web/src/features/evals/v2/components/Evaluators/Judges/PromptVariableEditor/PromptVariableEditor.tsx b/web/src/features/evals/v2/components/Evaluators/Judges/PromptVariableEditor/PromptVariableEditor.tsx
index 4e520b5da5..c8cded46b9 100644
--- a/web/src/features/evals/v2/components/Evaluators/Judges/PromptVariableEditor/PromptVariableEditor.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/Judges/PromptVariableEditor/PromptVariableEditor.tsx
@@ -160,6 +160,7 @@ export function PromptVariableEditor({
showPreviewToggle = false,
previewDisabledReason = null,
preview,
+ previewSurface = "default",
readOnly = false,
validateVariableMappings = true,
renderPreviewText = (value) => value,
@@ -185,6 +186,8 @@ export function PromptVariableEditor({
previewDisabledReason?: string | null;
/** Interpolated prompt state prepared by the owning container. */
preview?: InterpolatedPromptPreviewState;
+ /** Visual treatment for the rendered preview surface. */
+ previewSurface?: "default" | "muted";
/** Preserve variable syntax highlighting without exposing editor controls. */
readOnly?: boolean;
/** Whether variables without a known mapping should receive a warning. */
@@ -226,13 +229,11 @@ export function PromptVariableEditor({
}, [statusKey, mappingsKey, readOnly, validateVariableMappings]);
const hasToolbar =
- !readOnly &&
- Boolean(
- showPreviewToggle ||
- toolbarStart ||
- toolbarActionsBeforePreview ||
- toolbarActions,
- );
+ Boolean(toolbarStart) ||
+ (!readOnly &&
+ Boolean(
+ showPreviewToggle || toolbarActionsBeforePreview || toolbarActions,
+ ));
const activePreview = previewEnabled ? preview : undefined;
return (
@@ -311,11 +312,23 @@ export function PromptVariableEditor({
</div>
{activePreview ? (
activePreview.status === "unavailable" ? (
- <p className="ph-no-capture bg-muted/50 text-muted-foreground absolute inset-0 overflow-y-auto rounded-b-md border px-3 py-2 text-sm leading-5">
+ <p
+ className={cn(
+ "ph-no-capture bg-muted/50 text-muted-foreground absolute inset-0 overflow-y-auto rounded-b-md border px-3 py-2 text-sm leading-5",
+ previewSurface === "muted" &&
+ "bg-muted/50 text-muted-foreground",
+ )}
+ >
{activePreview.message}
</p>
) : (
- <pre className="ph-no-capture bg-muted/50 text-card-foreground absolute inset-0 overflow-y-auto rounded-b-md border px-3 py-2 font-sans text-sm leading-5 whitespace-pre-wrap">
+ <pre
+ className={cn(
+ "ph-no-capture bg-muted/50 text-card-foreground absolute inset-0 overflow-y-auto rounded-b-md border px-3 py-2 font-sans text-sm leading-5 whitespace-pre-wrap",
+ previewSurface === "muted" &&
+ "bg-muted/50 text-muted-foreground",
+ )}
+ >
{activePreview.fragments.map((fragment, index) => (
<Fragment key={index}>
{fragment.type === "text" ? (
diff --git a/web/src/features/evals/v2/components/Evaluators/Judges/ScoreOutputConfiguration/components/ScoreOutputSection/ScoreOutputSection.tsx b/web/src/features/evals/v2/components/Evaluators/Judges/ScoreOutputConfiguration/components/ScoreOutputSection/ScoreOutputSection.tsx
index cfb7d13edf..84d26b480a 100644
--- a/web/src/features/evals/v2/components/Evaluators/Judges/ScoreOutputConfiguration/components/ScoreOutputSection/ScoreOutputSection.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/Judges/ScoreOutputConfiguration/components/ScoreOutputSection/ScoreOutputSection.tsx
@@ -350,11 +350,11 @@ export function ScoreOutputSection({
{state.dataType === ScoreDataTypeEnum.BOOLEAN && (
<>
<span>as</span>
- <span className="bg-background inline-flex h-8 items-center rounded-md border px-2 font-bold">
+ <span className="bg-muted/50 text-foreground inline-flex h-8 items-center rounded-md border px-3 opacity-50">
true
</span>
<span>or</span>
- <span className="bg-background inline-flex h-8 items-center rounded-md border px-2 font-bold">
+ <span className="bg-muted/50 text-foreground inline-flex h-8 items-center rounded-md border px-3 opacity-50">
false
</span>
</>
diff --git a/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.stories.tsx b/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.stories.tsx
new file mode 100644
index 0000000000..b05f923210
--- /dev/null
+++ b/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.stories.tsx
@@ -0,0 +1,20 @@
+import { fn } from "storybook/test";
+
+import preview from "../../../../../../../../../../.storybook/preview";
+import { FilterModeToggle } from "./FilterModeToggle";
+
+const meta = preview.meta({ component: FilterModeToggle });
+
+export const Query = meta.story({
+ args: {
+ mode: "query",
+ onChange: fn(),
+ },
+});
+
+export const Builder = meta.story({
+ args: {
+ mode: "builder",
+ onChange: fn(),
+ },
+});
diff --git a/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.tsx b/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.tsx
index 36b363a4f5..bf29401110 100644
--- a/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/FilterModeToggle.tsx
@@ -1,7 +1,7 @@
import { Braces, ListFilter } from "lucide-react";
+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import type { EvaluatorFilterExperience } from "@/src/features/evals/v2/types/evaluatorFilterExperience";
-import { cn } from "@/src/utils/tailwind";
export function FilterModeToggle({
mode,
@@ -11,30 +11,14 @@ export function FilterModeToggle({
onChange: (mode: EvaluatorFilterExperience) => void;
}) {
return (
- <div
- className="bg-muted flex items-center rounded-md p-0.5"
- aria-label="Filter editor mode"
+ <Tabs
+ value={mode}
+ onValueChange={(value) => onChange(value as EvaluatorFilterExperience)}
>
- {(
- [
- { id: "query", label: "Query", icon: Braces },
- { id: "builder", label: "Builder", icon: ListFilter },
- ] as const
- ).map((option) => (
- <button
- key={option.id}
- type="button"
- aria-pressed={mode === option.id}
- onClick={() => onChange(option.id)}
- className={cn(
- "text-muted-foreground flex h-7 items-center gap-1 rounded px-2 text-xs",
- mode === option.id && "bg-background text-foreground shadow-sm",
- )}
- >
- <option.icon className="h-3.5 w-3.5" aria-hidden="true" />
- {option.label}
- </button>
- ))}
- </div>
+ <Tabs.List aria-label="Filter editor mode">
+ <Tabs.Trigger value="query" icon={Braces} label="Query" />
+ <Tabs.Trigger value="builder" icon={ListFilter} label="Builder" />
+ </Tabs.List>
+ </Tabs>
);
}
diff --git a/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/ObservationFilterBuilder/ObservationFilterBuilder.tsx b/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/ObservationFilterBuilder/ObservationFilterBuilder.tsx
index 4e08e7d43a..e4ad4fa8bc 100644
--- a/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/ObservationFilterBuilder/ObservationFilterBuilder.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/Testing/components/SampleObservationSelectorBase/components/ObservationFilterBuilder/ObservationFilterBuilder.tsx
@@ -24,7 +24,7 @@ export function ObservationFilterBuilder({
<div
ref={containerRef}
className={cn(
- "[&_table]:w-full [&_table]:table-fixed [&_td:first-child]:w-16 [&_td:last-child]:w-8 [&_td:last-child]:text-right",
+ "[&_table]:w-full [&_table]:table-fixed [&_td]:align-middle [&_td:first-child]:w-16 [&_td:last-child]:w-8 [&_td:last-child>button]:ml-auto [&_td:last-child>button]:flex [&_td:nth-last-child(2)]:pr-0",
isNarrow
? "[&_td:nth-child(2)]:w-40 [&_td:nth-child(3)]:w-32"
: "[&_td:nth-child(2)]:w-56 [&_td:nth-child(3)]:w-40",