Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(ai-gateway): list codex-auto-review on OpenAI connections (#18984)

Tobias Wochinger70aa60be76fb
diff --git a/web/src/__tests__/server/ai-gateway-control-plane.servertest.ts b/web/src/__tests__/server/ai-gateway-control-plane.servertest.ts
index 6d053a4643..e89ff35ee3 100644
--- a/web/src/__tests__/server/ai-gateway-control-plane.servertest.ts
+++ b/web/src/__tests__/server/ai-gateway-control-plane.servertest.ts
@@ -345,7 +345,7 @@ describe("AI gateway control plane", () => {
{
connectionId: connection.id,
success: true,
- models: ["disabled-model", "enabled-model"],
+ models: ["disabled-model", "enabled-model", "codex-auto-review"],
},
]);
await new GatewayModelCatalogService(prisma).clearModelCache(
@@ -1642,6 +1642,13 @@ describe("AI gateway control plane", () => {
displayName: "a-model",
createdAt: "1970-01-01T00:00:10.000Z",
},
+ {
+ id: "OpenAI-backup:codex-auto-review",
+ provider: "OPENAI",
+ canonicalSlug: "codex-auto-review",
+ displayName: "codex-auto-review",
+ createdAt: "1970-01-01T00:00:00.000Z",
+ },
{
id: "OpenAI-backup:shared-model",
provider: "OPENAI",
@@ -1656,6 +1663,13 @@ describe("AI gateway control plane", () => {
displayName: "a-model",
createdAt: "1970-01-01T00:00:10.000Z",
},
+ {
+ id: "OpenAI-primary:codex-auto-review",
+ provider: "OPENAI",
+ canonicalSlug: "codex-auto-review",
+ displayName: "codex-auto-review",
+ createdAt: "1970-01-01T00:00:00.000Z",
+ },
{
id: "OpenAI-primary:shared-model",
provider: "OPENAI",
@@ -1745,6 +1759,13 @@ describe("AI gateway control plane", () => {
displayName: "available-model",
createdAt: "1970-01-01T00:00:10.000Z",
},
+ {
+ id: "OpenAI-fallback:codex-auto-review",
+ provider: "OPENAI",
+ canonicalSlug: "codex-auto-review",
+ displayName: "codex-auto-review",
+ createdAt: "1970-01-01T00:00:00.000Z",
+ },
],
});
diff --git a/web/src/features/ai-gateway/fns/updateGatewayAllowedModels.clienttest.ts b/web/src/features/ai-gateway/fns/updateGatewayAllowedModels.clienttest.ts
index 9578ce23e3..22a391034a 100644
--- a/web/src/features/ai-gateway/fns/updateGatewayAllowedModels.clienttest.ts
+++ b/web/src/features/ai-gateway/fns/updateGatewayAllowedModels.clienttest.ts
@@ -16,7 +16,7 @@ describe("updateGatewayAllowedModels", () => {
).toEqual(["gpt-4o-mini"]);
});
- it("keeps row edits explicit when every catalog model is enabled", () => {
+ it("falls back to allow-all once every catalog model is enabled", () => {
expect(
updateGatewayAllowedModels({
allowedModels: ["gpt-4o"],
@@ -24,7 +24,7 @@ describe("updateGatewayAllowedModels", () => {
targetModels: ["gpt-4o-mini", "o3"],
enabled: true,
}),
- ).toEqual(models);
+ ).toBeNull();
});
it("preserves allowed models outside the current provider catalog", () => {
diff --git a/web/src/features/ai-gateway/fns/updateGatewayAllowedModels.ts b/web/src/features/ai-gateway/fns/updateGatewayAllowedModels.ts
index cb77faae67..9e39f90df8 100644
--- a/web/src/features/ai-gateway/fns/updateGatewayAllowedModels.ts
+++ b/web/src/features/ai-gateway/fns/updateGatewayAllowedModels.ts
@@ -18,5 +18,11 @@ export function updateGatewayAllowedModels({
else nextAllowedModels.delete(model);
}
+ if (
+ availableModels.length > 0 &&
+ availableModels.every((model) => nextAllowedModels.has(model))
+ ) {
+ return null;
+ }
return [...nextAllowedModels];
}
diff --git a/web/src/features/ai-gateway/server/provider/models/gatewayModelCatalogService.ts b/web/src/features/ai-gateway/server/provider/models/gatewayModelCatalogService.ts
index 0e4d7e0f56..f53e120285 100644
--- a/web/src/features/ai-gateway/server/provider/models/gatewayModelCatalogService.ts
+++ b/web/src/features/ai-gateway/server/provider/models/gatewayModelCatalogService.ts
@@ -43,6 +43,13 @@ export type ModelCatalogRefreshResult =
const MODEL_CACHE_PREFIX = "ai-gateway:models";
const MODEL_CACHE_TTL_SECONDS = 5 * 60;
+/**
+ * Codex sends its auto-review requests as `codex-auto-review`, which OpenAI serves but does not list in `/v1/models`.
+ * Listing it here keeps it allowed by default on every OpenAI connection while admins can still disable it.
+ */
+const CUSTOM_MODELS: Partial<Record<GatewayProviderName, string[]>> = {
+ OPENAI: ["codex-auto-review"],
+};
export class GatewayModelCatalogService {
private readonly repository: GatewayProviderRepository;
@@ -256,11 +263,8 @@ export class GatewayModelCatalogService {
error: models.error,
};
}
- await this.cacheModels(
- params.organizationId,
- params.connectionId,
- models.models,
- );
+ const catalog = addCustomModels(provider, models.models);
+ await this.cacheModels(params.organizationId, params.connectionId, catalog);
if (params.explicitRetry && connection.status === "ERROR") {
await this.repository.updateConnectionStatus({
organizationId: params.organizationId,
@@ -272,7 +276,7 @@ export class GatewayModelCatalogService {
return {
connectionId: connection.id,
success: true,
- models: models.models,
+ models: catalog,
};
}
@@ -315,6 +319,23 @@ export class GatewayModelCatalogService {
}
}
+function addCustomModels(
+ provider: GatewayProviderName,
+ models: GatewayModelCatalogEntry[],
+): GatewayModelCatalogEntry[] {
+ const discoveredIds = new Set(models.map(({ id }) => id));
+ const customModels = (CUSTOM_MODELS[provider] ?? [])
+ .filter((id) => !discoveredIds.has(id))
+ .map((id) => ({
+ id,
+ provider,
+ canonicalSlug: id,
+ displayName: id,
+ createdAt: new Date(0).toISOString(),
+ }));
+ return models.concat(customModels);
+}
+
function isGatewayModelCatalog(
value: unknown,
): value is GatewayModelCatalogEntry[] {
diff --git a/web/src/features/ai-gateway/server/provider/registry.servertest.ts b/web/src/features/ai-gateway/server/provider/registry.servertest.ts
index 0415ffa860..ade335ee7e 100644
--- a/web/src/features/ai-gateway/server/provider/registry.servertest.ts
+++ b/web/src/features/ai-gateway/server/provider/registry.servertest.ts
@@ -245,7 +245,7 @@ describe("AI gateway provider registry", () => {
).resolves.toEqual({
connectionId: "connection-1",
success: true,
- models: ["gpt-5"],
+ models: ["gpt-5", "codex-auto-review"],
});
expect(redis.get).not.toHaveBeenCalled();
expect(redis.del).toHaveBeenCalledWith(
@@ -262,7 +262,45 @@ describe("AI gateway provider registry", () => {
displayName: "gpt-5",
createdAt: "1970-01-01T00:00:10.000Z",
},
+ {
+ id: "codex-auto-review",
+ provider: "OPENAI",
+ canonicalSlug: "codex-auto-review",
+ displayName: "codex-auto-review",
+ createdAt: "1970-01-01T00:00:00.000Z",
+ },
]),
);
});
+
+ it("does not duplicate a custom model the provider already lists", async () => {
+ const fetcher = vi.fn<typeof fetch>().mockResolvedValue(
+ Response.json({
+ data: [
+ { id: "codex-auto-review", created: 10 },
+ { id: "gpt-5", created: 10 },
+ ],
+ }),
+ );
+ const prisma = {
+ gatewayAiConnection: {
+ findFirst: vi.fn().mockResolvedValue({
+ id: "connection-1",
+ organizationId: "org-1",
+ provider: "OPENAI",
+ encryptedCredential: encrypt("sk-test"),
+ status: "ENABLED",
+ allowedModels: null,
+ }),
+ },
+ } as unknown as PrismaClient;
+ const service = new GatewayModelCatalogService(prisma, fetcher, null);
+
+ await expect(
+ service.refreshModels({
+ organizationId: "org-1",
+ connectionId: "connection-1",
+ }),
+ ).resolves.toMatchObject({ models: ["codex-auto-review", "gpt-5"] });
+ });
});