Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(shared): apply LANGFUSE_S3_CONCURRENT_WRITES to plain-HTTP S3 endpoints (#18290)

qwerty294475439cf9dd6b
diff --git a/packages/shared/src/server/services/StorageService.test.ts b/packages/shared/src/server/services/StorageService.test.ts
index 9e5b8b2d1c..bbb4208e47 100644
--- a/packages/shared/src/server/services/StorageService.test.ts
+++ b/packages/shared/src/server/services/StorageService.test.ts
@@ -787,3 +787,56 @@ describe("S3StorageService SlowDown logging", () => {
expect(warnSpy).not.toHaveBeenCalled();
});
});
+
+describe("S3StorageService request handler socket limit", () => {
+ const originalConcurrentWrites = env.LANGFUSE_S3_CONCURRENT_WRITES;
+
+ const setConcurrentWrites = (value: number) => {
+ (
+ env as { LANGFUSE_S3_CONCURRENT_WRITES: number }
+ ).LANGFUSE_S3_CONCURRENT_WRITES = value;
+ };
+
+ afterEach(() => {
+ setConcurrentWrites(originalConcurrentWrites);
+ });
+
+ type ResolvedHandlerConfig = {
+ httpAgentProvider: () => Promise<{ maxSockets: number }>;
+ httpsAgent: { maxSockets: number };
+ };
+
+ const resolveHandlerConfig = (endpoint: string) => {
+ const service = StorageServiceFactory.getInstance({
+ accessKeyId: "test-access-key",
+ secretAccessKey: "test-secret-key",
+ bucketName: "test-bucket",
+ endpoint,
+ region: "us-east-1",
+ forcePathStyle: true,
+ useAzureBlob: false,
+ useGoogleCloudStorage: false,
+ useOCIObjectStorage: false,
+ awsSse: undefined,
+ awsSseKmsKeyId: undefined,
+ });
+
+ const client = (service as unknown as { client: S3Client }).client;
+ const handler = client.config.requestHandler as unknown as {
+ configProvider: Promise<ResolvedHandlerConfig>;
+ };
+
+ return handler.configProvider;
+ };
+
+ it("applies LANGFUSE_S3_CONCURRENT_WRITES to plain-HTTP endpoints such as MinIO", async () => {
+ setConcurrentWrites(123);
+
+ const config = await resolveHandlerConfig("http://127.0.0.1:9000");
+
+ // The HTTP agent is created lazily on the first non-TLS request.
+ const httpAgent = await config.httpAgentProvider();
+ expect(httpAgent.maxSockets).toBe(123);
+ expect(config.httpsAgent.maxSockets).toBe(123);
+ });
+});
diff --git a/packages/shared/src/server/services/StorageService.ts b/packages/shared/src/server/services/StorageService.ts
index 4c591fc431..72f4d599c8 100644
--- a/packages/shared/src/server/services/StorageService.ts
+++ b/packages/shared/src/server/services/StorageService.ts
@@ -133,7 +133,10 @@ function createS3RequestHandler(
const maxSockets = env.LANGFUSE_S3_CONCURRENT_WRITES;
if (!connectionValidation) {
+ // Both agents need the limit: plain-HTTP endpoints (e.g. MinIO) go through
+ // httpAgent, which otherwise stays at the SDK default of 50 sockets.
return new NodeHttpHandler({
+ httpAgent: { maxSockets },
httpsAgent: { maxSockets },
});
}