Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Remove SimpleDataTable (#19230)

Ben Bachem77eb043c5c9d
diff --git a/web/.storybook/docs/ThemeTokens/Color.tsx b/web/.storybook/docs/ThemeTokens/Color.tsx
index 6d3c6adb16..21ce83f0f3 100644
--- a/web/.storybook/docs/ThemeTokens/Color.tsx
+++ b/web/.storybook/docs/ThemeTokens/Color.tsx
@@ -218,7 +218,7 @@ function InteractionStatesSection({ ctx }: { ctx: TokenContext }) {
state="Hover · row"
classes="hover:bg-muted/50"
tokens="--muted at 50%"
- seenIn="DataTable / SimpleDataTable"
+ seenIn="DataTable"
sample={
<div
className="flex flex-col rounded-md border text-xs"
@@ -238,7 +238,7 @@ function InteractionStatesSection({ ctx }: { ctx: TokenContext }) {
state="Selected · row"
classes="data-[state=selected]:bg-muted"
tokens="--muted"
- seenIn="DataTable / SimpleDataTable"
+ seenIn="DataTable"
sample={
<div
className="flex flex-col rounded-md border text-xs"
diff --git a/web/src/components/design-system/table/Table.tsx b/web/src/components/design-system/table/Table.tsx
index 18bac3987d..8fad7984b0 100644
--- a/web/src/components/design-system/table/Table.tsx
+++ b/web/src/components/design-system/table/Table.tsx
@@ -20,7 +20,7 @@ import { Skeleton } from "@/src/components/ui/skeleton";
import { cn } from "@/src/utils/tailwind";
const INTERACTIVE_ROW_CLICK_SELECTOR =
- "a, button, input, select, textarea, summary, [role='button'], [role='link']";
+ "a, button, input, select, textarea, summary, [role='button'], [role='link'], [data-row-click-ignore]";
function shouldIgnoreRowClickTarget(target: EventTarget | null) {
if (!(target instanceof Element)) return false;
@@ -43,6 +43,8 @@ export interface TableProps<TData> {
loadingRowCount?: number;
noResultsMessage?: React.ReactNode;
onRowClick?: (row: TData, event?: React.MouseEvent) => void;
+ getRowLabel?: (row: TData) => string;
+ selectedRowId?: string | null;
columnVisibility?: VisibilityState;
onColumnVisibilityChange?: OnChangeFn<VisibilityState>;
columnOrder?: ColumnOrderState;
@@ -63,6 +65,8 @@ export function Table<TData extends object>({
loadingRowCount = 8,
noResultsMessage = "No results",
onRowClick,
+ getRowLabel,
+ selectedRowId,
columnVisibility,
onColumnVisibilityChange,
columnOrder,
@@ -140,6 +144,8 @@ export function Table<TData extends object>({
data: data.status === "success" ? data.data : [],
columns: tableColumns,
getCoreRowModel: getCoreRowModel(),
+ getRowId: (row, index) =>
+ "id" in row && typeof row.id === "string" ? row.id : String(index),
columnResizeMode: "onChange",
state: { columnVisibility, columnOrder },
onColumnVisibilityChange,
@@ -356,15 +362,29 @@ export function Table<TData extends object>({
rowHeight === "m" && "h-24",
rowHeight === "l" && "h-64",
onRowClick ? "cursor-pointer" : "cursor-default",
+ onRowClick &&
+ "focus-visible:outline-primary focus-visible:outline-2 focus-visible:outline-offset-[-2px]",
+ selectedRowId === row.id && "bg-muted",
)}
tabIndex={onRowClick ? 0 : undefined}
+ aria-label={getRowLabel?.(row.original)}
+ aria-keyshortcuts={onRowClick ? "Enter Space" : undefined}
+ aria-selected={
+ selectedRowId === undefined
+ ? undefined
+ : selectedRowId === row.id
+ }
onClick={(event) => {
if (shouldIgnoreRowClickTarget(event.target)) return;
onRowClick?.(row.original, event);
}}
onKeyDown={(event) => {
- if (event.key !== "Enter") return;
+ if (event.key !== "Enter" && event.key !== " ") return;
+ if (!event.currentTarget.contains(event.target as Node))
+ return;
if (shouldIgnoreRowClickTarget(event.target)) return;
+ if (!onRowClick) return;
+ event.preventDefault();
onRowClick?.(row.original);
}}
>
diff --git a/web/src/components/table/SimpleDataTable.clienttest.tsx b/web/src/components/table/SimpleDataTable.clienttest.tsx
deleted file mode 100644
index 0b524ea3a6..0000000000
--- a/web/src/components/table/SimpleDataTable.clienttest.tsx
+++ /dev/null
@@ -1,101 +0,0 @@
-import { fireEvent, render, screen } from "@testing-library/react";
-import { describe, expect, it, vi } from "vitest";
-
-import { type LangfuseColumnDef } from "@/src/components/table/types";
-import { SimpleDataTable } from "./SimpleDataTable";
-
-const columns: LangfuseColumnDef<{ id: string; name: string }>[] = [
- {
- accessorKey: "name",
- header: "Name",
- cell: ({ row }) => (
- <div data-row-click-ignore>
- <button type="button">{row.original.name}</button>
- </div>
- ),
- },
-];
-
-describe("SimpleDataTable", () => {
- it("activates clickable rows without intercepting nested controls", () => {
- const onRowClick = vi.fn();
-
- render(
- <SimpleDataTable
- columns={columns}
- data={[{ id: "row-1", name: "Nested action" }]}
- isLoading={false}
- noResults={null}
- onRowClick={onRowClick}
- getRowLabel={(row) => `Open ${row.name}`}
- />,
- );
-
- const button = screen.getByRole("button", { name: "Nested action" });
- const row = button.closest("tr");
-
- expect(row).not.toBeNull();
- expect(row).not.toHaveAttribute("role", "button");
- expect(row).toHaveAccessibleName("Open Nested action");
- expect(row).toHaveAttribute("aria-keyshortcuts", "Enter Space");
-
- fireEvent.click(button);
- fireEvent.keyDown(button, { key: "Enter" });
- expect(onRowClick).not.toHaveBeenCalled();
-
- fireEvent.keyDown(row!, { key: "Enter" });
- fireEvent.keyDown(row!, { key: " " });
- expect(onRowClick).toHaveBeenCalledTimes(2);
- });
-
- it("exposes selected rows to assistive technology", () => {
- render(
- <SimpleDataTable
- columns={columns}
- data={[{ id: "row-1", name: "Selected row" }]}
- isLoading={false}
- noResults={null}
- selectedRowId="row-1"
- onRowClick={vi.fn()}
- getRowLabel={(row) => `Select ${row.name}`}
- />,
- );
-
- expect(
- screen.getByRole("row", { name: "Select Selected row" }),
- ).toHaveAttribute("aria-selected", "true");
- });
-
- it("hides responsive columns consistently", () => {
- const responsiveColumns: LangfuseColumnDef<{
- id: string;
- name: string;
- detail: string;
- }>[] = [
- { accessorKey: "name", header: "Name" },
- {
- accessorKey: "detail",
- header: "Detail",
- hideBelowMd: true,
- },
- ];
-
- render(
- <SimpleDataTable
- columns={responsiveColumns}
- data={[{ id: "row-1", name: "Name value", detail: "Detail value" }]}
- isLoading={false}
- noResults={null}
- />,
- );
-
- expect(screen.getByRole("columnheader", { name: "Detail" })).toHaveClass(
- "hidden",
- "md:table-cell",
- );
- expect(screen.getByRole("cell", { name: "Detail value" })).toHaveClass(
- "hidden",
- "md:table-cell",
- );
- });
-});
diff --git a/web/src/components/table/SimpleDataTable.tsx b/web/src/components/table/SimpleDataTable.tsx
deleted file mode 100644
index a562ad11c2..0000000000
--- a/web/src/components/table/SimpleDataTable.tsx
+++ /dev/null
@@ -1,217 +0,0 @@
-/* eslint-disable no-nested-ternary */
-import {
- flexRender,
- getCoreRowModel,
- useReactTable,
- type Row,
-} from "@tanstack/react-table";
-import { Fragment, type ReactNode } from "react";
-
-import { Skeleton } from "@/src/components/ui/skeleton";
-import { type LangfuseColumnDef } from "@/src/components/table/types";
-import { cn } from "@/src/utils/tailwind";
-
-const ROW_CLICK_IGNORE_SELECTOR = "[data-row-click-ignore]";
-
-const shouldIgnoreRowClickTarget = (target: EventTarget | null) =>
- target instanceof Element &&
- Boolean(target.closest(ROW_CLICK_IGNORE_SELECTOR));
-
-export function SimpleDataTable<TData extends object>({
- columns,
- data,
- isLoading,
- noResults,
- presentation = "default",
- bodyTone = "default",
- rowVariant = "default",
- selectedRowId,
- onRowClick,
- getRowLabel,
- renderDetailRow,
-}: {
- columns: LangfuseColumnDef<TData>[];
- data: TData[];
- isLoading: boolean;
- noResults: ReactNode;
- presentation?: "default" | "dense" | "wide";
- bodyTone?: "default" | "muted";
- rowVariant?:
- | "default"
- | "muted-hover"
- | "primary-hover"
- | "primary-hover-static"
- | "review";
- selectedRowId?: string | null;
- renderDetailRow?: (row: Row<TData>) => ReactNode;
-} & (
- | {
- onRowClick?: undefined;
- getRowLabel?: undefined;
- }
- | {
- onRowClick: (row: TData) => void;
- getRowLabel: (row: TData) => string;
- }
-)) {
- const table = useReactTable({
- data,
- columns,
- getCoreRowModel: getCoreRowModel(),
- getRowId: (row, index) =>
- "id" in row && typeof row.id === "string" ? row.id : String(index),
- });
- const visibleColumns = table.getVisibleLeafColumns();
-
- return (
- <table
- className={cn(
- "w-full table-fixed caption-bottom border-separate border-spacing-0 space-y-4 overflow-auto text-sm",
- presentation === "wide" && "min-w-[60rem] table-auto",
- )}
- >
- <thead
- className={cn(
- "[&_tr]:border-b",
- presentation === "dense" && "bg-background sticky top-0 z-10",
- )}
- >
- {table.getHeaderGroups().map((headerGroup) => (
- <tr
- key={headerGroup.id}
- className="hover:bg-muted/50 data-[state=selected]:bg-muted border-b transition-colors"
- >
- {headerGroup.headers.map((header) => (
- <th
- key={header.id}
- className={cn(
- "bg-background text-muted-foreground relative h-10 border-b px-2 text-left align-middle font-bold [&:has([role=checkbox])]:pr-0",
- header.column.columnDef.hideBelowMd && "hidden md:table-cell",
- )}
- style={
- header.column.columnDef.size === undefined
- ? undefined
- : { width: header.getSize() }
- }
- >
- {header.isPlaceholder
- ? null
- : flexRender(
- header.column.columnDef.header,
- header.getContext(),
- )}
- </th>
- ))}
- </tr>
- ))}
- </thead>
- <tbody
- className={cn(
- "text-xs [&_tr:last-child]:border-0",
- bodyTone === "muted" && "text-muted-foreground",
- )}
- >
- {isLoading ? (
- Array.from({ length: 3 }).map((_, rowIndex) => (
- <tr
- key={`loading-row-${rowIndex}`}
- aria-hidden="true"
- className="hover:bg-muted/50 data-[state=selected]:bg-muted border-b transition-colors"
- >
- {visibleColumns.map((column) => {
- const loadingCell = column.columnDef.loadingCell;
- return (
- <td
- key={column.id}
- className={cn(
- "h-full overflow-hidden border-b align-middle [&:has([role=checkbox])]:pr-0 [:last-child_>_&]:border-b-0",
- column.columnDef.hideBelowMd && "hidden md:table-cell",
- column.columnDef.cellPadding === "compact"
- ? "px-2 py-0"
- : "p-2",
- column.columnDef.cellPadding === "none" && "p-0",
- )}
- >
- {typeof loadingCell === "function" ? (
- loadingCell()
- ) : loadingCell !== undefined ? (
- loadingCell
- ) : (
- <Skeleton className="h-4 w-1/2" />
- )}
- </td>
- );
- })}
- </tr>
- ))
- ) : table.getRowModel().rows.length === 0 ? (
- <tr className="hover:bg-muted/50 data-[state=selected]:bg-muted border-b transition-colors">
- <td
- colSpan={visibleColumns.length}
- className="h-full border-b p-2 text-center align-middle [&:has([role=checkbox])]:pr-0 [:last-child_>_&]:border-b-0"
- >
- {noResults}
- </td>
- </tr>
- ) : (
- table.getRowModel().rows.map((row) => (
- <Fragment key={row.id}>
- <tr
- className={cn(
- "hover:bg-muted/50 data-[state=selected]:bg-muted border-b transition-colors",
- onRowClick &&
- "focus-visible:outline-primary cursor-pointer focus-visible:outline-2 focus-visible:outline-offset-[-2px]",
- presentation === "dense" && "text-xs",
- rowVariant === "muted-hover" && "hover:bg-muted",
- (rowVariant === "primary-hover" ||
- rowVariant === "primary-hover-static") &&
- "hover:bg-primary-foreground",
- rowVariant === "primary-hover-static" && "cursor-default",
- rowVariant === "review" && "group/row",
- selectedRowId === row.id && "bg-muted",
- )}
- onClick={(event) => {
- if (shouldIgnoreRowClickTarget(event.target)) return;
- onRowClick?.(row.original);
- }}
- onKeyDown={(event) => {
- if (event.key !== "Enter" && event.key !== " ") return;
- if (shouldIgnoreRowClickTarget(event.target)) return;
-
- event.preventDefault();
- onRowClick?.(row.original);
- }}
- tabIndex={onRowClick ? 0 : undefined}
- aria-keyshortcuts={onRowClick ? "Enter Space" : undefined}
- aria-label={getRowLabel?.(row.original)}
- aria-selected={
- selectedRowId === undefined
- ? undefined
- : selectedRowId === row.id
- }
- >
- {row.getVisibleCells().map((cell) => (
- <td
- key={cell.id}
- className={cn(
- "h-full overflow-hidden border-b align-middle [&:has([role=checkbox])]:pr-0 [:last-child_>_&]:border-b-0",
- cell.column.columnDef.hideBelowMd &&
- "hidden md:table-cell",
- cell.column.columnDef.cellPadding === "compact"
- ? "px-2 py-0"
- : "p-2",
- cell.column.columnDef.cellPadding === "none" && "p-0",
- )}
- >
- {flexRender(cell.column.columnDef.cell, cell.getContext())}
- </td>
- ))}
- </tr>
- {renderDetailRow?.(row)}
- </Fragment>
- ))
- )}
- </tbody>
- </table>
- );
-}
diff --git a/web/src/ee/features/sso-settings/components/SsoConfigDialogController.stories.tsx b/web/src/ee/features/sso-settings/components/SsoConfigDialogController.stories.tsx
new file mode 100644
index 0000000000..9eecb8301f
--- /dev/null
+++ b/web/src/ee/features/sso-settings/components/SsoConfigDialogController.stories.tsx
@@ -0,0 +1,59 @@
+import { type ComponentProps } from "react";
+import { fn, userEvent, within } from "storybook/test";
+import preview from "../../../../../.storybook/preview";
+import { Button } from "@/src/components/design-system/Button/Button";
+import { SsoConfigDialogController } from "./SsoConfigDialogController";
+
+const meta = preview.meta({
+ component: SsoConfigDialogController,
+ args: {
+ isSaving: false,
+ onSave:
+ fn<
+ ComponentProps<typeof SsoConfigDialogController>["onSave"]
+ >().mockResolvedValue(undefined),
+ },
+ play: async ({ canvasElement }) => {
+ await userEvent.click(
+ within(canvasElement).getByRole("button", {
+ name: "Open SSO configuration",
+ }),
+ );
+ },
+});
+
+export const Configure = meta.story({
+ args: {
+ children: ({ openDialog }) => (
+ <Button
+ text="Open SSO configuration"
+ onClick={() => openDialog({ domain: "example.com", config: null })}
+ />
+ ),
+ },
+});
+
+export const Edit = meta.story({
+ args: {
+ children: ({ openDialog }) => (
+ <Button
+ text="Open SSO configuration"
+ onClick={() =>
+ openDialog({
+ domain: "company.com",
+ config: {
+ domain: "company.com",
+ authProvider: "okta",
+ authConfig: {
+ clientId: "example-client-id",
+ issuer: "https://company.okta.com",
+ },
+ createdAt: new Date("2026-09-01"),
+ updatedAt: new Date("2026-09-20"),
+ },
+ })
+ }
+ />
+ ),
+ },
+});
diff --git a/web/src/ee/features/sso-settings/components/SsoConfigDialogController.tsx b/web/src/ee/features/sso-settings/components/SsoConfigDialogController.tsx
index 414657eeaf..1abe7f388d 100644
--- a/web/src/ee/features/sso-settings/components/SsoConfigDialogController.tsx
+++ b/web/src/ee/features/sso-settings/components/SsoConfigDialogController.tsx
@@ -1,12 +1,9 @@
-/* eslint-disable @typescript-eslint/no-deprecated, react/no-unstable-nested-components, @typescript-eslint/no-use-before-define -- Legacy UI usage retained during migration to design-system components. */
-import { showErrorToast, showSuccessToast } from "@/src/features/notifications";
+/* eslint-disable @typescript-eslint/no-deprecated, @typescript-eslint/no-use-before-define -- Legacy UI usage retained during migration to design-system components. */
+import { showErrorToast } from "@/src/features/notifications";
import { ConfirmationDialogController } from "@/src/components/design-system/ConfirmationDialogController/ConfirmationDialogController";
import { DialogController } from "@/src/components/design-system/DialogController/DialogController";
import { Checkbox } from "@/src/components/design-system/Checkbox/Checkbox";
import { Button } from "@/src/components/ui/button";
-import { Card } from "@/src/components/ui/card";
-import { SimpleDataTable } from "@/src/components/table/SimpleDataTable";
-import { type LangfuseColumnDef } from "@/src/components/table/types";
import { SelectInput } from "@/src/components/design-system/SelectInput/SelectInput";
import {
DialogBody,
@@ -26,14 +23,12 @@ import {
} from "@/src/components/ui/form";
import { Input } from "@/src/components/ui/input";
import { SsoProviderSchema } from "@/src/ee/features/multi-tenant-sso";
-import { api } from "@/src/utils/api";
import { zodResolver } from "@hookform/resolvers/zod";
import { Check, Copy } from "@langfuse/icons";
-import { useMemo, useState } from "react";
+import { useId, useMemo, useState } from "react";
import { useForm } from "react-hook-form";
import { z } from "zod";
import { useCopyToClipboard } from "@/src/hooks/useCopyToClipboard";
-import { classifyTrpcToastError } from "@/src/utils/trpcErrorClassification";
import {
type SsoConfigRow,
type SsoConfigTableRow,
@@ -91,10 +86,12 @@ type AuthConfigFormField = `authConfig.${
| "idToken"}`;
export function SsoConfigDialogController({
- orgId,
+ onSave,
+ isSaving,
children,
}: {
- orgId: string;
+ onSave: (payload: SsoProviderSchema) => Promise<void>;
+ isSaving: boolean;
children: (control: {
openDialog: (config: SsoConfigTableRow) => void;
}) => React.ReactNode;
@@ -105,7 +102,8 @@ export function SsoConfigDialogController({
<DialogContent className="sm:max-w-xl">
<SsoConfigDialogContent
key={state.domain}
- orgId={orgId}
+ onSave={onSave}
+ isSaving={isSaving}
domain={state.domain}
existing={state.config}
closeDialog={closeDialog}
@@ -119,18 +117,19 @@ export function SsoConfigDialogController({
}
function SsoConfigDialogContent({
- orgId,
+ onSave,
+ isSaving,
domain,
existing,
closeDialog,
}: {
- orgId: string;
+ onSave: React.ComponentProps<typeof SsoConfigDialogController>["onSave"];
+ isSaving: boolean;
domain: string;
existing: SsoConfigRow | null;
closeDialog: () => void;
}) {
const [pendingValues, setPendingValues] = useState<FormValues | null>(null);
- const utils = api.useUtils();
const defaultValues = useMemo<FormValues>(() => {
const cfg = (existing?.authConfig ?? {}) as Record<string, unknown>;
@@ -166,27 +165,6 @@ function SsoConfigDialogContent({
return `${window.location.origin}/api/auth/callback/${domain}.${selectedProvider}`;
}, [domain, selectedProvider]);
- const saveMutation = api.ssoConfig.save.useMutation({
- onSuccess: () => {
- utils.ssoConfig.get.invalidate({ orgId });
- showSuccessToast({
- operation: existing ? "sso.update" : "sso.configure",
- title: existing ? "SSO updated" : "SSO configured",
- description: `Active for @${domain} within 1 hour.`,
- });
- closeDialog();
- setPendingValues(null);
- form.reset();
- },
- onError: (err) => {
- showErrorToast(
- existing ? "Update failed" : "SSO configuration failed",
- err.message,
- classifyTrpcToastError(err, existing ? "sso.update" : "sso.configure"),
- );
- },
- });
-
async function handleConfirm() {
if (!pendingValues) return;
const payload = buildSsoPayload(domain, pendingValues);
@@ -232,7 +210,10 @@ function SsoConfigDialogContent({
}
return;
}
- await saveMutation.mutateAsync({ orgId, payload: parsed.data });
+ await onSave(parsed.data);
+ closeDialog();
+ setPendingValues(null);
+ form.reset();
}
return (
@@ -245,7 +226,7 @@ function SsoConfigDialogContent({
text={`Saving will activate SSO for @${domain} within 1 hour. Every user at that domain will be redirected to your identity provider on sign-in - they will not be able to use Google, GitHub, password, or any other method until SSO is deleted.${existing ? " The new credentials will replace the active configuration." : ""} Tip: sign in via the new SSO in a second browser to confirm it works before closing this tab.`}
confirmLabel={existing ? "Replace" : "Activate SSO"}
variant="default"
- loading={saveMutation.isPending}
+ loading={isSaving}
onConfirm={handleConfirm}
>
{({ openDialog }) => (
@@ -426,7 +407,7 @@ function SsoConfigDialogContent({
<Button type="button" variant="ghost" onClick={closeDialog}>
Cancel
</Button>
- <Button type="submit" loading={saveMutation.isPending}>
+ <Button type="submit" loading={isSaving}>
Save
</Button>
</DialogFooter>
@@ -439,63 +420,52 @@ function SsoConfigDialogContent({
}
function CallbackUrlPanel({ callbackUrl }: { callbackUrl: string }) {
- const columns: LangfuseColumnDef<{ url: string }>[] = [
- {
- accessorKey: "url",
- header: "URL",
- cell: ({ getValue }) => (
- <CopyableCallbackUrl value={getValue<string>()} />
- ),
- },
- ];
+ const inputId = useId();
+ const { copy, isCopied } = useCopyToClipboard();
return (
<div>
- <p className="mb-2 text-sm font-bold">Callback URL</p>
- <Card className="overflow-hidden">
- <SimpleDataTable
- columns={columns}
- data={[{ url: callbackUrl }]}
- isLoading={false}
- noResults={null}
+ <label htmlFor={inputId} className="mb-2 block text-sm font-bold">
+ Callback URL
+ </label>
+ <div className="relative">
+ <Input
+ id={inputId}
+ value={callbackUrl}
+ readOnly
+ aria-describedby={`${inputId}-description`}
+ className="pr-8 font-mono"
/>
- </Card>
- <p className="text-muted-foreground mt-2 text-xs">
+ <Button
+ type="button"
+ variant="ghost"
+ size="icon-xs"
+ className="absolute top-1/2 right-0 -translate-y-1/2"
+ title="Copy to clipboard"
+ aria-label="Copy to clipboard"
+ onClick={async (event) => {
+ const button = event.currentTarget;
+ await copy(callbackUrl).catch(() => undefined);
+ button.focus();
+ }}
+ >
+ {isCopied ? (
+ <Check size="sm" color="default" />
+ ) : (
+ <Copy size="sm" color="default" />
+ )}
+ </Button>
+ </div>
+ <p
+ id={`${inputId}-description`}
+ className="text-muted-foreground mt-2 text-xs"
+ >
Add this URL as an authorized redirect URI in your identity provider.
</p>
</div>
);
}
-function CopyableCallbackUrl({ value }: { value: string }) {
- const { copy, isCopied } = useCopyToClipboard();
-
- return (
- <div className="relative pr-8 font-mono break-all">
- <span>{value}</span>
- <Button
- variant="ghost"
- size="icon-xs"
- className="absolute top-1/2 right-0 -translate-y-1/2"
- title="Copy to clipboard"
- aria-label="Copy to clipboard"
- onClick={async (event) => {
- event.preventDefault();
- const button = event.currentTarget;
- await copy(value).catch(() => undefined);
- button.focus();
- }}
- >
- {isCopied ? (
- <Check size="sm" color="default" />
- ) : (
- <Copy size="sm" color="default" />
- )}
- </Button>
- </div>
- );
-}
-
// Build the SsoProviderSchema-shaped payload from the flat form values.
// Handles the nested github-enterprise.enterprise.baseUrl shape.
function buildSsoPayload(domain: string, values: FormValues) {
diff --git a/web/src/ee/features/sso-settings/components/SsoConfigsTable/ConnectedSsoConfigsTable.tsx b/web/src/ee/features/sso-settings/components/SsoConfigsTable/ConnectedSsoConfigsTable.tsx
index d78933a221..b974941ca8 100644
--- a/web/src/ee/features/sso-settings/components/SsoConfigsTable/ConnectedSsoConfigsTable.tsx
+++ b/web/src/ee/features/sso-settings/components/SsoConfigsTable/ConnectedSsoConfigsTable.tsx
@@ -1,5 +1,7 @@
import { useMemo } from "react";
import { api } from "@/src/utils/api";
+import { showErrorToast, showSuccessToast } from "@/src/features/notifications";
+import { classifyTrpcToastError } from "@/src/utils/trpcErrorClassification";
import { Card } from "@/src/components/ui/card";
import { DeleteSsoConfigDialogController } from "../DeleteSsoConfigDialogController";
import { SsoConfigDialogController } from "../SsoConfigDialogController";
@@ -26,6 +28,27 @@ export function ConnectedSsoConfigsTable({ orgId }: { orgId: string }) {
return map;
}, [ssoConfigsQuery.data]);
+ const utils = api.useUtils();
+ const saveMutation = api.ssoConfig.save.useMutation({
+ onSuccess: (_, { payload }) => {
+ utils.ssoConfig.get.invalidate({ orgId });
+ const existing = configByDomain.has(payload.domain);
+ showSuccessToast({
+ operation: existing ? "sso.update" : "sso.configure",
+ title: existing ? "SSO updated" : "SSO configured",
+ description: `Active for @${payload.domain} within 1 hour.`,
+ });
+ },
+ onError: (err, { payload }) => {
+ const existing = configByDomain.has(payload.domain);
+ showErrorToast(
+ existing ? "Update failed" : "SSO configuration failed",
+ err.message,
+ classifyTrpcToastError(err, existing ? "sso.update" : "sso.configure"),
+ );
+ },
+ });
+
const data: SsoConfigTableRow[] = verifiedDomains.map((domain) => ({
domain: domain.domain,
config: configByDomain.get(domain.domain) ?? null,
@@ -42,7 +65,12 @@ export function ConnectedSsoConfigsTable({ orgId }: { orgId: string }) {
}
return (
- <SsoConfigDialogController orgId={orgId}>
+ <SsoConfigDialogController
+ isSaving={saveMutation.isPending}
+ onSave={async (payload) => {
+ await saveMutation.mutateAsync({ orgId, payload });
+ }}
+ >
{({ openDialog: openConfigDialog }) => (
<DeleteSsoConfigDialogController orgId={orgId}>
{({ openDialog: openDeleteDialog }) => (
diff --git a/web/src/features/chart-view-prototype/components/MockEventsTable.tsx b/web/src/features/chart-view-prototype/components/MockEventsTable.tsx
index 3d3d75035d..7260fa85c1 100644
--- a/web/src/features/chart-view-prototype/components/MockEventsTable.tsx
+++ b/web/src/features/chart-view-prototype/components/MockEventsTable.tsx
@@ -1,6 +1,6 @@
import React from "react";
import { Badge } from "@/src/components/ui/badge";
-import { SimpleDataTable } from "@/src/components/table/SimpleDataTable";
+import { Table } from "@/src/components/design-system/table/Table";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
@@ -122,13 +122,12 @@ export const MockEventsTable = React.memo(function MockEventsTable({
return (
<div className="flex h-full flex-col overflow-hidden">
- <div className="min-h-0 flex-1 overflow-auto">
- <SimpleDataTable
+ <div className="flex min-h-0 flex-1 flex-col">
+ <Table
+ tableName="Events"
columns={columns}
- data={rows}
- isLoading={false}
- noResults={null}
- presentation="dense"
+ data={{ status: "success", data: rows }}
+ noResultsMessage={null}
/>
</div>
<div className="text-muted-foreground border-t px-3 py-1.5 text-xs">
diff --git a/web/src/features/dashboard/components/SelectDashboardDialog.tsx b/web/src/features/dashboard/components/SelectDashboardDialog.tsx
index 231d5267ce..8c9e0da29d 100644
--- a/web/src/features/dashboard/components/SelectDashboardDialog.tsx
+++ b/web/src/features/dashboard/components/SelectDashboardDialog.tsx
@@ -10,7 +10,7 @@ import {
DialogBody,
} from "@/src/components/ui/dialog";
import { Button } from "@/src/components/ui/button";
-import { SimpleDataTable } from "@/src/components/table/SimpleDataTable";
+import { Table } from "@/src/components/design-system/table/Table";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
import { type LangfuseColumnDef } from "@/src/components/table/types";
@@ -106,16 +106,17 @@ export function SelectDashboardDialog({
No dashboards found.
</div>
) : (
- <SimpleDataTable
+ <Table
+ tableName="Dashboards"
columns={columns}
- data={
- dashboards.data?.dashboards.filter(
- (dashboard: Dashboard) => dashboard.owner === "PROJECT",
- ) ?? []
- }
- isLoading={false}
- noResults={null}
- rowVariant="muted-hover"
+ data={{
+ status: "success",
+ data:
+ dashboards.data?.dashboards.filter(
+ (dashboard: Dashboard) => dashboard.owner === "PROJECT",
+ ) ?? [],
+ }}
+ noResultsMessage={null}
selectedRowId={selectedDashboardId}
onRowClick={(dashboard) => setSelectedDashboardId(dashboard.id)}
getRowLabel={(dashboard) =>
diff --git a/web/src/features/v4-migration/V4MigrationStatusPage.clienttest.tsx b/web/src/features/v4-migration/V4MigrationStatusPage.clienttest.tsx
index a731d12885..0ffc9d2302 100644
--- a/web/src/features/v4-migration/V4MigrationStatusPage.clienttest.tsx
+++ b/web/src/features/v4-migration/V4MigrationStatusPage.clienttest.tsx
@@ -176,8 +176,9 @@ describe("V4MigrationStatusPage", () => {
render(<V4MigrationStatusPage />);
const table = screen.getByRole("table");
- expect(table).toHaveClass("min-w-[60rem]", "table-auto");
- expect(table.parentElement).toHaveClass("overflow-x-auto");
+ const widthConstraint = table.closest(".min-w-\\[60rem\\]");
+ expect(widthConstraint).not.toBeNull();
+ expect(widthConstraint?.parentElement).toHaveClass("overflow-x-auto");
});
it("shows migration readiness to project members", () => {
diff --git a/web/src/features/v4-migration/V4MigrationStatusPage.tsx b/web/src/features/v4-migration/V4MigrationStatusPage.tsx
index c5281e58b2..3ffc2ac138 100644
--- a/web/src/features/v4-migration/V4MigrationStatusPage.tsx
+++ b/web/src/features/v4-migration/V4MigrationStatusPage.tsx
@@ -7,7 +7,7 @@ import { useSession } from "next-auth/react";
import { ArrowRight } from "@langfuse/icons";
import ContainerPage from "@/src/components/layouts/ContainerPage";
import { Card } from "@/src/components/ui/card";
-import { SimpleDataTable } from "@/src/components/table/SimpleDataTable";
+import { Table } from "@/src/components/design-system/table/Table";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
import {
@@ -439,16 +439,17 @@ function OrgStatusSection({
</h3>
<Card className="overflow-hidden">
<div className="overflow-x-auto">
- <SimpleDataTable
- columns={columns}
- data={sortedRows}
- isLoading={false}
- noResults={null}
- presentation="wide"
- rowVariant="review"
- onRowClick={(row) => handleRowClick(row, row.readiness)}
- getRowLabel={(row) => `Review ${row.name}`}
- />
+ <div className="min-w-[60rem]">
+ <Table
+ tableName={`${org.name} migration status`}
+ columns={columns}
+ data={{ status: "success", data: sortedRows }}
+ noResultsMessage={null}
+ topBorder={false}
+ onRowClick={(row) => handleRowClick(row, row.readiness)}
+ getRowLabel={(row) => `Review ${row.name}`}
+ />
+ </div>
</div>
</Card>
</div>