Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

feat(experiments): streamline side-by-side comparison (#17929)

marliessophie7aead5f3de4d
diff --git a/web/src/components/scores-table-cell.tsx b/web/src/components/scores-table-cell.tsx
index 0f78522a00..fb7154b64a 100644
--- a/web/src/components/scores-table-cell.tsx
+++ b/web/src/components/scores-table-cell.tsx
@@ -19,14 +19,6 @@ import React from "react";
import { copyTextToClipboard } from "@/src/utils/clipboard";
import { Button } from "@/src/components/ui/button";
-// Boolean scores render as `true`/`false`; the capitalised entries keep the same
-// treatment for categorical scores whose category happens to be True/False.
-const COLOR_MAP = new Map([
- ["true", "bg-light-green p-0.5 text-dark-green"],
- ["True", "bg-light-green p-0.5 text-dark-green"],
- ["false", "bg-light-red p-0.5 text-dark-red"],
- ["False", "bg-light-red p-0.5 text-dark-red"],
-]);
const COLLAPSE_CATEGORICAL_SCORES_AFTER = 2;
const ScoreValueCounts = ({
@@ -91,12 +83,7 @@ export const ScoresTableCell = ({
// `inline-flex` triggers keep each icon's box the size of the icon, which
// the row then centres. Left to stretch, a trigger's box grows with the
// row and pins the icon to its top, off the value's centre.
- <span
- className={cn(
- "flex min-w-0 flex-row items-center gap-0.5 rounded-sm",
- COLOR_MAP.get(value),
- )}
- >
+ <span className="flex min-w-0 flex-row items-center gap-0.5 rounded-sm">
<span
className="truncate"
title={valueTitle ? `${valueTitle}: ${value}` : value}
diff --git a/web/src/components/table/data-table-toolbar.clienttest.tsx b/web/src/components/table/data-table-toolbar.clienttest.tsx
index f12e019b2f..a5b6330d94 100644
--- a/web/src/components/table/data-table-toolbar.clienttest.tsx
+++ b/web/src/components/table/data-table-toolbar.clienttest.tsx
@@ -1,6 +1,6 @@
import { fireEvent, render, screen } from "@testing-library/react";
import { vi } from "vitest";
-import { ExperimentFormatSetting } from "@/src/features/experiments";
+import { ExperimentDisplaySettings } from "@/src/features/experiments";
import {
DataTableToolbar,
type MultiSelect,
@@ -212,13 +212,21 @@ describe("DataTableToolbar presentation controls", () => {
).not.toBeInTheDocument();
});
- it("keeps the format switch accessible while the column picker is closed", () => {
+ it("opens display settings independently of the column picker", () => {
const onIoRenderModeChange = vi.fn();
render(
<DataTableToolbar
{...settingsProps}
toolbarSettings={
- <ExperimentFormatSetting
+ <ExperimentDisplaySettings
+ layout="grid"
+ onLayoutChange={vi.fn()}
+ diffMode="comparison"
+ onDiffModeChange={vi.fn()}
+ itemVisibility="all"
+ onItemVisibilityChange={vi.fn()}
+ hasComparisons
+ hasBaseline
ioRenderMode="json"
onIoRenderModeChange={onIoRenderModeChange}
/>
@@ -226,13 +234,15 @@ describe("DataTableToolbar presentation controls", () => {
/>,
);
- fireEvent.click(screen.getByRole("radio", { name: "JSON" }));
- expect(onIoRenderModeChange).not.toHaveBeenCalled();
- fireEvent.click(screen.getByRole("radio", { name: "Formatted" }));
+ expect(screen.queryByRole("menuitem", { name: "Formatted" })).toBeNull();
+ fireEvent.keyDown(screen.getByRole("button", { name: "Display" }), {
+ key: "Enter",
+ });
+ fireEvent.click(screen.getByRole("menuitem", { name: "Formatted" }));
expect(onIoRenderModeChange).toHaveBeenCalledExactlyOnceWith("text");
fireEvent.click(screen.getByRole("button", { name: /^Columns/ }));
expect(screen.getByRole("dialog")).toBeInTheDocument();
expect(screen.getByRole("button", { name: "Row height" })).toBeVisible();
- expect(screen.getByRole("radio", { name: "JSON" })).toBeVisible();
+ expect(screen.getByRole("button", { name: "Display" })).toBeVisible();
});
});
diff --git a/web/src/components/ui/badge.tsx b/web/src/components/ui/badge.tsx
index 975ff5ed05..f364aa63a8 100644
--- a/web/src/components/ui/badge.tsx
+++ b/web/src/components/ui/badge.tsx
@@ -35,6 +35,7 @@ const badgeVariants = cva(
"border-transparent bg-amber-100 text-amber-800 dark:bg-amber-950 dark:text-amber-200",
green:
"border-transparent bg-green-100 text-green-800 dark:bg-green-950 dark:text-green-200",
+ ghost: "border-transparent bg-transparent text-muted-foreground",
},
},
defaultVariants: {
diff --git a/web/src/features/datasets/components/DiffLabel.tsx b/web/src/features/datasets/components/DiffLabel.tsx
index b3ebefcbd4..2de1350715 100644
--- a/web/src/features/datasets/components/DiffLabel.tsx
+++ b/web/src/features/datasets/components/DiffLabel.tsx
@@ -1,5 +1,5 @@
/* eslint-disable @repo/no-style-props */
-import { Badge } from "@/src/components/ui/badge";
+import { Badge, type BadgeProps } from "@/src/components/ui/badge";
import {
type CategoricalDiff,
type NumericDiff,
@@ -23,6 +23,7 @@ export function DiffLabel({
className,
preferNegativeDiff = false,
title,
+ variant,
}: {
diff: NumericDiff | CategoricalDiff;
formatValue: (value: number) => string;
@@ -34,15 +35,20 @@ export function DiffLabel({
* (`describeRunComparison`). Falls back to the chip's own text.
*/
title?: string;
+ variant?: BadgeProps["variant"];
}) {
if (diff.type === "NUMERIC") {
return (
<Badge
- variant={getVariant(diff.direction, preferNegativeDiff)}
+ variant={variant ?? getVariant(diff.direction, preferNegativeDiff)}
// A number must never break across the badge's line box or give up
// width to a sibling: both render a fragment. If it cannot sit beside
// the value it qualifies, the caller's row wraps it whole.
- className={cn("shrink-0 font-bold whitespace-nowrap", className)}
+ className={cn(
+ "shrink-0 whitespace-nowrap",
+ variant === "ghost" ? "font-normal" : "font-bold",
+ className,
+ )}
title={title}
>
{diff.direction}
@@ -56,11 +62,15 @@ export function DiffLabel({
const move = diff.from && diff.to ? `${diff.from} → ${diff.to}` : "Varies";
return (
<Badge
- variant="warning"
+ variant={variant ?? "warning"}
// A named move can be longer than the cell it sits in, and the value it
// qualifies matters more than the move does — so shrink and ellipsise
// here rather than clipping mid-word, and keep the full move on hover.
- className={cn("min-w-0 truncate font-bold", className)}
+ className={cn(
+ "min-w-0 truncate",
+ variant === "ghost" ? "font-normal" : "font-bold",
+ className,
+ )}
title={title ?? move}
>
{move}
diff --git a/web/src/features/experiments/ExperimentResultsPage.tsx b/web/src/features/experiments/ExperimentResultsPage.tsx
index 053df98684..ee9f7b9a0e 100644
--- a/web/src/features/experiments/ExperimentResultsPage.tsx
+++ b/web/src/features/experiments/ExperimentResultsPage.tsx
@@ -10,7 +10,6 @@ import {
import useSessionStorage from "@/src/components/useSessionStorage";
import { useCallback, useEffect } from "react";
import { ExperimentDisplaySettings } from "@/src/features/experiments/components/ExperimentDisplaySettings";
-import { ExperimentFormatSetting } from "@/src/features/experiments/components/ExperimentFormatSetting";
import { useExperimentAccess } from "@/src/features/experiments/hooks/useExperimentAccess";
import { Spinner } from "@/src/components/design-system/Spinner/Spinner";
import { ExperimentSelectionControls } from "@/src/features/experiments/components/ExperimentSelectionControls";
@@ -148,23 +147,10 @@ export default function ExperimentResultsPage() {
/>
),
actionButtonsRight: (
- <>
- <ExperimentDisplaySettings
- layout={layout}
- onLayoutChange={handleLayoutChange}
- diffMode={diffMode}
- onDiffModeChange={handleDiffModeChange}
- itemVisibility={itemVisibility}
- onItemVisibilityChange={setItemVisibility}
- hasComparisons={comparisonIds.length > 0}
- hasBaseline={hasBaseline}
- />
-
- <OverviewPanelToggle
- open={isOverviewOpen}
- onOpenChange={setIsOverviewOpen}
- />
- </>
+ <OverviewPanelToggle
+ open={isOverviewOpen}
+ onOpenChange={setIsOverviewOpen}
+ />
),
}}
>
@@ -180,7 +166,15 @@ export default function ExperimentResultsPage() {
projectId={projectId}
ioRenderMode={ioRenderMode}
toolbarSettings={
- <ExperimentFormatSetting
+ <ExperimentDisplaySettings
+ layout={layout}
+ onLayoutChange={handleLayoutChange}
+ diffMode={diffMode}
+ onDiffModeChange={handleDiffModeChange}
+ itemVisibility={itemVisibility}
+ onItemVisibilityChange={setItemVisibility}
+ hasComparisons={comparisonIds.length > 0}
+ hasBaseline={hasBaseline}
ioRenderMode={ioRenderMode}
onIoRenderModeChange={setIoRenderMode}
/>
diff --git a/web/src/features/experiments/components/ExperimentDisplaySettings.tsx b/web/src/features/experiments/components/ExperimentDisplaySettings.tsx
index fc6130974c..3107859146 100644
--- a/web/src/features/experiments/components/ExperimentDisplaySettings.tsx
+++ b/web/src/features/experiments/components/ExperimentDisplaySettings.tsx
@@ -7,6 +7,7 @@ import {
DropdownMenuSeparator,
DropdownMenuTrigger,
} from "@/src/components/ui/dropdown-menu";
+import { type IoRenderMode } from "@/src/components/table/data-table-io-render-mode-switch";
import { Button } from "@/src/components/ui/button";
import { Settings2, Check } from "lucide-react";
import {
@@ -23,6 +24,8 @@ type ExperimentDisplaySettingsProps = {
onItemVisibilityChange: (visibility: "baseline-only" | "all") => void;
hasComparisons: boolean;
hasBaseline: boolean;
+ ioRenderMode: IoRenderMode;
+ onIoRenderModeChange: (mode: IoRenderMode) => void;
};
/** A menu row that reads as a radio option. */
@@ -52,7 +55,7 @@ const OptionItem = ({
* second line is measured against, and whether items missing from the baseline
* are listed.
*
- * These settings live in the URL and travel with a shared link.
+ * Comparison settings travel with a shared URL; cell format is stored locally.
*/
export function ExperimentDisplaySettings({
layout,
@@ -63,15 +66,17 @@ export function ExperimentDisplaySettings({
onItemVisibilityChange,
hasComparisons,
hasBaseline,
+ ioRenderMode,
+ onIoRenderModeChange,
}: ExperimentDisplaySettingsProps) {
const isItemVisibilityDisabled = !hasComparisons || !hasBaseline;
return (
<DropdownMenu>
<DropdownMenuTrigger asChild>
- <Button variant="outline">
+ <Button variant="outline" className="h-8 px-2.5 text-xs">
<Settings2 className="h-4 w-4" />
- <span className="ml-2 hidden md:inline">Display</span>
+ <span className="ml-2">Display</span>
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end" className="w-64">
@@ -97,6 +102,22 @@ export function ExperimentDisplaySettings({
<DropdownMenuSeparator />
+ <DropdownMenuLabel>Cell format</DropdownMenuLabel>
+ <OptionItem
+ selected={ioRenderMode === "json"}
+ onSelect={() => onIoRenderModeChange("json")}
+ >
+ JSON
+ </OptionItem>
+ <OptionItem
+ selected={ioRenderMode === "text"}
+ onSelect={() => onIoRenderModeChange("text")}
+ >
+ Formatted
+ </OptionItem>
+
+ <DropdownMenuSeparator />
+
<DropdownMenuLabel>Diff</DropdownMenuLabel>
<OptionItem
selected={diffMode === "comparison"}
diff --git a/web/src/features/experiments/components/ExperimentFormatSetting.tsx b/web/src/features/experiments/components/ExperimentFormatSetting.tsx
deleted file mode 100644
index 746a355448..0000000000
--- a/web/src/features/experiments/components/ExperimentFormatSetting.tsx
+++ /dev/null
@@ -1,39 +0,0 @@
-import { Braces, Text } from "lucide-react";
-import { ToggleGroup, ToggleGroupItem } from "@/src/components/ui/toggle-group";
-import { type IoRenderMode } from "@/src/components/table/data-table-io-render-mode-switch";
-
-export const ExperimentFormatSetting = ({
- ioRenderMode,
- onIoRenderModeChange,
-}: {
- ioRenderMode: IoRenderMode;
- onIoRenderModeChange: (mode: IoRenderMode) => void;
-}) => (
- <ToggleGroup
- type="single"
- value={ioRenderMode}
- onValueChange={(value) => {
- if (value === "json" || value === "text") onIoRenderModeChange(value);
- }}
- variant="outline"
- aria-label="Cell format"
- className="gap-0"
- >
- <ToggleGroupItem
- value="json"
- aria-label="JSON"
- className="h-8 gap-1.5 rounded-r-none px-2.5 text-xs"
- >
- <Braces className="h-3.5 w-3.5" />
- JSON
- </ToggleGroupItem>
- <ToggleGroupItem
- value="text"
- aria-label="Formatted"
- className="h-8 gap-1.5 rounded-l-none border-l-0 px-2.5 text-xs"
- >
- <Text className="h-3.5 w-3.5" />
- Formatted
- </ToggleGroupItem>
- </ToggleGroup>
-);
diff --git a/web/src/features/experiments/components/table/ExperimentGridCell.clienttest.tsx b/web/src/features/experiments/components/table/ExperimentGridCell.clienttest.tsx
index e13eb5b18e..bdd74eb00e 100644
--- a/web/src/features/experiments/components/table/ExperimentGridCell.clienttest.tsx
+++ b/web/src/features/experiments/components/table/ExperimentGridCell.clienttest.tsx
@@ -9,11 +9,13 @@ import type { VisibilityState } from "@tanstack/react-table";
import { ExperimentGridCell } from "./ExperimentGridCell";
import { TooltipProvider } from "@/src/components/ui/tooltip";
+const metadataQuery = vi.hoisted(() => vi.fn(() => ({ data: undefined })));
+
vi.mock("@/src/utils/api", () => ({
api: {
scores: {
getScoreMetadataById: {
- useQuery: () => ({ data: undefined }),
+ useQuery: metadataQuery,
},
},
},
@@ -31,6 +33,7 @@ const renderGridCell = (
columnVisibility: VisibilityState = { output: false, metadata: false },
output: unknown = null,
onExperimentClick?: (event: React.MouseEvent) => void,
+ isBaseline = true,
) =>
render(
<TooltipProvider>
@@ -49,6 +52,8 @@ const renderGridCell = (
type: "NUMERIC",
values: [0.8],
average: 0.8,
+ id: "score-id",
+ hasMetadata: true,
comment: "Evaluator comment",
executionTraceId: "execution-trace-id",
},
@@ -58,11 +63,28 @@ const renderGridCell = (
type: "NUMERIC",
values: [0.9],
average: 0.9,
+ id: "trace-score-id",
},
}}
observationScoreOrder={[observationScoreKey]}
traceScoreOrder={[traceScoreKey]}
- isBaseline
+ isBaseline={isBaseline}
+ baselineScores={{
+ [observationScoreKey]: {
+ type: "NUMERIC",
+ values: [0.3],
+ average: 0.3,
+ id: "baseline-score-id",
+ },
+ }}
+ baselineTraceScores={{
+ [traceScoreKey]: {
+ type: "NUMERIC",
+ values: [0.7],
+ average: 0.7,
+ id: "baseline-trace-score-id",
+ },
+ }}
columnVisibility={columnVisibility}
showScoreLevelLabels={showScoreLevelLabels}
/>
@@ -70,6 +92,23 @@ const renderGridCell = (
);
describe("ExperimentGridCell", () => {
+ it("keeps inline score diffs without explanatory native tooltips", () => {
+ const { unmount } = renderGridCell(
+ false,
+ { output: false, metadata: false },
+ null,
+ undefined,
+ false,
+ );
+ expect(screen.getByText("+0.50")).toBeInTheDocument();
+ expect(screen.getByText("+0.50")).not.toHaveAttribute("title");
+ expect(screen.getByText("+0.20")).toBeInTheDocument();
+ unmount();
+ renderGridCell(false);
+ expect(screen.queryByText("+0.50")).not.toBeInTheDocument();
+ expect(screen.queryByText("+0.20")).not.toBeInTheDocument();
+ });
+
it("shows full labels for every score when both levels are present", () => {
renderGridCell(true);
@@ -86,23 +125,55 @@ describe("ExperimentGridCell", () => {
expect(screen.getByText("correctness")).toBeInTheDocument();
});
- it("keeps cost and latency on the metadata line", () => {
+ it("shows separate labelled metrics", () => {
renderGridCell(false, { output: false });
+ expect(screen.getByText("Latency")).toBeInTheDocument();
+ expect(screen.getByText("Cost")).toBeInTheDocument();
+ expect(screen.getByText("Status")).toBeInTheDocument();
// Neither is recorded in this fixture, so both render the affordance.
expect(screen.getAllByText("not recorded")).toHaveLength(2);
});
- it("keeps the ids reachable behind the metadata line instead of listing them", () => {
+ it("hides metadata when only scores are selected", () => {
+ renderGridCell(false, {
+ output: false,
+ totalCost: false,
+ latencyMs: false,
+ level: false,
+ itemId: false,
+ observationId: false,
+ startTime: false,
+ });
+
+ expect(screen.getByText("quality")).toBeInTheDocument();
+ expect(
+ screen.queryByRole("button", { name: "IDs" }),
+ ).not.toBeInTheDocument();
+ });
+
+ it("omits identifiers even when old visibility preferences enable them", () => {
renderGridCell(false, { output: false });
expect(screen.queryByText("item-id")).not.toBeInTheDocument();
- expect(screen.getByRole("button", { name: "IDs" })).toBeInTheDocument();
+ expect(
+ screen.queryByRole("button", { name: "IDs" }),
+ ).not.toBeInTheDocument();
});
it("lets the output section take the row's spare height", () => {
- renderGridCell(false, { metadata: false });
-
+ renderGridCell(false, {});
+
+ expect(
+ screen
+ .getByText("quality")
+ .compareDocumentPosition(screen.getByText("Cost")),
+ ).toBe(Node.DOCUMENT_POSITION_FOLLOWING);
+ expect(
+ screen
+ .getByText("Cost")
+ .compareDocumentPosition(screen.getByText("Output")),
+ ).toBe(Node.DOCUMENT_POSITION_FOLLOWING);
const outputContent =
screen.getByText("Output").parentElement?.nextElementSibling;
@@ -113,9 +184,11 @@ describe("ExperimentGridCell", () => {
it("links evaluator score comments to their execution trace", async () => {
renderGridCell(false);
- fireEvent.pointerEnter(
- screen.getByRole("button", { name: "View score comment" }),
+ expect(metadataQuery).toHaveBeenCalledWith(
+ { projectId: "project-id", id: "score-id" },
+ expect.objectContaining({ enabled: false }),
);
+ fireEvent.pointerEnter(screen.getByText("quality"));
await act(async () => {
await new Promise((resolve) => setTimeout(resolve, 750));
});
@@ -124,6 +197,14 @@ describe("ExperimentGridCell", () => {
screen.getByRole("link", { name: "View execution trace" }),
);
+ expect(metadataQuery).toHaveBeenCalledWith(
+ { projectId: "project-id", id: "score-id" },
+ expect.objectContaining({ enabled: true }),
+ );
+ expect(screen.getByText("Evaluator comment")).toBeInTheDocument();
+ expect(
+ screen.queryByRole("button", { name: "View score comment" }),
+ ).not.toBeInTheDocument();
expect(executionTraceLink).toHaveAttribute(
"href",
"/project/project-id/traces/execution-trace-id",
diff --git a/web/src/features/experiments/components/table/ExperimentGridCell.tsx b/web/src/features/experiments/components/table/ExperimentGridCell.tsx
index 38120f6df2..8f5c0beade 100644
--- a/web/src/features/experiments/components/table/ExperimentGridCell.tsx
+++ b/web/src/features/experiments/components/table/ExperimentGridCell.tsx
@@ -24,30 +24,20 @@ import {
getVisibleCellRows,
} from "@/src/features/experiments/components/table/types";
import { buildLocalIsoDatePresentation } from "@/src/utils/dates";
-import { usdFormatter, latencyFormatter } from "@/src/utils/numbers";
+import { usdFormatter } from "@/src/utils/numbers";
import {
HoverCard,
HoverCardContent,
HoverCardTrigger,
} from "@/src/components/ui/hover-card";
-import {
- MessageCircleMore,
- BracesIcon,
- Copy,
- Check,
- ExternalLink,
-} from "lucide-react";
+import { Copy, Check, ExternalLink } from "lucide-react";
import { Button } from "@/src/components/ui/button";
import { copyTextToClipboard } from "@/src/utils/clipboard";
import { api } from "@/src/utils/api";
import { Skeleton } from "@/src/components/ui/skeleton";
import { JSONView } from "@/src/components/ui/CodeJsonViewer";
-import {
- decomposeAggregateScoreKey,
- getScoreDataTypeExplanation,
-} from "@/src/features/scores";
+import { decomposeAggregateScoreKey } from "@/src/features/scores";
import { cn } from "@/src/utils/tailwind";
-import { getPlainTextFromReactNode } from "@/src/utils/react-node-plain-text";
import Link from "next/link";
import { ScoreTag, type ScoreLevel } from "@/src/components/score-tag";
import { NotRecordedMetric } from "./NotRecordedMetric";
@@ -90,6 +80,7 @@ type ExperimentGridCellProps = {
* Data passed to cell row render functions.
*/
type GridCellData = {
+ showBaselineDelta: boolean;
projectId: string;
itemId: string;
output: unknown;
@@ -113,128 +104,6 @@ type GridCellData = {
isLoading: boolean;
};
-/**
- * Component to show score comment on hover
- */
-const ScoreCommentPeek = ({
- comment,
- executionTraceId,
- projectId,
-}: {
- comment: string;
- executionTraceId?: string | null;
- projectId: string;
-}) => {
- const [copied, setCopied] = useState(false);
-
- const handleCopy = async (e: React.MouseEvent<HTMLButtonElement>) => {
- e.stopPropagation();
- await copyTextToClipboard(comment);
- setCopied(true);
- setTimeout(() => setCopied(false), 2000);
- };
-
- return (
- <HoverCard>
- <HoverCardTrigger asChild>
- <button
- type="button"
- className="inline-flex cursor-pointer"
- aria-label="View score comment"
- >
- <MessageCircleMore size={12} className="text-muted-foreground" />
- </button>
- </HoverCardTrigger>
- <HoverCardContent className="flex flex-col p-0 text-xs break-normal whitespace-normal">
- {/* Name what the icon opened: a bare block of text next to a score
- does not say it is the score's comment. */}
- <div className="bg-popover sticky top-0 z-10 flex h-8 items-center justify-between px-1">
- <span className="text-muted-foreground pl-1.5 text-[10px] font-bold uppercase">
- Score comment
- </span>
- <Button
- onClick={handleCopy}
- variant="ghost"
- size="icon-xs"
- className="hover:bg-accent rounded p-1"
- aria-label={copied ? "Copied" : "Copy to clipboard"}
- >
- {copied ? (
- <Check className="h-3 w-3" />
- ) : (
- <Copy className="h-3 w-3" />
- )}
- </Button>
- </div>
- <div className="max-h-[40vh] overflow-y-auto p-3 pt-0">
- <p className="whitespace-pre-wrap">{comment}</p>
- {executionTraceId && (
- <Link
- href={`/project/${projectId}/traces/${encodeURIComponent(executionTraceId)}`}
- className="mt-2 flex items-center gap-1 text-blue-600 hover:underline"
- target="_blank"
- rel="noopener noreferrer"
- onClick={(event) => event.stopPropagation()}
- >
- <ExternalLink className="h-3 w-3" />
- View execution trace
- </Link>
- )}
- </div>
- </HoverCardContent>
- </HoverCard>
- );
-};
-
-/**
- * Component to show score metadata on hover
- */
-const ScoreMetadataPeek = ({
- scoreId,
- projectId,
-}: {
- scoreId: string;
- projectId: string;
-}) => {
- const [isOpen, setIsOpen] = useState(false);
-
- const { data: metadata } = api.scores.getScoreMetadataById.useQuery(
- {
- projectId,
- id: scoreId,
- },
- {
- enabled: !!projectId && !!scoreId && isOpen,
- trpc: {
- context: {
- skipBatch: true,
- },
- },
- refetchOnMount: false,
- refetchOnWindowFocus: false,
- refetchOnReconnect: false,
- staleTime: Infinity,
- },
- );
-
- const metadataLoaded = metadata && Object.keys(metadata).length > 0;
-
- return (
- <HoverCard onOpenChange={setIsOpen}>
- <HoverCardTrigger className="inline-flex cursor-pointer">
- <BracesIcon size={12} className="text-muted-foreground" />
- </HoverCardTrigger>
- <HoverCardContent className="overflow-hidden rounded-md border-none p-0 text-xs break-normal whitespace-normal">
- {metadataLoaded ? (
- <JSONView codeClassName="rounded-md!" json={metadata} />
- ) : (
- <Skeleton className="h-12 w-full" />
- )}
- </HoverCardContent>
- </HoverCard>
- );
-};
-
/**
* How one score reads in a cell: a categorical score's modal value, a numeric
* score's average. Shared with the hover sentence beside it, which has to
@@ -254,129 +123,161 @@ const scoreValueOf = (aggregate?: AggregatedScoreData | null): string => {
: EMPTY_VALUE_PLACEHOLDER;
};
+const formatLatency = (value: number) => `${(value / 1000).toFixed(4)}s`;
+const formatCost = (value: number) => usdFormatter(value, 4, 4);
+
+const valueColumnsClass = (showBaselineDelta: boolean) =>
+ showBaselineDelta
+ ? "grid shrink-0 grid-cols-[auto_4.5rem] items-center justify-items-start gap-1"
+ : "flex shrink-0 items-center justify-end gap-1";
+
/**
* Simple score display component for grid cells.
- * Shows only the score name, with source and type on hover.
+ * Keeps score details together in a single hover card.
*/
const ScoreItem = ({
scoreKey,
aggregate,
- baselineAggregate,
- baselineExperimentName,
diff,
projectId,
level,
showScoreLevelLabel,
+ showBaselineDelta,
}: {
scoreKey: string;
aggregate: AggregatedScoreData | null;
- baselineAggregate?: AggregatedScoreData | null;
- baselineExperimentName?: string;
diff?: BaselineDiff | null;
projectId: string;
level: Extract<ScoreLevel, "observation" | "trace">;
showScoreLevelLabel: boolean;
+ showBaselineDelta: boolean;
}) => {
// Decompose the key to get name, source, and dataType
const { name, source, dataType } = decomposeAggregateScoreKey(scoreKey);
const displayValue = scoreValueOf(aggregate);
- const hasComment = aggregate?.comment;
- const hasMetadata = aggregate?.hasMetadata && aggregate?.id;
-
- // `true → false` and `+0.07` do not say which side is the baseline.
- const diffTitle = diff
- ? describeRunComparison({
- baselineName: baselineExperimentName,
- ...(diff.type === "CATEGORICAL"
- ? {
- baselineText: diff.from ?? "several values",
- currentText: diff.to ?? "several values",
- }
- : {
- baselineText: scoreValueOf(baselineAggregate),
- currentText: scoreValueOf(aggregate),
- }),
- })
- : undefined;
+ const [isOpen, setIsOpen] = useState(false);
+ const [copied, setCopied] = useState(false);
+ const { data: metadata, isError } = api.scores.getScoreMetadataById.useQuery(
+ { projectId, id: aggregate?.id ?? "" },
+ {
+ enabled:
+ isOpen && !!projectId && !!aggregate?.id && !!aggregate.hasMetadata,
+ trpc: { context: { skipBatch: true } },
+ refetchOnMount: false,
+ refetchOnWindowFocus: false,
+ refetchOnReconnect: false,
+ staleTime: Infinity,
+ },
+ );
return (
- <div className="flex items-center justify-between gap-1 text-xs">
- <div className="flex max-w-[50%] min-w-0 items-center gap-1">
- {showScoreLevelLabel && <ScoreTag level={level} />}
- <HoverCard>
- {/* `asChild` keeps this a <span>. Without it Radix renders its
- default <a>, which `shouldIgnoreRowClickTarget` excludes — the
- score name would be a dead zone in a cell that opens on click. */}
- <HoverCardTrigger asChild>
- <span
- className="text-muted-foreground block min-w-0 truncate"
- title={name}
- >
+ <HoverCard onOpenChange={setIsOpen}>
+ <HoverCardTrigger asChild>
+ <div
+ tabIndex={0}
+ className="flex cursor-default items-center justify-between gap-2 text-xs"
+ >
+ <div className="flex min-w-0 items-center gap-1">
+ {showScoreLevelLabel && <ScoreTag level={level} />}
+ <span className="text-muted-foreground line-clamp-1 min-w-0">
{name}
</span>
- </HoverCardTrigger>
- <HoverCardContent
- side="left"
- className="w-auto p-2 text-xs"
- align="start"
- >
- <div className="flex flex-col gap-1">
- <div className="flex items-center gap-2">
- <span className="text-muted-foreground">Source:</span>
- <span className="capitalize">{source.toLowerCase()}</span>
- </div>
- <div className="flex items-center gap-2">
- <span className="text-muted-foreground">Type:</span>
- <span className="capitalize">{dataType.toLowerCase()}</span>
+ </div>
+ {/* Comparison rows reserve a delta slot even when their values are equal. */}
+ <div className={valueColumnsClass(showBaselineDelta)}>
+ <span className="flex max-w-full min-w-0 items-center gap-1">
+ {displayValue === EMPTY_VALUE_PLACEHOLDER ? (
+ <span className="text-xs">
+ <EmptyValue />
+ </span>
+ ) : (
+ <Badge
+ variant="secondary"
+ className="min-w-0 truncate text-xs font-bold"
+ title=""
+ >
+ {displayValue}
+ </Badge>
+ )}
+ </span>
+ {diff && (
+ <DiffLabel
+ variant="ghost"
+ className="px-0"
+ diff={diff}
+ formatValue={(value) => value.toFixed(2)}
+ />
+ )}
+ </div>
+ </div>
+ </HoverCardTrigger>
+ <HoverCardContent
+ align="start"
+ className="max-h-[50vh] w-80 overflow-auto text-xs break-words whitespace-normal"
+ onClick={(event) => event.stopPropagation()}
+ >
+ <div className="flex flex-col gap-3">
+ <span className="font-bold">{name}</span>
+ <dl className="grid grid-cols-[auto_1fr] gap-x-4 gap-y-1">
+ <dt className="text-muted-foreground">Value</dt>
+ <dd>{displayValue}</dd>
+ <dt className="text-muted-foreground">Source</dt>
+ <dd className="capitalize">{source.toLowerCase()}</dd>
+ <dt className="text-muted-foreground">Type</dt>
+ <dd className="capitalize">{dataType.toLowerCase()}</dd>
+ </dl>
+ {aggregate?.comment && (
+ <div>
+ <div className="flex items-center justify-between">
+ <span className="text-muted-foreground">Comment</span>
+ <Button
+ variant="ghost"
+ size="icon-xs"
+ aria-label={copied ? "Copied" : "Copy comment"}
+ onClick={async () => {
+ await copyTextToClipboard(aggregate.comment!);
+ setCopied(true);
+ setTimeout(() => setCopied(false), 2000);
+ }}
+ >
+ {copied ? (
+ <Check className="h-3 w-3" />
+ ) : (
+ <Copy className="h-3 w-3" />
+ )}
+ </Button>
</div>
- {/* The side-by-side layout has no score column headers, so the
- type is explained here instead. */}
- <p className="text-muted-foreground max-w-[260px]">
- {getScoreDataTypeExplanation(dataType)}
- </p>
+ <p className="whitespace-pre-wrap">{aggregate.comment}</p>
</div>
- </HoverCardContent>
- </HoverCard>
- </div>
- {/* The value never gives up width for the move chip beside it: a
- clipped value reads as data, so the move wraps under it instead. */}
- <div className="flex min-w-0 flex-wrap items-center justify-end gap-x-1 gap-y-0.5">
- <span className="flex max-w-full shrink-0 items-center gap-1">
- {displayValue === EMPTY_VALUE_PLACEHOLDER ? (
- <span className="text-xs">
- <EmptyValue />
- </span>
- ) : (
- <Badge
- variant="secondary"
- className="min-w-0 truncate text-xs"
- title={displayValue}
- >
- {displayValue}
- </Badge>
)}
- {hasComment && (
- <ScoreCommentPeek
- comment={aggregate.comment!}
- executionTraceId={aggregate.executionTraceId}
- projectId={projectId}
- />
+ {aggregate?.hasMetadata && aggregate.id && (
+ <div className="flex flex-col gap-1">
+ <span className="text-muted-foreground">Metadata</span>
+ {isError && <p>Could not load metadata.</p>}
+ {!isError && metadata !== undefined && (
+ <JSONView json={metadata} />
+ )}
+ {!isError && metadata === undefined && (
+ <Skeleton className="h-12 w-full" />
+ )}
+ </div>
)}
- {hasMetadata && (
- <ScoreMetadataPeek scoreId={aggregate.id!} projectId={projectId} />
+ {aggregate?.executionTraceId && (
+ <Link
+ href={`/project/${projectId}/traces/${encodeURIComponent(aggregate.executionTraceId)}`}
+ target="_blank"
+ rel="noopener noreferrer"
+ className="flex items-center gap-1 hover:underline"
+ >
+ <ExternalLink className="h-3 w-3" />
+ View execution trace
+ </Link>
)}
- </span>
- {diff && (
- <DiffLabel
- diff={diff}
- formatValue={(v) => v.toFixed(2)}
- title={diffTitle}
- />
- )}
- </div>
- </div>
+ </div>
+ </HoverCardContent>
+ </HoverCard>
);
};
@@ -392,12 +293,6 @@ const getScoreRowDefinition = (
aggregate={
level === "trace" ? data.traceScores[scoreKey] : data.scores[scoreKey]
}
- baselineAggregate={
- level === "trace"
- ? data.baselineTraceScores?.[scoreKey]
- : data.baselineScores?.[scoreKey]
- }
- baselineExperimentName={data.baselineExperimentName}
diff={
level === "trace"
? data.traceScoreDiffs?.[scoreKey]
@@ -406,171 +301,17 @@ const getScoreRowDefinition = (
projectId={data.projectId}
level={level}
showScoreLevelLabel={showScoreLevelLabel}
+ showBaselineDelta={data.showBaselineDelta}
/>
),
});
-/**
- * Simple key-value display for metadata fields
- */
-const MetadataItem = ({
- label,
- children,
-}: {
- label: string;
- children: React.ReactNode;
-}) => (
- <div className="flex items-center justify-between gap-4 text-xs">
- <span className="text-muted-foreground shrink-0">{label}</span>
- <div
- className="min-w-0 truncate"
- title={getPlainTextFromReactNode(children)}
- >
- {children}
- </div>
- </div>
-);
-
-/** Metadata fields that used to be a line each inside the cell. */
-const METADATA_KEYS = [
- "totalCost",
- "latencyMs",
- "level",
- "itemId",
- "observationId",
- "traceId",
- "startTime",
-] as const;
-
-const isMetadataFieldVisible = (
- columnVisibility: VisibilityState,
- key: (typeof METADATA_KEYS)[number],
-) => columnVisibility[key] !== false;
+const METADATA_KEYS = ["totalCost", "latencyMs", "level", "startTime"] as const;
const hasVisibleCellMetadata = (columnVisibility: VisibilityState) =>
- METADATA_KEYS.some((key) => isMetadataFieldVisible(columnVisibility, key));
-
-/** The footer fields that live behind the identifiers hover card. */
-const IDENTIFIER_KEYS = [
- "itemId",
- "observationId",
- "traceId",
- "startTime",
-] as const;
-
-const hasVisibleCellIdentifiers = (columnVisibility: VisibilityState) =>
- IDENTIFIER_KEYS.some((key) => isMetadataFieldVisible(columnVisibility, key));
-
-/**
- * The item's identifiers, one hover away. They are the same on every row of a
- * run and the peek view already carries them, so they don't earn a line each in
- * a cell whose payload is the output — but they stay reachable here, including
- * the link out to the execution trace.
- */
-const CellIdentifiers = ({
- data,
- columnVisibility,
-}: {
- data: GridCellData;
- columnVisibility: VisibilityState;
-}) => {
- const visible = (key: (typeof METADATA_KEYS)[number]) =>
- isMetadataFieldVisible(columnVisibility, key);
-
- const rows: Array<{ label: string; value: React.ReactNode }> = [
- ...(visible("itemId")
- ? [
- {
- label: "Item ID",
- value: <span className="font-mono text-xs">{data.itemId}</span>,
- },
- ]
- : []),
- ...(visible("observationId")
- ? [
- {
- label: "Observation",
- value: (
- <span className="font-mono text-xs">{data.observationId}</span>
- ),
- },
- ]
- : []),
- ...(visible("traceId")
- ? [
- {
- label: "Execution Trace",
- value: (
- <Link
- href={`/project/${encodeURIComponent(data.projectId)}/traces/${encodeURIComponent(data.traceId)}?observation=${encodeURIComponent(data.observationId)}`}
- className="text-primary inline-flex max-w-full items-center gap-1 hover:underline"
- onClick={(event) => event.stopPropagation()}
- >
- <span
- className="truncate font-mono text-xs"
- title={data.traceId}
- >
- {data.traceId}
- </span>
- <ExternalLink className="h-3 w-3 shrink-0" />
- </Link>
- ),
- },
- ]
- : []),
- ...(visible("startTime")
- ? [
- {
- label: "Start Time",
- value: (
- <span
- className="text-xs"
- title={
- buildLocalIsoDatePresentation({ date: data.startTime })?.title
- }
- >
- {
- buildLocalIsoDatePresentation({ date: data.startTime })
- ?.display
- }
- </span>
- ),
- },
- ]
- : []),
- ];
-
- return (
- <HoverCard>
- <HoverCardTrigger asChild>
- <button
- type="button"
- className="text-muted-foreground hover:text-foreground cursor-default text-[10px] font-bold uppercase underline decoration-dotted"
- onClick={(event) => event.stopPropagation()}
- >
- IDs
- </button>
- </HoverCardTrigger>
- <HoverCardContent
- side="left"
- align="start"
- className="flex w-auto max-w-96 flex-col gap-1 p-2"
- >
- {rows.map((row) => (
- <MetadataItem key={row.label} label={row.label}>
- {row.value}
- </MetadataItem>
- ))}
- </HoverCardContent>
- </HoverCard>
- );
-};
+ METADATA_KEYS.some((key) => columnVisibility[key] !== false);
-/**
- * One line of per-item metadata under the scores: the two metrics, the status,
- * and the identifiers behind a hover. Replaces the five-line labelled block
- * that made a comparison row ~380px of chrome around a 64px output.
- */
+/** Compact label/value rows for the experiment's measurements and status. */
const CellMetadataFooter = ({
data,
columnVisibility,
@@ -579,59 +320,93 @@ const CellMetadataFooter = ({
columnVisibility: VisibilityState;
}) => {
const visible = (key: (typeof METADATA_KEYS)[number]) =>
- isMetadataFieldVisible(columnVisibility, key);
-
+ columnVisibility[key] !== false;
+ const startTime = buildLocalIsoDatePresentation({ date: data.startTime });
return (
- <div className="text-muted-foreground flex flex-wrap items-center gap-x-2 gap-y-0.5 text-xs">
- {visible("totalCost") && (
- // Same rule as the diff layout's metric columns: the delta wraps
- // whole rather than being clipped mid-number.
- <span className="inline-flex min-w-0 flex-wrap items-center gap-x-1 gap-y-0.5">
- {data.totalCost ? (
- usdFormatter(data.totalCost, 2, 6)
- ) : (
- <NotRecordedMetric metric="cost" />
- )}
- {data.totalCostDiff && (
- <DiffLabel
- diff={data.totalCostDiff}
- preferNegativeDiff
- formatValue={(value) => usdFormatter(value, 2, 6)}
- title={describeRunComparison({
- baselineName: data.baselineExperimentName,
- baselineText: usdFormatter(data.baselineTotalCost ?? 0, 2, 6),
- currentText: usdFormatter(data.totalCost ?? 0, 2, 6),
- verb: "cost",
- })}
- />
+ <div className="flex flex-col gap-1 text-xs">
+ {(visible("latencyMs") || visible("startTime")) && (
+ <div className="flex items-center justify-between gap-2">
+ <div className="text-muted-foreground flex min-w-0 flex-wrap items-center gap-x-2">
+ {visible("latencyMs") && <span>Latency</span>}
+ {visible("startTime") && startTime && (
+ <>
+ <span aria-hidden>·</span>
+ <time
+ className="font-mono text-[10px]"
+ dateTime={data.startTime.toISOString()}
+ title={startTime.title}
+ >
+ {data.startTime.toLocaleTimeString()}
+ </time>
+ </>
+ )}
+ </div>
+ {visible("latencyMs") && (
+ <div className={valueColumnsClass(data.showBaselineDelta)}>
+ {data.latencyMs != null ? (
+ <span className="font-bold tabular-nums">
+ {formatLatency(data.latencyMs)}
+ </span>
+ ) : (
+ <NotRecordedMetric metric="latency" />
+ )}
+ {data.latencyDiff && (
+ <DiffLabel
+ variant="ghost"
+ className="px-0"
+ diff={data.latencyDiff}
+ preferNegativeDiff
+ formatValue={formatLatency}
+ title={describeRunComparison({
+ baselineName: data.baselineExperimentName,
+ baselineText: formatLatency(data.baselineLatencyMs ?? 0),
+ currentText: formatLatency(data.latencyMs ?? 0),
+ verb: "took",
+ })}
+ />
+ )}
+ </div>
)}
- </span>
+ </div>
)}
- {visible("latencyMs") && (
- <span className="inline-flex min-w-0 flex-wrap items-center gap-x-1 gap-y-0.5">
- {data.latencyMs != null ? (
- latencyFormatter(data.latencyMs)
- ) : (
- <NotRecordedMetric metric="latency" />
- )}
- {data.latencyDiff && (
- <DiffLabel
- diff={data.latencyDiff}
- preferNegativeDiff
- formatValue={(value) => latencyFormatter(value)}
- title={describeRunComparison({
- baselineName: data.baselineExperimentName,
- baselineText: latencyFormatter(data.baselineLatencyMs ?? 0),
- currentText: latencyFormatter(data.latencyMs ?? 0),
- verb: "took",
- })}
- />
- )}
- </span>
+ {visible("totalCost") && (
+ <div className="flex items-center justify-between gap-2">
+ <span className="text-muted-foreground">Cost</span>
+ <div className={valueColumnsClass(data.showBaselineDelta)}>
+ {data.totalCost != null ? (
+ <span className="font-bold tabular-nums">
+ {formatCost(data.totalCost)}
+ </span>
+ ) : (
+ <NotRecordedMetric metric="cost" />
+ )}
+ {data.totalCostDiff && (
+ <DiffLabel
+ variant="ghost"
+ className="px-0"
+ diff={data.totalCostDiff}
+ preferNegativeDiff
+ formatValue={formatCost}
+ title={describeRunComparison({
+ baselineName: data.baselineExperimentName,
+ baselineText: formatCost(data.baselineTotalCost ?? 0),
+ currentText: formatCost(data.totalCost ?? 0),
+ verb: "cost",
+ })}
+ />
+ )}
+ </div>
+ </div>
)}
- {visible("level") && <span>{data.level}</span>}
- {hasVisibleCellIdentifiers(columnVisibility) && (
- <CellIdentifiers data={data} columnVisibility={columnVisibility} />
+ {visible("level") && (
+ <div className="flex items-center justify-between gap-2">
+ <span className="text-muted-foreground">Status</span>
+ <div className={valueColumnsClass(data.showBaselineDelta)}>
+ <Badge variant="ghost" className="px-0">
+ {data.level}
+ </Badge>
+ </div>
+ </div>
)}
</div>
);
@@ -654,7 +429,7 @@ const GroupSection = ({
}) => (
<div
className={cn(
- "flex flex-col gap-1 px-2 py-1.5",
+ "flex flex-col gap-1 py-1.5 pl-2",
// `grow` takes the spare space but keeps its content's height as its
// base, so a cell with no spare space still shows the output rather than
// collapsing to its label and letting the output spill over the scores.
@@ -760,6 +535,7 @@ export const ExperimentGridCell = ({
);
const cellData: GridCellData = {
+ showBaselineDelta: !isBaseline && showDiff,
projectId,
itemId,
output,
@@ -784,28 +560,9 @@ export const ExperimentGridCell = ({
};
// Define cell rows declaratively - mirrors LangfuseColumnDef pattern
- // Fixed order: output, scores, metadata
+ // Fixed order: scores, metrics, output
const cellRows: CellRowDef<GridCellData>[] = useMemo(
() => [
- // Output section
- {
- accessorKey: "output",
- header: "Output",
- cell: ({ data }) =>
- data.isLoading ? (
- <ConnectedIOTableCell
- isLoading
- variant="output"
- singleLine={singleLine}
- />
- ) : (
- <ConnectedIOTableCell
- data={data.output ?? null}
- variant="output"
- singleLine={singleLine}
- />
- ),
- },
// Keep all score levels together. Individual score visibility still
// follows the list-view columns.
{
@@ -824,9 +581,7 @@ export const ExperimentGridCell = ({
: []),
],
},
- // One compact line, replacing the five labelled metadata rows. The ids
- // moved into its hover card; cost and latency stay visible because they
- // are what a reader compares between runs.
+ // Measurements share the scores' value and delta alignment.
...(hasVisibleCellMetadata(columnVisibility)
? ([
{
@@ -840,6 +595,25 @@ export const ExperimentGridCell = ({
},
] satisfies CellRowDef<GridCellData>[])
: []),
+ // Output section
+ {
+ accessorKey: "output",
+ header: "Output",
+ cell: ({ data }) =>
+ data.isLoading ? (
+ <ConnectedIOTableCell
+ isLoading
+ variant="output"
+ singleLine={singleLine}
+ />
+ ) : (
+ <ConnectedIOTableCell
+ data={data.output ?? null}
+ variant="output"
+ singleLine={singleLine}
+ />
+ ),
+ },
],
[
columnVisibility,
@@ -874,8 +648,8 @@ export const ExperimentGridCell = ({
.filter((section) => section.content !== null);
// The cell is the scrollport in this layout: the output section keeps its
- // content's height as its base, so a long output makes the cell taller than
- // the row and the reader scrolls the cell to reach the scores under it.
+ // content's height as its base, so a long output remains scrollable beneath
+ // the scores and metrics.
// `scrollbar-visible` is what says so — under the platform's overlay
// scrollbars a cell with more to show reads as one that was cut off.
return (
diff --git a/web/src/features/experiments/components/table/ExperimentGridSummary.tsx b/web/src/features/experiments/components/table/ExperimentGridSummary.tsx
new file mode 100644
index 0000000000..5cd2374928
--- /dev/null
+++ b/web/src/features/experiments/components/table/ExperimentGridSummary.tsx
@@ -0,0 +1,206 @@
+import { useMemo } from "react";
+import { ChevronDown, ChevronRight } from "lucide-react";
+import { decomposeAggregateScoreKey } from "@/src/features/scores";
+import { summariseScoreColumn } from "../../fns/summariseScoreColumn";
+import {
+ formatScoreColumnAggregate,
+ formatScoreValue,
+} from "../../fns/formatScoreColumnAggregate";
+import { DiffLabel } from "@/src/features/datasets";
+import { type ExperimentItemsTableRow } from "./types";
+import { type VisibilityState } from "@tanstack/react-table";
+
+export function ExperimentGridSummaryValues({
+ rows,
+ experimentId,
+ baselineExperimentId,
+ observationScoreOrder,
+ traceScoreOrder,
+ columnVisibility,
+ showScoreLevelLabels,
+ isLoading,
+ expanded,
+ showScoreNames,
+ onToggle,
+}: {
+ rows: ExperimentItemsTableRow[];
+ experimentId: string;
+ baselineExperimentId?: string;
+ observationScoreOrder: string[];
+ traceScoreOrder: string[];
+ columnVisibility: VisibilityState;
+ showScoreLevelLabels: boolean;
+ isLoading: boolean;
+ expanded: boolean;
+ showScoreNames: boolean;
+ onToggle: () => void;
+}) {
+ const hasComparison =
+ !!baselineExperimentId && experimentId !== baselineExperimentId;
+ const scores = useMemo(
+ () =>
+ [
+ ...observationScoreOrder.map((key) => ({
+ key,
+ field: "observationScores" as const,
+ level: "Observation",
+ columnId: key,
+ })),
+ ...traceScoreOrder.map((key) => ({
+ key,
+ field: "traceScores" as const,
+ level: "Trace",
+ columnId: `Trace-${key}`,
+ })),
+ ]
+ .filter((score) => columnVisibility[score.columnId] !== false)
+ .flatMap((score) => {
+ const { name, dataType, source } = decomposeAggregateScoreKey(
+ score.key,
+ );
+ if (
+ dataType !== "NUMERIC" &&
+ dataType !== "BOOLEAN" &&
+ dataType !== "CATEGORICAL"
+ )
+ return [];
+ const summary = summariseScoreColumn({
+ pairs: rows.map((row) => ({
+ baseline:
+ row.experiments.find(
+ (exp) => exp.experimentId === experimentId,
+ )?.[score.field]?.[score.key] ?? null,
+ comparison:
+ row.experiments.find(
+ (exp) => exp.experimentId === baselineExperimentId,
+ )?.[score.field]?.[score.key] ?? null,
+ })),
+ dataType,
+ hasComparison,
+ });
+ return [{ ...score, name, dataType, source, summary }];
+ }),
+ [
+ observationScoreOrder,
+ traceScoreOrder,
+ columnVisibility,
+ rows,
+ experimentId,
+ baselineExperimentId,
+ hasComparison,
+ ],
+ );
+
+ return (
+ <div className="border-t py-1">
+ <div className="h-6">
+ {showScoreNames && (
+ <button
+ type="button"
+ aria-expanded={expanded}
+ onClick={(event) => {
+ event.stopPropagation();
+ onToggle();
+ }}
+ className="text-muted-foreground hover:text-foreground focus-visible:ring-ring flex h-6 items-center gap-1 rounded text-left text-[10px] font-normal focus-visible:ring-2 focus-visible:outline-none"
+ >
+ {expanded ? (
+ <ChevronDown className="size-3" />
+ ) : (
+ <ChevronRight className="size-3" />
+ )}
+ SUMMARY · this page ({rows.length} items)
+ </button>
+ )}
+ </div>
+ {expanded &&
+ scores.map((score) => {
+ const { name, dataType, source, summary } = score;
+ const { baseline: aggregate, delta, movement } = summary;
+ let aggregateLabel = "not scored";
+ if (aggregate) {
+ aggregateLabel =
+ aggregate.kind === "average"
+ ? formatScoreValue(aggregate.value)
+ : formatScoreColumnAggregate(aggregate);
+ }
+ const value = isLoading ? "Loading…" : aggregateLabel;
+ const label = showScoreLevelLabels ? `${score.level}: ${name}` : name;
+ return (
+ <div
+ key={score.columnId}
+ className="flex h-7 min-w-0 items-center gap-4 px-1 font-normal tabular-nums"
+ aria-label={`${label}: ${value}`}
+ >
+ {showScoreNames && (
+ <span
+ className="min-w-0 flex-1 truncate text-xs"
+ title={`${label} (${source.toLowerCase()}, ${dataType.toLowerCase()})`}
+ >
+ {label}
+ </span>
+ )}
+ <div className="flex min-w-0 items-baseline gap-2 whitespace-nowrap">
+ <span
+ className="text-foreground min-w-0 truncate text-xs font-bold"
+ title={value}
+ >
+ {value}
+ </span>
+ {!isLoading &&
+ !hasComparison &&
+ aggregate?.kind === "average" && (
+ <span className="text-muted-foreground text-xs">AVG</span>
+ )}
+ {!isLoading && delta !== null && delta !== 0 && (
+ <DiffLabel
+ variant="ghost"
+ diff={{
+ type: "NUMERIC",
+ absoluteDifference: Math.abs(delta),
+ direction: delta < 0 ? "-" : "+",
+ }}
+ formatValue={formatScoreValue}
+ />
+ )}
+ </div>
+ {!isLoading && movement && (
+ <div
+ className="flex shrink-0 items-center gap-2 text-xs font-normal"
+ title={`${movement.unchanged} unchanged; ${movement.notComparable} not comparable`}
+ >
+ {dataType === "CATEGORICAL" ? (
+ <span aria-label={`${movement.changed} changed items`}>
+ ↻ {movement.changed}
+ </span>
+ ) : (
+ <>
+ <span
+ className="text-dark-green"
+ title="Improved items"
+ aria-label={`${movement.improved} improved items`}
+ >
+ ↗ {movement.improved}
+ </span>
+ <span
+ className="text-dark-red"
+ title="Regressed items"
+ aria-label={`${movement.regressed} regressed items`}
+ >
+ ↘ {movement.regressed}
+ </span>
+ </>
+ )}
+ </div>
+ )}
+ </div>
+ );
+ })}
+ {expanded && scores.length === 0 && showScoreNames && (
+ <span className="text-muted-foreground text-xs">
+ {isLoading ? "Loading scores…" : "No scores selected"}
+ </span>
+ )}
+ </div>
+ );
+}
diff --git a/web/src/features/experiments/components/table/ExperimentGridView.tsx b/web/src/features/experiments/components/table/ExperimentGridView.tsx
index 14547221e9..c1da5392aa 100644
--- a/web/src/features/experiments/components/table/ExperimentGridView.tsx
+++ b/web/src/features/experiments/components/table/ExperimentGridView.tsx
@@ -1,3 +1,5 @@
+import { ExperimentInputCell } from "./ExperimentInputCell";
+import { ExperimentGridSummaryValues } from "./ExperimentGridSummary";
import { DataTable } from "@/src/components/table/data-table";
import { shouldIgnoreRowClickTarget } from "@/src/components/table/shouldIgnoreRowClickTarget";
import { type LangfuseColumnDef } from "@/src/components/table/types";
@@ -11,7 +13,7 @@ import {
type ExperimentItemsTableRow,
getExperimentColorStyles,
} from "./types";
-import { useMemo, type ReactNode } from "react";
+import { useMemo, useState, type ReactNode } from "react";
import { type RowHeight } from "@/src/components/table/data-table-row-height-switch";
import {
type OnChangeFn,
@@ -96,6 +98,7 @@ export const ExperimentGridView = ({
setRowSelection,
highlightAllRows,
}: ExperimentGridViewProps) => {
+ const [summaryExpanded, setSummaryExpanded] = useState(true);
// Keep the explicit baseline separate from the comparison list. A baseline
// is optional, so c-only URLs render every selected experiment here.
const allExperimentIds = useMemo(
@@ -108,6 +111,16 @@ export const ExperimentGridView = ({
const { experimentNames } = useExperimentNames({ projectId });
+ const selectedExperiments = useMemo(
+ () =>
+ allExperimentIds
+ .map((id) =>
+ experimentNames.find((experiment) => experiment.experimentId === id),
+ )
+ .filter((experiment) => experiment?.datasetId != null),
+ [allExperimentIds, experimentNames],
+ );
+
// Build dynamic columns for each experiment
const experimentColumns = useMemo(() => {
return allExperimentIds.map((expId, index) => {
@@ -125,22 +138,40 @@ export const ExperimentGridView = ({
// and were causing the shared table header to fall back to 150px while
// the body used the configured column size.
id: `experiment_${index}`,
+ headerBlock: true,
+ headerLabel: expName,
+ headerClassName: "align-top",
header: () => (
- <div className="flex items-center gap-2">
- <span
- className={cn("truncate font-bold", colorStyles?.textClass)}
- title={expName}
- >
- {expName}
- </span>
- {useExperimentColors && (
- <Badge
- variant="outline"
- className={cn("shrink-0 font-bold", colorStyles?.badgeClass)}
+ <div>
+ <div className="flex h-9 items-center gap-2">
+ <span
+ className={cn("truncate font-bold", colorStyles?.textClass)}
+ title={expName}
>
- {isBaseline ? "Baseline" : "Comp"}
- </Badge>
- )}
+ {expName}
+ </span>
+ {useExperimentColors && (
+ <Badge
+ variant="outline"
+ className={cn("shrink-0 font-bold", colorStyles?.badgeClass)}
+ >
+ {isBaseline ? "Baseline" : "Comp"}
+ </Badge>
+ )}
+ </div>
+ <ExperimentGridSummaryValues
+ expanded={summaryExpanded}
+ showScoreNames={index === 0}
+ onToggle={() => setSummaryExpanded((expanded) => !expanded)}
+ rows={rows}
+ experimentId={expId}
+ baselineExperimentId={baselineExperimentId}
+ observationScoreOrder={observationScoreOrder}
+ traceScoreOrder={traceScoreOrder}
+ columnVisibility={columnVisibility}
+ showScoreLevelLabels={showScoreLevelLabels}
+ isLoading={isLoading}
+ />
</div>
),
size: 400,
@@ -215,6 +246,9 @@ export const ExperimentGridView = ({
} as LangfuseColumnDef<ExperimentItemsTableRow>;
});
}, [
+ rows,
+ isLoading,
+ summaryExpanded,
allExperimentIds,
experimentNames,
baselineExperimentId,
@@ -234,14 +268,32 @@ export const ExperimentGridView = ({
const columns: LangfuseColumnDef<ExperimentItemsTableRow>[] = useMemo(
() => [
// Include select column if provided
- ...(selectActionColumn ? [selectActionColumn] : []),
- createIOTableColumn<ExperimentItemsTableRow>({
+ ...(selectActionColumn
+ ? [{ ...selectActionColumn, headerClassName: "align-top pt-3" }]
+ : []),
+ {
accessorKey: "input",
header: "Input",
+ headerClassName: "align-top pt-3",
+ cellPadding: "none",
size: 200,
- getCell: (value) => (ioLoading ? { type: "loading" } : (value ?? null)),
- singleLine,
- }),
+ cell: ({ row }) => (
+ <ExperimentInputCell
+ projectId={projectId}
+ datasetId={
+ selectedExperiments.find((experiment) =>
+ row.original.experiments.some(
+ (item) => item.experimentId === experiment?.experimentId,
+ ),
+ )?.datasetId ?? null
+ }
+ itemId={row.original.itemId}
+ input={row.original.input}
+ isLoading={ioLoading}
+ singleLine={singleLine}
+ />
+ ),
+ },
// Gated: an empty expected output used to render as two literal quote
// characters, and a whole column of them is worse than no column.
...(showExpectedOutput
@@ -249,6 +301,7 @@ export const ExperimentGridView = ({
createIOTableColumn<ExperimentItemsTableRow>({
accessorKey: "expectedOutput",
header: "Expected Output",
+ headerClassName: "align-top pt-3",
size: 200,
getCell: (value) =>
ioLoading ? { type: "loading" } : value || undefined,
@@ -261,6 +314,8 @@ export const ExperimentGridView = ({
],
[
experimentColumns,
+ projectId,
+ selectedExperiments,
ioLoading,
selectActionColumn,
showExpectedOutput,
diff --git a/web/src/features/experiments/components/table/ExperimentInputCell.tsx b/web/src/features/experiments/components/table/ExperimentInputCell.tsx
new file mode 100644
index 0000000000..5170a43b61
--- /dev/null
+++ b/web/src/features/experiments/components/table/ExperimentInputCell.tsx
@@ -0,0 +1,57 @@
+import { ArrowUpRight } from "lucide-react";
+import Link from "next/link";
+import { useRouter } from "next/router";
+import { ConnectedIOTableCell } from "@/src/components/table/ConnectedIOTableCell";
+import { shouldIgnoreRowClickTarget } from "@/src/components/table/shouldIgnoreRowClickTarget";
+
+export function ExperimentInputCell({
+ projectId,
+ datasetId,
+ itemId,
+ input,
+ isLoading,
+ singleLine,
+}: {
+ projectId: string;
+ datasetId: string | null;
+ itemId: string;
+ input: string | null | undefined;
+ isLoading: boolean;
+ singleLine: boolean;
+}) {
+ const router = useRouter();
+ const href = datasetId
+ ? `/project/${projectId}/datasets/${datasetId}/items/${encodeURIComponent(itemId)}`
+ : null;
+
+ return (
+ <div
+ className={`group relative h-full w-full ${href ? "cursor-pointer pr-6" : ""}`}
+ onClick={(event) => {
+ event.stopPropagation();
+ if (!href || shouldIgnoreRowClickTarget(event.target)) return;
+ if (event.metaKey || event.ctrlKey || event.shiftKey) {
+ window.open(href, "_blank", "noopener,noreferrer");
+ } else {
+ return router.push(href);
+ }
+ }}
+ >
+ {href ? (
+ <Link
+ href={href}
+ aria-label="Open dataset item"
+ className="text-muted-foreground hover:text-primary absolute top-1 right-1 rounded-sm p-0.5 focus-visible:ring-2 focus-visible:outline-none"
+ onClick={(event) => event.stopPropagation()}
+ >
+ <ArrowUpRight className="h-3.5 w-3.5" aria-hidden />
+ </Link>
+ ) : null}
+ {isLoading ? (
+ <ConnectedIOTableCell isLoading singleLine={singleLine} />
+ ) : (
+ <ConnectedIOTableCell data={input ?? null} singleLine={singleLine} />
+ )}
+ </div>
+ );
+}
diff --git a/web/src/features/experiments/components/table/ExperimentItemsTable.tsx b/web/src/features/experiments/components/table/ExperimentItemsTable.tsx
index 2c84af8587..ce847cf00f 100644
--- a/web/src/features/experiments/components/table/ExperimentItemsTable.tsx
+++ b/web/src/features/experiments/components/table/ExperimentItemsTable.tsx
@@ -50,12 +50,7 @@ import {
} from "@/src/features/column-visibility";
import { buildLocalIsoDatePresentation } from "@/src/utils/dates";
import { usdFormatter, latencyFormatter } from "@/src/utils/numbers";
-import {
- type RowSelectionState,
- type VisibilityState,
-} from "@tanstack/react-table";
-import { IdTableCell } from "@/src/components/design-system/table/components/IdTableCell/IdTableCell";
-import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
+import { type RowSelectionState } from "@tanstack/react-table";
import { createIOTableColumn } from "@/src/components/design-system/table/columns/createIOTableColumn";
import { usePeekNavigation } from "@/src/components/table/peek/hooks/usePeekNavigation";
import { ExperimentGridView } from "./ExperimentGridView";
@@ -70,6 +65,7 @@ import {
hasAmbiguousTargetChange,
} from "@/src/features/experiments/lib/reconcileFilterTargets";
import { useExperimentItemsTableData } from "../../hooks/useExperimentItemsTableData";
+import { useExpectedOutputVisibility } from "../../hooks/useExpectedOutputVisibility";
import {
type ExperimentItemsTableRow,
type ExperimentItemsTableProps,
@@ -86,7 +82,6 @@ import {
collectPresentScoreKeys,
composeAggregateScoreKey,
createScoreColumns,
- revealScoreColumns,
withPresentScoreKeys,
} from "@/src/features/scores";
import { Skeleton } from "@/src/components/ui/skeleton";
@@ -622,12 +617,9 @@ export default function ExperimentItemsTable({
limit: "pageSize",
});
- // Medium by default: with the ids out of the cell a row no longer needs the
- // tallest option to show its output, and two rows per screen was the
- // complaint. Large stays one click away for reading long outputs.
const [rowHeight, setRowHeight] = useRowHeightLocalStorage(
- "experiment-items",
- "m",
+ "experiment-items-compact",
+ "s",
);
const ioSingleLine = ioRenderMode === "text";
@@ -808,7 +800,7 @@ export default function ExperimentItemsTable({
});
// Running items without an expected output is common, so don't spend a column
- // on it when nothing has one. Kept while IO loads so it doesn't flash.
+ // on it before loaded IO confirms there is expected output to display.
//
// Whether the column exists is a property of the runs being compared, not of
// the page that happens to be loaded, so a page of items that all lack an
@@ -832,16 +824,11 @@ export default function ExperimentItemsTable({
() => (experimentSelectionKey ? experimentSelectionKey.split(",") : []),
[experimentSelectionKey],
);
- const [expectedOutputSeenFor, setExpectedOutputSeenFor] = useState<
- string | null
- >(null);
- useEffect(() => {
- if (expectedOutputOnPage) setExpectedOutputSeenFor(experimentSelectionKey);
- }, [expectedOutputOnPage, experimentSelectionKey]);
- const showExpectedOutput =
- ioLoading ||
- expectedOutputOnPage ||
- expectedOutputSeenFor === experimentSelectionKey;
+ const showExpectedOutput = useExpectedOutputVisibility(
+ experimentSelectionKey,
+ expectedOutputOnPage,
+ ioLoading,
+ );
const { selectActionColumn } = TableSelectionManager<ExperimentItemsTableRow>(
{
@@ -1088,6 +1075,7 @@ export default function ExperimentItemsTable({
return {
...scoreCol,
+ defaultHidden: false,
// The header holds this column's analysis, so it also sets the
// column's floor: the shared table's default lets a column be dragged
// to 20px, which is narrower than `−0.12 ↗1 ↘14` and would clip a
@@ -1231,6 +1219,7 @@ export default function ExperimentItemsTable({
</span>
{diff && (
<DiffLabel
+ variant="ghost"
diff={diff}
formatValue={(v) => v.toFixed(2)}
title={diffTitle}
@@ -1299,6 +1288,7 @@ export default function ExperimentItemsTable({
header: "Expected Output",
size: 300,
enableHiding: true,
+ defaultHidden: true,
// An empty expected output used to render as two literal quote characters.
getCell: (value) => (ioLoading ? { type: "loading" } : value || undefined),
singleLine: ioSingleLine,
@@ -1329,8 +1319,8 @@ export default function ExperimentItemsTable({
if (!diff) return null;
return (
<DiffLabel
+ variant="ghost"
diff={diff}
- preferNegativeDiff
formatValue={format}
title={describeRunComparison({
baselineName: runNameOf(baselineId),
@@ -1344,12 +1334,6 @@ export default function ExperimentItemsTable({
const columns: LangfuseColumnDef<ExperimentItemsTableRow>[] = [
...(hideControls ? [] : [selectActionColumn]),
- createIdTableColumn<ExperimentItemsTableRow>({
- accessorKey: "itemId",
- header: "Item ID",
- size: 150,
- enableHiding: true,
- }),
createIOTableColumn<ExperimentItemsTableRow>({
accessorKey: "input",
header: "Input",
@@ -1394,6 +1378,7 @@ export default function ExperimentItemsTable({
header: "Output",
size: 300,
enableHiding: true,
+ defaultHidden: true,
cell: ({ row }) => {
const outputs = row.original.outputs ?? [];
return (
@@ -1416,8 +1401,7 @@ export default function ExperimentItemsTable({
);
},
},
- // Cost and latency read as measurements, the ids as lookups — both
- // sit behind the score columns so the analysis is above the fold.
+ // Measurements sit behind the scores so the analysis is above the fold.
{
accessorKey: "totalCost",
id: "totalCost",
@@ -1471,6 +1455,7 @@ export default function ExperimentItemsTable({
),
size: 120,
enableHiding: true,
+ defaultHidden: true,
cell: ({ row }) => {
const experiments = row.original.experiments;
const baselineLatency = baselineExperimentOf(experiments)?.latencyMs;
@@ -1501,27 +1486,6 @@ export default function ExperimentItemsTable({
);
},
},
- {
- accessorKey: "observationId",
- id: "observationId",
- headerLabel: "Observation ID",
- header: () => renderExperimentSpecificHeader("Observation ID"),
- size: 180,
- enableHiding: true,
- cell: ({ row }) => {
- const experiments = row.original.experiments;
- return (
- <StackedExperimentCell
- experiments={experiments}
- allExperimentIds={allExperimentIds}
- colorExperimentIds={colorExperimentIds}
- row={row.original}
- onExperimentClick={onExperimentCellClick}
- renderValue={(exp) => <IdTableCell value={exp.observationId} />}
- />
- );
- },
- },
{
accessorKey: "startTime",
id: "startTime",
@@ -1585,7 +1549,7 @@ export default function ExperimentItemsTable({
headerLabel: "Experiment",
header: () => renderExperimentSpecificHeader("Experiment"),
size: 150,
- defaultHidden: true,
+ defaultHidden: false,
enableHiding: true,
cell: ({ row }) => {
const experiments = row.original.experiments;
@@ -1614,38 +1578,10 @@ export default function ExperimentItemsTable({
},
];
- const scoreColumnIds = useMemo(
- () =>
- [...observationScoreColumns, ...traceScoreColumns].map(
- (column) => column.accessorKey,
- ),
- [observationScoreColumns, traceScoreColumns],
- );
-
- // Score columns are now visible by default. A returning user has `false`
- // persisted for every one of them from the previous default, so this one-time
- // migration reaches them too — see `revealScoreColumns` for how a user who
- // picked their own score columns is left alone. It is consumed once and for
- // good, so it waits for the score columns to be known rather than running
- // against an empty or half-loaded set.
- const columnVisibilityMigrations = useMemo(
- () => [
- {
- versionKey: `experimentItemsColumnVisibility-scoresVisible-v1-${projectId}`,
- apply: (visibility: VisibilityState) =>
- isFilterOptionsLoading
- ? null
- : revealScoreColumns(visibility, scoreColumnIds),
- },
- ],
- [projectId, scoreColumnIds, isFilterOptionsLoading],
- );
-
const [columnVisibility, setColumnVisibilityState] =
useColumnVisibility<ExperimentItemsTableRow>(
- `experimentItemsColumnVisibility-${projectId}`,
+ `experimentItemsColumnVisibility-compare-${projectId}`,
columns,
- columnVisibilityMigrations,
);
// the score columns moved ahead of the metrics and ids so their
@@ -1655,7 +1591,7 @@ export default function ExperimentItemsTable({
const columnOrderMigrations = useMemo(
() => [
{
- versionKey: `experimentItemsColumnOrder-scoresEarlier-v2-${projectId}`,
+ versionKey: `experimentItemsColumnOrder-compare-${projectId}`,
apply: resetStaleDefaultColumnOrder,
},
],
diff --git a/web/src/features/experiments/components/table/ExperimentScoreMatrix.tsx b/web/src/features/experiments/components/table/ExperimentScoreMatrix.tsx
index ce115dd719..61a5e21b95 100644
--- a/web/src/features/experiments/components/table/ExperimentScoreMatrix.tsx
+++ b/web/src/features/experiments/components/table/ExperimentScoreMatrix.tsx
@@ -79,6 +79,7 @@ const MatrixCell = ({
<span className="font-bold">{formatScoreColumnAggregate(baseline)}</span>
{hasBaselineColumn && delta !== null && delta !== 0 && (
<DiffLabel
+ variant="ghost"
diff={{
type: "NUMERIC",
absoluteDifference: Math.abs(delta),
diff --git a/web/src/features/experiments/components/table/ScoreColumnHeaderSummary.tsx b/web/src/features/experiments/components/table/ScoreColumnHeaderSummary.tsx
index 4e69e9bd9d..8072ce26f0 100644
--- a/web/src/features/experiments/components/table/ScoreColumnHeaderSummary.tsx
+++ b/web/src/features/experiments/components/table/ScoreColumnHeaderSummary.tsx
@@ -168,6 +168,7 @@ export const ScoreColumnHeaderSummary = ({
<span className="text-muted-foreground flex min-w-0 items-center gap-x-1 overflow-hidden text-[10px] leading-tight font-normal tabular-nums">
{deltaToShow !== null && (
<DiffLabel
+ variant="ghost"
diff={{
type: "NUMERIC",
absoluteDifference: Math.abs(deltaToShow),
diff --git a/web/src/features/experiments/hooks/useExpectedOutputVisibility.ts b/web/src/features/experiments/hooks/useExpectedOutputVisibility.ts
new file mode 100644
index 0000000000..8526f03de2
--- /dev/null
+++ b/web/src/features/experiments/hooks/useExpectedOutputVisibility.ts
@@ -0,0 +1,23 @@
+import { useState } from "react";
+
+/** Keep the column available once expected output has been found in a selection. */
+export function useExpectedOutputVisibility(
+ selectionKey: string,
+ hasExpectedOutput: boolean,
+ ioLoading: boolean,
+) {
+ const [seen, setSeen] = useState({ selectionKey, hasExpectedOutput: false });
+ const hasLoadedExpectedOutput = !ioLoading && hasExpectedOutput;
+ const visible =
+ hasLoadedExpectedOutput ||
+ (seen.selectionKey === selectionKey && seen.hasExpectedOutput);
+
+ if (
+ seen.selectionKey !== selectionKey ||
+ seen.hasExpectedOutput !== visible
+ ) {
+ setSeen({ selectionKey, hasExpectedOutput: visible });
+ }
+
+ return visible;
+}
diff --git a/web/src/features/experiments/hooks/useExperimentResultsState.clienttest.tsx b/web/src/features/experiments/hooks/useExperimentResultsState.clienttest.tsx
index 6c2ceba5e2..51fa3298c1 100644
--- a/web/src/features/experiments/hooks/useExperimentResultsState.clienttest.tsx
+++ b/web/src/features/experiments/hooks/useExperimentResultsState.clienttest.tsx
@@ -93,7 +93,7 @@ describe("useExperimentResultsState", () => {
localStorage.clear();
});
- it("defaults to the one-row-per-item diff layout once a comparison exists", () => {
+ it("defaults to one column per experiment with or without comparisons", () => {
queryParamStore.set("baseline", "baseline-run");
render(<Harness />);
@@ -105,19 +105,38 @@ describe("useExperimentResultsState", () => {
render(<Harness />);
- expect(screen.getAllByTestId("layout")[1].textContent).toBe("list");
+ expect(screen.getAllByTestId("layout")[1].textContent).toBe("grid");
});
it("lets an explicit layout in the URL win over the default", () => {
queryParamStore.set("baseline", "baseline-run");
queryParamStore.set("c", ["comp-a"]);
- queryParamStore.set("layout", "grid");
+ queryParamStore.set("layout", "list");
render(<Harness />);
+ expect(screen.getByTestId("layout").textContent).toBe("list");
+ });
+
+ it("ignores the old layout preference after the comparison layout reset", () => {
+ localStorage.setItem("experiment-results-layout", JSON.stringify("list"));
+ render(<Harness />);
expect(screen.getByTestId("layout").textContent).toBe("grid");
});
+ it("preserves a remembered layout when the URL does not specify one", () => {
+ localStorage.setItem(
+ "experiment-results-compare-layout",
+ JSON.stringify("list"),
+ );
+ queryParamStore.set("baseline", "baseline-run");
+ queryParamStore.set("c", ["comp-a"]);
+
+ render(<Harness />);
+
+ expect(screen.getByTestId("layout").textContent).toBe("list");
+ });
+
it("derives hasBaseline correctly", () => {
queryParamStore.set("baseline", "baseline-run");
queryParamStore.set("c", ["comp-a"]);
diff --git a/web/src/features/experiments/hooks/useExperimentResultsState.ts b/web/src/features/experiments/hooks/useExperimentResultsState.ts
index c104cf1fb2..b0a07d15de 100644
--- a/web/src/features/experiments/hooks/useExperimentResultsState.ts
+++ b/web/src/features/experiments/hooks/useExperimentResultsState.ts
@@ -111,22 +111,17 @@ export function useExperimentResultsState() {
setComparisonIds(comparisonIds.filter((existingId) => existingId !== id));
// Layout and diff mode: the URL wins so a view stays shareable, then the
- // user's remembered pick, then the default for the current selection.
+ // user's remembered pick, then the one-column-per-experiment default.
const [storedLayout, setStoredLayout] =
useLocalStorage<ExperimentResultsLayout | null>(
- "experiment-results-layout",
+ "experiment-results-compare-layout",
null,
);
const [storedDiffMode, setStoredDiffMode] =
useLocalStorage<ExperimentDiffMode | null>("experiment-results-diff", null);
- // With something to compare against, one row per item beats one wide column
- // per experiment: a three-way comparison pushes the third experiment off a
- // 1512px screen entirely.
const layout: ExperimentResultsLayout =
- asLayout(state.layout) ??
- storedLayout ??
- (comparisonIds.length > 0 ? "list" : "grid");
+ asLayout(state.layout) ?? storedLayout ?? "grid";
const setLayout = (newLayout: ExperimentResultsLayout) => {
setStoredLayout(newLayout);
diff --git a/web/src/features/experiments/index.ts b/web/src/features/experiments/index.ts
index c4b7f40bf7..39b0c5c974 100644
--- a/web/src/features/experiments/index.ts
+++ b/web/src/features/experiments/index.ts
@@ -8,7 +8,7 @@
// useExperimentEvaluatorSelection stays deep so evals' template-selector
// does not load CreateExperimentsForm.
export { CreateExperimentsForm } from "@/src/features/experiments/components/CreateExperimentsForm";
-export { ExperimentFormatSetting } from "@/src/features/experiments/components/ExperimentFormatSetting";
+export { ExperimentDisplaySettings } from "@/src/features/experiments/components/ExperimentDisplaySettings";
export { ExperimentPeekFooter } from "@/src/features/experiments/components/ExperimentPeekFooter";
export { useEvaluatorDefaults } from "@/src/features/experiments/hooks/useEvaluatorDefaults";
export { useExperimentAccess } from "@/src/features/experiments/hooks/useExperimentAccess";