🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): Use correct step size on numeric filters (#19099)
Ben Bachem801eb1940c23
diff --git a/packages/shared/src/eventsTable.ts b/packages/shared/src/eventsTable.tsindex 7583cec788..ee78ecdc2d 100644--- a/packages/shared/src/eventsTable.ts+++ b/packages/shared/src/eventsTable.ts@@ -250,6 +250,7 @@ const eventsTableColsDefinition = [name: "Prompt Version",id: "promptVersion",type: "number",+ step: 1,internal: "e.prompt_version",nullable: true,},@@ -281,6 +282,7 @@ const eventsTableColsDefinition = [name: "Input Tokens",id: "inputTokens",type: "number",+ step: 1,internal:"arraySum(mapValues(mapFilter(x -> positionCaseInsensitive(x.1, 'input') > 0, usage_details)))",nullable: true,@@ -289,6 +291,7 @@ const eventsTableColsDefinition = [name: "Cached Input Tokens",id: "cachedInputTokens",type: "number",+ step: 1,internal: eventsTableCachedInputTokensSql,nullable: true,},@@ -296,6 +299,7 @@ const eventsTableColsDefinition = [name: "Output Tokens",id: "outputTokens",type: "number",+ step: 1,internal:"arraySum(mapValues(mapFilter(x -> positionCaseInsensitive(x.1, 'output') > 0, usage_details)))",nullable: true,@@ -304,6 +308,7 @@ const eventsTableColsDefinition = [name: "Total Tokens",id: "totalTokens",type: "number",+ step: 1,internal:"if(mapExists((k, v) -> (k = 'total'), usage_details), usage_details['total'], NULL)",nullable: true,@@ -441,6 +446,7 @@ const eventsTableColsDefinition = [name: "Comment Count",id: "commentCount",type: "number",+ step: 1,internal: "", // handled by comment filter helpers},{@@ -545,6 +551,7 @@ const eventsTableColsDefinition = [name: "Available Tools",id: "toolDefinitions",type: "number",+ step: 1,internal: "length(mapKeys(e.tool_definitions))",nullable: true,},@@ -552,6 +559,7 @@ const eventsTableColsDefinition = [name: "Tool Calls",id: "toolCalls",type: "number",+ step: 1,internal: "length(e.tool_calls)",nullable: true,},diff --git a/packages/shared/src/observationsTable.ts b/packages/shared/src/observationsTable.tsindex 2029d9372f..17cca64a7e 100644--- a/packages/shared/src/observationsTable.ts+++ b/packages/shared/src/observationsTable.ts@@ -156,6 +156,7 @@ export const observationsTableCols: ColumnDefinition[] = [name: "Input Tokens",id: "inputTokens",type: "number",+ step: 1,internal: 'o."prompt_tokens"',nullable: true,},@@ -163,6 +164,7 @@ export const observationsTableCols: ColumnDefinition[] = [name: "Output Tokens",id: "outputTokens",type: "number",+ step: 1,internal: 'o."completion_tokens"',nullable: true,},@@ -170,6 +172,7 @@ export const observationsTableCols: ColumnDefinition[] = [name: "Total Tokens",id: "totalTokens",type: "number",+ step: 1,internal: 'o."total_tokens"',nullable: true,},@@ -177,6 +180,7 @@ export const observationsTableCols: ColumnDefinition[] = [name: "Tokens",id: "tokens",type: "number",+ step: 1,internal: 'o."total_tokens"',},{@@ -225,6 +229,7 @@ export const observationsTableCols: ColumnDefinition[] = [name: "Prompt Version",id: "promptVersion",type: "number",+ step: 1,internal: "p.version",nullable: true,},@@ -239,6 +244,7 @@ export const observationsTableCols: ColumnDefinition[] = [name: "Comment Count",id: "commentCount",type: "number",+ step: 1,internal: "", // handled by comment filter helpers},{@@ -267,6 +273,7 @@ export const observationsTableCols: ColumnDefinition[] = [name: "Available Tools",id: "toolDefinitions",type: "number",+ step: 1,internal: "", // ClickHouse onlynullable: true,},@@ -274,6 +281,7 @@ export const observationsTableCols: ColumnDefinition[] = [name: "Tool Calls",id: "toolCalls",type: "number",+ step: 1,internal: "", // ClickHouse onlynullable: true,},diff --git a/packages/shared/src/tableDefinitions/promptsTable.ts b/packages/shared/src/tableDefinitions/promptsTable.tsindex 2793c3e54c..4a197c263e 100644--- a/packages/shared/src/tableDefinitions/promptsTable.ts+++ b/packages/shared/src/tableDefinitions/promptsTable.ts@@ -19,6 +19,7 @@ export const promptsTableCols: ColumnDefinition[] = [name: "Version",id: "version",type: "number",+ step: 1,internal: 'p."version"',},{diff --git a/packages/shared/src/tableDefinitions/sessionsView.ts b/packages/shared/src/tableDefinitions/sessionsView.tsindex 2afc8e5698..edab040a20 100644--- a/packages/shared/src/tableDefinitions/sessionsView.ts+++ b/packages/shared/src/tableDefinitions/sessionsView.ts@@ -45,6 +45,7 @@ export const sessionsViewCols: ColumnDefinition[] = [name: "Traces Count",id: "countTraces",type: "number",+ step: 1,internal: 't."countTraces"',},{@@ -69,24 +70,28 @@ export const sessionsViewCols: ColumnDefinition[] = [name: "Input Tokens",id: "inputTokens",type: "number",+ step: 1,internal: 'o."promptTokens"',},{name: "Output Tokens",id: "outputTokens",type: "number",+ step: 1,internal: 'o."completionTokens"',},{name: "Total Tokens",id: "totalTokens",type: "number",+ step: 1,internal: 'o."totalTokens"',},{name: "Usage",id: "usage",type: "number",+ step: 1,internal: 'o."totalTokens"',},{@@ -121,6 +126,7 @@ export const sessionsViewCols: ColumnDefinition[] = [name: "Comment Count",id: "commentCount",type: "number",+ step: 1,internal: "", // handled by comment filter helpers},{@@ -151,6 +157,7 @@ export const sessionsEventsViewCols: ColumnDefinition[] =name: "Tool Calls",id: "toolCalls",type: "number",+ step: 1,internal: "st.tool_calls_count",},{diff --git a/packages/shared/src/tableDefinitions/tracesTable.ts b/packages/shared/src/tableDefinitions/tracesTable.tsindex ee32c13c54..18217ead06 100644--- a/packages/shared/src/tableDefinitions/tracesTable.ts+++ b/packages/shared/src/tableDefinitions/tracesTable.ts@@ -113,6 +113,7 @@ export const tracesTableCols: ColumnDefinition[] = [name: "Input Tokens",id: "inputTokens",type: "number",+ step: 1,internal: 'generation_metrics."promptTokens"',nullable: true,},@@ -120,6 +121,7 @@ export const tracesTableCols: ColumnDefinition[] = [name: "Output Tokens",id: "outputTokens",type: "number",+ step: 1,internal: 'generation_metrics."completionTokens"',nullable: true,},@@ -127,30 +129,35 @@ export const tracesTableCols: ColumnDefinition[] = [name: "Error Level Count",id: "errorCount",type: "number",+ step: 1,internal: 'generation_metrics."errorCount"',},{name: "Warning Level Count",id: "warningCount",type: "number",+ step: 1,internal: 'generation_metrics."warningCount"',},{name: "Default Level Count",id: "defaultCount",type: "number",+ step: 1,internal: 'generation_metrics."defaultCount"',},{name: "Debug Level Count",id: "debugCount",type: "number",+ step: 1,internal: 'generation_metrics."debugCount"',},{name: "Total Tokens",id: "totalTokens",type: "number",+ step: 1,internal: 'generation_metrics."totalTokens"',nullable: true,},@@ -158,6 +165,7 @@ export const tracesTableCols: ColumnDefinition[] = [name: "Tokens",id: "tokens",type: "number",+ step: 1,internal: 'generation_metrics."totalTokens"',nullable: true,},@@ -213,6 +221,7 @@ export const tracesTableCols: ColumnDefinition[] = [name: "Comment Count",id: "commentCount",type: "number",+ step: 1,internal: "", // handled by comment filter helpers},{diff --git a/web/src/components/table/data-table-controls.tsx b/web/src/components/table/data-table-controls.tsxindex a1356d5e17..48741279e0 100644--- a/web/src/components/table/data-table-controls.tsx+++ b/web/src/components/table/data-table-controls.tsx@@ -572,6 +572,7 @@ export function DataTableControls({loading={filter.loading}min={filter.min}max={filter.max}+ step={filter.step}value={filter.value}conditions={filter.conditions}onRemoveCondition={filter.onRemoveCondition}@@ -1320,6 +1321,7 @@ interface CategoricalFacetProps extends BaseFacetProps {interface NumericFacetProps extends BaseFacetProps {min: number;max: number;+ step?: number;value: [number, number] | null;conditions: NumericUIFilter["conditions"];onRemoveCondition: (index: number) => void;@@ -1974,6 +1976,7 @@ function NumericFacet({loading,min,max,+ step,value,conditions,onRemoveCondition,@@ -2115,7 +2118,7 @@ function NumericFacet({value={isActive ? localValue[0] : ""}placeholder={String(min)}min={min}- step="any"+ step={step ?? "any"}onChange={handleMinInputChange}className="h-8"/>@@ -2140,7 +2143,7 @@ function NumericFacet({value={isActive ? localValue[1] : ""}placeholder={String(max)}min={min}- step="any"+ step={step ?? "any"}onChange={handleMaxInputChange}className="h-8"/>@@ -2155,7 +2158,7 @@ function NumericFacet({<Slidermin={min}max={max}- step={max - min <= 1000 ? 0.01 : 1}+ step={step ?? (max - min <= 1000 ? 0.01 : 1)}value={localValue}onValueChange={handleSliderChange}/>diff --git a/web/src/features/filters/hooks/useSidebarFilterState.tsx b/web/src/features/filters/hooks/useSidebarFilterState.tsxindex 9baa1c6065..9502727b9a 100644--- a/web/src/features/filters/hooks/useSidebarFilterState.tsx+++ b/web/src/features/filters/hooks/useSidebarFilterState.tsx@@ -226,6 +226,7 @@ export interface NumericUIFilter extends BaseUIFilter {onRemoveCondition: (index: number) => void;min: number;max: number;+ step?: number;onChange: (value: [number, number]) => void;unit?: string;}@@ -1410,6 +1411,9 @@ export function useSidebarFilterPresentation((f) => f.column === facet.column && f.type === "number",);const disableState = getFacetDisabledState(facet);+ const column = config.columnDefinitions.find(+ (column) => column.id === facet.column,+ );return {type: "numeric",column: facet.column,@@ -1421,6 +1425,9 @@ export function useSidebarFilterPresentation(conditions,min: facet.min,max: facet.max,+ step:+ facet.step ??+ (column?.type === "number" ? column.step : undefined),unit: facet.unit,loading: false,expanded: expandedSet.has(facet.column),