🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
refactor(web): Fix no-null-render: StripeCustomerPortalButton.tsx (#18221)
Ben Bachem804ad519ec2c
diff --git a/web/src/ee/features/billing/components/BillingActionButtons.tsx b/web/src/ee/features/billing/components/BillingActionButtons.tsxindex 253844d1bc..c5fc9d71f7 100644--- a/web/src/ee/features/billing/components/BillingActionButtons.tsx+++ b/web/src/ee/features/billing/components/BillingActionButtons.tsx@@ -4,6 +4,7 @@ import { Button } from "@/src/components/ui/button";import Link from "next/link";import { useSupportDrawer } from "@/src/features/support-chat";+import { useHasOrganizationAccess } from "@/src/features/rbac";import { useV4MigrationPanel } from "@/src/features/v4-migration/V4MigrationPanelProvider";import { StripeCustomerPortalButton } from "./StripeCustomerPortalButton";import { BillingSwitchPlanDialog } from "./BillingSwitchPlanDialog";@@ -17,6 +18,10 @@ export const BillingActionButtons = () => {hasValidPaymentMethod,isLoading,} = useBillingInformation();+ const hasBillingAccess = useHasOrganizationAccess({+ organizationId: organization?.id,+ scope: "langfuseCloudBilling:CRUD",+ });const { setOpen } = useSupportDrawer();const { setOpen: setMigrationPanelOpen } = useV4MigrationPanel();@@ -58,11 +63,13 @@ export const BillingActionButtons = () => {{organization && hasActiveSubscription && (<>- <StripeCustomerPortalButton- orgId={organization.id}- title="Update Billing Details"- variant="secondary"- />+ {hasBillingAccess && (+ <StripeCustomerPortalButton+ orgId={organization.id}+ title="Update Billing Details"+ variant="secondary"+ />+ )}<StripeCancellationButtonorgId={organization.id}variant="secondary"diff --git a/web/src/ee/features/billing/components/StripeCustomerPortalButton.tsx b/web/src/ee/features/billing/components/StripeCustomerPortalButton.tsxindex 37dc9b19dd..9f22af78bf 100644--- a/web/src/ee/features/billing/components/StripeCustomerPortalButton.tsx+++ b/web/src/ee/features/billing/components/StripeCustomerPortalButton.tsx@@ -1,6 +1,4 @@-/* eslint-disable @repo/no-null-render */import { Button } from "@/src/components/ui/button";-import { useHasOrganizationAccess } from "@/src/features/rbac";import { api } from "@/src/utils/api";import { useEffect, useState } from "react";import { toast } from "sonner";@@ -14,11 +12,6 @@ export const StripeCustomerPortalButton = ({title: string;variant: "secondary" | "default";}) => {- const hasAccess = useHasOrganizationAccess({- organizationId: orgId,- scope: "langfuseCloudBilling:CRUD",- });-const [loading, setLoading] = useState(false);useEffect(() => {@@ -69,10 +62,6 @@ export const StripeCustomerPortalButton = ({}};- if (!hasAccess) {- return null;- }-return (<Buttonvariant={variant}