🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(sessions): Collapse sidebar in modern session peeks (#17408)
Ben Bachem8159c321f9e8
diff --git a/web/src/components/table/peek/peek-trace-detail.tsx b/web/src/components/table/peek/peek-trace-detail.tsxindex 506534aea1..047e669649 100644--- a/web/src/components/table/peek/peek-trace-detail.tsx+++ b/web/src/components/table/peek/peek-trace-detail.tsx@@ -19,9 +19,10 @@ export const TablePeekViewTraceDetail = ("children" | "title"> & {projectId: string;+ layout?: React.ComponentProps<typeof TraceDetailBody>["layout"];},) => {- const { projectId } = props;+ const { projectId, layout, ...tablePeekViewProps } = props;const router = useRouter();const { traceId, timestamp } = resolvePeekTraceParams({@@ -57,7 +58,7 @@ export const TablePeekViewTraceDetail = (timestamp,onAfterDelete: (deletedTraceId: string) => {if (shouldClosePeekAfterDelete(peekIdRef.current, deletedTraceId)) {- props.closePeek();+ tablePeekViewProps.closePeek();}},}@@ -65,7 +66,7 @@ export const TablePeekViewTraceDetail = (return (<TablePeekView- {...props}+ {...tablePeekViewProps}title={traceDetailTitle(trace.data, traceId)}actions={actionProps ? <TraceDetailActions {...actionProps} /> : undefined@@ -79,6 +80,7 @@ export const TablePeekViewTraceDetail = (<TraceDetailBodytrace={trace.data}context="peek"+ layout={layout}truncatedAtObservations={trace.truncatedAtObservations}/></TablePeekView>diff --git a/web/src/features/sessions/SessionPages.tsx b/web/src/features/sessions/SessionPages.tsxindex 621fab00c7..3e7eb6b3a4 100644--- a/web/src/features/sessions/SessionPages.tsx+++ b/web/src/features/sessions/SessionPages.tsx@@ -2065,6 +2065,7 @@ const LoadedSessionEventsPage: React.FC<{tableName="session-events"isV4={true}projectId={projectId}+ layout={isModernSessionEnabled ? "observation-focused" : "default"}/></Page></SessionDetailStoreProvider>diff --git a/web/src/features/traces/components/Trace.tsx b/web/src/features/traces/components/Trace.tsxindex abc20ba9e3..5aedf0c2f7 100644--- a/web/src/features/traces/components/Trace.tsx+++ b/web/src/features/traces/components/Trace.tsx@@ -41,11 +41,12 @@ export type TraceProps = {corrections: ScoreDomain[];projectId: string;context?: "fullscreen" | "peek" | "annotation";+ layout?: "default" | "observation-focused";/** Observation cap this trace was loaded under, when it hit it. */truncatedAtObservations?: number;};-const DESKTOP_LAYOUT_BY_CONTEXT = {+const DESKTOP_LAYOUTS = {fullscreen: {groupId: "trace-layout-v3",defaultNavigationCollapsed: false,@@ -56,6 +57,11 @@ const DESKTOP_LAYOUT_BY_CONTEXT = {defaultNavigationCollapsed: false,expandDetailOnMount: false,},+ "peek-observation-focused": {+ groupId: "trace-layout-peek-navigation-collapsed-v1",+ defaultNavigationCollapsed: true,+ expandDetailOnMount: false,+ },annotation: {groupId: "trace-layout-annotation-v1",defaultNavigationCollapsed: true,@@ -63,24 +69,25 @@ const DESKTOP_LAYOUT_BY_CONTEXT = {},} as const;-type DesktopLayout =- (typeof DESKTOP_LAYOUT_BY_CONTEXT)[keyof typeof DESKTOP_LAYOUT_BY_CONTEXT];+type DesktopLayout = (typeof DESKTOP_LAYOUTS)[keyof typeof DESKTOP_LAYOUTS];/*** SelectionProvider sits ABOVE the trace data so the selected observation can be* resolved before the tree is built: past the observation cap the selected row is* missing from the loaded list and has to be fetched and merged in.*/-export function Trace({ context, ...props }: TraceProps) {+export function Trace({ context, layout = "default", ...props }: TraceProps) {const traceContext = context ?? "fullscreen";+ const desktopLayoutKey =+ traceContext === "peek" && layout === "observation-focused"+ ? "peek-observation-focused"+ : traceContext;+ const desktopLayout = DESKTOP_LAYOUTS[desktopLayoutKey];return (<ViewPreferencesProvider traceContext={traceContext}><SelectionProvider>- <TraceWithSelection- {...props}- desktopLayout={DESKTOP_LAYOUT_BY_CONTEXT[traceContext]}- />+ <TraceWithSelection {...props} desktopLayout={desktopLayout} /></SelectionProvider></ViewPreferencesProvider>);diff --git a/web/src/features/traces/components/TraceDetailBody.tsx b/web/src/features/traces/components/TraceDetailBody.tsxindex a9c7a028df..c3558ae618 100644--- a/web/src/features/traces/components/TraceDetailBody.tsx+++ b/web/src/features/traces/components/TraceDetailBody.tsx@@ -1,4 +1,4 @@-import { Trace } from "@/src/features/traces/components/Trace";+import { Trace, type TraceProps } from "@/src/features/traces/components/Trace";import { Skeleton } from "@/src/components/ui/skeleton";import { type useTraceDetailData } from "@/src/features/traces/hooks/useTraceDetailData";@@ -17,10 +17,12 @@ export function TraceDetailBody({context,keySuffix,truncatedAtObservations,+ layout,}: {trace: TraceDetailData | undefined;context: "peek" | "fullscreen" | "annotation";keySuffix?: string;+ layout?: TraceProps["layout"];/** Observation cap this trace was loaded under, when it hit it. */truncatedAtObservations?: number;}) {@@ -34,6 +36,7 @@ export function TraceDetailBody({projectId={trace.projectId}observations={trace.observations}context={context}+ layout={layout}truncatedAtObservations={truncatedAtObservations}/>);