🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(traces): show skills in the preview tab (#18890)
tobi_kl85162fb9562e
diff --git a/web/src/features/traces/components/DetailSkillsTab.stories.tsx b/web/src/features/traces/components/DetailSkillsTab.stories.tsxdeleted file mode 100644index aa0e7db5ca..0000000000--- a/web/src/features/traces/components/DetailSkillsTab.stories.tsx+++ /dev/null@@ -1,79 +0,0 @@-import preview from "../../../../.storybook/preview";-import { DetailSkillsTab } from "./DetailSkillsTab";--const meta = preview.meta({ component: DetailSkillsTab });--export const Available = meta.story({- args: {- projectId: "storybook-project",- isLoading: false,- skills: {- kind: "available",- items: [- {- skillName: "refund-policy",- langfuseSkillId: "refund",- skillVersion: 3,- },- {- skillName: "shipping-policy",- langfuseSkillId: "shipping",- skillVersion: 1,- },- {- skillName: "subscription-support",- langfuseSkillId: "subscription",- skillVersion: 2,- },- { skillName: "account-security" },- ],- },- },-});--export const Loaded = meta.story({- args: {- projectId: "storybook-project",- isLoading: false,- skills: {- kind: "loaded",- items: [- {- skillName: "refund-policy",- langfuseSkillId: "refund",- skillVersion: 3,- filePath: "SKILL.md",- },- {- skillName: "refund-policy",- langfuseSkillId: "refund",- skillVersion: 3,- filePath: "references/refunds.md",- },- {- skillName: "shipping-policy",- langfuseSkillId: "shipping",- skillVersion: 1,- filePath: "references/international-shipping.md",- },- { skillName: "local-customer-support", filePath: "SKILL.md" },- ],- },- },-});--export const Empty = meta.story({- args: {- projectId: "storybook-project",- isLoading: false,- skills: { kind: "loaded", items: [] },- },-});--export const Loading = meta.story({- args: {- projectId: "storybook-project",- isLoading: true,- skills: { kind: "available", items: [] },- },-});diff --git a/web/src/features/traces/components/DetailSkillsTab.tsx b/web/src/features/traces/components/DetailSkillsTab.tsxdeleted file mode 100644index 0786f2de13..0000000000--- a/web/src/features/traces/components/DetailSkillsTab.tsx+++ /dev/null@@ -1,147 +0,0 @@-import {- type SkillsAvailable,- type SkillsResourceLoaded,-} from "@langfuse/shared";-import { FileCode2, FileText } from "lucide-react";--import { Badge } from "@/src/components/design-system/Badge/Badge";-import { LinkBadge } from "@/src/components/design-system/LinkBadge/LinkBadge";-import { Skeleton } from "@/src/components/ui/skeleton";--type SkillGroup = {- skill: SkillsAvailable[number];- files: Set<string>;-};--export function DetailSkillsTab({- projectId,- skills,- isLoading,-}: {- projectId: string;- skills:- | { kind: "available"; items: SkillsAvailable }- | { kind: "loaded"; items: SkillsResourceLoaded };- isLoading: boolean;-}) {- const groups = new Map<string, SkillGroup>();- for (const skill of skills.items) {- const key = JSON.stringify([- skill.langfuseSkillId ?? null,- skill.skillName,- skill.skillVersion ?? null,- ]);- const group = groups.get(key) ?? { skill, files: new Set<string>() };- groups.set(key, group);- if ("filePath" in skill) group.files.add(skill.filePath);- }- const fileCount = Array.from(groups.values()).reduce(- (count, group) => count + group.files.size,- 0,- );- const isAvailable = skills.kind === "available";-- return (- <div className="ph-no-capture flex min-h-0 flex-1 flex-col gap-4 overflow-auto p-4">- <div className="flex flex-col gap-1.5">- <div className="flex flex-wrap items-center gap-2">- <h3 className="text-sm font-bold">- {isAvailable ? "Available skills" : "Loaded skills"}- </h3>- {!isLoading && groups.size > 0 ? (- <Badge color="filled" size="sm" text={String(groups.size)} />- ) : null}- {!isLoading && !isAvailable && fileCount > 0 ? (- <span className="text-muted-foreground text-xs">- {fileCount} {fileCount === 1 ? "file" : "files"} loaded- </span>- ) : null}- </div>- <p className="text-muted-foreground text-xs leading-relaxed">- {isAvailable- ? "Skills offered to this generation. Availability does not mean a skill was loaded."- : "Skill files loaded by this tool call."}- </p>- </div>-- {isLoading ? (- <div- className="flex flex-col gap-3"- role="status"- aria-label="Loading skills"- >- <Skeleton className="h-16 w-full rounded-md" />- <Skeleton className="h-16 w-full rounded-md" />- </div>- ) : null}- {!isLoading && groups.size === 0 ? (- <div className="flex flex-col items-center gap-2 rounded-md border border-dashed px-4 py-10 text-center">- <FileCode2 className="icon-lg text-muted-foreground" aria-hidden />- <p className="text-sm font-bold">- {isAvailable- ? "No available skills recorded"- : "No loaded skills recorded"}- </p>- <p className="text-muted-foreground max-w-sm text-xs">- {isAvailable- ? "This generation has no recorded skill availability."- : "This tool call has no recorded skill file loads."}- </p>- </div>- ) : null}- {!isLoading && groups.size > 0 ? (- <ul className="flex flex-col gap-3">- {Array.from(groups, ([key, { skill, files }]) => (- <li key={key} className="min-w-0 overflow-hidden rounded-md border">- <div className="flex min-w-0 items-center gap-3 px-3 py-3">- <div className="bg-muted flex shrink-0 items-center justify-center rounded-md p-2">- <FileCode2- className="icon-base text-muted-foreground"- aria-hidden- />- </div>- <div className="flex min-w-0 flex-1 flex-wrap items-center gap-2">- {skill.langfuseSkillId && skill.skillVersion != null ? (- <LinkBadge- href={`/project/${projectId}/skills/${encodeURIComponent(skill.skillName)}?version=${skill.skillVersion}`}- text={skill.skillName}- newTab- noCapture- />- ) : (- <Badge color="ghost" font="mono" text={skill.skillName} />- )}- {skill.skillVersion != null ? (- <Badge- color="filled"- size="sm"- text={`v${skill.skillVersion}`}- />- ) : null}- </div>- </div>- {files.size > 0 ? (- <ul className="bg-muted/20 flex flex-col border-t">- {Array.from(files, (filePath) => (- <li- key={filePath}- className="flex min-w-0 items-start gap-2 px-3 py-2"- >- <FileText- className="icon-base text-muted-foreground mt-0.5 shrink-0"- aria-hidden- />- <span className="min-w-0 font-mono text-xs leading-relaxed break-all">- {filePath}- </span>- </li>- ))}- </ul>- ) : null}- </li>- ))}- </ul>- ) : null}- </div>- );-}diff --git a/web/src/features/traces/components/IOPreview/IOPreview.tsx b/web/src/features/traces/components/IOPreview/IOPreview.tsxindex f77ced341a..22cb25b128 100644--- a/web/src/features/traces/components/IOPreview/IOPreview.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreview.tsx@@ -20,6 +20,7 @@ import {import { IOPreviewJSON, type IOPreviewJSONProps } from "./IOPreviewJSON";import { IOPreviewJSONSimple } from "./IOPreviewJSONSimple";import { IOPreviewPretty } from "./IOPreviewPretty";+import type { SectionSkillsProps } from "./components/SectionSkills";import { type ChatMLParserResult } from "../../hooks/useChatMLParser";import { Button } from "@/src/components/ui/button";import { ActionButton } from "@/src/components/ActionButton";@@ -62,6 +63,7 @@ export interface ExpansionStateProps {}export interface IOPreviewProps extends ExpansionStateProps {+ skills?: SectionSkillsProps["skills"];input?: Prisma.JsonValue;output?: Prisma.JsonValue;status?: ObservationStatusMessage;@@ -112,6 +114,7 @@ export interface IOPreviewProps extends ExpansionStateProps {* - Pre-parsed data from Web Worker eliminates duplicate parsing*/export function IOPreview({+ skills,input,output,status,@@ -188,6 +191,7 @@ export function IOPreview({// Shared props for both view componentsconst sharedProps = {+ skills,input,output,status,diff --git a/web/src/features/traces/components/IOPreview/IOPreviewPretty.tsx b/web/src/features/traces/components/IOPreview/IOPreviewPretty.tsxindex 1c93a5caa5..1c9353c400 100644--- a/web/src/features/traces/components/IOPreview/IOPreviewPretty.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreviewPretty.tsx@@ -17,6 +17,10 @@ import {} from "../../hooks/useIOPreviewParser";import { ChatMessageList } from "../ChatMessageList";import { SectionToolDefinitions } from "./components/SectionToolDefinitions";+import {+ SectionSkills,+ type SectionSkillsProps,+} from "./components/SectionSkills";import {type ExpansionStateProps,type IOPreviewContentMode,@@ -93,6 +97,7 @@ function JsonInputOutputView({}export interface IOPreviewPrettyProps extends ExpansionStateProps {+ skills?: SectionSkillsProps["skills"];input?: Prisma.JsonValue;output?: Prisma.JsonValue;status?: ObservationStatusMessage;@@ -132,6 +137,7 @@ export interface IOPreviewPrettyProps extends ExpansionStateProps {* view, use IOPreviewJSON instead.*/export function IOPreviewPretty({+ skills,input,output,status,@@ -283,6 +289,10 @@ export function IOPreviewPretty({/>) : null}+ {showData && skills && skills.items.length > 0 ? (+ <SectionSkills projectId={projectId} skills={skills} />+ ) : null}+{shouldRenderMessages ? (<div><ChatMessageListdiff --git a/web/src/features/traces/components/IOPreview/components/SectionSkills.stories.tsx b/web/src/features/traces/components/IOPreview/components/SectionSkills.stories.tsxnew file mode 100644index 0000000000..45315ff503--- /dev/null+++ b/web/src/features/traces/components/IOPreview/components/SectionSkills.stories.tsx@@ -0,0 +1,98 @@+import { expect, userEvent, within } from "storybook/test";++import preview from "../../../../../../.storybook/preview";+import { SectionSkills } from "./SectionSkills";++const meta = preview.meta({ component: SectionSkills });++export const Available = meta.story({+ args: {+ projectId: "storybook-project",+ skills: {+ kind: "available",+ items: [+ {+ skillName: "refund-policy",+ langfuseSkillId: "refund",+ skillVersion: 3,+ },+ {+ skillName: "shipping-policy",+ langfuseSkillId: "shipping",+ skillVersion: 1,+ },+ {+ skillName: "subscription-support",+ langfuseSkillId: "subscription",+ skillVersion: 2,+ },+ { skillName: "account-security" },+ { skillName: "billing-support" },+ { skillName: "return-policy" },+ { skillName: "order-tracking" },+ { skillName: "customer-escalation" },+ { skillName: "tone-of-voice" },+ { skillName: "product-guide" },+ ],+ },+ },+});++export const Loaded = meta.story({+ name: "(Test) Loaded",+ args: {+ projectId: "storybook-project",+ skills: {+ kind: "loaded",+ items: [+ {+ skillName: "refund-policy",+ langfuseSkillId: "refund",+ skillVersion: 3,+ filePath: "SKILL.md",+ },+ {+ skillName: "refund-policy",+ langfuseSkillId: "refund",+ skillVersion: 3,+ filePath: "references/refunds.md",+ },+ {+ skillName: "shipping-policy",+ langfuseSkillId: "shipping",+ skillVersion: 1,+ filePath: "references/international-shipping.md",+ },+ { skillName: "local-customer-support", filePath: "SKILL.md" },+ ],+ },+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ const summary = canvas.getByRole("button", {+ name: "3 loaded skills show",+ });++ await expect(summary).toHaveAttribute("aria-expanded", "false");+ await userEvent.click(summary);+ const refundFiles = canvas.getByRole("button", {+ name: "Files loaded for refund-policy",+ });+ await userEvent.click(refundFiles);+ await expect(canvas.getByText("references/refunds.md")).toBeVisible();++ await userEvent.click(summary);+ await userEvent.click(summary);+ await expect(canvas.getByText("references/refunds.md")).toBeVisible();++ await userEvent.click(+ canvas.getByRole("button", { name: "Files loaded for shipping-policy" }),+ );+ await expect(+ canvas.getByRole("button", { name: "Files loaded for refund-policy" }),+ ).toHaveAttribute("aria-expanded", "false");+ await expect(+ canvas.getByText("references/international-shipping.md"),+ ).toBeVisible();+ },+});diff --git a/web/src/features/traces/components/IOPreview/components/SectionSkills.tsx b/web/src/features/traces/components/IOPreview/components/SectionSkills.tsxnew file mode 100644index 0000000000..a4978fa42b--- /dev/null+++ b/web/src/features/traces/components/IOPreview/components/SectionSkills.tsx@@ -0,0 +1,199 @@+import { useState } from "react";+import {+ type SkillsAvailable,+ type SkillsResourceLoaded,+} from "@langfuse/shared";+import { FileCode2, FileText } from "lucide-react";++import { Badge } from "@/src/components/design-system/Badge/Badge";+import { DropdownIndicator } from "@/src/components/design-system/DropdownIndicator/DropdownIndicator";+import { LinkBadge } from "@/src/components/design-system/LinkBadge/LinkBadge";+import {+ Collapsible,+ CollapsibleContent,+ CollapsibleTrigger,+} from "@/src/components/ui/collapsible";+import { InternalFeatureBadge } from "@/src/features/feature-flags";++export function SectionSkills({ projectId, skills }: SectionSkillsProps) {+ const [isGroupExpanded, setGroupExpanded] = useState(false);+ const [expandedSkillKey, setExpandedSkillKey] = useState("");+ const groups = groupSkills(skills.items);+ const isAvailable = skills.kind === "available";++ function handleGroupChange(open: boolean) {+ setGroupExpanded(open);+ }++ function handleSkillChange(value: string) {+ setExpandedSkillKey(value);+ }++ return (+ <section+ className="ph-no-capture border-border border-b pb-4"+ aria-label="Skills"+ >+ <div className="flex items-center gap-2 px-1 py-1">+ <h3 className="io-message-header text-base font-bold">Skills</h3>+ <Badge color="filled" size="sm" text={String(groups.length)} />+ <InternalFeatureBadge />+ </div>+ <Collapsible+ open={isGroupExpanded}+ onOpenChange={handleGroupChange}+ className="flex flex-col gap-2"+ >+ <CollapsibleTrigger className="hover:bg-muted/20 flex w-full items-center justify-between gap-2 rounded-sm border px-3 py-2 text-left text-sm font-bold">+ <span className="flex min-w-0 flex-1 items-center gap-2">+ <FileCode2+ className="icon-base text-muted-foreground shrink-0"+ aria-hidden+ />+ <span>+ {groups.length} {isAvailable ? "available" : "loaded"}{" "}+ {groups.length === 1 ? "skill" : "skills"}+ </span>+ </span>+ <Badge+ color="filled"+ size="sm"+ text={isGroupExpanded ? "hide" : "show"}+ />+ <DropdownIndicator direction={isGroupExpanded ? "down" : "right"} />+ </CollapsibleTrigger>+ <CollapsibleContent asChild>+ <ul className="flex flex-col gap-2">+ {groups.map((group) => (+ <SkillRow+ key={group.key}+ projectId={projectId}+ group={group}+ expanded={expandedSkillKey === group.key}+ onExpandedChange={handleSkillChange}+ />+ ))}+ </ul>+ </CollapsibleContent>+ </Collapsible>+ </section>+ );+}++function SkillRow({+ projectId,+ group,+ expanded,+ onExpandedChange,+}: SkillRowProps) {+ const { skill, files } = group;++ function handleOpenChange(open: boolean) {+ onExpandedChange(open ? group.key : "");+ }++ return (+ <Collapsible asChild open={expanded} onOpenChange={handleOpenChange}>+ <li className="min-w-0 overflow-hidden rounded-sm border">+ <div className="flex min-w-0 items-center gap-2 px-3 py-1.5">+ <FileCode2+ className="icon-base text-muted-foreground shrink-0"+ aria-hidden+ />+ <div className="flex min-w-0 flex-1 flex-wrap items-center gap-x-2 gap-y-1">+ {skill.langfuseSkillId && skill.skillVersion != null ? (+ <LinkBadge+ href={`/project/${projectId}/skills/${encodeURIComponent(skill.skillName)}?version=${skill.skillVersion}`}+ text={skill.skillName}+ newTab+ noCapture+ />+ ) : (+ <Badge color="ghost" font="mono" text={skill.skillName} />+ )}+ {skill.skillVersion != null ? (+ <Badge color="filled" size="sm" text={`v${skill.skillVersion}`} />+ ) : null}+ </div>+ {files.size > 0 ? (+ <CollapsibleTrigger+ className="hover:bg-muted/20 flex shrink-0 items-center gap-1.5 rounded-sm px-1 py-0.5"+ aria-label={`Files loaded for ${skill.skillName}`}+ >+ <Badge+ color="green"+ size="sm"+ text={`${files.size} ${files.size === 1 ? "file" : "files"}`}+ />+ <DropdownIndicator direction={expanded ? "down" : "right"} />+ </CollapsibleTrigger>+ ) : null}+ </div>+ {files.size > 0 ? (+ <CollapsibleContent asChild>+ <ul className="bg-muted/30 flex flex-col gap-2 border-t px-3 py-3">+ {Array.from(files, (filePath) => (+ <SkillFileRow key={filePath} filePath={filePath} />+ ))}+ </ul>+ </CollapsibleContent>+ ) : null}+ </li>+ </Collapsible>+ );+}++function SkillFileRow({ filePath }: SkillFileRowProps) {+ return (+ <li className="flex min-w-0 items-start gap-2">+ <FileText+ className="icon-base text-muted-foreground mt-0.5 shrink-0"+ aria-hidden+ />+ <span className="min-w-0 font-mono text-xs leading-relaxed break-all">+ {filePath}+ </span>+ </li>+ );+}++function groupSkills(+ items: SectionSkillsProps["skills"]["items"],+): SkillGroup[] {+ const groups = new Map<string, SkillGroup>();+ for (const skill of items) {+ const key = JSON.stringify([+ skill.langfuseSkillId ?? null,+ skill.skillName,+ skill.skillVersion ?? null,+ ]);+ const group = groups.get(key) ?? { key, skill, files: new Set<string>() };+ groups.set(key, group);+ if ("filePath" in skill) group.files.add(skill.filePath);+ }+ return Array.from(groups.values());+}++export interface SectionSkillsProps {+ projectId: string;+ skills:+ | { kind: "available"; items: SkillsAvailable }+ | { kind: "loaded"; items: SkillsResourceLoaded };+}++type SkillRowProps = {+ projectId: string;+ group: SkillGroup;+ expanded: boolean;+ onExpandedChange: (key: string) => void;+};++type SkillFileRowProps = {+ filePath: string;+};++type SkillGroup = {+ key: string;+ skill: SkillsAvailable[number];+ files: Set<string>;+};diff --git a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsxindex 3130a167d8..d12ec5c3c7 100644--- a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx+++ b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx@@ -66,10 +66,10 @@ import {import { useHasProjectAccess } from "@/src/features/rbac";import { useSession } from "next-auth/react";import { ObservationPreview } from "./ObservationPreview";+import type { SectionSkillsProps } from "../IOPreview/components/SectionSkills";import { useInternalFeaturesEnabled } from "@/src/features/feature-flags";import { TraceMessagesView } from "../TraceMessagesView/TraceMessagesView";import { DetailAttributesTab } from "../DetailAttributesTab";-import { DetailSkillsTab } from "../DetailSkillsTab";import { buildModelParameters } from "@/src/features/traces/fns/buildModelParameters";import { buildObservationAttributes } from "@/src/features/traces/fns/buildObservationAttributes";@@ -125,7 +125,6 @@ export function ConnectedObservationDetailView({isAnnotationMode,hasObservations: observations.length > 0,canViewScores: true,- hasSkills: observation.type === "GENERATION" || observation.type === "TOOL",});const showLogViewTab = tabs.includes("log");const showScoresTab = tabs.includes("scores");@@ -336,6 +335,13 @@ export function ConnectedObservationDetailView({return null;}, [observation.latency, observation.startTime, observation.endTime]);+ const previewSkills = getPreviewSkills({+ internalFeaturesEnabled,+ observationType: observation.type,+ skillsAvailable: observationWithIO?.skillsAvailable,+ skillsResourceLoaded: observationWithIO?.skillsResourceLoaded,+ });+return (<CommentDrawerControllerprojectId={projectId}@@ -486,6 +492,7 @@ export function ConnectedObservationDetailView({previewProps={{observationName: observation.name ?? undefined,observationType: observation.type,+ skills: previewSkills,input: observationWithIOCompat.data?.input ?? undefined,output: observationWithIOCompat.data?.output ?? undefined,status: observation.statusMessage@@ -564,26 +571,6 @@ export function ConnectedObservationDetailView({/></Tabs.Content>- {tabs.includes("skills") ? (- <Tabs.Content value="skills" layout="fill">- <DetailSkillsTab- projectId={projectId}- isLoading={isLoadingObservation}- skills={- observation.type === "GENERATION"- ? {- kind: "available",- items: observationWithIO?.skillsAvailable ?? [],- }- : {- kind: "loaded",- items: observationWithIO?.skillsResourceLoaded ?? [],- }- }- />- </Tabs.Content>- ) : null}-{showScoresTab ? (<Tabs.Content value="scores" layout="fill"><div className="flex h-full min-h-0 w-full flex-1 flex-col overflow-hidden">@@ -624,3 +611,30 @@ export function ConnectedObservationDetailView({</CommentDrawerController>);}++function getPreviewSkills({+ internalFeaturesEnabled,+ observationType,+ skillsAvailable,+ skillsResourceLoaded,+}: PreviewSkillsInput): SectionSkillsProps["skills"] | undefined {+ if (!internalFeaturesEnabled) return undefined;+ if (observationType === "GENERATION") {+ return { kind: "available", items: skillsAvailable ?? [] };+ }+ if (observationType === "TOOL") {+ return { kind: "loaded", items: skillsResourceLoaded ?? [] };+ }+ return undefined;+}++type PreviewSkillsInput = {+ internalFeaturesEnabled: boolean;+ observationType: ObservationReturnTypeWithMetadata["type"];+ skillsAvailable:+ | ObservationReturnTypeWithMetadata["skillsAvailable"]+ | undefined;+ skillsResourceLoaded:+ | ObservationReturnTypeWithMetadata["skillsResourceLoaded"]+ | undefined;+};diff --git a/web/src/features/traces/components/TraceDetailTabsBarList.tsx b/web/src/features/traces/components/TraceDetailTabsBarList.tsxindex dd94e57d6f..ac63f5142b 100644--- a/web/src/features/traces/components/TraceDetailTabsBarList.tsx+++ b/web/src/features/traces/components/TraceDetailTabsBarList.tsx@@ -10,7 +10,6 @@ const labels: Record<DetailTab, string> = {preview: "Preview",messages: "Messages",attributes: "Attributes",- skills: "Skills",scores: "Scores",log: "Log View",};@@ -69,7 +68,7 @@ function LoadedTraceDetailTabsBarList({key={tab}value={tab}label={labels[tab]}- internal={tab === "messages" || tab === "skills"}+ internal={tab === "messages"}tooltip={tab === "log" ? logViewDescription : undefined}/>))}diff --git a/web/src/features/traces/constants/detailTabs.ts b/web/src/features/traces/constants/detailTabs.tsindex 04eba2952a..5cfcbe9e10 100644--- a/web/src/features/traces/constants/detailTabs.ts+++ b/web/src/features/traces/constants/detailTabs.ts@@ -2,7 +2,6 @@ export const DETAIL_TABS = ["preview","messages","attributes",- "skills","scores","log",] as const;diff --git a/web/src/features/traces/fns/getDetailTabs.ts b/web/src/features/traces/fns/getDetailTabs.tsindex 3d76f59ff6..275a266f14 100644--- a/web/src/features/traces/fns/getDetailTabs.ts+++ b/web/src/features/traces/fns/getDetailTabs.ts@@ -7,7 +7,6 @@ export function getDetailTabs({isAnnotationMode,hasObservations,canViewScores,- hasSkills = false,}: {target: "trace" | "observation";isV4: boolean;@@ -15,13 +14,11 @@ export function getDetailTabs({isAnnotationMode: boolean;hasObservations: boolean;canViewScores: boolean;- hasSkills?: boolean;}) {const visibility: Record<DetailTab, boolean> = {preview: true,messages: isV4 && internalFeaturesEnabled,attributes: true,- skills: target === "observation" && internalFeaturesEnabled && hasSkills,scores: canViewScores && !isAnnotationMode,log: (target === "trace" || isV4) && hasObservations && !isAnnotationMode,};