🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(evals): use radio controls for sample observation selection (#17134)
Tobias Wochinger87ad13587382
diff --git a/web/src/components/Radio/Radio.stories.tsx b/web/src/components/Radio/Radio.stories.tsxnew file mode 100644index 0000000000..761a9080d7--- /dev/null+++ b/web/src/components/Radio/Radio.stories.tsx@@ -0,0 +1,62 @@+import { fn } from "storybook/test";+import preview from "../../../.storybook/preview";+import { Radio } from "./Radio";++const meta = preview.meta({+ component: Radio,+ args: {+ "aria-label": "Sample option",+ onChange: fn(),+ },+});++export const Default = meta.story({});++export const Checked = meta.story({+ args: {+ defaultChecked: true,+ },+});++export const Disabled = meta.story({+ args: {+ disabled: true,+ },+});++export const DisabledChecked = meta.story({+ args: {+ defaultChecked: true,+ disabled: true,+ },+});++export const Group = meta.story({+ parameters: {+ controls: {+ disable: true,+ },+ },+ render: () => (+ <fieldset className="flex flex-col gap-2">+ <legend className="mb-1 text-sm font-bold">Sample observation</legend>+ {[+ { label: "Checkout generation", value: "checkout" },+ { label: "Support generation", value: "support" },+ { label: "Search generation", value: "search" },+ ].map((option, index) => (+ <label+ key={option.value}+ className="flex cursor-pointer items-center gap-2 text-sm"+ >+ <Radio+ name="sample-observation"+ value={option.value}+ defaultChecked={index === 0}+ />+ {option.label}+ </label>+ ))}+ </fieldset>+ ),+});diff --git a/web/src/components/Radio/Radio.tsx b/web/src/components/Radio/Radio.tsxnew file mode 100644index 0000000000..3c236d075b--- /dev/null+++ b/web/src/components/Radio/Radio.tsx@@ -0,0 +1,38 @@+"use client";++import * as React from "react";++type RadioProps = Pick<+ React.ComponentPropsWithRef<"input">,+ | "aria-label"+ | "checked"+ | "defaultChecked"+ | "disabled"+ | "id"+ | "name"+ | "onChange"+ | "ref"+ | "required"+ | "value"+>;++function Radio({ ref, ...props }: RadioProps) {+ return (+ <span className="relative inline-flex h-4 w-4 shrink-0">+ <input+ ref={ref}+ type="radio"+ className="peer absolute inset-0 m-0 h-4 w-4 cursor-pointer opacity-0 disabled:cursor-not-allowed"+ {...props}+ />+ <span+ aria-hidden="true"+ className="border-control-border peer-checked:border-control-fill peer-focus-visible:ring-ring flex h-4 w-4 items-center justify-center rounded-full border shadow-sm peer-focus-visible:ring-1 peer-focus-visible:outline-hidden peer-disabled:opacity-50 peer-checked:[&>span]:opacity-100"+ >+ <span className="bg-control-fill h-2 w-2 rounded-full opacity-0" />+ </span>+ </span>+ );+}++export { Radio };diff --git a/web/src/features/evals/v2/components/Evaluators/Testing/components/EvaluatorSampleObservationSelector/EvaluatorSampleObservationSelector.tsx b/web/src/features/evals/v2/components/Evaluators/Testing/components/EvaluatorSampleObservationSelector/EvaluatorSampleObservationSelector.tsxindex 9c06bb125e..bc32647e11 100644--- a/web/src/features/evals/v2/components/Evaluators/Testing/components/EvaluatorSampleObservationSelector/EvaluatorSampleObservationSelector.tsx+++ b/web/src/features/evals/v2/components/Evaluators/Testing/components/EvaluatorSampleObservationSelector/EvaluatorSampleObservationSelector.tsx@@ -1,8 +1,8 @@-import { useMemo } from "react";+import { useId, useMemo } from "react";import { Star } from "lucide-react";import type { FilterState } from "@langfuse/shared";-import { Checkbox } from "@/src/components/design-system/Checkbox/Checkbox";+import { Radio } from "@/src/components/Radio/Radio";import type { LangfuseColumnDef } from "@/src/components/table/types";import type { AbsoluteTimeRange } from "@/src/utils/date-range-utils";import { compactNumberFormatter } from "@/src/utils/numbers";@@ -45,17 +45,20 @@ export function EvaluatorSampleObservationSelector({onSelect: (observation: SampleObservation | null) => void;onOpenTrace: (observation: SampleObservation) => void;}) {+ const selectionGroupName = useId();const leadingColumns = useMemo<LangfuseColumnDef<SampleObservation>[]>(() => [{accessorKey: "sample",id: "sample",header: () => (- <>+ <div className="flex w-full justify-center"><Star aria-hidden="true" className="h-4 w-4" /><span className="sr-only">Sample</span>- </>+ </div>),+ headerBlock: true,+ headerLabel: "Sample",size: 72,enableHiding: false,isFixedPosition: true,@@ -63,19 +66,22 @@ export function EvaluatorSampleObservationSelector({cellPadding: "none",cell: ({ row }) => (<label- className="flex h-full w-full cursor-pointer items-center px-2"+ className="flex h-full w-full cursor-pointer items-center justify-center px-2"+ htmlFor={`sample-selection-${selectionGroupName}-${row.original.id}`}onClick={(event) => event.stopPropagation()}>- <Checkbox+ <Radio+ id={`sample-selection-${selectionGroupName}-${row.original.id}`}+ name={selectionGroupName}checked={selectedObservationId === row.original.id}aria-label={`Use ${row.original.name ?? row.original.id} as sample`}- onCheckedChange={() => onSelect(row.original)}+ onChange={() => onSelect(row.original)}/></label>),},],- [onSelect, selectedObservationId],+ [onSelect, selectedObservationId, selectionGroupName],);return (