Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(filters): show ellipsis for long option labels (#18206)

Tobias Wochinger882de0e0d313
diff --git a/web/src/features/experiments/components/steps/DatasetPicker.stories.tsx b/web/src/features/experiments/components/steps/DatasetPicker.stories.tsx
new file mode 100644
index 0000000000..82bce21fcd
--- /dev/null
+++ b/web/src/features/experiments/components/steps/DatasetPicker.stories.tsx
@@ -0,0 +1,35 @@
+import { expect, fn, userEvent, within } from "storybook/test";
+
+import preview from "../../../../../.storybook/preview";
+
+import { DatasetPicker } from "./DatasetPicker";
+
+const meta = preview.meta({
+ component: DatasetPicker,
+});
+
+export default meta;
+
+const longDatasetName =
+ "dataset_abcdefghijklmnopqrstuvwxyz_abcdefghijklmnopqrstuvwxyz_abcdefghijklmnopqrstuvwxyz";
+
+export const WithLongDatasetName = meta.story({
+ name: "(Test) Long dataset name",
+ args: {
+ datasets: [{ id: "dataset-1", name: longDatasetName }],
+ selectedDatasetId: null,
+ onSelect: fn(),
+ },
+ play: async ({ canvasElement }) => {
+ await userEvent.click(within(canvasElement).getByRole("combobox"));
+
+ const optionLabel = await within(
+ canvasElement.ownerDocument.body,
+ ).findByTitle(longDatasetName);
+ const styles = getComputedStyle(optionLabel);
+
+ await expect(styles.overflow).toBe("hidden");
+ await expect(styles.textOverflow).toBe("ellipsis");
+ await expect(styles.whiteSpace).toBe("nowrap");
+ },
+});
diff --git a/web/src/features/experiments/components/steps/DatasetPicker.tsx b/web/src/features/experiments/components/steps/DatasetPicker.tsx
new file mode 100644
index 0000000000..61692acc64
--- /dev/null
+++ b/web/src/features/experiments/components/steps/DatasetPicker.tsx
@@ -0,0 +1,96 @@
+import { CheckIcon } from "lucide-react";
+
+import { DropdownIndicator } from "@/src/components/design-system/DropdownIndicator/DropdownIndicator";
+import { Button } from "@/src/components/ui/button";
+import {
+ InputCommand,
+ InputCommandEmpty,
+ InputCommandGroup,
+ InputCommandInput,
+ InputCommandItem,
+ InputCommandList,
+} from "@/src/components/ui/input-command";
+import { PopoverController } from "@/src/components/ui/popover";
+import { cn } from "@/src/utils/tailwind";
+
+type DatasetPickerProps = {
+ datasets: Array<{ id: string; name: string }>;
+ selectedDatasetId: string | null;
+ onSelect: (datasetId: string) => void;
+};
+
+export function DatasetPicker({
+ datasets,
+ selectedDatasetId,
+ onSelect,
+}: DatasetPickerProps) {
+ const selectedDataset = datasets.find(
+ (dataset) => dataset.id === selectedDatasetId,
+ );
+
+ return (
+ <PopoverController
+ align="start"
+ contentClassName="w-(--radix-popover-trigger-width) overflow-auto p-0"
+ disabled={false}
+ modal={false}
+ renderContent={({ closePopover }) => (
+ <InputCommand>
+ <InputCommandInput
+ placeholder="Search datasets..."
+ className="h-9"
+ variant="bottom"
+ />
+ <InputCommandList>
+ <InputCommandEmpty>No dataset found.</InputCommandEmpty>
+ <InputCommandGroup>
+ {datasets.map((dataset) => (
+ <InputCommandItem
+ key={dataset.id}
+ onSelect={() => {
+ onSelect(dataset.id);
+ closePopover();
+ }}
+ >
+ <span
+ className="min-w-0 flex-1 truncate"
+ title={dataset.name}
+ >
+ {dataset.name}
+ </span>
+ <CheckIcon
+ className={cn(
+ "ml-auto h-4 w-4 shrink-0",
+ dataset.id === selectedDatasetId
+ ? "opacity-100"
+ : "opacity-0",
+ )}
+ />
+ </InputCommandItem>
+ ))}
+ </InputCommandGroup>
+ </InputCommandList>
+ </InputCommand>
+ )}
+ >
+ {({ isOpen, Trigger }) => (
+ <Trigger asChild>
+ <Button
+ variant="outline"
+ role="combobox"
+ aria-expanded={isOpen}
+ className="min-w-0 flex-1 justify-between gap-2 px-2 font-normal"
+ >
+ <span
+ className="min-w-0 flex-1 truncate text-left"
+ title={selectedDataset?.name}
+ >
+ {selectedDataset?.name ?? "Select a dataset"}
+ </span>
+ <DropdownIndicator />
+ </Button>
+ </Trigger>
+ )}
+ </PopoverController>
+ );
+}
diff --git a/web/src/features/experiments/components/steps/DatasetStep.tsx b/web/src/features/experiments/components/steps/DatasetStep.tsx
index ade393a52b..af4319cb94 100644
--- a/web/src/features/experiments/components/steps/DatasetStep.tsx
+++ b/web/src/features/experiments/components/steps/DatasetStep.tsx
@@ -1,4 +1,4 @@
-import React, { useState } from "react";
+import React from "react";
import {
FormControl,
FormField,
@@ -19,14 +19,6 @@ import {
PopoverContent,
PopoverTrigger,
} from "@/src/components/ui/popover";
-import {
- InputCommandEmpty,
- InputCommandGroup,
- InputCommandInput,
- InputCommandList,
- InputCommand,
- InputCommandItem,
-} from "@/src/components/ui/input-command";
import {
Card,
CardDescription,
@@ -34,13 +26,12 @@ import {
CardTitle,
} from "@/src/components/ui/card";
import { Button } from "@/src/components/ui/button";
-import { Info, CircleCheck, CheckIcon } from "lucide-react";
-import { DropdownIndicator } from "@/src/components/design-system/DropdownIndicator/DropdownIndicator";
-import { cn } from "@/src/utils/tailwind";
+import { Info, CircleCheck } from "lucide-react";
import { type DatasetStepProps } from "@/src/features/experiments/types/stepProps";
import { StepHeader } from "@/src/features/experiments/components/shared/StepHeader";
import { api } from "@/src/utils/api";
import { format } from "date-fns";
+import { DatasetPicker } from "@/src/features/experiments/components/steps/DatasetPicker";
export const DatasetStep: React.FC<DatasetStepProps> = ({
projectId,
@@ -56,7 +47,6 @@ export const DatasetStep: React.FC<DatasetStepProps> = ({
validationResult,
} = datasetState;
const { selectedPromptName, selectedPromptVersion } = promptInfo;
- const [datasetPopoverOpen, setDatasetPopoverOpen] = useState(false);
// Fetch dataset versions when a dataset is selected
const { data: datasetVersions } = api.datasets.listDatasetVersions.useQuery(
@@ -83,61 +73,14 @@ export const DatasetStep: React.FC<DatasetStepProps> = ({
<FormItem>
<FormLabel>Dataset</FormLabel>
<div className="flex items-center gap-2">
- <Popover
- open={datasetPopoverOpen}
- onOpenChange={setDatasetPopoverOpen}
- >
- <PopoverTrigger asChild>
- <Button
- variant="outline"
- role="combobox"
- aria-expanded={datasetPopoverOpen}
- className="flex-1 justify-between gap-2 px-2 font-normal"
- >
- {field.value
- ? datasets?.find((d) => d.id === field.value)?.name
- : "Select a dataset"}
- <DropdownIndicator />
- </Button>
- </PopoverTrigger>
- <PopoverContent
- className="w-(--radix-popover-trigger-width) overflow-auto p-0"
- align="start"
- >
- <InputCommand>
- <InputCommandInput
- placeholder="Search datasets..."
- className="h-9"
- variant="bottom"
- />
- <InputCommandList>
- <InputCommandEmpty>No dataset found.</InputCommandEmpty>
- <InputCommandGroup>
- {(datasets ?? []).map((dataset) => (
- <InputCommandItem
- key={dataset.id}
- onSelect={() => {
- field.onChange(dataset.id);
- form.clearErrors("datasetId");
- setDatasetPopoverOpen(false);
- }}
- >
- {dataset.name}
- <CheckIcon
- className={cn(
- "ml-auto h-4 w-4",
- dataset.id === field.value
- ? "opacity-100"
- : "opacity-0",
- )}
- />
- </InputCommandItem>
- ))}
- </InputCommandGroup>
- </InputCommandList>
- </InputCommand>
- </PopoverContent>
- </Popover>
+ <DatasetPicker
+ datasets={datasets ?? []}
+ selectedDatasetId={field.value}
+ onSelect={(datasetId) => {
+ field.onChange(datasetId);
+ form.clearErrors("datasetId");
+ }}
+ />
{selectedPromptName && selectedPromptVersion !== null && (
<Popover>