Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Use `createDateTableColumn` more (#16938)

Ben Bachem88763f4d7391
diff --git a/web/src/components/table/use-cases/score-configs.tsx b/web/src/components/table/use-cases/score-configs.tsx
index 49ba604eef..f4e2f74032 100644
--- a/web/src/components/table/use-cases/score-configs.tsx
+++ b/web/src/components/table/use-cases/score-configs.tsx
@@ -21,6 +21,7 @@ import { Archive, Edit, MoreVertical, PlusIcon } from "lucide-react";
import { Button } from "@/src/components/ui/button";
import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrder";
import { SettingsTableCard } from "@/src/components/layouts/settings-table-card";
+import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
import { useHasProjectAccess } from "@/src/features/rbac/utils/checkProjectAccess";
import {
@@ -36,8 +37,8 @@ type ScoreConfigTableRow = {
id: string;
name: string;
dataType: ScoreConfigDataType;
- createdAt: string;
- updatedAt: string;
+ createdAt: Date;
+ updatedAt: Date;
range: {
maxValue?: number | null;
minValue?: number | null;
@@ -134,13 +135,12 @@ export function ScoreConfigsTable({ projectId }: { projectId: string }) {
enableHiding: true,
defaultHidden: true,
},
- {
+ createDateTableColumn<ScoreConfigTableRow>({
accessorKey: "createdAt",
- id: "createdAt",
header: "Created At",
enableHiding: true,
defaultHidden: true,
- },
+ }),
{
accessorKey: "isArchived",
id: "isArchived",
@@ -293,8 +293,8 @@ export function ScoreConfigsTable({ projectId }: { projectId: string }) {
name: config.name,
dataType: config.dataType,
description: config.description,
- createdAt: config.createdAt.toLocaleString(),
- updatedAt: config.updatedAt.toLocaleString(),
+ createdAt: config.createdAt,
+ updatedAt: config.updatedAt,
range: {
maxValue: config.maxValue,
minValue: config.minValue,
diff --git a/web/src/features/batch-actions/components/BatchActionsTable.tsx b/web/src/features/batch-actions/components/BatchActionsTable.tsx
index cfeea86742..3a9860b094 100644
--- a/web/src/features/batch-actions/components/BatchActionsTable.tsx
+++ b/web/src/features/batch-actions/components/BatchActionsTable.tsx
@@ -11,7 +11,6 @@ import {
TooltipProvider,
TooltipTrigger,
} from "@/src/components/ui/tooltip";
-import { buildLocalIsoDatePresentation } from "@/src/utils/dates";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createUserTableColumn } from "@/src/components/design-system/table/columns/createUserTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
@@ -114,24 +113,11 @@ export function BatchActionsTable(props: { projectId: string }) {
header: "Created",
size: 150,
}),
- {
+ createDateTableColumn<BatchActionRow>({
accessorKey: "finishedAt",
- id: "finishedAt",
header: "Finished",
size: 150,
- cell: ({ row }) => {
- const finishedAt = row.getValue("finishedAt") as Date | null;
- const preparedDate = buildLocalIsoDatePresentation({
- date: finishedAt,
- });
-
- return preparedDate ? (
- <span title={preparedDate.title}>{preparedDate.display}</span>
- ) : (
- <span className="text-muted-foreground">-</span>
- );
- },
- },
+ }),
createUserTableColumn<BatchActionRow>({
accessorKey: "user",
header: "Created By",
diff --git a/web/src/features/evals/components/eval-log.tsx b/web/src/features/evals/components/eval-log.tsx
index 43b9f940c5..2bfd5e3e30 100644
--- a/web/src/features/evals/components/eval-log.tsx
+++ b/web/src/features/evals/components/eval-log.tsx
@@ -11,6 +11,7 @@ import {
} from "@/src/components/table/data-table-controls";
import { ResizableFilterLayout } from "@/src/components/table/resizable-filter-layout";
import { type LangfuseColumnDef } from "@/src/components/table/types";
+import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createLinkTableColumn } from "@/src/components/design-system/table/columns/createLinkTableColumn";
import { createIOTableColumn } from "@/src/components/design-system/table/columns/createIOTableColumn";
import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrder";
@@ -38,8 +39,8 @@ export type JobExecutionRow = {
scoreValue?: number | string;
scoreComment?: string;
scoreMetadata?: Prisma.JsonValue;
- startTime?: string;
- endTime?: string;
+ startTime?: Date;
+ endTime?: Date;
traceId?: string;
executionTraceId?: string;
templateId: string;
@@ -93,13 +94,13 @@ export default function EvalLogTable({
getStatus: (status) =>
status ? jobExecutionStatusToStatus[status] : undefined,
}),
- columnHelper.accessor("startTime", {
- id: "startTime",
+ createDateTableColumn<JobExecutionRow>({
+ accessorKey: "startTime",
header: "Start Time",
enableHiding: true,
}),
- columnHelper.accessor("endTime", {
- id: "endTime",
+ createDateTableColumn<JobExecutionRow>({
+ accessorKey: "endTime",
header: "End Time",
enableHiding: true,
}),
@@ -233,8 +234,8 @@ export default function EvalLogTable({
jobConfig.score?.stringValue ?? jobConfig.score?.value ?? undefined,
scoreComment: jobConfig.score?.comment ?? undefined,
scoreMetadata: jobConfig.score?.metadata ?? undefined,
- startTime: jobConfig.startTime?.toLocaleString() ?? undefined,
- endTime: jobConfig.endTime?.toLocaleString() ?? undefined,
+ startTime: jobConfig.startTime ?? undefined,
+ endTime: jobConfig.endTime ?? undefined,
traceId: jobConfig.jobInputTraceId ?? undefined,
executionTraceId: jobConfig.executionTraceId ?? undefined,
templateId: jobConfig.jobTemplateId ?? "",
diff --git a/web/src/features/evals/components/eval-templates-table.tsx b/web/src/features/evals/components/eval-templates-table.tsx
index 2e3841a5ef..8986627dde 100644
--- a/web/src/features/evals/components/eval-templates-table.tsx
+++ b/web/src/features/evals/components/eval-templates-table.tsx
@@ -54,6 +54,7 @@ import {
shouldShowEvalTemplate,
} from "@/src/features/evals/utils/code-eval-template-utils";
import { SiPython, SiTypescript } from "react-icons/si";
+import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
@@ -375,13 +376,10 @@ export default function EvalsTemplateTable({
);
},
}),
- columnHelper.accessor("latestCreatedAt", {
+ createDateTableColumn<EvalsTemplateRow>({
+ accessorKey: "latestCreatedAt",
header: "Last Edited",
- id: "latestCreatedAt",
- size: 80,
- cell: (row) => {
- return row.getValue()?.toLocaleDateString();
- },
+ size: 150,
}),
createNumberTableColumn<EvalsTemplateRow>({
accessorKey: "usageCount",
diff --git a/web/src/features/evals/components/evaluator-table.tsx b/web/src/features/evals/components/evaluator-table.tsx
index 6364e6828a..4216a8c281 100644
--- a/web/src/features/evals/components/evaluator-table.tsx
+++ b/web/src/features/evals/components/evaluator-table.tsx
@@ -46,6 +46,7 @@ import { MaintainerTooltip } from "@/src/features/evals/components/maintainer-to
import { useHasProjectAccess } from "@/src/features/rbac/utils/checkProjectAccess";
import { Skeleton } from "@/src/components/ui/skeleton";
import { usdFormatter } from "@/src/utils/numbers";
+import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
import {
@@ -302,14 +303,14 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
);
},
}),
- columnHelper.accessor("createdAt", {
- id: "createdAt",
+ createDateTableColumn<EvaluatorDataRow>({
+ accessorKey: "createdAt",
header: "Created At",
enableSorting: true,
size: 150,
}),
- columnHelper.accessor("updatedAt", {
- id: "updatedAt",
+ createDateTableColumn<EvaluatorDataRow>({
+ accessorKey: "updatedAt",
header: "Updated At",
enableSorting: true,
size: 150,
diff --git a/web/src/features/evals/hooks/useEvaluatorTableData.ts b/web/src/features/evals/hooks/useEvaluatorTableData.ts
index 8a9ab6a623..075fef26f0 100644
--- a/web/src/features/evals/hooks/useEvaluatorTableData.ts
+++ b/web/src/features/evals/hooks/useEvaluatorTableData.ts
@@ -18,8 +18,8 @@ import { RAGAS_TEMPLATE_PREFIX } from "@/src/features/evals/types";
export type EvaluatorDataRow = {
id: string;
status: string;
- createdAt: string;
- updatedAt: string;
+ createdAt: Date;
+ updatedAt: Date;
maintainer: string;
rawStatus: string;
template?: {
@@ -109,8 +109,8 @@ export const useEvaluatorTableData = ({
id: jobConfig.id,
status,
rawStatus: jobConfig.status,
- createdAt: jobConfig.createdAt.toLocaleString(),
- updatedAt: jobConfig.updatedAt.toLocaleString(),
+ createdAt: jobConfig.createdAt,
+ updatedAt: jobConfig.updatedAt,
template: jobConfig.evalTemplate
? {
id: jobConfig.evalTemplate.id,
diff --git a/web/src/features/rbac/components/MembersTable.tsx b/web/src/features/rbac/components/MembersTable.tsx
index 8b875b0442..ec86398b7c 100644
--- a/web/src/features/rbac/components/MembersTable.tsx
+++ b/web/src/features/rbac/components/MembersTable.tsx
@@ -31,6 +31,7 @@ import {
} from "@/src/components/ui/hover-card";
import Link from "next/link";
import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrder";
+import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { SettingsTableCard } from "@/src/components/layouts/settings-table-card";
import useSessionStorage from "@/src/components/useSessionStorage";
import { useQueryParam, withDefault, StringParam } from "use-query-params";
@@ -318,17 +319,12 @@ export function MembersTable({
},
] satisfies LangfuseColumnDef<MembersTableRow>[])
: []),
- {
+ createDateTableColumn<MembersTableRow>({
accessorKey: "createdAt",
- id: "createdAt",
header: "Member Since",
enableHiding: true,
defaultHidden: true,
- cell: ({ row }) => {
- const value = row.getValue("createdAt") as MembersTableRow["createdAt"];
- return value ? new Date(value).toLocaleString() : undefined;
- },
- },
+ }),
{
accessorKey: "meta",
id: "meta",
diff --git a/web/src/features/rbac/components/MembershipInvitesPage.tsx b/web/src/features/rbac/components/MembershipInvitesPage.tsx
index 410c4ed7d7..62c6d2b56c 100644
--- a/web/src/features/rbac/components/MembershipInvitesPage.tsx
+++ b/web/src/features/rbac/components/MembershipInvitesPage.tsx
@@ -10,6 +10,7 @@ import { type Role } from "@langfuse/shared";
import { useHasProjectAccess } from "@/src/features/rbac/utils/checkProjectAccess";
import Header from "@/src/components/layouts/header";
import useSessionStorage from "@/src/components/useSessionStorage";
+import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createUserTableColumn } from "@/src/components/design-system/table/columns/createUserTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
@@ -100,15 +101,10 @@ export function MembershipInvitesPage({
accessorKey: "orgRole",
header: "Organization Role",
}),
- {
+ createDateTableColumn<InvitesTableRow>({
accessorKey: "createdAt",
- id: "createdAt",
header: "Invited On",
- cell: ({ row }) => {
- const value = row.getValue("createdAt") as InvitesTableRow["createdAt"];
- return value ? new Date(value).toLocaleString() : undefined;
- },
- },
+ }),
...(projectId
? [
createTextTableColumn<InvitesTableRow>({