🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
feat(trace): Improve status message rendering (#16547)
Ben Bachem89045dd03ce2
diff --git a/packages/shared/scripts/seeder/utils/clickhouse-builder.ts b/packages/shared/scripts/seeder/utils/clickhouse-builder.tsindex 359afb6437..16d06bbf36 100644--- a/packages/shared/scripts/seeder/utils/clickhouse-builder.ts+++ b/packages/shared/scripts/seeder/utils/clickhouse-builder.ts@@ -231,11 +231,23 @@ export class ClickHouseQueryBuilder {when type = 'GENERATION' then concat('generation-', toString(number % 10))when type = 'SPAN' then concat('span-', toString(number % 10))else concat('event-', toString(number % 10))- end AS name,- ${this.buildNestedMetadataMapSql(["'key'", "'value'"])} AS metadata,- multiIf(h3 % 1000 < 850, 'DEFAULT', h3 % 1000 < 955, 'DEBUG', h3 % 1000 < 969, 'ERROR', 'WARNING') AS level,- NULL AS status_message,- NULL AS version,+ end AS name,+ ${this.buildNestedMetadataMapSql(["'key'", "'value'"])} AS metadata,+ multiIf(h3 % 1000 < 850, 'DEFAULT', h3 % 1000 < 955, 'DEBUG', h3 % 1000 < 969, 'ERROR', 'WARNING') AS level,+ multiIf(+ level = 'ERROR' AND h2 % 2 = 0,+ '{"error":{"code":"upstream_timeout","message":"The upstream model did not respond in time.","retryable":true},"requestId":"seed-request-42"}',+ level = 'ERROR',+ 'Upstream model request timed out after 30 seconds.',+ level = 'WARNING',+ 'The response completed after one automatic retry.',+ level = 'DEBUG',+ 'Prompt cache lookup completed without a matching entry.',+ level = 'DEFAULT' AND h2 % 10 = 0,+ 'The response completed with additional status details.',+ NULL+ ) AS status_message,+ NULL AS version,if(type = 'GENERATION',if(h2 % 10 < 4, '${escapedHeavyMarkdown}', '${escapedChatMl}'),NULL) AS input,diff --git a/web/src/components/ui/MarkdownJsonView.tsx b/web/src/components/ui/MarkdownJsonView.tsxindex 4d2947ad26..5900a6b6e5 100644--- a/web/src/components/ui/MarkdownJsonView.tsx+++ b/web/src/components/ui/MarkdownJsonView.tsx@@ -11,6 +11,7 @@ import { Check, Copy } from "lucide-react";import { useMemo, useState } from "react";import { type z } from "zod";import { useMarkdownRenderCharacterLimit } from "@/src/hooks/useMarkdownRenderCharacterLimit";+import { cn } from "@/src/utils/tailwind";type MarkdownJsonViewHeaderProps = {title: string | React.ReactNode;@@ -19,6 +20,7 @@ type MarkdownJsonViewHeaderProps = {handleOnCopy: (event?: React.MouseEvent<HTMLButtonElement>) => void;canEnableMarkdown?: boolean;controlButtons?: React.ReactNode;+ inset?: boolean;};export function MarkdownJsonViewHeader({@@ -28,11 +30,17 @@ export function MarkdownJsonViewHeader({handleOnCopy,canEnableMarkdown: _canEnableMarkdown = true,controlButtons,+ inset = false,}: MarkdownJsonViewHeaderProps) {const [isCopied, setIsCopied] = useState(false);return (- <div className="io-message-header group-hover:bg-muted/80 flex flex-row items-center justify-between px-1 py-1 text-sm font-bold capitalize transition-colors">+ <div+ className={cn(+ "io-message-header group-hover:bg-muted/80 flex flex-row items-center justify-between py-1 text-sm font-bold capitalize transition-colors",+ inset ? "px-2" : "px-1",+ )}+ >{/* Masked from session recordings: the title can be a customer-providedmessage `name` (or tool name) rather than a fixed role string. */}<div className="ph-no-capture flex items-center gap-2">diff --git a/web/src/components/ui/PrettyJsonView.tsx b/web/src/components/ui/PrettyJsonView.tsxindex 963a209d90..963407c3cd 100644--- a/web/src/components/ui/PrettyJsonView.tsx+++ b/web/src/components/ui/PrettyJsonView.tsx@@ -86,6 +86,34 @@ const SYSTEM_TITLES = ["system", "Input"];const MONO_TEXT_CLASSES = "font-mono text-xs wrap-break-word";const PREVIEW_TEXT_CLASSES = "italic text-gray-500 dark:text-gray-400";+type PrettyJsonViewTone = "danger" | "warning" | "muted" | "neutral";++const PRETTY_JSON_VIEW_TONE_CLASSES: Record<+ PrettyJsonViewTone,+ { container: string; row: string; cell: string }+> = {+ danger: {+ container: "border-dark-red bg-light-red",+ row: "hover:bg-light-red",+ cell: "border-dark-red/30",+ },+ warning: {+ container: "border-dark-yellow/40 bg-light-yellow",+ row: "hover:bg-light-yellow",+ cell: "border-dark-yellow/20",+ },+ muted: {+ container: "border-muted-foreground/15 bg-muted/30 text-muted-foreground",+ row: "hover:bg-muted/30",+ cell: "border-muted-foreground/15",+ },+ neutral: {+ container: "bg-card",+ row: "hover:bg-card",+ cell: "border-border",+ },+};+// decodeUnicodeInJson was extracted to a standalone module so that other JSON// viewers (e.g. CodeJsonViewer) can reuse it without creating an import cycle.// Re-exported here for backward compatibility with existing imports and tests.@@ -304,6 +332,7 @@ interface JsonTableRowProps {toggleCellExpansion: (cellId: string) => void;stickyTopLevelKey: boolean;stickyOffsets: { header: number; row: number };+ toneClasses?: (typeof PRETTY_JSON_VIEW_TONE_CLASSES)[PrettyJsonViewTone];}const JsonTableRowComponent = memo(@@ -316,6 +345,7 @@ const JsonTableRowComponent = memo(toggleCellExpansion,stickyTopLevelKey,stickyOffsets,+ toneClasses,}: JsonTableRowProps) => {// Hook is now at top level of this component ✅const isExpandable =@@ -348,6 +378,7 @@ const JsonTableRowComponent = memo(row.original.level === 0 && stickyTopLevelKey? "bg-background sticky z-10 shadow-xs": "",+ toneClasses?.row,)}style={row.original.level === 0 && stickyTopLevelKey@@ -358,7 +389,10 @@ const JsonTableRowComponent = memo({row.getVisibleCells().map((cell) => (<TableCellkey={cell.id}- className="px-2 py-1 align-top whitespace-normal"+ className={cn(+ "px-2 py-1 align-top whitespace-normal",+ toneClasses?.cell,+ )}style={{ width: `${cell.column.columnDef.size}%` }}>{flexRender(cell.column.columnDef.cell, cell.getContext())}@@ -386,6 +420,7 @@ function JsonPrettyTable({stickyTopLevelKey = false,showObservationTypeBadge = false,metadataActions,+ toneClasses,}: {data: JsonTableRow[];expandAllRef?: React.RefObject<(() => void) | null>;@@ -403,6 +438,7 @@ function JsonPrettyTable({stickyTopLevelKey?: boolean;showObservationTypeBadge?: boolean;metadataActions?: MetadataFilterActions;+ toneClasses?: (typeof PRETTY_JSON_VIEW_TONE_CLASSES)[PrettyJsonViewTone];}) {const headerRef = useRef<HTMLTableRowElement>(null);const topLevelRowRef = useRef<HTMLTableRowElement>(null);@@ -656,7 +692,10 @@ function JsonPrettyTable({<TableRowkey={headerGroup.id}ref={index === 0 ? headerRef : undefined}- className={stickyTopLevelKey ? "sticky top-0 z-20" : ""}+ className={cn(+ stickyTopLevelKey ? "sticky top-0 z-20" : "",+ toneClasses?.row,+ )}>{headerGroup.headers.map((header) => (<TableHead@@ -664,6 +703,7 @@ function JsonPrettyTable({className={cn("h-8 px-2 py-1",stickyTopLevelKey ? "bg-background" : "bg-transparent",+ toneClasses?.cell,)}style={{ width: `${header.column.columnDef.size}%` }}>@@ -694,6 +734,7 @@ function JsonPrettyTable({toggleCellExpansion={toggleCellExpansion}stickyTopLevelKey={stickyTopLevelKey}stickyOffsets={stickyOffsets}+ toneClasses={toneClasses}/>))}</TableBody>@@ -723,6 +764,8 @@ export function PrettyJsonView(props: {showNullValues?: boolean;stickyTopLevelKey?: boolean;showObservationTypeBadge?: boolean;+ tone?: PrettyJsonViewTone;+ inset?: boolean;/** Content to render between header and main content (e.g., thinking blocks) */afterHeader?: React.ReactNode;/** When set, rows show an actions menu with copy + add-to-filter shortcuts@@ -732,6 +775,10 @@ export function PrettyJsonView(props: {since the title can carry a message `name` instead of the role). */isSystemPrompt?: boolean;}) {+ const toneClasses = props.tone+ ? PRETTY_JSON_VIEW_TONE_CLASSES[props.tone]+ : undefined;+ const codeClassName = cn(props.codeClassName, toneClasses?.container);// Large plain-string gate (LFE-10991): a multi-MB top-level string skips// deepParseJson's object-only `maxSize` guard, so without this it would run// several full-length main-thread passes (parse, the markdown-probe@@ -1188,11 +1235,7 @@ export function PrettyJsonView(props: {<div className="io-message-content ph-no-capture"><divclassName={cn(- getContainerClasses(- props.title,- props.scrollable,- props.codeClassName,- ),+ getContainerClasses(props.title, props.scrollable, codeClassName),)}><div className="space-y-2 p-3">@@ -1212,11 +1255,7 @@ export function PrettyJsonView(props: {<divclassName={cn("flex items-center",- getContainerClasses(- props.title,- props.scrollable,- props.codeClassName,- ),+ getContainerClasses(props.title, props.scrollable, codeClassName),)}><span className={`font-mono ${PREVIEW_TEXT_CLASSES}`}>@@ -1252,7 +1291,7 @@ export function PrettyJsonView(props: {className={getContainerClasses(props.title,props.scrollable,- props.codeClassName,+ codeClassName,"flex text-xs wrap-break-word whitespace-pre-wrap",)}>@@ -1276,6 +1315,7 @@ export function PrettyJsonView(props: {stickyTopLevelKey={props.stickyTopLevelKey}showObservationTypeBadge={props.showObservationTypeBadge}metadataActions={props.metadataActions}+ toneClasses={toneClasses}/>)}</div>@@ -1296,7 +1336,7 @@ export function PrettyJsonView(props: {hideTitle={true} // But hide the title, we display itclassName=""isLoading={props.isLoading}- codeClassName={props.codeClassName}+ codeClassName={codeClassName}collapseStringsAfterLength={props.collapseStringsAfterLength}media={props.media}scrollable={props.scrollable}@@ -1348,6 +1388,7 @@ export function PrettyJsonView(props: {<divclassName={cn("flex max-h-full min-h-0 flex-col",+ props.inset && "[&_.io-message-content]:px-2",props.className,props.scrollable ? "overflow-hidden" : "",)}@@ -1359,6 +1400,7 @@ export function PrettyJsonView(props: {canEnableMarkdown={false}handleOnValueChange={() => {}} // No-op, parent handles statehandleOnCopy={handleOnCopy}+ inset={props.inset}controlButtons={<>{shouldUseTableView && (diff --git a/web/src/features/traces/components/IOPreview/IOPreview.tsx b/web/src/features/traces/components/IOPreview/IOPreview.tsxindex 40f26e6e1c..be6c36c6bb 100644--- a/web/src/features/traces/components/IOPreview/IOPreview.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreview.tsx@@ -14,6 +14,7 @@ import { type ChatMLParserResult } from "../../hooks/useChatMLParser";import { Button } from "@/src/components/ui/button";import { ActionButton } from "@/src/components/ActionButton";import { BookOpen, X } from "lucide-react";+import type { ObservationStatusMessage } from "./components/statusMessagePresentation";export type { ViewMode };export type IOPreviewContentMode = "all" | "conversation";@@ -53,6 +54,7 @@ export interface ExpansionStateProps {export interface IOPreviewProps extends ExpansionStateProps {input?: Prisma.JsonValue;output?: Prisma.JsonValue;+ status?: ObservationStatusMessage;metadata?: Prisma.JsonValue;outputCorrection?: ScoreDomain;// Pre-parsed data (optional, from useParsedObservation hook for performance)@@ -104,6 +106,7 @@ export interface IOPreviewProps extends ExpansionStateProps {export function IOPreview({input,output,+ status,outputCorrection,metadata,parsedInput,@@ -178,6 +181,7 @@ export function IOPreview({const sharedProps = {input,output,+ status,outputCorrection,metadata,parsedInput,@@ -239,6 +243,7 @@ export function IOPreview({<IOPreviewJSONinput={input}output={output}+ status={status}metadata={metadata}parsedInput={parsedInput}parsedOutput={parsedOutput}@@ -265,6 +270,7 @@ export function IOPreview({<IOPreviewJSONSimpleinput={input}output={output}+ status={status}metadata={metadata}outputCorrection={outputCorrection}parsedInput={parsedInput}@@ -286,6 +292,7 @@ export function IOPreview({projectId={projectId}traceId={traceId}environment={environment}+ showCorrections={showCorrections}/>) : (<IOPreviewPrettydiff --git a/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx b/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsxindex 733b4e97cc..bf7fd8f452 100644--- a/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx@@ -36,6 +36,11 @@ import {JSON_VIEW_RENDER_ROW_LIMIT,probeJsonField,} from "./fns/jsonViewSizeGate";+import {+ getStatusMessagePresentation,+ parseStructuredStatusMessage,+ type ObservationStatusMessage,+} from "./components/statusMessagePresentation";// A field needing windowing is gated to the lazy byte-engine viewer, so the// gate row limit IS the virtualization threshold (single source of truth). The@@ -43,6 +48,16 @@ import {// `needsVirtualization` note below.const VIRTUALIZATION_THRESHOLD = JSON_VIEW_RENDER_ROW_LIMIT;+const STATUS_MESSAGE_BACKGROUND_COLORS: Record<+ ObservationStatusMessage["level"],+ string+> = {+ ERROR: "var(--light-red)",+ WARNING: "var(--light-yellow)",+ DEBUG: "hsl(var(--muted) / 0.3)",+ DEFAULT: "hsl(var(--card))",+};+/*** Decode a field's \uXXXX escapes, but only when it fits under the decoder's* node budget. `decodeUnicodeInJson` caps at DECODE_UNICODE_MAX_NODES and copies@@ -60,6 +75,7 @@ function decodeIfWithinBudget(value: unknown, rowCount: number): unknown {export interface IOPreviewJSONProps {input?: Prisma.JsonValue;output?: Prisma.JsonValue;+ status?: ObservationStatusMessage;metadata?: Prisma.JsonValue;outputCorrection?: ScoreDomain;// Pre-parsed data (from useParsedObservation hook)@@ -105,6 +121,7 @@ export interface IOPreviewJSONProps {function IOPreviewJSONInner({input,output,+ status,metadata,parsedInput,parsedOutput,@@ -147,6 +164,9 @@ function IOPreviewJSONInner({}),[isDark],);+ const statusPresentation = status+ ? getStatusMessagePresentation(status.level)+ : null;// Fall back to raw values when caller does not provide pre-parsed fields// (e.g. session events rows in v4 mode). Parse once here, BEFORE the decode@@ -469,6 +489,15 @@ function IOPreviewJSONInner({});const result = [];+ if (status && statusPresentation) {+ result.push({+ key: "status-message",+ title: statusPresentation.title,+ data: parseStructuredStatusMessage(status.message) ?? status.message,+ backgroundColor: STATUS_MESSAGE_BACKGROUND_COLORS[status.level],+ minHeight: "4px",+ });+ }if (showInput) {result.push(inputTooLarge@@ -554,6 +583,8 @@ function IOPreviewJSONInner({}, [showInput,showOutput,+ status,+ statusPresentation,showMetadata,inputTooLarge,outputTooLarge,diff --git a/web/src/features/traces/components/IOPreview/IOPreviewJSONSimple.tsx b/web/src/features/traces/components/IOPreview/IOPreviewJSONSimple.tsxindex a20e7974e8..06136435b1 100644--- a/web/src/features/traces/components/IOPreview/IOPreviewJSONSimple.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreviewJSONSimple.tsx@@ -8,10 +8,13 @@ import {JSON_VIEW_RENDER_CHAR_LIMIT,probeJsonField,} from "./fns/jsonViewSizeGate";+import { StatusMessageSection } from "./components/StatusMessageSection";+import type { ObservationStatusMessage } from "./components/statusMessagePresentation";export interface IOPreviewJSONSimpleProps {input?: Prisma.JsonValue;output?: Prisma.JsonValue;+ status?: ObservationStatusMessage;metadata?: Prisma.JsonValue;outputCorrection?: ScoreDomain;// Pre-parsed data (optional, from useParsedObservation hook for performance)@@ -56,6 +59,7 @@ export interface IOPreviewJSONSimpleProps {export function IOPreviewJSONSimple({input,output,+ status,metadata,outputCorrection,parsedInput,@@ -129,6 +133,9 @@ export function IOPreviewJSONSimple({return (<div className="[&_.io-message-content]:px-2 [&_.io-message-header]:px-2">+ {status ? (+ <StatusMessageSection status={status} currentView="json" />+ ) : null}{showInput &&(inputTooLarge ? (<LargeJsonFieldFallbackdiff --git a/web/src/features/traces/components/IOPreview/IOPreviewPretty.tsx b/web/src/features/traces/components/IOPreview/IOPreviewPretty.tsxindex 1fe7a6636a..325b0b4762 100644--- a/web/src/features/traces/components/IOPreview/IOPreviewPretty.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreviewPretty.tsx@@ -16,6 +16,8 @@ import {} from "./IOPreview";import { CorrectedOutputField } from "./components/CorrectedOutputField";import { isOnlyJsonMessage } from "../../fns/chatMessageUtils";+import { StatusMessageSection } from "./components/StatusMessageSection";+import type { ObservationStatusMessage } from "./components/statusMessagePresentation";interface JsonInputOutputViewProps {parsedInput: unknown;@@ -86,6 +88,7 @@ function JsonInputOutputView({export interface IOPreviewPrettyProps extends ExpansionStateProps {input?: Prisma.JsonValue;output?: Prisma.JsonValue;+ status?: ObservationStatusMessage;metadata?: Prisma.JsonValue;outputCorrection?: ScoreDomain;// Pre-parsed data (optional, from useParsedObservation hook for performance)@@ -126,6 +129,7 @@ export interface IOPreviewPrettyProps extends ExpansionStateProps {export function IOPreviewPretty({input,output,+ status,metadata,outputCorrection,parsedInput: preParsedInput,@@ -272,6 +276,10 @@ export function IOPreviewPretty({return (<div>+ {showData && status ? (+ <StatusMessageSection status={status} currentView="pretty" />+ ) : null}+{showData ? (<SectionToolDefinitionstools={allTools}diff --git a/web/src/features/traces/components/IOPreview/components/StatusMessageSection.stories.tsx b/web/src/features/traces/components/IOPreview/components/StatusMessageSection.stories.tsxnew file mode 100644index 0000000000..f9ae7f4add--- /dev/null+++ b/web/src/features/traces/components/IOPreview/components/StatusMessageSection.stories.tsx@@ -0,0 +1,46 @@+import preview from "../../../../../../.storybook/preview";+import { StatusMessageSection } from "./StatusMessageSection";++const meta = preview.meta({+ component: StatusMessageSection,+});++export const Default = meta.story({+ args: {+ currentView: "pretty",+ status: {+ level: "DEFAULT",+ message: "The observation completed with additional status details.",+ },+ },+});++export const Debug = meta.story({+ args: {+ currentView: "pretty",+ status: {+ level: "DEBUG",+ message: "Detailed diagnostic information for this observation.",+ },+ },+});++export const Warning = meta.story({+ args: {+ currentView: "pretty",+ status: {+ level: "WARNING",+ message: "The observation completed with a recoverable warning.",+ },+ },+});++export const Error = meta.story({+ args: {+ currentView: "pretty",+ status: {+ level: "ERROR",+ message: "Upstream model request timed out after 30 seconds.",+ },+ },+});diff --git a/web/src/features/traces/components/IOPreview/components/StatusMessageSection.tsx b/web/src/features/traces/components/IOPreview/components/StatusMessageSection.tsxnew file mode 100644index 0000000000..9ab195be7c--- /dev/null+++ b/web/src/features/traces/components/IOPreview/components/StatusMessageSection.tsx@@ -0,0 +1,67 @@+import { useMemo } from "react";+import { MarkdownJsonViewHeader } from "@/src/components/ui/MarkdownJsonView";+import { PrettyJsonView } from "@/src/components/ui/PrettyJsonView";+import { cn } from "@/src/utils/tailwind";+import { copyTextToClipboard } from "@/src/utils/clipboard";+import {+ getStatusMessagePresentation,+ parseStructuredStatusMessage,+ type ObservationStatusMessage,+} from "./statusMessagePresentation";++const STATUS_MESSAGE_CLASS_NAMES: Record<+ ObservationStatusMessage["level"],+ string+> = {+ ERROR: "border-dark-red bg-light-red",+ WARNING: "border-dark-yellow/40 bg-light-yellow",+ DEBUG: "border-muted-foreground/15 bg-muted/30 text-muted-foreground",+ DEFAULT: "bg-card",+};++export function StatusMessageSection({+ status,+ currentView,+}: {+ status: ObservationStatusMessage;+ currentView: "pretty" | "json";+}) {+ const presentation = getStatusMessagePresentation(status.level);+ const parsedStatusMessage = useMemo(+ () => parseStructuredStatusMessage(status.message),+ [status.message],+ );++ if (parsedStatusMessage !== undefined) {+ return (+ <PrettyJsonView+ title={presentation.title}+ json={status.message}+ parsedJson={parsedStatusMessage}+ currentView={currentView}+ tone={presentation.tone}+ inset+ />+ );+ }++ return (+ <div>+ <MarkdownJsonViewHeader+ title={presentation.title}+ handleOnValueChange={() => undefined}+ handleOnCopy={() => copyTextToClipboard(status.message)}+ canEnableMarkdown={false}+ inset+ />+ <div+ className={cn(+ "ph-no-capture mx-2 rounded-sm border px-2 py-2 text-xs wrap-break-word whitespace-pre-wrap",+ STATUS_MESSAGE_CLASS_NAMES[status.level],+ )}+ >+ {status.message}+ </div>+ </div>+ );+}diff --git a/web/src/features/traces/components/IOPreview/components/statusMessagePresentation.clienttest.ts b/web/src/features/traces/components/IOPreview/components/statusMessagePresentation.clienttest.tsnew file mode 100644index 0000000000..fac1b7ff51--- /dev/null+++ b/web/src/features/traces/components/IOPreview/components/statusMessagePresentation.clienttest.ts@@ -0,0 +1,28 @@+import { describe, expect, it } from "vitest";++import { parseStructuredStatusMessage } from "./statusMessagePresentation";++describe("parseStructuredStatusMessage", () => {+ it("parses JSON objects and arrays", () => {+ expect(+ parseStructuredStatusMessage('{"error":{"retryable":true}}'),+ ).toEqual({+ error: { retryable: true },+ });+ expect(parseStructuredStatusMessage('[{"code":"timeout"}]')).toEqual([+ { code: "timeout" },+ ]);+ });++ it("leaves plain text and JSON scalars as text", () => {+ expect(parseStructuredStatusMessage("Request timed out")).toBeUndefined();+ expect(parseStructuredStatusMessage("404")).toBeUndefined();+ expect(parseStructuredStatusMessage('"Request timed out"')).toBeUndefined();+ });++ it("does not parse oversized status messages", () => {+ expect(+ parseStructuredStatusMessage(`{"message":"${"x".repeat(5_000)}"}`),+ ).toBeUndefined();+ });+});diff --git a/web/src/features/traces/components/IOPreview/components/statusMessagePresentation.ts b/web/src/features/traces/components/IOPreview/components/statusMessagePresentation.tsnew file mode 100644index 0000000000..1ea7627c29--- /dev/null+++ b/web/src/features/traces/components/IOPreview/components/statusMessagePresentation.ts@@ -0,0 +1,54 @@+import { deepParseJson, type ObservationLevelType } from "@langfuse/shared";+import { assertUnreachable } from "@/src/utils/types";++// Status messages do not use the async I/O parser. Keep shallow structured+// values below the eager JSON viewers' tree budget; larger values stay text.+const STATUS_MESSAGE_JSON_PARSE_LIMIT = 5_000;++export interface ObservationStatusMessage {+ level: ObservationLevelType;+ message: string;+}++export function parseStructuredStatusMessage(message: string) {+ if (message.length > STATUS_MESSAGE_JSON_PARSE_LIMIT) return undefined;++ const parsed = deepParseJson(message, {+ maxSize: STATUS_MESSAGE_JSON_PARSE_LIMIT,+ maxDepth: 2,+ });++ return typeof parsed === "object" && parsed !== null ? parsed : undefined;+}++export function getStatusMessagePresentation(level: ObservationLevelType) {+ if (level === "ERROR") {+ return {+ title: "Error",+ tone: "danger" as const,+ };+ }++ if (level === "WARNING") {+ return {+ title: "Warning",+ tone: "warning" as const,+ };+ }++ if (level === "DEBUG") {+ return {+ title: "Debug",+ tone: "muted" as const,+ };+ }++ if (level === "DEFAULT") {+ return {+ title: "Status",+ tone: "neutral" as const,+ };+ }++ return assertUnreachable(level);+}diff --git a/web/src/features/traces/components/ObservationDetailView/ObservationDetailView.tsx b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsxsimilarity index 78%rename from web/src/features/traces/components/ObservationDetailView/ObservationDetailView.tsxrename to web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsxindex 500018f943..cbd21b688b 100644--- a/web/src/features/traces/components/ObservationDetailView/ObservationDetailView.tsx+++ b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx@@ -1,5 +1,5 @@/**- * ObservationDetailView - Shows observation-level details when an observation is selected+ * ConnectedObservationDetailView - Connects observation details to application data.** Responsibility:* - Display observation metadata (type, timestamp, model, environment, etc.)@@ -19,29 +19,28 @@*/import { type ObservationReturnTypeWithMetadata } from "@/src/server/api/routers/traces";+import { useCallback, useMemo, useState } from "react";+import { Switch } from "@/src/components/design-system/Switch/Switch";+import {+ HoverCard,+ HoverCardContent,+ HoverCardTrigger,+} from "@/src/components/ui/hover-card";+import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";import {TabsBar,TabsBarContent,TabsBarList,TabsBarTrigger,} from "@/src/components/ui/tabs-bar";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";-import { Switch } from "@/src/components/design-system/Switch/Switch";import {Tooltip,TooltipContent,TooltipProvider,TooltipTrigger,} from "@/src/components/ui/tooltip";-import {- HoverCard,- HoverCardContent,- HoverCardTrigger,-} from "@/src/components/ui/hover-card";-import { useCallback, useMemo, useState } from "react";import { type SelectionData } from "@/src/features/comments/contexts/InlineCommentSelectionContext";import ScoresTable from "@/src/components/table/use-cases/scores";-import { IOPreview } from "@/src/features/traces/components/IOPreview/IOPreview";import { getMostRecentCorrection } from "@/src/features/corrections/utils/getMostRecentCorrection";import { useJsonExpansion } from "@/src/features/traces/contexts/JsonExpansionContext";import { useMedia } from "@/src/features/traces/hooks/useMedia";@@ -57,27 +56,27 @@ import { api } from "@/src/utils/api";// Extracted componentsimport { ObservationDetailViewHeader } from "./components/ObservationDetailViewHeader";import { TraceLogView } from "../TraceLogView/TraceLogView";-import { TRACE_VIEW_CONFIG } from "@/src/features/traces/constants/traceViewConfig";import { useV4Beta } from "@/src/features/events/hooks/useV4Beta";+import { TRACE_VIEW_CONFIG } from "@/src/features/traces/constants/traceViewConfig";import {aggregateTraceMetrics,getDescendantIds,} from "@/src/features/traces/fns/traceAggregation";-import TagList from "@/src/features/tag/components/TagList";import { useHasProjectAccess } from "@/src/features/rbac/utils/checkProjectAccess";import { useSession } from "next-auth/react";+import { ObservationPreview } from "./ObservationPreview";-export interface ObservationDetailViewProps {+export interface ConnectedObservationDetailViewProps {observation: ObservationReturnTypeWithMetadata;projectId: string;traceId: string;}-export function ObservationDetailView({+export function ConnectedObservationDetailView({observation,projectId,traceId,-}: ObservationDetailViewProps) {+}: ConnectedObservationDetailViewProps) {// Tab and view state from URL (via SelectionContext)const {selectedTab: globalSelectedTab,@@ -97,7 +96,6 @@ export function ObservationDetailView({} = useTraceData();const isLogViewVirtualized =observations.length >= TRACE_VIEW_CONFIG.logView.virtualizationThreshold;-// Get jsonViewPreference directly from ViewPreferencesContext for "json-beta" supportconst {jsonViewPreference,@@ -180,9 +178,8 @@ export function ObservationDetailView({// Map jsonViewPreference to currentView format expected by child componentsconst currentView = jsonViewPreference;-- const selectedViewTab =- jsonViewPreference === "pretty" ? "pretty" : ("json" as const);+ const selectedViewTab = currentView === "pretty" ? "pretty" : "json";+ const [isPrettyViewAvailable, setIsPrettyViewAvailable] = useState(true);const handleViewTabChange = useCallback((tab: string) => {@@ -204,9 +201,6 @@ export function ObservationDetailView({[setJsonBetaEnabled, setJsonViewPreference],);- const [isPrettyViewAvailable, setIsPrettyViewAvailable] = useState(true);- const [isJSONBetaVirtualized, setIsJSONBetaVirtualized] = useState(false);-// states for the inline commentsconst [pendingSelection, setPendingSelection] =useState<SelectionData | null>(null);@@ -313,7 +307,6 @@ export function ObservationDetailView({return (<div className="flex h-full flex-col overflow-hidden">- {/* Header section (extracted component) */}<ObservationDetailViewHeaderobservation={observation}observationWithIO={observationWithIO}@@ -330,7 +323,6 @@ export function ObservationDetailView({treeNodeTotalCost={treeNode?.totalCost}/>- {/* Tabs section */}<TabsBarvalue={selectedTab}className="flex min-h-0 flex-1 flex-col overflow-hidden"@@ -338,15 +330,14 @@ export function ObservationDetailView({setSelectedTab(value as "preview" | "log" | "scores")}>- {/* Hide entire tabs bar when only Preview tab remains (annotation mode) */}{showTabsBar && (<TooltipProvider><TabsBarList><TabsBarTrigger value="preview">Preview</TabsBarTrigger>- {showScoresTab && (+ {showScoresTab ? (<TabsBarTrigger value="scores">Scores</TabsBarTrigger>- )}- {showLogViewTab && (+ ) : null}+ {showLogViewTab ? (<TabsBarTrigger value="log"><Tooltip><TooltipTrigger asChild>@@ -359,10 +350,8 @@ export function ObservationDetailView({</TooltipContent></Tooltip></TabsBarTrigger>- )}+ ) : null}- {/* View toggle (Formatted/JSON) - show for preview and log tabs when pretty view available */}- {/* JSON views are disabled for virtualized log view (large traces) */}{(selectedTab === "log" ||(selectedTab === "preview" && isPrettyViewAvailable)) && (<>@@ -374,7 +363,6 @@ export function ObservationDetailView({: selectedViewTab}onValueChange={(value) => {- // Don't allow JSON views for virtualized log viewif (selectedTab === "log" &&isLogViewVirtualized &&@@ -431,7 +419,6 @@ export function ObservationDetailView({)}</TabsList></Tabs>- {/* Beta toggle - only show when JSON is selected and not in virtualized log view */}{selectedViewTab === "json" &&!(selectedTab === "log" && isLogViewVirtualized) && (<div className="mr-1 flex items-center gap-1.5">@@ -451,105 +438,75 @@ export function ObservationDetailView({</TooltipProvider>)}- {/* Preview tab content */}<TabsBarContentvalue="preview"className="mt-0 flex max-h-full min-h-0 w-full flex-1">- <div- className={`flex min-h-0 w-full flex-1 flex-col ${- currentView === "json-beta" && isJSONBetaVirtualized- ? "overflow-hidden"- : "overflow-auto pb-4"- }`}- >- {isRoot &&- observation.traceTags &&- observation.traceTags.length > 0 && (- <>- <div- className={`px-2 pt-2 text-sm font-bold ${currentView !== "pretty" ? "shrink-0" : ""}`}- >- Tags- </div>- <div- className={`flex flex-wrap gap-x-1 gap-y-1 px-2 pb-2 ${currentView !== "pretty" ? "shrink-0" : ""}`}- >- <TagList- selectedTags={observation.traceTags}- isLoading={false}- />- </div>- </>- )}- <IOPreview- key={observation.id}- observationName={observation.name ?? undefined}- input={observationWithIOCompat.data?.input ?? undefined}- output={observationWithIOCompat.data?.output ?? undefined}- outputCorrection={outputCorrection}- metadata={observationWithIOCompat.data?.metadata ?? undefined}- parsedInput={parsedInput}- parsedOutput={parsedOutput}- parsedMetadata={parsedMetadata}- isLoading={observationWithIOCompat.isLoading}- isParsing={isWaitingForParsing}- media={observationMedia.data}- currentView={currentView}- setIsPrettyViewAvailable={setIsPrettyViewAvailable}- inputExpansionState={formattedExpansion.input}- outputExpansionState={formattedExpansion.output}- metadataExpansionState={formattedExpansion.metadata}- onInputExpansionChange={(exp) =>+ <ObservationPreview+ currentView={currentView}+ tags={isRoot ? observation.traceTags : undefined}+ previewKey={observation.id}+ onPrettyViewAvailabilityChange={setIsPrettyViewAvailable}+ previewProps={{+ observationName: observation.name ?? undefined,+ input: observationWithIOCompat.data?.input ?? undefined,+ output: observationWithIOCompat.data?.output ?? undefined,+ status: observation.statusMessage+ ? {+ level: observation.level,+ message: observation.statusMessage,+ }+ : undefined,+ outputCorrection,+ metadata: observationWithIOCompat.data?.metadata ?? undefined,+ parsedInput,+ parsedOutput,+ parsedMetadata,+ isLoading: observationWithIOCompat.isLoading,+ isParsing: isWaitingForParsing,+ media: observationMedia.data,+ inputExpansionState: formattedExpansion.input,+ outputExpansionState: formattedExpansion.output,+ metadataExpansionState: formattedExpansion.metadata,+ onInputExpansionChange: (exp) =>setFormattedFieldExpansion("input",exp as Record<string, boolean>,- )- }- onOutputExpansionChange={(exp) =>+ ),+ onOutputExpansionChange: (exp) =>setFormattedFieldExpansion("output",exp as Record<string, boolean>,- )- }- onMetadataExpansionChange={(exp) =>+ ),+ onMetadataExpansionChange: (exp) =>setFormattedFieldExpansion("metadata",exp as Record<string, boolean>,- )- }- advancedJsonExpansionState={advancedJsonExpansion}- onAdvancedJsonExpansionChange={setAdvancedJsonExpansion}- jsonInputExpanded={jsonExpansion.input}- jsonOutputExpanded={jsonExpansion.output}- jsonMetadataExpanded={jsonExpansion.metadata}- onJsonInputExpandedChange={(expanded) =>- setJsonFieldExpansion("input", expanded)- }- onJsonOutputExpandedChange={(expanded) =>- setJsonFieldExpansion("output", expanded)- }- onJsonMetadataExpandedChange={(expanded) =>- setJsonFieldExpansion("metadata", expanded)- }- enableInlineComments={true}- onAddInlineComment={handleAddInlineComment}- commentedPathsByField={commentedPathsByField}- showMetadata- observationId={observation.id}- onVirtualizationChange={setIsJSONBetaVirtualized}- projectId={projectId}- traceId={traceId}- environment={observation.environment}- />- {currentView !== "json-beta" && (- <div className="h-4 w-full shrink-0" />- )}- </div>+ ),+ advancedJsonExpansionState: advancedJsonExpansion,+ onAdvancedJsonExpansionChange: setAdvancedJsonExpansion,+ jsonInputExpanded: jsonExpansion.input,+ jsonOutputExpanded: jsonExpansion.output,+ jsonMetadataExpanded: jsonExpansion.metadata,+ onJsonInputExpandedChange: (expanded) =>+ setJsonFieldExpansion("input", expanded),+ onJsonOutputExpandedChange: (expanded) =>+ setJsonFieldExpansion("output", expanded),+ onJsonMetadataExpandedChange: (expanded) =>+ setJsonFieldExpansion("metadata", expanded),+ enableInlineComments: true,+ onAddInlineComment: handleAddInlineComment,+ commentedPathsByField,+ showMetadata: true,+ observationId: observation.id,+ projectId,+ traceId,+ environment: observation.environment,+ }}+ /></TabsBarContent>- {/* Scores tab content */}- {showScoresTab && (+ {showScoresTab ? (<TabsBarContentvalue="scores"className="mt-0 mr-4 mb-2 flex h-full min-h-0 flex-1 overflow-hidden"@@ -573,10 +530,9 @@ export function ObservationDetailView({/></div></TabsBarContent>- )}+ ) : null}- {/* Log View tab content (v4 mode only) */}- {showLogViewTab && (+ {showLogViewTab ? (<TabsBarContentvalue="log"className="mt-0 flex max-h-full min-h-0 w-full flex-1"@@ -587,7 +543,7 @@ export function ObservationDetailView({currentView={isLogViewVirtualized ? "pretty" : currentView}/></TabsBarContent>- )}+ ) : null}</TabsBar></div>);diff --git a/web/src/features/traces/components/ObservationDetailView/ObservationPreview.stories.tsx b/web/src/features/traces/components/ObservationDetailView/ObservationPreview.stories.tsxnew file mode 100644index 0000000000..cb94d5eb0c--- /dev/null+++ b/web/src/features/traces/components/ObservationDetailView/ObservationPreview.stories.tsx@@ -0,0 +1,176 @@+import preview from "../../../../../.storybook/preview";+import { ObservationPreview } from "./ObservationPreview";++const meta = preview.meta({+ component: ObservationPreview,+});++export const Default = meta.story({+ args: {+ tags: ["production", "support"],+ previewKey: "default-observation",+ previewProps: {+ input: {+ customerId: "customer-123",+ question: "How do I reduce API latency?",+ },+ output: {+ recommendation: "Enable prompt caching and stream the response.",+ latencyMs: 842,+ },+ metadata: {+ model: "example-model",+ region: "eu-west-1",+ },+ projectId: "storybook-project",+ traceId: "storybook-trace",+ showMetadata: true,+ showCorrections: false,+ },+ },+});++export const Error = meta.story({+ args: {+ previewKey: "error-observation",+ previewProps: {+ input: {+ customerId: "customer-123",+ question: "How do I reduce API latency?",+ },+ output: null,+ status: {+ level: "ERROR",+ message: "Upstream model request timed out after 30 seconds",+ },+ metadata: {+ model: "example-model",+ region: "eu-west-1",+ },+ projectId: "storybook-project",+ traceId: "storybook-trace",+ showMetadata: true,+ showCorrections: false,+ },+ },+});++export const JsonError = meta.story({+ args: {+ previewKey: "json-error-observation",+ previewProps: {+ input: {+ customerId: "customer-123",+ question: "How do I reduce API latency?",+ },+ output: null,+ status: {+ level: "ERROR",+ message: JSON.stringify(+ {+ error: {+ code: "upstream_timeout",+ message: "The upstream model did not respond in time.",+ retryable: true,+ },+ requestId: "req_01K3H8TQ9V",+ },+ null,+ 2,+ ),+ },+ metadata: {+ model: "example-model",+ region: "eu-west-1",+ },+ projectId: "storybook-project",+ traceId: "storybook-trace",+ showMetadata: true,+ showCorrections: false,+ },+ },+});++export const Warning = meta.story({+ args: {+ previewKey: "warning-observation",+ previewProps: {+ input: {+ customerId: "customer-123",+ question: "How do I reduce API latency?",+ },+ output: {+ recommendation: "Enable prompt caching and stream the response.",+ latencyMs: 1842,+ },+ status: {+ level: "WARNING",+ message: "The response completed after one automatic retry.",+ },+ metadata: {+ model: "example-model",+ region: "eu-west-1",+ },+ projectId: "storybook-project",+ traceId: "storybook-trace",+ showMetadata: true,+ showCorrections: false,+ },+ },+});++export const Debug = meta.story({+ args: {+ previewKey: "debug-observation",+ previewProps: {+ input: {+ customerId: "customer-123",+ question: "How do I reduce API latency?",+ },+ output: {+ recommendation: "Enable prompt caching and stream the response.",+ latencyMs: 842,+ },+ status: {+ level: "DEBUG",+ message: "Prompt cache lookup completed without a matching entry.",+ },+ metadata: {+ model: "example-model",+ region: "eu-west-1",+ },+ projectId: "storybook-project",+ traceId: "storybook-trace",+ showMetadata: true,+ showCorrections: false,+ },+ },+});++export const Info = meta.story({+ args: {+ previewKey: "info-observation",+ previewProps: {+ input: {+ customerId: "customer-123",+ question: "How do I reduce API latency?",+ },+ output: {+ recommendation: "Enable prompt caching and stream the response.",+ latencyMs: 842,+ },+ status: {+ level: "DEFAULT",+ message: "The response completed with additional status details.",+ },+ metadata: {+ model: "example-model",+ region: "eu-west-1",+ },+ projectId: "storybook-project",+ traceId: "storybook-trace",+ showMetadata: true,+ showCorrections: false,+ },+ },+});diff --git a/web/src/features/traces/components/ObservationDetailView/ObservationPreview.tsx b/web/src/features/traces/components/ObservationDetailView/ObservationPreview.tsxnew file mode 100644index 0000000000..cb5d32cf69--- /dev/null+++ b/web/src/features/traces/components/ObservationDetailView/ObservationPreview.tsx@@ -0,0 +1,60 @@+import { useState, type ComponentProps, type Key } from "react";++import { IOPreview } from "@/src/features/traces/components/IOPreview/IOPreview";+import TagList from "@/src/features/tag/components/TagList";++export interface ObservationPreviewProps {+ currentView?: ComponentProps<typeof IOPreview>["currentView"];+ tags?: string[] | null;+ previewKey: Key;+ previewProps: Omit<+ ComponentProps<typeof IOPreview>,+ "currentView" | "setIsPrettyViewAvailable" | "onVirtualizationChange"+ >;+ onPrettyViewAvailabilityChange?: (isAvailable: boolean) => void;+}++export function ObservationPreview({+ currentView,+ tags,+ previewKey,+ previewProps,+ onPrettyViewAvailabilityChange,+}: ObservationPreviewProps) {+ const [isJSONBetaVirtualized, setIsJSONBetaVirtualized] = useState(false);++ return (+ <div+ className={`flex min-h-0 w-full flex-1 flex-col ${+ currentView === "json-beta" && isJSONBetaVirtualized+ ? "overflow-hidden"+ : "overflow-auto pb-4"+ }`}+ >+ {tags && tags.length > 0 ? (+ <>+ <div+ className={`px-2 pt-2 text-sm font-bold ${currentView && currentView !== "pretty" ? "shrink-0" : ""}`}+ >+ Tags+ </div>+ <div+ className={`flex flex-wrap gap-x-1 gap-y-1 px-2 pb-2 ${currentView && currentView !== "pretty" ? "shrink-0" : ""}`}+ >+ <TagList selectedTags={tags} isLoading={false} />+ </div>+ </>+ ) : null}+ <IOPreview+ key={previewKey}+ {...previewProps}+ currentView={currentView}+ setIsPrettyViewAvailable={onPrettyViewAvailabilityChange}+ onVirtualizationChange={setIsJSONBetaVirtualized}+ />+ {currentView !== "json-beta" ? (+ <div className="h-4 w-full shrink-0" />+ ) : null}+ </div>+ );+}diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsxindex 121c534a1f..467256c614 100644--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx@@ -34,7 +34,6 @@ import {ReleaseBadge,VersionBadge,LevelBadge,- StatusMessageBadge,} from "../../ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple";import { SessionBadge, UserIdBadge } from "../../TraceMetadataBadges";import { CostBadge, UsageBadge } from "../../ObservationMetadataBadgesTooltip";@@ -554,7 +553,6 @@ export const ObservationDetailViewHeader = memo(modelParameters={observation.modelParameters}/><LevelBadge level={observation.level} />- <StatusMessageBadge statusMessage={observation.statusMessage} />{observation.promptId && (<PromptBadgepromptId={observation.promptId}diff --git a/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx b/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsxindex e486cce302..105174613b 100644--- a/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx+++ b/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx@@ -81,13 +81,3 @@ export function LevelBadge({ level }: { level: string | null | undefined }) {</Badge>);}--export function StatusMessageBadge({- statusMessage,-}: {- statusMessage: string | null | undefined;-}) {- if (!statusMessage) return null;-- return <Badge variant="tertiary">{statusMessage}</Badge>;-}diff --git a/web/src/features/traces/components/TracePanelDetail.clienttest.tsx b/web/src/features/traces/components/TracePanelDetail.clienttest.tsxindex c2ccb1cea2..032cb894d7 100644--- a/web/src/features/traces/components/TracePanelDetail.clienttest.tsx+++ b/web/src/features/traces/components/TracePanelDetail.clienttest.tsx@@ -35,9 +35,9 @@ vi.mock(() => ({ TraceDetailView: () => <div data-testid="trace-detail" /> }),);vi.mock(- "@/src/features/traces/components/ObservationDetailView/ObservationDetailView",+ "@/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView",() => ({- ObservationDetailView: ({+ ConnectedObservationDetailView: ({observation,}: {observation: ObservationReturnTypeWithMetadata;diff --git a/web/src/features/traces/components/TracePanelDetail.tsx b/web/src/features/traces/components/TracePanelDetail.tsxindex d8692ed574..985c8327a3 100644--- a/web/src/features/traces/components/TracePanelDetail.tsx+++ b/web/src/features/traces/components/TracePanelDetail.tsx@@ -21,7 +21,7 @@ import { useTraceData } from "@/src/features/traces/contexts/TraceDataContext";import { useSelectedObservation } from "@/src/features/traces/hooks/useSelectedObservation";import { Skeleton } from "@/src/components/ui/skeleton";import { TraceDetailView } from "./TraceDetailView/TraceDetailView";-import { ObservationDetailView } from "./ObservationDetailView/ObservationDetailView";+import { ConnectedObservationDetailView } from "./ObservationDetailView/ConnectedObservationDetailView";import { useMemo } from "react";function PanelMessage({ title, body }: { title: string; body: string }) {@@ -57,7 +57,7 @@ export function TracePanelDetail() {switch (selected.kind) {case "observation":return (- <ObservationDetailView+ <ConnectedObservationDetailViewobservation={selected.observation}projectId={trace.projectId}traceId={trace.id}