Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

feat(skills): show traces for selected skill versions (#18893)

tobi_kl8ca8ac3be7c3
diff --git a/packages/shared/src/eventsTable.ts b/packages/shared/src/eventsTable.ts
index f831708f7e..7583cec788 100644
--- a/packages/shared/src/eventsTable.ts
+++ b/packages/shared/src/eventsTable.ts
@@ -52,6 +52,13 @@ export const isRootObservation = ({
// absent (NULL != '' is NULL, i.e. not true), so only real payloads match.
export const eventsTableHasInputSql = "e.input != ''";
export const eventsTableHasOutputSql = "e.output != ''";
+export const eventsTableLoadedSkillNamesSql =
+ "e.skills_resource_loaded.skillName";
+export const eventsTableLoadedSkillVersionsSql =
+ "arrayMap(skill -> concat(skill.skillName, '@', toString(skill.skillVersion)), e.skills_resource_loaded)";
+export const eventsTableAvailableSkillNamesSql = "e.skills_available.skillName";
+export const eventsTableAvailableSkillVersionsSql =
+ "arrayMap(skill -> concat(skill.skillName, '@', toString(skill.skillVersion)), e.skills_available)";
const isCachedInputMetric = (key: string): boolean => {
const normalizedKey = key.toLowerCase();
@@ -490,6 +497,34 @@ const eventsTableColsDefinition = [
options: [], // to be added at runtime
nullable: true,
},
+ {
+ name: "Loaded Skill Names",
+ id: "skillsNamesLoaded",
+ type: "arrayOptions",
+ internal: eventsTableLoadedSkillNamesSql,
+ options: [],
+ },
+ {
+ name: "Loaded Skill Versions",
+ id: "skillsVersionsLoaded",
+ type: "arrayOptions",
+ internal: eventsTableLoadedSkillVersionsSql,
+ options: [],
+ },
+ {
+ name: "Available Skill Names",
+ id: "skillNamesAvailable",
+ type: "arrayOptions",
+ internal: eventsTableAvailableSkillNamesSql,
+ options: [],
+ },
+ {
+ name: "Available Skill Versions",
+ id: "skillVersionsAvailable",
+ type: "arrayOptions",
+ internal: eventsTableAvailableSkillVersionsSql,
+ options: [],
+ },
{
name: "Available Tool Names",
id: "toolNames",
diff --git a/packages/shared/src/server/tableMappings/mapEventsTable.ts b/packages/shared/src/server/tableMappings/mapEventsTable.ts
index 039614390e..100e788d74 100644
--- a/packages/shared/src/server/tableMappings/mapEventsTable.ts
+++ b/packages/shared/src/server/tableMappings/mapEventsTable.ts
@@ -10,6 +10,10 @@ import {
eventsTableCachedInputCostSql,
eventsTableCachedInputTokensSql,
eventsTableTraceNameSql,
+ eventsTableLoadedSkillNamesSql,
+ eventsTableLoadedSkillVersionsSql,
+ eventsTableAvailableSkillNamesSql,
+ eventsTableAvailableSkillVersionsSql,
} from "../../eventsTable";
import { tokenCountFilterClickhouseType } from "./tokenCountFilterType";
@@ -375,6 +379,42 @@ export const eventsTableNativeUiColumnDefinitions: UiColumnMappings = [
clickhouseTableName: "events_proto",
clickhouseSelect: "length(e.tool_calls)",
},
+ {
+ uiTableName: "Loaded Skill Names",
+ uiTableId: "skillsNamesLoaded",
+ clickhouseTableName: "events_proto",
+ clickhouseSelect: eventsTableLoadedSkillNamesSql,
+ },
+ {
+ uiTableName: "Loaded Skill Versions",
+ uiTableId: "skillsVersionsLoaded",
+ clickhouseTableName: "events_proto",
+ clickhouseSelect: eventsTableLoadedSkillVersionsSql,
+ },
+ {
+ uiTableName: "Available Skill Names",
+ uiTableId: "skillNamesAvailable",
+ clickhouseTableName: "events_proto",
+ clickhouseSelect: eventsTableAvailableSkillNamesSql,
+ },
+ {
+ uiTableName: "Available Skill Versions",
+ uiTableId: "skillVersionsAvailable",
+ clickhouseTableName: "events_proto",
+ clickhouseSelect: eventsTableAvailableSkillVersionsSql,
+ },
+ {
+ uiTableName: "Skill Names",
+ uiTableId: "skillNames",
+ clickhouseTableName: "events_proto",
+ clickhouseSelect: `arrayConcat(${eventsTableLoadedSkillNamesSql}, ${eventsTableAvailableSkillNamesSql})`,
+ },
+ {
+ uiTableName: "Skill Versions",
+ uiTableId: "skillVersions",
+ clickhouseTableName: "events_proto",
+ clickhouseSelect: `arrayConcat(${eventsTableLoadedSkillVersionsSql}, ${eventsTableAvailableSkillVersionsSql})`,
+ },
{
uiTableName: "Tool Names",
uiTableId: "toolNames",
diff --git a/web/src/features/events/components/EventsTable.tsx b/web/src/features/events/components/EventsTable.tsx
index daac2a0c65..c4bc8e9342 100644
--- a/web/src/features/events/components/EventsTable.tsx
+++ b/web/src/features/events/components/EventsTable.tsx
@@ -256,6 +256,7 @@ export type EventsTableProps = {
userId?: string;
promptName?: string;
promptVersion?: number;
+ skill?: { name: string; version?: number };
omittedFilter?: ObservationEventsOmittableFilterColumn[];
hideControls?: boolean;
// External control props for embedded preview tables
@@ -309,6 +310,7 @@ export default function ObservationsEventsTable({
userId,
promptName,
promptVersion,
+ skill,
omittedFilter = [],
hideControls = false,
externalFilterState,
@@ -654,6 +656,21 @@ export default function ObservationsEventsTable({
},
]
: []),
+ ...(skill
+ ? [
+ {
+ column:
+ skill.version === undefined ? "skillNames" : "skillVersions",
+ type: "arrayOptions" as const,
+ operator: "any of" as const,
+ value: [
+ skill.version === undefined
+ ? skill.name
+ : `${skill.name}@${skill.version}`,
+ ],
+ },
+ ]
+ : []),
...(promptName
? [
{
@@ -675,7 +692,7 @@ export default function ObservationsEventsTable({
]
: []),
],
- [userId, sessionId, promptName, promptVersion],
+ [userId, sessionId, promptName, promptVersion, skill],
);
const facetRefiningFilter = useMemo(
@@ -893,7 +910,7 @@ export default function ObservationsEventsTable({
// scoped. Unlike the old gate, an unsupported filter no longer HIDES the
// chart: the chart forwards what it can and the sidebar + search bar mark the
// rest as "not applied" (see chartFilterExclusions below).
- const chartEnabled = !hideControls && !userId && !sessionId;
+ const chartEnabled = !hideControls && !userId && !sessionId && !skill;
// Hide the strip where it would silently diverge from the table: prompt-version scope (not forwardable, no "not applied" affordance) or external date/filter pins.
const outlierStripEnabled =
diff --git a/web/src/features/skills/components/SkillEditor.tsx b/web/src/features/skills/components/SkillEditor.tsx
index 41f9bea5a5..201e79de6f 100644
--- a/web/src/features/skills/components/SkillEditor.tsx
+++ b/web/src/features/skills/components/SkillEditor.tsx
@@ -6,6 +6,7 @@ import {
useState,
} from "react";
import { useMediaQuery } from "react-responsive";
+import { StringParam, useQueryParam, withDefault } from "use-query-params";
import { MAX_SKILL_FILES } from "@langfuse/shared";
import { useStore } from "zustand";
import {
@@ -19,6 +20,8 @@ import {
} from "lucide-react";
import { Tooltip } from "@/src/components/design-system/Tooltip/Tooltip";
import { IconButton } from "@/src/components/design-system/IconButton/IconButton";
+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
+import { SkillLinkedTraces } from "@/src/features/skills/components/SkillLinkedTraces";
import { Badge } from "@/src/components/design-system/Badge/Badge";
import { CodeMirrorEditor } from "@/src/components/editor";
import Page from "@/src/components/layouts/page";
@@ -174,6 +177,12 @@ export function SkillEditor({
const [isSaving, setIsSaving] = useState(false);
const [isDownloading, setIsDownloading] = useState(false);
const isDraft = view.kind === "draft";
+ const [selectedTab, setSelectedTab] = useQueryParam(
+ "tab",
+ withDefault(StringParam, "files"),
+ );
+ const activeTab =
+ !isDraft && selectedTab === "linked-traces" ? "linked-traces" : "files";
const canEditFiles = isDraft && canCreate && !isSaving;
const isDesktop = useMediaQuery({ query: "(min-width: 768px)" });
const [treeState, setTreeState] = useState<SkillFileExplorerState>(() => ({
@@ -647,38 +656,61 @@ export function SkillEditor({
) : (
<SkillVersionHistory kind="new" />
)}
- <div className="min-h-[720px] min-w-0 flex-1 md:min-h-0">
- <ResizablePanelGroup
- key={isDesktop ? "desktop" : "mobile"}
- orientation={isDesktop ? "horizontal" : "vertical"}
+ <div className="flex min-h-[720px] min-w-0 flex-1 flex-col md:min-h-0">
+ <Tabs
+ value={activeTab}
+ onValueChange={(value) => setSelectedTab(value)}
+ layout="fill"
>
- <ResizablePanel
- defaultSize={isDesktop ? "28%" : "32%"}
- minSize={isDesktop ? "20%" : "24%"}
- maxSize={isDesktop ? "42%" : "50%"}
- >
- <SkillFileExplorer
- store={store}
- readOnly={!isDraft || !canCreate}
- disabled={isSaving}
- state={treeState}
- onStateChange={setTreeState}
- onUpload={() => setIsUploadOpen(true)}
- />
- </ResizablePanel>
- <ResizableHandle withHandle />
- <ResizablePanel
- defaultSize={isDesktop ? "72%" : "68%"}
- minSize={isDesktop ? "45%" : "42%"}
- >
- <SkillFileEditor
- projectId={projectId}
- store={store}
- isDraft={isDraft}
- editable={canEditFiles}
- />
- </ResizablePanel>
- </ResizablePanelGroup>
+ <Tabs.List variant="underline">
+ <Tabs.Trigger value="files" label="Files" />
+ {!isDraft ? (
+ <Tabs.Trigger value="linked-traces" label="Traces" />
+ ) : null}
+ </Tabs.List>
+ {!isDraft && baseVersion !== null ? (
+ <Tabs.Content value="linked-traces" layout="fill">
+ <SkillLinkedTraces
+ projectId={projectId}
+ name={name}
+ version={baseVersion}
+ />
+ </Tabs.Content>
+ ) : null}
+ <Tabs.Content value="files" layout="fill">
+ <ResizablePanelGroup
+ key={isDesktop ? "desktop" : "mobile"}
+ orientation={isDesktop ? "horizontal" : "vertical"}
+ >
+ <ResizablePanel
+ defaultSize={isDesktop ? "28%" : "32%"}
+ minSize={isDesktop ? "20%" : "24%"}
+ maxSize={isDesktop ? "42%" : "50%"}
+ >
+ <SkillFileExplorer
+ store={store}
+ readOnly={!isDraft || !canCreate}
+ disabled={isSaving}
+ state={treeState}
+ onStateChange={setTreeState}
+ onUpload={() => setIsUploadOpen(true)}
+ />
+ </ResizablePanel>
+ <ResizableHandle withHandle />
+ <ResizablePanel
+ defaultSize={isDesktop ? "72%" : "68%"}
+ minSize={isDesktop ? "45%" : "42%"}
+ >
+ <SkillFileEditor
+ projectId={projectId}
+ store={store}
+ isDraft={isDraft}
+ editable={canEditFiles}
+ />
+ </ResizablePanel>
+ </ResizablePanelGroup>
+ </Tabs.Content>
+ </Tabs>
</div>
</div>
</div>
diff --git a/web/src/features/skills/components/SkillEditorPage.tsx b/web/src/features/skills/components/SkillEditorPage.tsx
index d86bec8f8f..045c313a32 100644
--- a/web/src/features/skills/components/SkillEditorPage.tsx
+++ b/web/src/features/skills/components/SkillEditorPage.tsx
@@ -285,7 +285,19 @@ function ExistingSkillSession({
onSelect: async (selectedVersion) => {
await router.push({
pathname: router.pathname,
- query: { projectId, skillName, version: selectedVersion },
+ query: {
+ projectId,
+ skillName,
+ version: selectedVersion,
+ ...(router.query.tab === "linked-traces"
+ ? {
+ tab: "linked-traces",
+ ...(router.query.dateRange
+ ? { dateRange: router.query.dateRange }
+ : {}),
+ }
+ : {}),
+ },
});
},
}}
diff --git a/web/src/features/skills/components/SkillLinkedTraces.tsx b/web/src/features/skills/components/SkillLinkedTraces.tsx
new file mode 100644
index 0000000000..c81672ce52
--- /dev/null
+++ b/web/src/features/skills/components/SkillLinkedTraces.tsx
@@ -0,0 +1,27 @@
+import EventsTable from "@/src/features/events/components/EventsTable";
+import { TableHeaderControls } from "@/src/components/table/table-header-controls";
+import { useTableDateRange } from "@/src/hooks/useTableDateRange";
+
+export function SkillLinkedTraces({
+ projectId,
+ name,
+ version,
+}: {
+ projectId: string;
+ name: string;
+ version?: number;
+}) {
+ const { timeRange, setTimeRange } = useTableDateRange(projectId);
+
+ return (
+ <div className="flex min-h-0 flex-1 flex-col overflow-hidden">
+ <TableHeaderControls timeRange={timeRange} setTimeRange={setTimeRange} />
+ <EventsTable
+ projectId={projectId}
+ skill={{ name, version }}
+ isolateTableState
+ hideControls
+ />
+ </div>
+ );
+}