🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(shared): keep trace latency NULL when no observation has an end time (#18330)
Niklas Semmler8ff3c768e294
diff --git a/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.ts b/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.tsindex 29f1528d68..d12d033ca5 100644--- a/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.ts+++ b/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.ts@@ -548,7 +548,7 @@ const EVENTS_AGGREGATION_FIELDS = {updated_at: "max(updated_at) AS updated_at",total_cost: "sum(total_cost) AS total_cost",latency_milliseconds:- "date_diff('millisecond', min(start_time), greatest(max(start_time), max(end_time))) AS latency_milliseconds",+ "if(max(end_time) IS NULL, NULL, date_diff('millisecond', min(start_time), greatest(max(start_time), max(end_time)))) AS latency_milliseconds",observation_ids:"groupUniqArrayIf(span_id, span_id <> '') AS observation_ids",observation_count:diff --git a/packages/shared/src/server/repositories/traces.ts b/packages/shared/src/server/repositories/traces.tsindex 0012a164d6..0fae71f747 100644--- a/packages/shared/src/server/repositories/traces.ts+++ b/packages/shared/src/server/repositories/traces.ts@@ -1292,7 +1292,7 @@ export const getTracesForAnalyticsIntegrations = async function* (o.trace_id,sum(total_cost) as total_cost,count(*) as observation_count,- date_diff('millisecond', least(min(start_time), min(end_time)), greatest(max(start_time), max(end_time))) as latency_milliseconds+ if(min(end_time) IS NULL, NULL, date_diff('millisecond', least(min(start_time), min(end_time)), greatest(max(start_time), max(end_time)))) as latency_millisecondsFROM observations o FINALWHERE o.project_id = {projectId: String}AND o.start_time >= {minTimestamp: DateTime64(3)} - ${TRACE_TO_OBSERVATIONS_INTERVAL}@@ -1660,7 +1660,7 @@ async function buildTracesBaseQuery(SELECTtrace_id,project_id,- ${includeMetricsInCTE ? "sum(total_cost) as total_cost, date_diff('millisecond', least(min(start_time), min(end_time)), greatest(max(start_time), max(end_time))) as latency_milliseconds, " : ""}+ ${includeMetricsInCTE ? "sum(total_cost) as total_cost, if(min(end_time) IS NULL, NULL, date_diff('millisecond', least(min(start_time), min(end_time)), greatest(max(start_time), max(end_time)))) as latency_milliseconds, " : ""}sumMap(usage_details) as usage_details,sumMap(cost_details) as cost_details,multiIf(arrayExists(x -> x = 'ERROR', groupArray(level)), 'ERROR', arrayExists(x -> x = 'WARNING', groupArray(level)), 'WARNING', arrayExists(x -> x = 'DEFAULT', groupArray(level)), 'DEFAULT', 'DEBUG') AS aggregated_level,diff --git a/packages/shared/src/server/services/traces-ui-table-service.ts b/packages/shared/src/server/services/traces-ui-table-service.tsindex 8954a59a05..e9a975e78f 100644--- a/packages/shared/src/server/services/traces-ui-table-service.ts+++ b/packages/shared/src/server/services/traces-ui-table-service.ts@@ -311,7 +311,7 @@ async function getTracesTableGeneric(props: FetchTracesTableProps) {COUNT(*) AS observation_count,sumMap(usage_details) as usage_details,SUM(total_cost) AS total_cost,- date_diff('millisecond', least(min(start_time), min(end_time)), greatest(max(start_time), max(end_time))) as latency_milliseconds,+ if(min(end_time) IS NULL, NULL, date_diff('millisecond', least(min(start_time), min(end_time)), greatest(max(start_time), max(end_time)))) as latency_milliseconds,countIf(level = 'ERROR') as error_count,countIf(level = 'WARNING') as warning_count,countIf(level = 'DEFAULT') as default_count,diff --git a/web/src/__tests__/server/traces-trpc.servertest.ts b/web/src/__tests__/server/traces-trpc.servertest.tsindex a5886d61d5..d429a619aa 100644--- a/web/src/__tests__/server/traces-trpc.servertest.ts+++ b/web/src/__tests__/server/traces-trpc.servertest.ts@@ -876,6 +876,32 @@ describe("traces trpc", () => {});describe("traces.metrics", () => {+ it("should not derive latency from start times when no observation has an end time", async () => {+ const trace = createTrace({ project_id: projectId });+ const startTime = Date.now();+ const observations = [0, 5_000].map((offset) =>+ createObservation({+ project_id: projectId,+ trace_id: trace.id,+ type: "EVENT",+ start_time: startTime + offset,+ end_time: null,+ }),+ );++ await createTracesCh([trace]);+ await createObservationsCh(observations);++ const metrics = await caller.traces.metrics({+ projectId,+ traceIds: [trace.id],+ filter: [],+ });++ expect(metrics).toHaveLength(1);+ expect(metrics[0]?.latency).toBe(0);+ });+it("should aggregate observation-only scores onto the trace row", async () => {const trace = createTrace({project_id: projectId,