🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(traces): use the tags of all observations for events-based traces (#18864)
Max Azatian91f9e223c19f
diff --git a/packages/shared/src/server/query-ast/extensions.ts b/packages/shared/src/server/query-ast/extensions.tsindex 89b1529d23..4669e6ba9c 100644--- a/packages/shared/src/server/query-ast/extensions.ts+++ b/packages/shared/src/server/query-ast/extensions.ts@@ -402,6 +402,11 @@ export function arrayLength(return functionCall("length", [array]);}+/** ClickHouse `arraySort(array)`: the elements in ascending order. */+export function arraySort<T>(array: Expression<T[]>): ChExpression<T[]> {+ return functionCall("arraySort", [array]);+}+/** ClickHouse `notEmpty(array)`. */export function notEmpty(array: Expression<unknown[]>): ChExpression<SqlBool> {return functionCall("notEmpty", [array]);diff --git a/packages/shared/src/server/repositories/__snapshots__/events.golden.test.ts.snap b/packages/shared/src/server/repositories/__snapshots__/events.golden.test.ts.snapindex d63ab8d6f8..64eeae3182 100644--- a/packages/shared/src/server/repositories/__snapshots__/events.golden.test.ts.snap+++ b/packages/shared/src/server/repositories/__snapshots__/events.golden.test.ts.snap@@ -2469,7 +2469,7 @@ exports[`golden: events point-reads & existence family > getTraceByIdFromEventsTcountIf(e.level = 'ERROR') AS error_count,countIf(e.level = 'DEFAULT') AS default_count,countIf(e.level = 'DEBUG') AS debug_count,- argMaxIf(e.tags, e.event_ts, notEmpty(e.tags)) AS tags,+ arraySort(groupUniqArrayArrayIf(e.tags, notEmpty(e.tags))) AS tags,argMaxIf(e.release, e.event_ts, e.release != '') AS release,argMaxIf(e.evaluator_id, e.event_ts, e.evaluator_id != '') AS evaluator_id,argMaxIf(e.evaluation_rule_id, e.event_ts, e.evaluation_rule_id != '') AS evaluation_rule_id,@@ -2574,7 +2574,7 @@ exports[`golden: events point-reads & existence family > getTraceByIdFromEventsTcountIf(e.level = 'ERROR') AS error_count,countIf(e.level = 'DEFAULT') AS default_count,countIf(e.level = 'DEBUG') AS debug_count,- argMaxIf(e.tags, e.event_ts, notEmpty(e.tags)) AS tags,+ arraySort(groupUniqArrayArrayIf(e.tags, notEmpty(e.tags))) AS tags,argMaxIf(e.release, e.event_ts, e.release != '') AS release,argMaxIf(e.evaluator_id, e.event_ts, e.evaluator_id != '') AS evaluator_id,argMaxIf(e.evaluation_rule_id, e.event_ts, e.evaluation_rule_id != '') AS evaluation_rule_id,@@ -2681,7 +2681,7 @@ exports[`golden: events point-reads & existence family > getTraceByIdFromEventsTcountIf(e.level = 'ERROR') AS error_count,countIf(e.level = 'DEFAULT') AS default_count,countIf(e.level = 'DEBUG') AS debug_count,- argMaxIf(e.tags, e.event_ts, notEmpty(e.tags)) AS tags,+ arraySort(groupUniqArrayArrayIf(e.tags, notEmpty(e.tags))) AS tags,argMaxIf(e.release, e.event_ts, e.release != '') AS release,argMaxIf(e.evaluator_id, e.event_ts, e.evaluator_id != '') AS evaluator_id,argMaxIf(e.evaluation_rule_id, e.event_ts, e.evaluation_rule_id != '') AS evaluation_rule_id,@@ -2788,7 +2788,7 @@ exports[`golden: events point-reads & existence family > getTraceByIdFromEventsTcountIf(e.level = 'ERROR') AS error_count,countIf(e.level = 'DEFAULT') AS default_count,countIf(e.level = 'DEBUG') AS debug_count,- argMaxIf(e.tags, e.event_ts, notEmpty(e.tags)) AS tags,+ arraySort(groupUniqArrayArrayIf(e.tags, notEmpty(e.tags))) AS tags,argMaxIf(e.release, e.event_ts, e.release != '') AS release,argMaxIf(e.evaluator_id, e.event_ts, e.evaluator_id != '') AS evaluator_id,argMaxIf(e.evaluation_rule_id, e.event_ts, e.evaluation_rule_id != '') AS evaluation_rule_id,@@ -3610,7 +3610,7 @@ exports[`golden: events trace aggregation family > getTracesFromEventsTableForPucountIf(e.level = 'ERROR') AS error_count,countIf(e.level = 'DEFAULT') AS default_count,countIf(e.level = 'DEBUG') AS debug_count,- argMaxIf(e.tags, e.event_ts, notEmpty(e.tags)) AS tags,+ arraySort(groupUniqArrayArrayIf(e.tags, notEmpty(e.tags))) AS tags,argMaxIf(e.release, e.event_ts, e.release != '') AS release,argMaxIf(e.evaluator_id, e.event_ts, e.evaluator_id != '') AS evaluator_id,argMaxIf(e.evaluation_rule_id, e.event_ts, e.evaluation_rule_id != '') AS evaluation_rule_id,@@ -3733,7 +3733,7 @@ exports[`golden: events trace aggregation family > getTracesFromEventsTableForPucountIf(e.level = 'ERROR') AS error_count,countIf(e.level = 'DEFAULT') AS default_count,countIf(e.level = 'DEBUG') AS debug_count,- argMaxIf(e.tags, e.event_ts, notEmpty(e.tags)) AS tags,+ arraySort(groupUniqArrayArrayIf(e.tags, notEmpty(e.tags))) AS tags,argMaxIf(e.release, e.event_ts, e.release != '') AS release,argMaxIf(e.evaluator_id, e.event_ts, e.evaluator_id != '') AS evaluator_id,argMaxIf(e.evaluation_rule_id, e.event_ts, e.evaluation_rule_id != '') AS evaluation_rule_id,diff --git a/packages/shared/src/server/repositories/events-selects.ts b/packages/shared/src/server/repositories/events-selects.tsindex 3927f90d48..f8ad115d69 100644--- a/packages/shared/src/server/repositories/events-selects.ts+++ b/packages/shared/src/server/repositories/events-selects.ts@@ -15,6 +15,7 @@ import {anyValue,arrayExists,arrayLength,+ arraySort,concat,countIf,dateDiff,@@ -338,10 +339,8 @@ function traceAggregationSelectMap(eb: EventsExpressionBuilder) {error_count: countLevel(eb, "ERROR").as("error_count"),default_count: countLevel(eb, "DEFAULT").as("default_count"),debug_count: countLevel(eb, "DEBUG").as("debug_count"),- tags: argMaxIf(- eb.ref("e.tags"),- eb.ref("e.event_ts"),- notEmpty(eb.ref("e.tags")),+ tags: arraySort(+ groupUniqArrayArrayIf(eb.ref("e.tags"), notEmpty(eb.ref("e.tags"))),).as("tags"),release: latestNonEmptyOf(eb, "e.release").as("release"),// Evaluator execution fields are stamped on every internal evaluation span.diff --git a/packages/shared/src/server/services/__snapshots__/sessions-ui-table-events-service.golden.test.ts.snap b/packages/shared/src/server/services/__snapshots__/sessions-ui-table-events-service.golden.test.ts.snapindex ce34f5b43a..46716c3e94 100644--- a/packages/shared/src/server/services/__snapshots__/sessions-ui-table-events-service.golden.test.ts.snap+++ b/packages/shared/src/server/services/__snapshots__/sessions-ui-table-events-service.golden.test.ts.snap@@ -58,7 +58,7 @@ exports[`golden: sessions simple aggregates family > getSessionTracesFromEventscountIf(e.level = 'ERROR') AS error_count,countIf(e.level = 'DEFAULT') AS default_count,countIf(e.level = 'DEBUG') AS debug_count,- argMaxIf(e.tags, e.event_ts, notEmpty(e.tags)) AS tags,+ arraySort(groupUniqArrayArrayIf(e.tags, notEmpty(e.tags))) AS tags,argMaxIf(e.release, e.event_ts, e.release != '') AS release,argMaxIf(e.evaluator_id, e.event_ts, e.evaluator_id != '') AS evaluator_id,argMaxIf(e.evaluation_rule_id, e.event_ts, e.evaluation_rule_id != '') AS evaluation_rule_id,diff --git a/web/src/__tests__/server/repositories/event-repository.servertest.ts b/web/src/__tests__/server/repositories/event-repository.servertest.tsindex d6a304cdfc..be62da2c11 100644--- a/web/src/__tests__/server/repositories/event-repository.servertest.ts+++ b/web/src/__tests__/server/repositories/event-repository.servertest.ts@@ -13,6 +13,7 @@ import {getObservationsCountFromEventsTableForPublicApi,updateEvents,getTraceByIdFromEventsTable,+ getTracesFromEventsTableForPublicApi,getObservationsBatchIOFromEventsTable,getLatestSdkVersionInfoFromEvents,getTracesIdentifierForSessionFromEvents,@@ -4741,6 +4742,42 @@ describe("Clickhouse Events Repository Test", () => {});});+ maybe("Trace tags", () => {+ it("should return the tags of all observations, not only the latest", async () => {+ const traceId = randomUUID();+ const sharedTag = `shared-${traceId}`;+ const middleTag = `middle-${traceId}`;+ const start = new Date("2026-01-01T00:00:00.000Z").getTime();++ await createEventsCh(+ [[sharedTag], [sharedTag, middleTag], [sharedTag]].map((tags, i) => {+ const id = randomUUID();+ const timestamp = new Date(start + i * 1000);+ return createEvent({+ id,+ span_id: id,+ project_id: projectId,+ trace_id: traceId,+ tags,+ start_time: timestamp,+ event_ts: timestamp,+ });+ }),+ );++ const trace = await getTraceByIdFromEventsTable({ projectId, traceId });+ expect(trace?.tags).toEqual([middleTag, sharedTag]);++ const traces = await getTracesFromEventsTableForPublicApi({+ projectId,+ page: 1,+ limit: 10,+ tags: middleTag,+ });+ expect(traces.map((t) => t.id)).toEqual([traceId]);+ });+ });+maybe("Update methods", () => {it("should allow to set/unset bookmarked", async () => {const traceId = randomUUID();