🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): observation Attributes tab (#17540)
Trang Nguyen935bf114a332
diff --git a/web/src/components/table/ValueCell.tsx b/web/src/components/table/ValueCell.tsxindex 50e0dd4bb1..a11144c597 100644--- a/web/src/components/table/ValueCell.tsx+++ b/web/src/components/table/ValueCell.tsx@@ -184,7 +184,7 @@ function getTruncatedValue(value: string, maxChars: number): string {return truncated + "...";}-function getCopyValue(value: unknown): string {+export function getCopyValue(value: unknown): string {if (typeof value === "string") {return value; // Return string without quotes}@@ -350,12 +350,15 @@ export const ValueCell = memo(toggleCellExpansion,preserveStringWhitespace = false,metadataActions,+ rowActions,}: {row: Row<JsonTableRow>;expandedCells: Set<string>;toggleCellExpansion: (cellId: string) => void;preserveStringWhitespace?: boolean;metadataActions?: MetadataFilterActions;+ /** Replaces the built-in menu, for tables with their own row actions. */+ rowActions?: (row: Row<JsonTableRow>) => React.ReactNode;}) => {const { value, type } = row.original;const cellId = `${row.id}-value`;@@ -524,16 +527,20 @@ export const ValueCell = memo({/* Hover affordance: a one-click copy by default, or an actions menu(copy + filter shortcuts) in metadata views. */}- {metadataActions ? (+ {rowActions || metadataActions ? (<DropdownMenuControlleralign="end"maxWidth="320px"- renderMenu={() => (- <ValueCellActionsMenuContent- row={row}- metadataActions={metadataActions}- />- )}+ renderMenu={() =>+ rowActions ? (+ rowActions(row)+ ) : metadataActions ? (+ <ValueCellActionsMenuContent+ row={row}+ metadataActions={metadataActions}+ />+ ) : null+ }>{({ isOpen, Trigger }) => (<Trigger asChild>diff --git a/web/src/components/ui/PrettyJsonView.tsx b/web/src/components/ui/PrettyJsonView.tsxindex 7564af935c..849519784e 100644--- a/web/src/components/ui/PrettyJsonView.tsx+++ b/web/src/components/ui/PrettyJsonView.tsx@@ -423,7 +423,9 @@ function JsonPrettyTable({stickyTopLevelKey = false,showObservationTypeBadge = false,metadataActions,+ rowActions,toneClasses,+ showHeader = true,}: {data: JsonTableRow[];expandAllRef?: React.RefObject<(() => void) | null>;@@ -441,7 +443,10 @@ function JsonPrettyTable({stickyTopLevelKey?: boolean;showObservationTypeBadge?: boolean;metadataActions?: MetadataFilterActions;+ rowActions?: (row: Row<JsonTableRow>) => React.ReactNode;toneClasses?: (typeof PRETTY_JSON_VIEW_TONE_CLASSES)[PrettyJsonViewTone];+ /** Drop the Path / Value header row. */+ showHeader?: boolean;}) {const headerRef = useRef<HTMLTableRowElement>(null);const topLevelRowRef = useRef<HTMLTableRowElement>(null);@@ -571,6 +576,7 @@ function JsonPrettyTable({row.original.key === "code_eval_source_code"}metadataActions={metadataActions}+ rowActions={rowActions}/>),},@@ -690,7 +696,7 @@ function JsonPrettyTable({return (<div className={cn("w-full", !noBorder && "rounded-sm border")}><table className="w-full table-fixed caption-bottom border-separate border-spacing-0 space-y-4 overflow-auto text-sm">- <thead className="[&_tr]:border-b">+ <thead className={cn("[&_tr]:border-b", !showHeader && "hidden")}>{table.getHeaderGroups().map((headerGroup, index) => (<trkey={headerGroup.id}@@ -752,6 +758,8 @@ export function PrettyJsonView(props: {parsedJson?: unknown; // Pre-parsed data (optional, from useParsedObservation hook)title?: string;titleIcon?: React.ReactNode;+ /** Drop the Path / Value header row. */+ showHeader?: boolean;className?: string;isLoading?: boolean;isParsing?: boolean;@@ -778,6 +786,8 @@ export function PrettyJsonView(props: {/** When set, rows show an actions menu with copy + add-to-filter shortcuts(metadata views only). */metadataActions?: MetadataFilterActions;+ /** Replaces the built-in row menu, for tables with their own actions. */+ rowActions?: (row: Row<JsonTableRow>) => React.ReactNode;/** Collapse long string content to a preview (from raw `role === "system"`,since the title can carry a message `name` instead of the role). */isSystemPrompt?: boolean;@@ -1344,7 +1354,9 @@ export function PrettyJsonView(props: {stickyTopLevelKey={props.stickyTopLevelKey}showObservationTypeBadge={props.showObservationTypeBadge}metadataActions={props.metadataActions}+ rowActions={props.rowActions}toneClasses={toneClasses}+ showHeader={props.showHeader}/>)}</div>diff --git a/web/src/features/events/lib/eventsTablePaths.ts b/web/src/features/events/lib/eventsTablePaths.tsindex 6a5b7dce69..e69e359065 100644--- a/web/src/features/events/lib/eventsTablePaths.ts+++ b/web/src/features/events/lib/eventsTablePaths.ts@@ -1,7 +1,10 @@import {type FilterState,+ TABLE_AGGREGATION_OPTIONS,+ TIME_RANGES,decodeFiltersGeneric,encodeFiltersGeneric,+ rangeToString,} from "@langfuse/shared";type BuildEventsTablePathForSpanNameParams = {@@ -77,6 +80,75 @@ export function buildEventsTablePathForObservationType({});}+/** Smallest preset window still containing `time`, else an absolute day. */+function dateRangeCovering(time: Date, now = new Date()): string {+ const ageMinutes = (now.getTime() - time.getTime()) / 60_000;+ for (const option of TABLE_AGGREGATION_OPTIONS) {+ const minutes = TIME_RANGES[option].minutes;+ // Presets reach back from now, so a future timestamp must not match.+ if (minutes != null && ageMinutes >= 0 && ageMinutes < minutes * 0.9) {+ return rangeToString({ range: option });+ }+ }+ const dayMs = 24 * 60 * 60_000;+ return rangeToString({+ from: new Date(time.getTime() - dayMs),+ to: new Date(+ Math.max(time.getTime(), Math.min(now.getTime(), time.getTime() + dayMs)),+ ),+ });+}++function rangeCovers(encoded: string, time: Date, now = new Date()): boolean {+ const preset = Object.values(TIME_RANGES).find(+ (def) => def.abbreviation === encoded,+ );+ if (preset?.minutes != null) {+ const age = now.getTime() - time.getTime();+ return age >= 0 && age < preset.minutes * 60_000;+ }+ const [from, to] = encoded.split("-").map(Number);+ if (Number.isFinite(from) && Number.isFinite(to)) {+ return time.getTime() >= from && time.getTime() <= to;+ }+ return false;+}++export function buildEventsTablePathForColumnFilter({+ currentPath,+ projectId,+ target,+ filter,+ coverTime,+}: {+ currentPath: string;+ projectId: string;+ target: "observations" | "traces";+ filter: FilterState[number];+ /** A time the window must include. */+ coverTime?: Date;+}) {+ const url = new URL(currentPath, "https://langfuse.local");+ const params = new URLSearchParams();++ const dateRange = url.searchParams.get("dateRange");+ if (coverTime && !(dateRange && rangeCovers(dateRange, coverTime))) {+ params.set("dateRange", dateRangeCovering(coverTime));+ } else if (dateRange) {+ params.set("dateRange", dateRange);+ }++ const existingFilters = decodeFiltersGeneric(+ url.searchParams.get("filter") ?? "",+ ).filter((f) => f.column !== filter.column);++ params.set("filter", encodeFiltersGeneric([...existingFilters, filter]));++ const query = params.toString();++ return `/project/${projectId}/${target}${query ? `?${query}` : ""}`;+}+export type MetadataFilterOperator = "=" | "contains" | "does not contain";type BuildEventsTablePathForMetadataFilterParams = {diff --git a/web/src/features/traces/components/IOPreview/IOPreview.tsx b/web/src/features/traces/components/IOPreview/IOPreview.tsxindex eac079b4d4..540d39b110 100644--- a/web/src/features/traces/components/IOPreview/IOPreview.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreview.tsx@@ -255,6 +255,7 @@ export function IOPreview({*/}{selectedView === "json-beta" ? (<IOPreviewJSON+ hideMetadata={!showMetadata}input={input}output={output}status={status}@@ -282,6 +283,7 @@ export function IOPreview({/>) : selectedView === "json" ? (<IOPreviewJSONSimple+ hideMetadata={!showMetadata}input={input}output={output}status={status}diff --git a/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx b/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsxindex d4e32a3d8d..dee4a3819c 100644--- a/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx@@ -86,6 +86,7 @@ export interface IOPreviewJSONProps {hideIfNull?: boolean;hideOutput?: boolean;hideInput?: boolean;+ hideMetadata?: boolean;// Media attachmentsmedia?: MediaReturnType[];// Callback to inform parent if virtualization is being used (for scroll handling)@@ -131,6 +132,7 @@ function IOPreviewJSONInner({hideIfNull = false,hideOutput = false,hideInput = false,+ hideMetadata = false,media,onVirtualizationChange,enableInlineComments = false,@@ -278,7 +280,8 @@ function IOPreviewJSONInner({!hideOutput &&(outputTooLarge || !(hideIfNull && effectiveOutput === undefined));const showMetadata =- metadataTooLarge || !(hideIfNull && effectiveMetadata === undefined);+ !hideMetadata &&+ (metadataTooLarge || !(hideIfNull && effectiveMetadata === undefined));const downloadName = observationId ?? traceId;diff --git a/web/src/features/traces/components/IOPreview/IOPreviewJSONSimple.tsx b/web/src/features/traces/components/IOPreview/IOPreviewJSONSimple.tsxindex 06136435b1..b382d3435e 100644--- a/web/src/features/traces/components/IOPreview/IOPreviewJSONSimple.tsx+++ b/web/src/features/traces/components/IOPreview/IOPreviewJSONSimple.tsx@@ -27,6 +27,7 @@ export interface IOPreviewJSONSimpleProps {media?: MediaReturnType[];hideOutput?: boolean;hideInput?: boolean;+ hideMetadata?: boolean;observationId?: string;projectId: string;traceId: string;@@ -70,6 +71,7 @@ export function IOPreviewJSONSimple({hideIfNull = false,hideOutput = false,hideInput = false,+ hideMetadata = false,media,inputExpanded,outputExpanded,@@ -127,7 +129,8 @@ export function IOPreviewJSONSimple({!hideInput && (inputTooLarge || !(hideIfNull && !effectiveInput));const showOutput =!hideOutput && (outputTooLarge || !(hideIfNull && !effectiveOutput));- const showMetadata = metadataTooLarge || !(hideIfNull && !effectiveMetadata);+ const showMetadata =+ !hideMetadata && (metadataTooLarge || !(hideIfNull && !effectiveMetadata));const downloadName = observationId ?? traceId;diff --git a/web/src/features/traces/components/ObservationDetailView/AttributeRowActions.tsx b/web/src/features/traces/components/ObservationDetailView/AttributeRowActions.tsxnew file mode 100644index 0000000000..f1490e0436--- /dev/null+++ b/web/src/features/traces/components/ObservationDetailView/AttributeRowActions.tsx@@ -0,0 +1,125 @@+/** Row menu for the Attributes table: copy, then include / exclude via the+ * attribute's own table column. */++import { useRouter } from "next/router";+import { Copy, Filter, FilterX } from "lucide-react";+import { type Row } from "@tanstack/react-table";+import { type FilterState } from "@langfuse/shared";++import {+ DropdownMenuItem,+ DropdownMenuSeparator,+} from "@/src/components/ui/dropdown-menu";+import { getCopyValue } from "@/src/components/table/ValueCell";+import { type JsonTableRow } from "@/src/components/table/utils/jsonExpansionUtils";+import { copyTextToClipboard } from "@/src/utils/clipboard";+import { buildEventsTablePathForColumnFilter } from "@/src/features/events/lib/eventsTablePaths";+import { attributeColumnFilter } from "@/src/features/traces/fns/attributeColumnFilter";+import { attributeGrammar } from "@/src/features/traces/fns/attributeGrammar";+import { usePostHogClientCapture } from "@/src/features/posthog-analytics/usePostHogClientCapture";++export type AttributeTableAction = "copy" | "include_filter" | "exclude_filter";++export function AttributeRowActions({+ row,+ projectId,+ filterTarget,+ anchorTime,+ analyticsTable,+}: {+ row: Row<JsonTableRow>;+ projectId: string;+ filterTarget: "observations" | "traces";+ /** Keeps the target table's window covering the source row. */+ anchorTime?: Date | null;+ analyticsTable: "attributes" | "metadata";+}) {+ const router = useRouter();+ const capture = usePostHogClientCapture();+ const { key, value, hasChildren } = row.original;+ const valueText = String(value);+ const filter =+ hasChildren || key == null+ ? null+ : attributeColumnFilter(key, valueText, filterTarget);+ const includeText = filter ? attributeGrammar(key ?? "", valueText) : null;+ const excludeClause = filter?.exclude;++ const track = (action: AttributeTableAction) =>+ capture("trace_detail:attribute_table_action", {+ table: analyticsTable,+ action,+ });++ const navigate = (+ clause: FilterState[number],+ target: "observations" | "traces",+ ) =>+ router.push(+ buildEventsTablePathForColumnFilter({+ currentPath: router.asPath,+ projectId,+ target,+ filter: clause,+ coverTime: anchorTime ?? undefined,+ }),+ );++ return (+ <>+ <DropdownMenuItem+ className="text-xs"+ onSelect={() => {+ track("copy");+ copyTextToClipboard(getCopyValue(value));+ }}+ >+ <Copy className="mr-2 h-3.5 w-3.5 shrink-0" />+ {hasChildren ? "Copy structure" : "Copy value"}+ </DropdownMenuItem>+ {filter && includeText ? (+ <>+ <DropdownMenuSeparator />+ <DropdownMenuItem+ className="text-xs"+ onSelect={() => {+ track("include_filter");+ navigate(filter.include, filter.target);+ }}+ >+ <Filter className="mr-2 h-3.5 w-3.5 shrink-0" />+ <span className="flex min-w-0 flex-col">+ <span>Include in filter</span>+ <span+ className="text-muted-foreground truncate font-mono"+ title={includeText}+ >+ {includeText}+ </span>+ </span>+ </DropdownMenuItem>+ {excludeClause ? (+ <DropdownMenuItem+ className="text-xs"+ onSelect={() => {+ track("exclude_filter");+ navigate(excludeClause, filter.target);+ }}+ >+ <FilterX className="mr-2 h-3.5 w-3.5 shrink-0" />+ <span className="flex min-w-0 flex-col">+ <span>Exclude from filter</span>+ <span+ className="text-muted-foreground truncate font-mono"+ title={`-${includeText}`}+ >+ -{includeText}+ </span>+ </span>+ </DropdownMenuItem>+ ) : null}+ </>+ ) : null}+ </>+ );+}diff --git a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsxindex 6a3718403e..d0f1748b20 100644--- a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx+++ b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx@@ -48,7 +48,10 @@ import ScoresTable from "@/src/components/table/use-cases/scores";import { getMostRecentCorrection } from "@/src/features/corrections/utils/getMostRecentCorrection";import { useJsonExpansion } from "@/src/features/traces/contexts/JsonExpansionContext";import { useMedia } from "@/src/features/traces/hooks/useMedia";-import { useSelection } from "@/src/features/traces/contexts/SelectionContext";+import {+ type DetailTab,+ useSelection,+} from "@/src/features/traces/contexts/SelectionContext";import { usePostHogClientCapture } from "@/src/features/posthog-analytics/usePostHogClientCapture";import { useTraceAnalyticsDimensions } from "@/src/features/traces/hooks/useTraceAnalyticsDimensions";import { useViewPreferences } from "@/src/features/traces/contexts/ViewPreferencesContext";@@ -71,6 +74,9 @@ import {import { useHasProjectAccess } from "@/src/features/rbac";import { useSession } from "next-auth/react";import { ObservationPreview } from "./ObservationPreview";+import { ObservationAttributesTab } from "./ObservationAttributesTab";+import { buildModelParameters } from "@/src/features/traces/fns/buildModelParameters";+import { buildObservationAttributes } from "@/src/features/traces/fns/buildObservationAttributes";export interface ConnectedObservationDetailViewProps {observation: ObservationReturnTypeWithMetadata;@@ -119,9 +125,15 @@ export function ConnectedObservationDetailView({const showLogViewTab =isV4Enabled && observations.length > 0 && !isAnnotationMode;const showScoresTab = !isAnnotationMode;-- // Hide entire tabs bar when only Preview tab remains (cleaner annotation mode UI)- const showTabsBar = showLogViewTab || showScoresTab;+ const attributes = buildObservationAttributes({+ model: observation.model,+ environment: observation.environment,+ release: observation.release,+ version: observation.version,+ sessionId: observation.sessionId,+ userId: observation.userId,+ });+ const modelParameters = buildModelParameters(observation.modelParameters);// for v4:// is this observation topmost in tree? we don't check for root observation here as this is not necessarily given.@@ -159,10 +171,10 @@ export function ConnectedObservationDetailView({return aggregateTraceMetrics(allObservations);}, [isRoot, treeNode, observations, observation]);- // Map global tab to observation-specific tabs (preview, log, scores)- // "log" tab only available in v4 mode when there are observations+ // "log" is v4-only and needs observations; everything else falls back to preview.const selectedTab = useMemo(() => {if (globalSelectedTab === "scores") return "scores" as const;+ if (globalSelectedTab === "attributes") return "attributes" as const;if (globalSelectedTab === "log" && showLogViewTab) return "log" as const;return "preview" as const;}, [globalSelectedTab, showLogViewTab]);@@ -178,7 +190,7 @@ export function ConnectedObservationDetailView({});}, [projectId, traceId, utils]);- const setSelectedTab = (tab: "preview" | "log" | "scores") => {+ const setSelectedTab = (tab: DetailTab) => {if (tab === "scores") {refreshTraceScores();}@@ -359,117 +371,110 @@ export function ConnectedObservationDetailView({<TabsBarvalue={selectedTab}className="flex min-h-0 flex-1 flex-col overflow-hidden"- onValueChange={(value) =>- setSelectedTab(value as "preview" | "log" | "scores")- }+ onValueChange={(value) => setSelectedTab(value as DetailTab)}>- {showTabsBar && (- <TooltipProvider>- <TabsBarList>- <TabsBarTrigger value="preview">Preview</TabsBarTrigger>- {showScoresTab ? (- <TabsBarTrigger value="scores">Scores</TabsBarTrigger>- ) : null}- {showLogViewTab ? (- <TabsBarTrigger value="log">- <Tooltip>- <TooltipTrigger asChild>- <span>Log View</span>- </TooltipTrigger>- <TooltipContent className="text-xs">- {isLogViewVirtualized- ? `Shows all ${observations.length} observations with virtualization enabled.`- : "Shows all observations concatenated. Great for quickly scanning through them."}- </TooltipContent>- </Tooltip>- </TabsBarTrigger>- ) : null}-- {(selectedTab === "log" ||- (selectedTab === "preview" && isPrettyViewAvailable)) && (- <>- <div className="ml-auto h-fit px-2 py-0.5">- <Tabs- value={- selectedTab === "log" && isLogViewVirtualized- ? "pretty"- : selectedViewTab+ <TooltipProvider>+ <TabsBarList>+ <TabsBarTrigger value="preview">Preview</TabsBarTrigger>+ <TabsBarTrigger value="attributes">Attributes</TabsBarTrigger>+ {showScoresTab ? (+ <TabsBarTrigger value="scores">Scores</TabsBarTrigger>+ ) : null}+ {showLogViewTab ? (+ <TabsBarTrigger value="log">+ <Tooltip>+ <TooltipTrigger asChild>+ <span>Log View</span>+ </TooltipTrigger>+ <TooltipContent className="text-xs">+ {isLogViewVirtualized+ ? `Shows all ${observations.length} observations with virtualization enabled.`+ : "Shows all observations concatenated. Great for quickly scanning through them."}+ </TooltipContent>+ </Tooltip>+ </TabsBarTrigger>+ ) : null}++ {(selectedTab === "log" ||+ (selectedTab === "preview" && isPrettyViewAvailable)) && (+ <>+ <div className="ml-auto h-fit px-2 py-0.5">+ <Tabs+ value={+ selectedTab === "log" && isLogViewVirtualized+ ? "pretty"+ : selectedViewTab+ }+ onValueChange={(value) => {+ if (+ selectedTab === "log" &&+ isLogViewVirtualized &&+ value === "json"+ ) {+ return;}- onValueChange={(value) => {- if (- selectedTab === "log" &&- isLogViewVirtualized &&- value === "json"- ) {- return;- }- handleViewTabChange(value);- }}- >- <Tabs.List size="sm">- <Tabs.Trigger- value="pretty"- size="sm"- label="Formatted"- />- {selectedTab === "log" && isLogViewVirtualized ? (- <HoverCard openDelay={200}>- <HoverCardTrigger asChild>- <span>- <Tabs.Trigger- value="json"- size="sm"- disabled- label="JSON"- />- </span>- </HoverCardTrigger>- <HoverCardContent- align="end"- className="w-64 text-sm"- sideOffset={8}- >- <p className="font-bold">- JSON view unavailable- </p>- <p className="text-muted-foreground mt-1">- Disabled for traces with{" "}- {- TRACE_VIEW_CONFIG.logView- .virtualizationThreshold- }- + observations to maintain performance.- </p>- </HoverCardContent>- </HoverCard>- ) : (- <Tabs.Trigger- value="json"- size="sm"- label="JSON"- />- )}- </Tabs.List>- </Tabs>- </div>- {selectedViewTab === "json" &&- !(selectedTab === "log" && isLogViewVirtualized) && (- <div className="mr-1 flex items-center gap-1.5">- <Switch- size="sm"- checked={jsonBetaEnabled}- onCheckedChange={handleBetaToggle}- />- <span className="text-muted-foreground text-xs">- Beta- </span>- </div>- )}- </>- )}- </TabsBarList>- </TooltipProvider>- )}+ handleViewTabChange(value);+ }}+ >+ <Tabs.List size="sm">+ <Tabs.Trigger+ value="pretty"+ size="sm"+ label="Formatted"+ />+ {selectedTab === "log" && isLogViewVirtualized ? (+ <HoverCard openDelay={200}>+ <HoverCardTrigger asChild>+ <span>+ <Tabs.Trigger+ value="json"+ size="sm"+ disabled+ label="JSON"+ />+ </span>+ </HoverCardTrigger>+ <HoverCardContent+ align="end"+ className="w-64 text-sm"+ sideOffset={8}+ >+ <p className="font-bold">+ JSON view unavailable+ </p>+ <p className="text-muted-foreground mt-1">+ Disabled for traces with{" "}+ {+ TRACE_VIEW_CONFIG.logView+ .virtualizationThreshold+ }+ + observations to maintain performance.+ </p>+ </HoverCardContent>+ </HoverCard>+ ) : (+ <Tabs.Trigger value="json" size="sm" label="JSON" />+ )}+ </Tabs.List>+ </Tabs>+ </div>+ {selectedViewTab === "json" &&+ !(selectedTab === "log" && isLogViewVirtualized) && (+ <div className="mr-1 flex items-center gap-1.5">+ <Switch+ size="sm"+ checked={jsonBetaEnabled}+ onCheckedChange={handleBetaToggle}+ />+ <span className="text-muted-foreground text-xs">+ Beta+ </span>+ </div>+ )}+ </>+ )}+ </TabsBarList>+ </TooltipProvider><TabsBarContentvalue="preview"@@ -537,7 +542,8 @@ export function ConnectedObservationDetailView({objectStartTime: observation.startTime,}),commentedPathsByField,- showMetadata: true,+ // Metadata lives in the Attributes tab now.+ showMetadata: false,observationId: observation.id,projectId,traceId,@@ -546,6 +552,22 @@ export function ConnectedObservationDetailView({/></TabsBarContent>+ <TabsBarContent+ value="attributes"+ className="mt-0 flex max-h-full min-h-0 w-full flex-1"+ >+ <ObservationAttributesTab+ attributes={attributes}+ attributesAnchorTime={observation.startTime}+ modelParameters={modelParameters}+ metadata={observationWithIOCompat.data?.metadata ?? undefined}+ parsedMetadata={parsedMetadata}+ observationId={observation.id}+ projectId={projectId}+ currentView={selectedViewTab}+ />+ </TabsBarContent>+{showScoresTab ? (<TabsBarContentvalue="scores"diff --git a/web/src/features/traces/components/ObservationDetailView/ObservationAttributesTab.tsx b/web/src/features/traces/components/ObservationDetailView/ObservationAttributesTab.tsxnew file mode 100644index 0000000000..4d763189bf--- /dev/null+++ b/web/src/features/traces/components/ObservationDetailView/ObservationAttributesTab.tsx@@ -0,0 +1,115 @@+/** Attributes, model parameters and metadata as three tables. */++import { useMemo } from "react";++import { PrettyJsonView } from "@/src/components/ui/PrettyJsonView";+import { type MetadataFilterActions } from "@/src/components/table/ValueCell";+import { AttributeRowActions } from "./AttributeRowActions";+import { LargeJsonFieldFallback } from "@/src/features/traces/components/IOPreview/components/LargeJsonFieldFallback";+import {+ JSON_VIEW_RENDER_CHAR_LIMIT,+ probeJsonField,+} from "@/src/features/traces/components/IOPreview/fns/jsonViewSizeGate";++const SECTION_CLASS =+ "[&_.io-message-content]:px-3 [&_.io-message-header]:px-3";++export function ObservationAttributesTab({+ attributes,+ attributesAnchorTime,+ modelParameters,+ metadata,+ parsedMetadata,+ observationId,+ projectId,+ currentView,+}: {+ attributes: Record<string, unknown>;+ attributesAnchorTime: Date;+ modelParameters: Record<string, unknown> | null;+ metadata: unknown;+ /** Avoids re-parsing. */+ parsedMetadata?: unknown;+ observationId: string;+ projectId: string;+ currentView: "pretty" | "json";+}) {+ const metadataActions: MetadataFilterActions = {+ projectId,+ filterTarget: "observations",+ };+ const hasAttributes = Object.keys(attributes).length > 0;+ const hasMetadata =+ metadata !== null &&+ metadata !== undefined &&+ !(typeof metadata === "object" && Object.keys(metadata).length === 0);+ // PrettyJsonView is unvirtualized; oversized payloads get the fallback.+ const metadataProbe = useMemo(() => probeJsonField(metadata), [metadata]);+ const metadataTooLarge = metadataProbe.size > JSON_VIEW_RENDER_CHAR_LIMIT;++ return (+ <div className="flex min-h-0 w-full flex-1 flex-col overflow-auto pb-4">+ <div className="space-y-4 pt-2">+ {hasAttributes ? (+ <div className={SECTION_CLASS}>+ <PrettyJsonView+ title="Attributes"+ showHeader={false}+ json={attributes}+ currentView={currentView}+ rowActions={(row) => (+ <AttributeRowActions+ row={row}+ projectId={projectId}+ filterTarget="observations"+ anchorTime={attributesAnchorTime}+ analyticsTable="attributes"+ />+ )}+ hoverControls+ />+ </div>+ ) : null}+ {modelParameters ? (+ <div className={SECTION_CLASS}>+ <PrettyJsonView+ title="Model parameters"+ showHeader={false}+ json={modelParameters}+ currentView={currentView}+ hoverControls+ />+ </div>+ ) : null}+ {hasMetadata ? (+ <div className={SECTION_CLASS}>+ {metadataTooLarge ? (+ <LargeJsonFieldFallback+ title="Metadata"+ serialized={metadataProbe.serialized}+ isString={metadataProbe.isString}+ charCount={metadataProbe.size}+ downloadFileBase={`metadata-${observationId}`}+ />+ ) : (+ <PrettyJsonView+ title="Metadata"+ showHeader={false}+ json={metadata}+ parsedJson={parsedMetadata}+ currentView={currentView}+ metadataActions={metadataActions}+ hoverControls+ />+ )}+ </div>+ ) : null}+ {!hasAttributes && !modelParameters && !hasMetadata ? (+ <p className="text-muted-foreground px-3 text-sm">+ No attributes, model parameters or metadata on this observation.+ </p>+ ) : null}+ </div>+ </div>+ );+}diff --git a/web/src/features/traces/components/ObservationDetailView/components/ModelParametersBadges.stories.tsx b/web/src/features/traces/components/ObservationDetailView/components/ModelParametersBadges.stories.tsxdeleted file mode 100644index e775ee3c60..0000000000--- a/web/src/features/traces/components/ObservationDetailView/components/ModelParametersBadges.stories.tsx+++ /dev/null@@ -1,23 +0,0 @@-import preview from "../../../../../../.storybook/preview";-import { ModelParametersBadges } from "./ModelParametersBadges";--const meta = preview.meta({- component: ModelParametersBadges,- args: {- modelParameters: {- temperature: 0.7,- maxTokens: 2048,- responseFormat: { type: "json_object" },- },- },-});--export const Default = meta.story({});--export const LongValue = meta.story({- args: {- modelParameters: {- stop: "A long model parameter value that should truncate when space is constrained",- },- },-});diff --git a/web/src/features/traces/components/ObservationDetailView/components/ModelParametersBadges.tsx b/web/src/features/traces/components/ObservationDetailView/components/ModelParametersBadges.tsxdeleted file mode 100644index 62ca02c5f8..0000000000--- a/web/src/features/traces/components/ObservationDetailView/components/ModelParametersBadges.tsx+++ /dev/null@@ -1,47 +0,0 @@-/* eslint-disable @repo/no-null-render */-/**- * Model parameters badges for ObservationDetailView- * Renders dynamic badges for each model parameter with truncation- */--import { type JsonNested } from "@langfuse/shared";-import { Badge } from "@/src/components/design-system/Badge/Badge";--export function ModelParametersBadges({- modelParameters,-}: {- modelParameters: JsonNested | null | undefined;-}) {- // Only render if modelParameters is an object (not array, primitive, or null)- if (- !modelParameters ||- typeof modelParameters !== "object" ||- Array.isArray(modelParameters)- ) {- return null;- }-- const entries = Object.entries(modelParameters).filter(- ([_, value]) => value !== null,- );-- if (entries.length === 0) return null;-- return (- <>- {entries.map(([key, value]) => {- const valueString =- Object.prototype.toString.call(value) === "[object Object]"- ? JSON.stringify(value)- : value?.toString();-- const text = `${key}: ${valueString}`;- return (- <span key={key} className="inline-flex max-w-md">- <Badge text={text} title={text} />- </span>- );- })}- </>- );-}diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsxindex 501499b991..1d66b3699d 100644--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx@@ -35,9 +35,6 @@ import { PromptBadge } from "@/src/features/traces/components/PromptBadge";import {LatencyBadge,TimeToFirstTokenBadge,- EnvironmentBadge,- ReleaseBadge,- VersionBadge,} from "@/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple";import { ObservationLevelBadge } from "@/src/features/traces/components/ObservationLevelBadge";import { EvaluatorBadge } from "@/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge";@@ -47,7 +44,6 @@ import {} from "@/src/features/traces/components/ObservationMetadataBadgesTooltip";import { resolveObservationCostSource } from "@/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/costSource";import { ModelBadge } from "@/src/features/traces/components/ObservationDetailView/components/ModelBadge";-import { ModelParametersBadges } from "@/src/features/traces/components/ObservationDetailView/components/ModelParametersBadges";import {type WithStringifiedMetadata,type MetadataDomainClient,@@ -747,8 +743,6 @@ export const ObservationDetailViewHeader = memo(projectId={projectId}/>)}- <EnvironmentBadge environment={observation.environment} />- <ReleaseBadge release={observation.release} />{displayedTotalCost != null && displayedCostDetails && (<CostBadgetotalCost={displayedTotalCost}@@ -776,7 +770,6 @@ export const ObservationDetailViewHeader = memo(usageDetails={observation.usageDetails}/>)}- <VersionBadge version={observation.version} />{observation.model && (<ModelBadgemodel={observation.model}@@ -785,9 +778,6 @@ export const ObservationDetailViewHeader = memo(usageDetails={observation.usageDetails}/>)}- <ModelParametersBadges- modelParameters={observation.modelParameters}- />{observation.level !== "DEFAULT" && (<ObservationLevelBadgelevel={observation.level}diff --git a/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.clienttest.tsx b/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.clienttest.tsxdeleted file mode 100644index e5257c042f..0000000000--- a/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.clienttest.tsx+++ /dev/null@@ -1,17 +0,0 @@-import { render, screen } from "@testing-library/react";--import { ReleaseBadge } from "./ObservationMetadataBadgesSimple";--describe("ReleaseBadge", () => {- it("shows an observation release", () => {- render(<ReleaseBadge release="181" />);-- expect(screen.getByText("Release: 181")).toBeInTheDocument();- });-- it("hides when no release is available", () => {- const { container } = render(<ReleaseBadge release={null} />);-- expect(container).toBeEmptyDOMElement();- });-});diff --git a/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx b/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsxindex f96134334f..878e19c8aa 100644--- a/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx+++ b/web/src/features/traces/components/ObservationMetadataBadgesSimple/ObservationMetadataBadgesSimple.tsx@@ -30,33 +30,3 @@ export function TimeToFirstTokenBadge({/>);}--export function EnvironmentBadge({- environment,-}: {- environment: string | null | undefined;-}) {- if (!environment) return null;-- return <Badge text={`Env: ${environment}`} />;-}--export function ReleaseBadge({- release,-}: {- release: string | null | undefined;-}) {- if (!release) return null;-- return <Badge text={`Release: ${release}`} />;-}--export function VersionBadge({- version,-}: {- version: string | null | undefined;-}) {- if (!version) return null;-- return <Badge text={`Version: ${version}`} />;-}diff --git a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsxindex 7b8e722aa4..e0fad0d5dd 100644--- a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx+++ b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx@@ -42,7 +42,10 @@ import { useParsedTrace } from "@/src/hooks/useParsedTrace";// Contexts and hooksimport { useTraceData } from "@/src/features/traces/contexts/TraceDataContext";import { useViewPreferences } from "@/src/features/traces/contexts/ViewPreferencesContext";-import { useSelection } from "@/src/features/traces/contexts/SelectionContext";+import {+ type DetailTab,+ useSelection,+} from "@/src/features/traces/contexts/SelectionContext";import { usePostHogClientCapture } from "@/src/features/posthog-analytics/usePostHogClientCapture";import { useTraceAnalyticsDimensions } from "@/src/features/traces/hooks/useTraceAnalyticsDimensions";import { useIsAuthenticatedAndProjectMember } from "@/src/features/auth";@@ -78,7 +81,11 @@ export function TraceDetailView({}: TraceDetailViewProps) {const router = useRouter();// Tab and view state from URL (via SelectionContext)- const { selectedTab, setSelectedTab } = useSelection();+ const { selectedTab: globalSelectedTab, setSelectedTab } = useSelection();+ // `attributes` is observation-only; Radix renders nothing for a value with+ // no Content, which blanks the panel.+ const selectedTab =+ globalSelectedTab === "attributes" ? "preview" : globalSelectedTab;const utils = api.useUtils();const capture = usePostHogClientCapture();const analyticsDimensions = useTraceAnalyticsDimensions();@@ -235,7 +242,7 @@ export function TraceDetailView({...analyticsDimensions,});}- setSelectedTab(value as "preview" | "log" | "scores");+ setSelectedTab(value as DetailTab);};return (diff --git a/web/src/features/traces/contexts/SelectionContext.tsx b/web/src/features/traces/contexts/SelectionContext.tsxindex 73923fa80e..4b04e0b9f4 100644--- a/web/src/features/traces/contexts/SelectionContext.tsx+++ b/web/src/features/traces/contexts/SelectionContext.tsx@@ -34,8 +34,8 @@ import {} from "./ViewPreferencesContext";// Valid tab values for detail view-export type DetailTab = "preview" | "log" | "scores";-const VALID_TABS: DetailTab[] = ["preview", "log", "scores"];+export type DetailTab = "preview" | "attributes" | "log" | "scores";+const VALID_TABS: DetailTab[] = ["preview", "attributes", "log", "scores"];const DEFAULT_TAB: DetailTab = "preview";// Valid view preference valuesdiff --git a/web/src/features/traces/fns/attributeColumnFilter.clienttest.ts b/web/src/features/traces/fns/attributeColumnFilter.clienttest.tsnew file mode 100644index 0000000000..40227fc83c--- /dev/null+++ b/web/src/features/traces/fns/attributeColumnFilter.clienttest.ts@@ -0,0 +1,41 @@+// @vitest-environment node++import { describe, expect, it } from "vitest";+import { attributeColumnFilter } from "./attributeColumnFilter";++describe("attributeColumnFilter", () => {+ it("filters session and user on the caller's table with option clauses", () => {+ for (const [key, column] of [+ ["session_id", "sessionId"],+ ["user_id", "userId"],+ ] as const) {+ for (const target of ["observations", "traces"] as const) {+ const filter = attributeColumnFilter(key, "abc", target);+ expect(filter?.target).toBe(target);+ expect(filter?.include).toEqual({+ column,+ type: "stringOptions",+ operator: "any of",+ value: ["abc"],+ });+ expect(filter?.exclude).toEqual({+ column,+ type: "stringOptions",+ operator: "none of",+ value: ["abc"],+ });+ }+ }+ });++ it("offers no exclude for string columns, which cannot negate exactly", () => {+ const filter = attributeColumnFilter("version", "1.2", "traces");+ expect(filter?.include).toEqual({+ column: "version",+ type: "string",+ operator: "=",+ value: "1.2",+ });+ expect(filter?.exclude).toBeUndefined();+ });+});diff --git a/web/src/features/traces/fns/attributeColumnFilter.ts b/web/src/features/traces/fns/attributeColumnFilter.tsnew file mode 100644index 0000000000..2d6b8d0750--- /dev/null+++ b/web/src/features/traces/fns/attributeColumnFilter.ts@@ -0,0 +1,75 @@+/** Which table column can filter each attribute. */++import { type FilterState } from "@langfuse/shared";++export type AttributeTarget = "observations" | "traces";++export type AttributeColumnFilter = {+ target: AttributeTarget;+ include: FilterState[number];+ /** Absent when the column has no exact negation. */+ exclude?: FilterState[number];+};++function optionsFilter(+ column: string,+ value: string,+ target: AttributeTarget,+): AttributeColumnFilter {+ return {+ target,+ include: {+ column,+ type: "stringOptions" as const,+ operator: "any of" as const,+ value: [value],+ },+ exclude: {+ column,+ type: "stringOptions" as const,+ operator: "none of" as const,+ value: [value],+ },+ };+}++function textFilter(+ column: string,+ value: string,+ target: AttributeTarget,+): AttributeColumnFilter {+ return {+ target,+ include: {+ column,+ type: "string" as const,+ operator: "=" as const,+ value,+ },+ };+}++/** Keys absent here have no column, so they get no filter shortcut. */+const ATTRIBUTE_COLUMNS: Record<+ string,+ (value: string, target: AttributeTarget) => AttributeColumnFilter | null+> = {+ environment: (value, target) => optionsFilter("environment", value, target),+ // Traces have no model column.+ model: (value) => optionsFilter("model", value, "observations"),+ session_id: (value, target) => optionsFilter("sessionId", value, target),+ user_id: (value, target) => optionsFilter("userId", value, target),+ version: (value, target) => textFilter("version", value, target),+ // Observations have no release column, and an observation's release could+ // belong to a different trace record.+ release: (value, target) =>+ target === "traces" ? textFilter("release", value, "traces") : null,+};++export function attributeColumnFilter(+ key: string,+ value: string,+ target: AttributeTarget,+): AttributeColumnFilter | null {+ return ATTRIBUTE_COLUMNS[key]?.(value, target) ?? null;+}diff --git a/web/src/features/traces/fns/attributeGrammar.clienttest.ts b/web/src/features/traces/fns/attributeGrammar.clienttest.tsnew file mode 100644index 0000000000..68bf46c44c--- /dev/null+++ b/web/src/features/traces/fns/attributeGrammar.clienttest.ts@@ -0,0 +1,13 @@+// @vitest-environment node++import { describe, expect, it } from "vitest";+import { attributeGrammar } from "./attributeGrammar";++describe("attributeGrammar", () => {+ it("reads as search-bar grammar", () => {+ expect(attributeGrammar("session_id", "s42")).toBe("session_id:s42");+ expect(attributeGrammar("user_id", "maya chen")).toBe(+ 'user_id:"maya chen"',+ );+ });+});diff --git a/web/src/features/traces/fns/attributeGrammar.ts b/web/src/features/traces/fns/attributeGrammar.tsnew file mode 100644index 0000000000..29313f0b15--- /dev/null+++ b/web/src/features/traces/fns/attributeGrammar.ts@@ -0,0 +1,6 @@+/** Search-bar grammar for a key/value pair. */++export function attributeGrammar(key: string, value: string): string {+ const v = /[\s:"()]/.test(value) ? JSON.stringify(value) : value;+ return `${key}:${v}`;+}diff --git a/web/src/features/traces/fns/buildModelParameters.clienttest.ts b/web/src/features/traces/fns/buildModelParameters.clienttest.tsnew file mode 100644index 0000000000..664cb20268--- /dev/null+++ b/web/src/features/traces/fns/buildModelParameters.clienttest.ts@@ -0,0 +1,15 @@+// @vitest-environment node++import { describe, expect, it } from "vitest";+import { buildModelParameters } from "./buildModelParameters";++describe("buildModelParameters", () => {+ it("keeps the call's parameters as their own table and drops empty ones", () => {+ expect(+ buildModelParameters({ temperature: 0.2, top_p: null, tools: ["a"] }),+ ).toEqual({ temperature: 0.2, tools: ["a"] });+ expect(buildModelParameters({})).toBeNull();+ expect(buildModelParameters(null)).toBeNull();+ expect(buildModelParameters("gpt-4" as unknown as null)).toBeNull();+ });+});diff --git a/web/src/features/traces/fns/buildModelParameters.ts b/web/src/features/traces/fns/buildModelParameters.tsnew file mode 100644index 0000000000..3b7fb3ef57--- /dev/null+++ b/web/src/features/traces/fns/buildModelParameters.ts@@ -0,0 +1,18 @@+/** The call's own parameters. Null when empty, so the table does not render. */++import { type JsonNested } from "@langfuse/shared";++export function buildModelParameters(+ modelParameters: JsonNested | null | undefined,+): Record<string, unknown> | null {+ if (+ !modelParameters ||+ typeof modelParameters !== "object" ||+ Array.isArray(modelParameters)+ )+ return null;+ const entries = Object.entries(modelParameters).filter(+ ([, value]) => value !== null && value !== undefined,+ );+ return entries.length > 0 ? Object.fromEntries(entries) : null;+}diff --git a/web/src/features/traces/fns/buildObservationAttributes.clienttest.ts b/web/src/features/traces/fns/buildObservationAttributes.clienttest.tsnew file mode 100644index 0000000000..99aaff2f3c--- /dev/null+++ b/web/src/features/traces/fns/buildObservationAttributes.clienttest.ts@@ -0,0 +1,35 @@+// @vitest-environment node++import { describe, expect, it } from "vitest";+import { buildObservationAttributes } from "./buildObservationAttributes";++describe("buildObservationAttributes", () => {+ it("adds session and user after the fixed keys and skips empty values", () => {+ const attributes = buildObservationAttributes({+ model: "gpt-4.1-mini",+ environment: "prod",+ release: null,+ version: "v7",+ sessionId: "s42",+ userId: null,+ });+ expect(Object.keys(attributes)).toEqual([+ "model",+ "environment",+ "version",+ "session_id",+ ]);+ expect(attributes.session_id).toBe("s42");+ });++ it("is empty when the observation carries none of the keys", () => {+ expect(+ buildObservationAttributes({+ model: null,+ environment: null,+ release: null,+ version: null,+ }),+ ).toEqual({});+ });+});diff --git a/web/src/features/traces/fns/buildObservationAttributes.ts b/web/src/features/traces/fns/buildObservationAttributes.tsnew file mode 100644index 0000000000..1f7aa61893--- /dev/null+++ b/web/src/features/traces/fns/buildObservationAttributes.ts@@ -0,0 +1,28 @@+/** The fixed-key facts behind the Attributes table. */++export function buildObservationAttributes({+ model,+ environment,+ release,+ version,+ sessionId,+ userId,+}: {+ model: string | null;+ environment: string | null;+ release: string | null | undefined;+ version: string | null;+ /** Trace-level; v4 events carry them on every observation. */+ sessionId?: string | null;+ userId?: string | null;+}): Record<string, unknown> {+ const attributes: Record<string, unknown> = {};+ if (model) attributes.model = model;+ if (environment) attributes.environment = environment;+ if (release) attributes.release = release;+ if (version) attributes.version = version;+ // SDK spelling; both are search-bar aliases.+ if (sessionId) attributes.session_id = sessionId;+ if (userId) attributes.user_id = userId;+ return attributes;+}