🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): timeline gutter with 12px icons and rounded connectors (#18279)
Trang Nguyen93eea1e0e118
diff --git a/web/src/features/traces/components/TraceTimelineDense/TimelineDense.stories.tsx b/web/src/features/traces/components/TraceTimelineDense/TimelineDense.stories.tsxindex 5ecc50161e..d53f2ef2c9 100644--- a/web/src/features/traces/components/TraceTimelineDense/TimelineDense.stories.tsx+++ b/web/src/features/traces/components/TraceTimelineDense/TimelineDense.stories.tsx@@ -1397,11 +1397,11 @@ export const DeepConnectorsStillMeet = meta.story({await expect(rows.length).toBeGreaterThan(8);// A chain, so the row above is the parent: where a row's own spine descends- // is exactly where its child's connector must rise to.+ // is exactly where its child's elbow (its left border) must rise to.const spineOf = (row: HTMLElement) =>row.querySelector<HTMLElement>('div[class*="bottom-0"][class*="w-px"]');const stubOf = (row: HTMLElement) =>- row.querySelector<HTMLElement>('div[class*="top-0"][class*="w-px"]');+ row.querySelector<HTMLElement>('div[class*="top-0"][class*="border-l"]');let checked = 0;for (let index = 1; index < rows.length; index++) {diff --git a/web/src/features/traces/components/TraceTimelineDense/TimelineDense.tsx b/web/src/features/traces/components/TraceTimelineDense/TimelineDense.tsxindex a466a172c8..cbec2d9508 100644--- a/web/src/features/traces/components/TraceTimelineDense/TimelineDense.tsx+++ b/web/src/features/traces/components/TraceTimelineDense/TimelineDense.tsx@@ -160,8 +160,8 @@ const RAIL_SQUARE_MAX = 5;const RAIL_WIDTH = RAIL_MAX_DEPTH * RAIL_INDENT + RAIL_SQUARE_MAX + 2;/** Indent per level once the gutter is open, matching the production gutter. */const GUTTER_INDENT = 14;-/** The ItemBadge box at `isSmall`, which is square. */-const GUTTER_ICON = 16;+/** Type icon size in the gutter, same as the tree rows. */+const GUTTER_ICON = 12;/** A name needs at least this much to be worth indenting away from. */const GUTTER_NAME_MIN = 48;/**@@ -1927,18 +1927,18 @@ function GutterContent({: null}{showName && depth > 0 ? (<>+ {node.isLastSibling ? null : (+ <div+ className="bg-border-contrast absolute inset-y-0 w-px"+ style={{ left: `${parentRailX}px` }}+ />+ )}<div- className={cn(- "bg-border-contrast absolute top-0 w-px",- node.isLastSibling ? "h-1/2" : "bottom-0",- )}- style={{ left: `${parentRailX}px` }}- />- <div- className="bg-border-contrast absolute top-1/2 h-px"+ className="border-border-contrast absolute top-0 rounded-bl-md border-b border-l mask-r-from-40%"style={{left: `${parentRailX}px`,- width: `${Math.max(indent - parentRailX, 0)}px`,+ height: "calc(50% + 0.5px)",+ width: `${Math.max(indent - parentRailX - 1, 0)}px`,}}/></>@@ -1946,10 +1946,10 @@ function GutterContent({{/* This row's own spine, descending from below its icon to its children. */}{showName && node.hasChildren && !node.isCollapsed ? (<div- className="bg-border-contrast absolute bottom-0 w-px"+ className="bg-border-contrast absolute bottom-0 w-px mask-t-from-[calc(100%-var(--spacing)*2)]"style={{left: `${railX}px`,- top: `calc(50% + ${GUTTER_ICON / 2}px)`,+ top: `calc(50% + ${GUTTER_ICON / 2 + 1}px)`,}}/>) : null}@@ -1973,7 +1973,7 @@ function GutterContent({<span className="shrink-0"><ItemTypeIcontype={node.type as LangfuseItemType}- className="size-4"+ className="size-3"/></span><span