🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
refactor(web): Clean up `LocalIsoDate` (#16400)
Ben Bachem9d7898cc653d
diff --git a/.agents/skills/react-component-guidelines/SKILL.md b/.agents/skills/react-component-guidelines/SKILL.mdindex d66e878f0c..de1d91e4ce 100644--- a/.agents/skills/react-component-guidelines/SKILL.md+++ b/.agents/skills/react-component-guidelines/SKILL.md@@ -14,6 +14,7 @@ Components are useful because they act as an encapsulated unit and therefore pro## Composition+- Shared components should own meaningful presentation or complex logic. There must be a reason for code to be a component over a pure function or hook. When most logic is JSX-independent, use a pure function and keep trivial JSX at each call site. Use a hook over a pure function only when React lifecycle or state is required.- Avoid polymorphic components:- **Presentation:** A component should own one concrete presentation. When an action needs different presentations across contexts (e.g. sometimes a button, sometimes an icon), keep them separate rather than selecting between them with mode props or flags.- **Behavior:** A component should own one cohesive workflow. When a prop selects fundamentally different workflows, split them into separate behavior-owning components. For example, prefer dedicated create, update, and delete dialog controllers over one action component whose `mode` changes the entire interaction.diff --git a/web/src/components/LocalIsoDate.tsx b/web/src/components/LocalIsoDate.tsxindex 4275114ed2..d6e07b5e10 100644--- a/web/src/components/LocalIsoDate.tsx+++ b/web/src/components/LocalIsoDate.tsx@@ -1,4 +1,3 @@-/* eslint-disable @repo/no-style-props */type Accuracy = "day" | "hour" | "minute" | "second" | "millisecond";export const formatLocalIsoDate = (@@ -34,25 +33,33 @@ export const formatLocalIsoDate = (return formatted;};-export const LocalIsoDate = ({+export const prepareLocalIsoDate = ({date,accuracy = "second",- className,}: {- date: Date;+ date: unknown;accuracy?: Accuracy;- className?: string;}) => {if (!(date instanceof Date) || isNaN(date.getTime())) {return null;}- const localDateString = formatLocalIsoDate(date, false, accuracy);- const utcDateString = formatLocalIsoDate(date, true, "millisecond");+ return {+ display: formatLocalIsoDate(date, false, accuracy),+ title: `UTC: ${formatLocalIsoDate(date, true, "millisecond")}`,+ };+};++export const LocalIsoDate = ({+ date,+ accuracy,+}: {+ date: Date;+ accuracy?: Accuracy;+}) => {+ const preparedDate = prepareLocalIsoDate({ date, accuracy });- return (- <span title={`UTC: ${utcDateString}`} className={className}>- {localDateString}- </span>- );+ return preparedDate ? (+ <span title={preparedDate.title}>{preparedDate.display}</span>+ ) : null;};diff --git a/web/src/features/experiments/components/table/ExperimentGridCell.tsx b/web/src/features/experiments/components/table/ExperimentGridCell.tsxindex 0e486849d7..6b7513b7d6 100644--- a/web/src/features/experiments/components/table/ExperimentGridCell.tsx+++ b/web/src/features/experiments/components/table/ExperimentGridCell.tsx@@ -558,7 +558,9 @@ export const ExperimentGridCell = ({accessorKey: "startTime",cell: ({ data }) => (<MetadataItem label="Start Time">- <LocalIsoDate date={data.startTime} className="text-xs" />+ <span className="text-xs">+ <LocalIsoDate date={data.startTime} />+ </span></MetadataItem>),},diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsxindex 921365aa8b..f61a7ee2db 100644--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx@@ -375,12 +375,8 @@ export const ObservationDetailViewHeader = memo(<div className="flex flex-col gap-2">{/* Timestamp */}- <div className="flex flex-wrap items-center gap-1">- <LocalIsoDate- date={observation.startTime}- accuracy="millisecond"- className="text-sm"- />+ <div className="flex flex-wrap items-center gap-1 text-sm">+ <LocalIsoDate date={observation.startTime} accuracy="millisecond" /></div>{/* Other badges */}diff --git a/web/src/features/traces/components/TraceDetailView/components/TraceDetailViewHeader.tsx b/web/src/features/traces/components/TraceDetailView/components/TraceDetailViewHeader.tsxindex cd5b711b36..b3b4213ac8 100644--- a/web/src/features/traces/components/TraceDetailView/components/TraceDetailViewHeader.tsx+++ b/web/src/features/traces/components/TraceDetailView/components/TraceDetailViewHeader.tsx@@ -239,12 +239,8 @@ export const TraceDetailViewHeader = memo(function TraceDetailViewHeader({{/* Metadata badges */}<div className="flex flex-col gap-2">{/* Timestamp */}- <div className="flex flex-wrap items-center gap-1">- <LocalIsoDate- date={trace.timestamp}- accuracy="millisecond"- className="text-sm"- />+ <div className="flex flex-wrap items-center gap-1 text-sm">+ <LocalIsoDate date={trace.timestamp} accuracy="millisecond" /></div>{/* Other badges */}