Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): use pointer cursor on dropdown menu items (#16327)

Nikita Kabardin9ec8a2ce0258
diff --git a/web/src/components/ui/dropdown-menu.stories.tsx b/web/src/components/ui/dropdown-menu.stories.tsx
new file mode 100644
index 0000000000..8f99887745
--- /dev/null
+++ b/web/src/components/ui/dropdown-menu.stories.tsx
@@ -0,0 +1,101 @@
+import { CopyIcon } from "lucide-react";
+import { expect, fn, within } from "storybook/test";
+import preview from "../../../.storybook/preview";
+import { Button } from "./button";
+import {
+ DropdownMenu,
+ DropdownMenuContent,
+ DropdownMenuItem,
+ DropdownMenuSeparator,
+ DropdownMenuSub,
+ DropdownMenuSubContent,
+ DropdownMenuSubTrigger,
+ DropdownMenuTrigger,
+} from "./dropdown-menu";
+
+const meta = preview.meta({
+ component: DropdownMenu,
+ render: () => (
+ <DropdownMenu defaultOpen>
+ <DropdownMenuTrigger asChild>
+ <Button aria-label="Options" size="icon-xs" variant="ghost">
+ Options
+ </Button>
+ </DropdownMenuTrigger>
+ <DropdownMenuContent align="start">
+ <DropdownMenuItem className="text-xs" onSelect={fn()}>
+ <span>
+ filter by <span className="font-bold">name:SupportChatSession</span>
+ </span>
+ </DropdownMenuItem>
+ <DropdownMenuItem className="text-xs" onSelect={fn()}>
+ <span>
+ filter by <span className="font-bold">type:SPAN</span>
+ </span>
+ </DropdownMenuItem>
+ <DropdownMenuSeparator />
+ <DropdownMenuItem className="text-xs" onSelect={fn()}>
+ <CopyIcon className="mr-2 h-4 w-4" />
+ Copy Trace ID
+ </DropdownMenuItem>
+ <DropdownMenuItem className="text-xs" onSelect={fn()}>
+ <CopyIcon className="mr-2 h-4 w-4" />
+ Copy Observation ID
+ </DropdownMenuItem>
+ </DropdownMenuContent>
+ </DropdownMenu>
+ ),
+});
+
+export default meta;
+
+export const Default = meta.story({});
+
+const renderDisabledSubTrigger = () => (
+ <DropdownMenu defaultOpen>
+ <DropdownMenuTrigger asChild>
+ <Button aria-label="Search type" size="sm" variant="outline">
+ Search type
+ </Button>
+ </DropdownMenuTrigger>
+ <DropdownMenuContent align="start">
+ <DropdownMenuItem onSelect={fn()}>IDs / Names</DropdownMenuItem>
+ <DropdownMenuSub>
+ <DropdownMenuSubTrigger disabled>Full Text</DropdownMenuSubTrigger>
+ <DropdownMenuSubContent>
+ <DropdownMenuItem onSelect={fn()}>All fields</DropdownMenuItem>
+ </DropdownMenuSubContent>
+ </DropdownMenuSub>
+ </DropdownMenuContent>
+ </DropdownMenu>
+);
+
+export const DisabledSubTrigger = meta.story({
+ render: renderDisabledSubTrigger,
+});
+
+export const TestMenuItemsUsePointerCursor = meta.story({
+ name: "(Test) Menu items use pointer cursor",
+ play: async ({ canvasElement }) => {
+ const body = within(canvasElement.ownerDocument.body);
+ const items = await body.findAllByRole("menuitem");
+
+ await expect(items.length).toBeGreaterThan(0);
+
+ for (const item of items) {
+ await expect(getComputedStyle(item).cursor).toBe("pointer");
+ }
+ },
+});
+
+export const TestDisabledSubTriggerUsesNotAllowedCursor = meta.story({
+ name: "(Test) Disabled subtrigger uses not-allowed cursor",
+ render: renderDisabledSubTrigger,
+ play: async ({ canvasElement }) => {
+ const body = within(canvasElement.ownerDocument.body);
+ const item = await body.findByRole("menuitem", { name: "Full Text" });
+
+ await expect(item).toHaveAttribute("data-disabled");
+ await expect(getComputedStyle(item).cursor).toBe("not-allowed");
+ },
+});
diff --git a/web/src/components/ui/dropdown-menu.tsx b/web/src/components/ui/dropdown-menu.tsx
index 7dc03b052b..c0c2712665 100644
--- a/web/src/components/ui/dropdown-menu.tsx
+++ b/web/src/components/ui/dropdown-menu.tsx
@@ -49,7 +49,7 @@ const DropdownMenuSubTrigger = React.forwardRef<
<DropdownMenuPrimitive.SubTrigger
ref={ref}
className={cn(
- "focus:bg-accent data-[state=open]:bg-accent flex cursor-default items-center rounded-sm px-2 py-1.5 text-sm outline-hidden select-none",
+ "focus:bg-accent data-[state=open]:bg-accent flex cursor-pointer items-center rounded-sm px-2 py-1.5 text-sm outline-hidden select-none data-disabled:cursor-not-allowed",
inset && "pl-8",
className,
)}
@@ -265,7 +265,7 @@ const DropdownMenuItem = React.forwardRef<
<DropdownMenuPrimitive.Item
ref={ref}
className={cn(
- "focus:bg-accent focus:text-accent-foreground relative flex cursor-default items-center rounded-sm px-2 py-1.5 text-sm outline-hidden transition-colors select-none data-disabled:opacity-50",
+ "focus:bg-accent focus:text-accent-foreground relative flex cursor-pointer items-center rounded-sm px-2 py-1.5 text-sm outline-hidden transition-colors select-none data-disabled:cursor-not-allowed data-disabled:opacity-50",
!allowPointerEventsWhenDisabled && "data-disabled:pointer-events-none",
inset && "pl-8",
className,
@@ -464,7 +464,7 @@ const DropdownMenuCheckboxItem = React.forwardRef<
<DropdownMenuPrimitive.CheckboxItem
ref={ref}
className={cn(
- "focus:bg-accent focus:text-accent-foreground relative flex cursor-default items-center rounded-sm py-1.5 pr-2 pl-8 text-sm outline-hidden transition-colors select-none data-disabled:pointer-events-none data-disabled:opacity-50",
+ "focus:bg-accent focus:text-accent-foreground relative flex cursor-pointer items-center rounded-sm py-1.5 pr-2 pl-8 text-sm outline-hidden transition-colors select-none data-disabled:pointer-events-none data-disabled:opacity-50",
className,
)}
checked={checked}
@@ -489,7 +489,7 @@ const DropdownMenuRadioItem = React.forwardRef<
<DropdownMenuPrimitive.RadioItem
ref={ref}
className={cn(
- "focus:bg-accent focus:text-accent-foreground relative flex cursor-default items-center rounded-sm py-1.5 pr-2 pl-8 text-sm outline-hidden transition-colors select-none data-disabled:pointer-events-none data-disabled:opacity-50",
+ "focus:bg-accent focus:text-accent-foreground relative flex cursor-pointer items-center rounded-sm py-1.5 pr-2 pl-8 text-sm outline-hidden transition-colors select-none data-disabled:pointer-events-none data-disabled:opacity-50",
className,
)}
{...props}
diff --git a/web/src/features/scores/components/multi-select-key-values.tsx b/web/src/features/scores/components/multi-select-key-values.tsx
index 16d395eef6..996151484e 100644
--- a/web/src/features/scores/components/multi-select-key-values.tsx
+++ b/web/src/features/scores/components/multi-select-key-values.tsx
@@ -256,7 +256,7 @@ export function MultiSelectKeyValues<
return (
<DropdownMenuSub key={group.label}>
- <DropdownMenuSubTrigger className="flex w-full cursor-default items-center select-none">
+ <DropdownMenuSubTrigger className="flex w-full items-center select-none">
<Component className="mr-2 h-4 w-4 opacity-50" />
<span>{group.label}</span>
</DropdownMenuSubTrigger>