🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
refactor(web): Fix no-null-render: EvaluatorBadge.tsx (#17230)
Ben Bachema019553b2094
diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsxindex ba3dabb08b..d88458d7f9 100644--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx@@ -745,12 +745,18 @@ export const ObservationDetailViewHeader = memo(userId={observation.userId ?? null}projectId={projectId}/>- <EvaluatorBadge- evaluatorId={evaluatorId}- evaluatorName={evaluator.data?.name}- environment={observation.environment}- projectId={projectId}- />+ {evaluatorId &&+ (observation.environment ===+ LangfuseInternalTraceEnvironment.LLMJudge ||+ observation.environment ===+ LangfuseInternalTraceEnvironment.CodeEval) &&+ !evaluatorId.startsWith("managed:") && (+ <EvaluatorBadge+ evaluatorId={evaluatorId}+ evaluatorName={evaluator.data?.name}+ projectId={projectId}+ />+ )}<EnvironmentBadge environment={observation.environment} /><ReleaseBadge release={observation.release} />{displayedTotalCost != null && displayedCostDetails && (diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge.stories.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge.stories.tsxindex 9462ea4ce7..b99b44629d 100644--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge.stories.tsx+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge.stories.tsx@@ -6,7 +6,6 @@ const meta = preview.meta({args: {evaluatorId: "evaluator-id",evaluatorName: "Quality check",- environment: "langfuse-llm-as-a-judge",projectId: "project-id",},});diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge.tsxindex 9dd69ab98b..bcfa921f2a 100644--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge.tsx+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/components/EvaluatorBadge/EvaluatorBadge.tsx@@ -1,5 +1,3 @@-/* eslint-disable @repo/no-null-render */-import { LangfuseInternalTraceEnvironment } from "@langfuse/shared";import { ExternalLinkIcon } from "lucide-react";import Link from "next/link";@@ -8,20 +6,12 @@ import { Badge } from "@/src/components/design-system/Badge/Badge";export function EvaluatorBadge({evaluatorId,evaluatorName,- environment,projectId,}: {- evaluatorId: string | null;+ evaluatorId: string;evaluatorName?: string | null;- environment: string;projectId: string;}) {- const isEvaluatorExecution =- environment === LangfuseInternalTraceEnvironment.LLMJudge ||- environment === LangfuseInternalTraceEnvironment.CodeEval;- const isManagedTemplate = evaluatorId?.startsWith("managed:") ?? false;- if (!evaluatorId || !isEvaluatorExecution || isManagedTemplate) return null;-return (<Linkhref={`/project/${projectId}/evals/v2/${encodeURIComponent(evaluatorId)}`}