🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
refactor(web): Clean up `Tabs` component (#16940)
Ben Bachema4ebd331861d
diff --git a/web/.storybook/main.ts b/web/.storybook/main.tsindex 1c627b2618..ac749a0ac8 100644--- a/web/.storybook/main.ts+++ b/web/.storybook/main.ts@@ -28,6 +28,7 @@ const DESIGN_COMPONENT_STORIES = ["SearchInput/SearchInput","Spinner/Spinner","Switch/Switch",+ "Tabs/Tabs","TextLink/TextLink","Toggle/Toggle","table/components/IOTableCell/IOTableCell",diff --git a/web/src/components/design-system/Tabs/Tabs.stories.tsx b/web/src/components/design-system/Tabs/Tabs.stories.tsxnew file mode 100644index 0000000000..b24baf606a--- /dev/null+++ b/web/src/components/design-system/Tabs/Tabs.stories.tsx@@ -0,0 +1,252 @@+import React from "react";+import { KeyRound, User } from "lucide-react";+import { expect, userEvent, within } from "storybook/test";++import preview from "../../../../.storybook/preview";+import { Tabs } from "./Tabs";++type ListVariant = NonNullable<+ React.ComponentProps<typeof Tabs.List>["variant"]+>;+type ListSize = NonNullable<React.ComponentProps<typeof Tabs.List>["size"]>;++const meta = preview.meta({+ component: Tabs,+});++const listVariants = Object.keys({+ default: true,+ underline: true,+ outline: true,+} satisfies Record<ListVariant, true>) as ListVariant[];++const listSizes = Object.keys({+ default: true,+ md: true,+ sm: true,+ auto: true,+} satisfies Record<ListSize, true>) as ListSize[];++const defaultChildren = (+ <>+ <Tabs.List>+ <Tabs.Trigger value="account" label="Account" />+ <Tabs.Trigger value="password" label="Password" />+ </Tabs.List>+ <Tabs.Content value="account">Account settings</Tabs.Content>+ <Tabs.Content value="password">Password settings</Tabs.Content>+ </>+);++const fullWidthChildren = (+ <>+ <Tabs.List layout="full">+ <span className="flex-1">+ <Tabs.Trigger value="first" label="First" />+ </span>+ <span className="flex-1">+ <Tabs.Trigger value="second" label="Second" />+ </span>+ </Tabs.List>+ <Tabs.Content value="first">First tab fills its wrapper.</Tabs.Content>+ <Tabs.Content value="second">Second tab fills its wrapper.</Tabs.Content>+ </>+);++export const Default = meta.story({+ args: {+ defaultValue: "account",+ children: defaultChildren,+ },+});++export const Disabled = meta.story({+ args: {+ defaultValue: "account",+ children: (+ <>+ <Tabs.List>+ <Tabs.Trigger value="account" label="Account" />+ <Tabs.Trigger value="password" disabled label="Password" />+ </Tabs.List>+ <Tabs.Content value="account">Account settings</Tabs.Content>+ <Tabs.Content value="password">Password settings</Tabs.Content>+ </>+ ),+ },+});++export const FullWidth = meta.story({+ args: {+ defaultValue: "first",+ children: fullWidthChildren,+ },+});++export const WithIcons = meta.story({+ args: {+ defaultValue: "account",+ children: (+ <>+ <Tabs.List>+ <Tabs.Trigger value="account" icon={User} label="Account" />+ <Tabs.Trigger value="password" icon={KeyRound} label="Password" />+ </Tabs.List>+ <Tabs.Content value="account">Account settings</Tabs.Content>+ <Tabs.Content value="password">Password settings</Tabs.Content>+ </>+ ),+ },+});++export const VariantMatrix = meta.story({+ parameters: {+ controls: {+ disable: true,+ },+ },+ render: () => (+ <div className="grid gap-6">+ {listVariants.map((variant) =>+ listSizes.map((size) => (+ <div key={`${variant}-${size}`}>+ <div className="text-muted-foreground mb-2 text-sm">+ {variant} / {size}+ </div>+ <Tabs defaultValue="one">+ <Tabs.List variant={variant} size={size}>+ <Tabs.Trigger+ value="one"+ variant={variant === "underline" ? "underline" : "default"}+ size={size === "sm" ? "sm" : "default"}+ label="One"+ />+ <Tabs.Trigger+ value="two"+ variant={variant === "underline" ? "underline" : "default"}+ size={size === "sm" ? "sm" : "default"}+ label="Two"+ />+ </Tabs.List>+ </Tabs>+ </div>+ )),+ )}+ </div>+ ),+});++export const SwitchesTab = meta.story({+ name: "(Test) Switches Tab",+ args: {+ defaultValue: "account",+ children: defaultChildren,+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ const passwordTab = canvas.getByRole("tab", { name: "Password" });++ await userEvent.click(passwordTab);+ await expect(passwordTab).toHaveAttribute("aria-selected", "true");+ await expect(canvas.getByText("Password settings")).toBeVisible();+ },+});++export const FillsWrappedTrigger = meta.story({+ name: "(Test) Fills Wrapped Trigger",+ args: {+ defaultValue: "first",+ children: fullWidthChildren,+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ const firstTab = canvas.getByRole("tab", { name: "First" });+ const wrapper = firstTab.parentElement;++ await expect(wrapper).toBeTruthy();+ await expect(+ Math.abs(+ firstTab.getBoundingClientRect().width -+ wrapper!.getBoundingClientRect().width,+ ),+ ).toBeLessThan(1);+ },+});++export const CentersWrappedTriggerVertically = meta.story({+ name: "(Test) Centers Wrapped Trigger Vertically",+ args: {+ defaultValue: "first",+ children: fullWidthChildren,+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ const firstTab = canvas.getByRole("tab", { name: "First" });+ const wrapper = firstTab.parentElement;+ const list = firstTab.closest('[role="tablist"]');++ await expect(wrapper).toBeTruthy();+ await expect(list).toBeTruthy();++ const listRect = list!.getBoundingClientRect();+ const tabRect = firstTab.getBoundingClientRect();+ const topInset = tabRect.top - listRect.top;+ const bottomInset = listRect.bottom - tabRect.bottom;++ await expect(Math.abs(topInset - bottomInset)).toBeLessThan(1);+ },+});++export const KeepsUnwrappedTriggersContentWidth = meta.story({+ name: "(Test) Keeps Unwrapped Triggers Content Width",+ args: {+ defaultValue: "short",+ children: (+ <Tabs.List variant="outline">+ <Tabs.Trigger value="short" label="Python" />+ <Tabs.Trigger value="long" label="TypeScript" />+ </Tabs.List>+ ),+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ const shortTab = canvas.getByRole("tab", { name: "Python" });+ const longTab = canvas.getByRole("tab", { name: "TypeScript" });++ await expect(longTab.getBoundingClientRect().width).toBeGreaterThan(+ shortTab.getBoundingClientRect().width,+ );+ },+});++export const TruncatesLabel = meta.story({+ name: "(Test) Truncates Label",+ args: {+ defaultValue: "long",+ children: (+ <Tabs.List>+ <span className="w-20">+ <Tabs.Trigger+ value="long"+ label="A label that is too long for its trigger"+ />+ </span>+ </Tabs.List>+ ),+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ const tab = canvas.getByRole("tab", {+ name: "A label that is too long for its trigger",+ });+ const label = within(tab).getByText(+ "A label that is too long for its trigger",+ );++ await expect(tab).toHaveAttribute(+ "title",+ "A label that is too long for its trigger",+ );+ await expect(label.scrollWidth).toBeGreaterThan(label.clientWidth);+ },+});diff --git a/web/src/components/design-system/Tabs/Tabs.tsx b/web/src/components/design-system/Tabs/Tabs.tsxnew file mode 100644index 0000000000..0d5d816eed--- /dev/null+++ b/web/src/components/design-system/Tabs/Tabs.tsx@@ -0,0 +1,205 @@+"use client";++import * as React from "react";+import * as TabsPrimitive from "@radix-ui/react-tabs";+import { cva, type VariantProps } from "class-variance-authority";+import { type LucideIcon } from "lucide-react";++const tabsListVariants = cva(+ "text-muted-foreground items-center justify-center [&>:not([role=tab])]:flex [&>:not([role=tab])>[role=tab]]:w-full",+ {+ variants: {+ variant: {+ default: "bg-muted rounded-md",+ underline: "rounded-none border-b bg-transparent",+ outline:+ "bg-background rounded-md border **:data-[state=active]:bg-muted",+ },+ size: {+ default: "",+ md: "",+ sm: "",+ auto: "",+ },+ layout: {+ default: "inline-flex",+ full: "grid w-full auto-cols-fr grid-flow-col",+ packed: "inline-flex",+ },+ gap: {+ none: "",+ sm: "gap-1",+ lg: "gap-4",+ },+ },+ compoundVariants: [+ { variant: "default", size: "default", class: "h-8 p-1" },+ { variant: "default", size: "md", class: "h-7 p-1" },+ { variant: "default", size: "sm", class: "h-6 p-0.5" },+ { variant: "default", size: "auto", class: "h-auto p-1" },+ { variant: "outline", size: "default", class: "h-8 p-1" },+ { variant: "outline", size: "md", class: "h-7 p-1" },+ { variant: "outline", size: "sm", class: "h-6 p-0.5" },+ { variant: "outline", size: "auto", class: "h-auto p-1" },+ { variant: "underline", size: "default", class: "h-auto p-0" },+ { variant: "underline", size: "md", class: "h-auto p-0" },+ { variant: "underline", size: "sm", class: "h-auto p-0" },+ { variant: "underline", size: "auto", class: "h-auto p-0" },+ ],+ defaultVariants: {+ variant: "default",+ size: "default",+ layout: "default",+ gap: "none",+ },+ },+);++const tabsTriggerVariants = cva(+ "ring-offset-background focus-visible:ring-ring data-[state=active]:text-foreground inline-flex min-w-0 items-center justify-center gap-1.5 font-bold leading-none whitespace-nowrap transition-all focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden disabled:pointer-events-none disabled:cursor-not-allowed disabled:opacity-50",+ {+ variants: {+ variant: {+ default:+ "rounded-sm data-[state=active]:bg-background data-[state=active]:shadow-xs",+ underline:+ "rounded-none border-b-2 border-transparent bg-transparent text-muted-foreground shadow-none data-[state=active]:border-primary-accent data-[state=active]:bg-transparent data-[state=active]:shadow-none",+ },+ size: {+ default: "h-6 px-2 py-0.5 text-sm",+ lg: "h-7 px-1 text-xs",+ sm: "h-5 px-1 text-xs",+ },+ },+ defaultVariants: {+ variant: "default",+ size: "default",+ },+ },+);++type TabsListProps = {+ "aria-label"?: string;+ children: React.ReactNode;+} & Pick<+ VariantProps<typeof tabsListVariants>,+ "gap" | "layout" | "size" | "variant"+>;+type TabsRootProps = {+ children: React.ReactNode;+ onValueChange?: (value: string) => void;+ ref?: React.Ref<HTMLDivElement>;+} & (+ | { defaultValue: string; value?: never }+ | { defaultValue?: never; value: string }+);++function TabsRoot({+ children,+ defaultValue,+ onValueChange,+ ref,+ value,+}: TabsRootProps) {+ return (+ <TabsPrimitive.Root+ defaultValue={defaultValue}+ onValueChange={onValueChange}+ ref={ref}+ value={value}+ >+ {children}+ </TabsPrimitive.Root>+ );+}++function TabsList({+ "aria-label": ariaLabel,+ children,+ gap,+ layout,+ size,+ variant,+}: TabsListProps) {+ return (+ <TabsPrimitive.List+ aria-label={ariaLabel}+ className={tabsListVariants({ gap, layout, size, variant })}+ >+ {children}+ </TabsPrimitive.List>+ );+}++type TabsTriggerProps = {+ disabled?: boolean;+ icon?: LucideIcon;+ value: string;+} & Pick<VariantProps<typeof tabsTriggerVariants>, "size" | "variant"> &+ (+ | {+ /** Preferred for plain-text trigger content. */+ label: string;+ children?: never;+ title?: never;+ }+ | {+ label?: never;+ /** Rich-content escape hatch. */+ children: React.ReactNode;+ title?: string;+ }+ );++function TabsTrigger({+ children,+ disabled,+ icon: Icon,+ label,+ size,+ title,+ value,+ variant,+}: TabsTriggerProps) {+ return (+ <TabsPrimitive.Trigger+ value={value}+ disabled={disabled}+ title={label ?? title}+ className={tabsTriggerVariants({ size, variant })}+ >+ {Icon ? <Icon aria-hidden="true" className="size-3.5 shrink-0" /> : null}+ {label !== undefined ? (+ <span className="min-w-0 truncate" title={label}>+ {label}+ </span>+ ) : (+ children+ )}+ </TabsPrimitive.Trigger>+ );+}++type TabsContentProps = {+ children: React.ReactNode;+ value: string;+};++function TabsContent({ children, value }: TabsContentProps) {+ return (+ <TabsPrimitive.Content+ value={value}+ className="ring-offset-background focus-visible:ring-ring focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden"+ >+ {children}+ </TabsPrimitive.Content>+ );+}++const Tabs = Object.assign(TabsRoot, {+ List: TabsList,+ Trigger: TabsTrigger,+ Content: TabsContent,+});++export { Tabs };diff --git a/web/src/components/table/data-table-controls.tsx b/web/src/components/table/data-table-controls.tsxindex 6d25fd0cb3..ccad8a417a 100644--- a/web/src/components/table/data-table-controls.tsx+++ b/web/src/components/table/data-table-controls.tsx@@ -9,7 +9,7 @@ import {useCallback,} from "react";import { ScrollArea } from "@/src/components/ui/scroll-area";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import {Select,SelectContent,@@ -1870,13 +1870,9 @@ function CategoricalSelectContent({onOperatorChange(newOperator as "any of" | "all of" | "none of")}>- <TabsList className="grid h-6 w-full grid-cols-3 p-0.5">- <TabsTrigger value="any of" className="h-5 px-1 text-xs">- Any of- </TabsTrigger>- <TabsTrigger value="all of" className="h-5 px-1 text-xs">- All of- </TabsTrigger>+ <Tabs.List layout="full" size="sm">+ <Tabs.Trigger value="any of" size="sm" label="Any of" />+ <Tabs.Trigger value="all of" size="sm" label="All of" />{/* Without a persisted selection, switching to "none of" is adeliberate no-op in the state model (an empty exclusionwould persist a vacuous filter — LFE-10717), which used to@@ -1885,14 +1881,13 @@ function CategoricalSelectContent({engages by itself when a value is unchecked. */}<Tooltip delayDuration={80}><TooltipTrigger asChild>- <span className="min-w-0">- <TabsTrigger+ <span className="w-full min-w-0">+ <Tabs.Triggervalue="none of"disabled={operator === undefined}- className="h-5 w-full px-1 text-xs disabled:cursor-not-allowed disabled:opacity-50"- >- None of- </TabsTrigger>+ size="sm"+ label="None of"+ /></span></TooltipTrigger>{operator === undefined && (@@ -1902,7 +1897,7 @@ function CategoricalSelectContent({</TooltipContent>)}</Tooltip>- </TabsList>+ </Tabs.List></Tabs></div>)}@@ -2515,14 +2510,10 @@ function FilterModeTabs({ mode, onModeChange }: FilterModeTabsProps) {value={mode}onValueChange={(newMode) => onModeChange(newMode as "select" | "text")}>- <TabsList className="grid h-6 w-full grid-cols-2 p-0.5">- <TabsTrigger value="select" className="h-5 px-2 text-xs">- Select- </TabsTrigger>- <TabsTrigger value="text" className="h-5 px-2 text-xs">- Text- </TabsTrigger>- </TabsList>+ <Tabs.List layout="full" size="sm">+ <Tabs.Trigger value="select" size="sm" label="Select" />+ <Tabs.Trigger value="text" size="sm" label="Text" />+ </Tabs.List></Tabs></div>);diff --git a/web/src/components/ui/tabs.tsx b/web/src/components/ui/tabs.tsxdeleted file mode 100644index cc4804c954..0000000000--- a/web/src/components/ui/tabs.tsx+++ /dev/null@@ -1,56 +0,0 @@-/* eslint-disable @repo/no-style-props, @repo/no-margin-on-root-elements */-"use client";--import * as React from "react";-import * as TabsPrimitive from "@radix-ui/react-tabs";--import { cn } from "@/src/utils/tailwind";--const Tabs = TabsPrimitive.Root;--const TabsList = React.forwardRef<- React.ComponentRef<typeof TabsPrimitive.List>,- React.ComponentPropsWithoutRef<typeof TabsPrimitive.List>->(({ className, ...props }, ref) => (- <TabsPrimitive.List- ref={ref}- className={cn(- "bg-muted text-muted-foreground inline-flex h-8 items-center justify-center rounded-md p-1",- className,- )}- {...props}- />-));-TabsList.displayName = TabsPrimitive.List.displayName;--const TabsTrigger = React.forwardRef<- React.ComponentRef<typeof TabsPrimitive.Trigger>,- React.ComponentPropsWithoutRef<typeof TabsPrimitive.Trigger>->(({ className, ...props }, ref) => (- <TabsPrimitive.Trigger- ref={ref}- className={cn(- "ring-offset-background focus-visible:ring-ring data-[state=active]:bg-background data-[state=active]:text-foreground inline-flex h-6 items-center justify-center rounded-sm px-2 py-0.5 text-sm font-bold whitespace-nowrap transition-all focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden disabled:pointer-events-none disabled:opacity-50 data-[state=active]:shadow-xs",- className,- )}- {...props}- />-));-TabsTrigger.displayName = TabsPrimitive.Trigger.displayName;--const TabsContent = React.forwardRef<- React.ComponentRef<typeof TabsPrimitive.Content>,- React.ComponentPropsWithoutRef<typeof TabsPrimitive.Content>->(({ className, ...props }, ref) => (- <TabsPrimitive.Content- ref={ref}- className={cn(- "ring-offset-background focus-visible:ring-ring mt-2 focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:outline-hidden",- className,- )}- {...props}- />-));-TabsContent.displayName = TabsPrimitive.Content.displayName;--export { Tabs, TabsList, TabsTrigger, TabsContent };diff --git a/web/src/features/batch-actions/components/AddObservationsToDatasetDialog/components/CustomMappingEditor.tsx b/web/src/features/batch-actions/components/AddObservationsToDatasetDialog/components/CustomMappingEditor.tsxindex e14bfec577..78846df455 100644--- a/web/src/features/batch-actions/components/AddObservationsToDatasetDialog/components/CustomMappingEditor.tsx+++ b/web/src/features/batch-actions/components/AddObservationsToDatasetDialog/components/CustomMappingEditor.tsx@@ -1,7 +1,7 @@import { Button } from "@/src/components/ui/button";import { Input } from "@/src/components/ui/input";import { Label } from "@/src/components/ui/label";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { Plus, Trash2 } from "lucide-react";import { v4 as uuidv4 } from "uuid";import { JsonPathInput } from "./JsonPathInput";@@ -145,16 +145,17 @@ export function CustomMappingEditor({<div className="bg-muted/30 space-y-2 rounded-md border p-4"><div><Label className="text-sm font-bold">Target</Label>- <Tabs- value={config.type}- onValueChange={(v) => handleTypeChange(v as MappingTarget)}- className="mt-2"- >- <TabsList className="grid w-full grid-cols-2">- <TabsTrigger value="root">Root</TabsTrigger>- <TabsTrigger value="keyValueMap">Key-value map</TabsTrigger>- </TabsList>- </Tabs>+ <div className="mt-2">+ <Tabs+ value={config.type}+ onValueChange={(v) => handleTypeChange(v as MappingTarget)}+ >+ <Tabs.List layout="full">+ <Tabs.Trigger value="root" label="Root" />+ <Tabs.Trigger value="keyValueMap" label="Key-value map" />+ </Tabs.List>+ </Tabs>+ </div></div>{config.type === "root" && (diff --git a/web/src/features/evals/components/eval-template-type-selector.tsx b/web/src/features/evals/components/eval-template-type-selector.tsxindex aae3f52ef1..99b9fed0df 100644--- a/web/src/features/evals/components/eval-template-type-selector.tsx+++ b/web/src/features/evals/components/eval-template-type-selector.tsx@@ -14,7 +14,7 @@ import {FormLabel,FormMessage,} from "@/src/components/ui/form";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { type templateFormSchema } from "@/src/features/evals/utils/template-form-schema";import {type CodeEvalSourceCodeLanguage,@@ -114,32 +114,32 @@ export function EvalTemplateTypeSelector({)}>- <TabsList className="grid w-fit max-w-fit grid-flow-col gap-4">+ <Tabs.List layout="packed" gap="lg">{mode === "all" ? (- <TabsTrigger- value={EvalTemplateType.LLM_AS_JUDGE}- className="min-w-[100px]"- >- LLM-as-judge- </TabsTrigger>+ <span className="min-w-[100px]">+ <Tabs.Trigger+ value={EvalTemplateType.LLM_AS_JUDGE}+ label="LLM-as-judge"+ />+ </span>) : null}- <TabsTrigger- value={EvalTemplateSourceCodeLanguage.TYPESCRIPT}- className="min-w-[100px]"- >- TypeScript- </TabsTrigger>+ <span className="min-w-[100px]">+ <Tabs.Trigger+ value={EvalTemplateSourceCodeLanguage.TYPESCRIPT}+ label="TypeScript"+ />+ </span>{codeEvalCapabilities.supportedSourceCodeLanguages.includes(EvalTemplateSourceCodeLanguage.PYTHON,) ? (- <TabsTrigger- value={EvalTemplateSourceCodeLanguage.PYTHON}- className="min-w-[100px]"- >- Python- </TabsTrigger>+ <span className="min-w-[100px]">+ <Tabs.Trigger+ value={EvalTemplateSourceCodeLanguage.PYTHON}+ label="Python"+ />+ </span>) : null}- </TabsList>+ </Tabs.List></Tabs></FormControl><FormMessage />diff --git a/web/src/features/evals/components/inner-evaluator-form.tsx b/web/src/features/evals/components/inner-evaluator-form.tsxindex 193aad2a46..9b5b35839f 100644--- a/web/src/features/evals/components/inner-evaluator-form.tsx+++ b/web/src/features/evals/components/inner-evaluator-form.tsx@@ -12,7 +12,7 @@ import {FormMessage,} from "@/src/components/ui/form";import { zodResolver } from "@hookform/resolvers/zod";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { Badge } from "@/src/components/ui/badge";import {tracesTableColsWithOptions,@@ -885,41 +885,44 @@ export const InnerEvaluatorForm = (props: {}}}>- <TabsList className="grid w-fit max-w-fit grid-flow-col gap-4">- <TabsTrigger- value="event"- disabled={props.disabled || props.mode === "edit"}- className="min-w-[100px] gap-1.5"- >- <CircleDot className="h-3.5 w-3.5" />- Observations- </TabsTrigger>- {showLegacyTargetOptions && (- <TabsTrigger- value="trace"+ <Tabs.List layout="packed" gap="lg">+ <span className="min-w-[100px]">+ <Tabs.Trigger+ value="event"disabled={props.disabled || props.mode === "edit"}- className="min-w-[100px] gap-1.5"- >- <ListTree className="h-3.5 w-3.5" />- Traces- <Badge- variant="secondary"- size="sm"- className="border-border border font-normal"+ icon={CircleDot}+ label="Observations"+ />+ </span>+ {showLegacyTargetOptions && (+ <span className="min-w-[100px]">+ <Tabs.Trigger+ value="trace"+ disabled={+ props.disabled || props.mode === "edit"+ }+ icon={ListTree}>- Legacy- </Badge>- </TabsTrigger>+ Traces+ <Badge+ variant="secondary"+ size="sm"+ className="border-border border font-normal"+ >+ Legacy+ </Badge>+ </Tabs.Trigger>+ </span>)}- <TabsTrigger- value="offline-experiment"- disabled={props.disabled || props.mode === "edit"}- className="min-w-[100px] gap-1.5"- >- <FlaskConical className="h-3.5 w-3.5" />- Experiments- </TabsTrigger>- </TabsList>+ <span className="min-w-[100px]">+ <Tabs.Trigger+ value="offline-experiment"+ disabled={props.disabled || props.mode === "edit"}+ icon={FlaskConical}+ label="Experiments"+ />+ </span>+ </Tabs.List></Tabs></FormControl><FormMessage />@@ -966,31 +969,32 @@ export const InnerEvaluatorForm = (props: {);}}>- <TabsList className="grid w-fit max-w-fit grid-flow-col gap-4">- <TabsTrigger- value="otel"- className="min-w-[100px] gap-1.5"- disabled={props.mode === "edit" || props.disabled}- >- <FlaskConical className="h-3.5 w-3.5" />- Experiment Runner SDK- </TabsTrigger>- <TabsTrigger- value="non-otel"- className="min-w-[100px] gap-1.5"- disabled={props.mode === "edit" || props.disabled}- >- <BetweenHorizonalStart className="h-3.5 w-3.5" />- Low-level SDK methods- <Badge- variant="secondary"- size="sm"- className="border-border border font-normal"+ <Tabs.List layout="packed" gap="lg">+ <span className="min-w-[100px]">+ <Tabs.Trigger+ value="otel"+ disabled={props.mode === "edit" || props.disabled}+ icon={FlaskConical}+ label="Experiment Runner SDK"+ />+ </span>+ <span className="min-w-[100px]">+ <Tabs.Trigger+ value="non-otel"+ disabled={props.mode === "edit" || props.disabled}+ icon={BetweenHorizonalStart}>- Legacy- </Badge>- </TabsTrigger>- </TabsList>+ Low-level SDK methods+ <Badge+ variant="secondary"+ size="sm"+ className="border-border border font-normal"+ >+ Legacy+ </Badge>+ </Tabs.Trigger>+ </span>+ </Tabs.List></Tabs></div>)}diff --git a/web/src/features/evals/v2/components/Evaluators/Code/EvaluatorCodeLanguageSelector/EvaluatorCodeLanguageSelector.tsx b/web/src/features/evals/v2/components/Evaluators/Code/EvaluatorCodeLanguageSelector/EvaluatorCodeLanguageSelector.tsxindex 7df9587766..7eccec4a83 100644--- a/web/src/features/evals/v2/components/Evaluators/Code/EvaluatorCodeLanguageSelector/EvaluatorCodeLanguageSelector.tsx+++ b/web/src/features/evals/v2/components/Evaluators/Code/EvaluatorCodeLanguageSelector/EvaluatorCodeLanguageSelector.tsx@@ -4,7 +4,7 @@ import {type EvalTemplateSourceCodeLanguage,} from "@langfuse/shared";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { sourceCodeLanguageLabel } from "@/src/features/evals/v2/fns/evaluators/sourceCodeLanguageLabel";/** Selects the runtime language for a code evaluator. */@@ -24,26 +24,24 @@ export function EvaluatorCodeLanguageSelector({onValueChange(language as EvalTemplateSourceCodeLanguage)}>- <TabsList className="bg-background **:data-[state=active]:bg-muted border">- <TabsTrigger+ <Tabs.List variant="outline">+ <Tabs.Triggervalue={EvalTemplateSourceCodeLanguageEnum.PYTHON}- className="gap-1.5 leading-none"disabled={disabled}><SiPython className="h-3.5 w-3.5 shrink-0" />{sourceCodeLanguageLabel(EvalTemplateSourceCodeLanguageEnum.PYTHON)}- </TabsTrigger>- <TabsTrigger+ </Tabs.Trigger>+ <Tabs.Triggervalue={EvalTemplateSourceCodeLanguageEnum.TYPESCRIPT}- className="gap-1.5 leading-none"disabled={disabled}><SiTypescript className="h-3.5 w-3.5 shrink-0" />{sourceCodeLanguageLabel(EvalTemplateSourceCodeLanguageEnum.TYPESCRIPT,)}- </TabsTrigger>- </TabsList>+ </Tabs.Trigger>+ </Tabs.List></Tabs>);}diff --git a/web/src/features/evals/v2/components/Evaluators/EvaluationTypeConfiguration/components/EvaluationTypeToggle/EvaluationTypeToggle.tsx b/web/src/features/evals/v2/components/Evaluators/EvaluationTypeConfiguration/components/EvaluationTypeToggle/EvaluationTypeToggle.tsxindex e336201bd1..106b0f8122 100644--- a/web/src/features/evals/v2/components/Evaluators/EvaluationTypeConfiguration/components/EvaluationTypeToggle/EvaluationTypeToggle.tsx+++ b/web/src/features/evals/v2/components/Evaluators/EvaluationTypeConfiguration/components/EvaluationTypeToggle/EvaluationTypeToggle.tsx@@ -1,7 +1,7 @@import { Code2, Sparkles } from "lucide-react";import { EvalTemplateTypeEnum, type EvalTemplateType } from "@langfuse/shared";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";/** Selects the evaluator implementation. */export function EvaluationTypeToggle({@@ -18,28 +18,24 @@ export function EvaluationTypeToggle({value={value}onValueChange={(mode) => onValueChange(mode as EvalTemplateType)}>- <TabsList className="bg-background **:data-[state=active]:bg-muted border">+ <Tabs.List variant="outline">{!disabled || value === EvalTemplateTypeEnum.LLM_AS_JUDGE ? (- <TabsTrigger+ <Tabs.Triggervalue={EvalTemplateTypeEnum.LLM_AS_JUDGE}- className="gap-1.5 leading-none"disabled={disabled}- >- <Sparkles className="h-3.5 w-3.5 shrink-0" />- LLM-as-a-judge- </TabsTrigger>+ icon={Sparkles}+ label="LLM-as-a-judge"+ />) : null}{!disabled || value === EvalTemplateTypeEnum.CODE ? (- <TabsTrigger+ <Tabs.Triggervalue={EvalTemplateTypeEnum.CODE}- className="gap-1.5 leading-none"disabled={disabled}- >- <Code2 className="h-3.5 w-3.5 shrink-0" />- Code evaluator- </TabsTrigger>+ icon={Code2}+ label="Code evaluator"+ />) : null}- </TabsList>+ </Tabs.List></Tabs>);}diff --git a/web/src/features/in-app-agent/components/InAppAgentWindow.tsx b/web/src/features/in-app-agent/components/InAppAgentWindow.tsxindex 3a7533dd40..5e623db745 100644--- a/web/src/features/in-app-agent/components/InAppAgentWindow.tsx+++ b/web/src/features/in-app-agent/components/InAppAgentWindow.tsx@@ -81,7 +81,7 @@ import {type InAppAgentSubmitOptions,} from "@/src/features/in-app-agent/quickActions";import { usePostHogClientCapture } from "@/src/features/posthog-analytics";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";const AUTO_SCROLL_THRESHOLD_PX = 50;const SCROLL_DIRECTION_TOLERANCE_PX = 1;@@ -137,31 +137,35 @@ function InAppAgentQuickActionPicker({<p className="text-muted-foreground mt-1 max-w-xs text-center text-xs leading-relaxed">What do you want to do?</p>- <Tabs- value={selectedContext}- className="mt-4 w-full max-w-sm"- onValueChange={(value) => {- if (isInAppAgentQuickActionContext(value)) {- setSelectedContext(value);- }- }}- >- <TabsList- aria-label="Quick action category"- className="flex h-auto w-full rounded-none border-b bg-transparent p-0"+ <div className="mt-4 w-full max-w-sm">+ <Tabs+ value={selectedContext}+ onValueChange={(value) => {+ if (isInAppAgentQuickActionContext(value)) {+ setSelectedContext(value);+ }+ }}>- {IN_APP_AGENT_QUICK_ACTION_CONTEXTS.map((context) => (- <TabsTrigger- key={context}- value={context}- disabled={isDisabled}- className="text-muted-foreground data-[state=active]:border-primary-accent data-[state=active]:text-foreground h-7 min-w-0 flex-1 rounded-none border-b-2 border-transparent bg-transparent px-1 text-xs shadow-none data-[state=active]:bg-transparent data-[state=active]:shadow-none"- >- {IN_APP_AGENT_QUICK_ACTION_CONTEXT_LABELS[context]}- </TabsTrigger>- ))}- </TabsList>- </Tabs>+ <Tabs.List+ aria-label="Quick action category"+ variant="underline"+ size="auto"+ layout="full"+ >+ {IN_APP_AGENT_QUICK_ACTION_CONTEXTS.map((context) => (+ <span key={context} className="min-w-0 flex-1">+ <Tabs.Trigger+ value={context}+ disabled={isDisabled}+ variant="underline"+ size="lg"+ label={IN_APP_AGENT_QUICK_ACTION_CONTEXT_LABELS[context]}+ />+ </span>+ ))}+ </Tabs.List>+ </Tabs>+ </div><div className="mt-3 grid w-full max-w-sm grid-cols-1 gap-2">{selectedActions.map((action, position) => {const ActionIcon = action.icon ?? contextFallbackIcon;diff --git a/web/src/features/prompts/components/NewPromptForm/index.tsx b/web/src/features/prompts/components/NewPromptForm/index.tsxindex 95c18652e0..f59c11c8da 100644--- a/web/src/features/prompts/components/NewPromptForm/index.tsx+++ b/web/src/features/prompts/components/NewPromptForm/index.tsx@@ -13,12 +13,7 @@ import {FormLabel,FormMessage,} from "@/src/components/ui/form";-import {- Tabs,- TabsContent,- TabsList,- TabsTrigger,-} from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { Textarea } from "@/src/components/ui/textarea";import useProjectIdFromURL from "@/src/hooks/useProjectIdFromURL";import { api, reportTrpcErrorWithoutToast } from "@/src/utils/api";@@ -300,28 +295,28 @@ export const NewPromptForm: React.FC<NewPromptFormProps> = (props) => {}}>{!initialPrompt ? (- <TabsList className="flex w-full">- <TabsTrigger- disabled={- Boolean(initialPromptVariant) &&- initialPromptVariant?.type !== PromptType.Text- }- className="flex-1"- value={PromptType.Text}- >- {capitalize(PromptType.Text)}- </TabsTrigger>- <TabsTrigger- disabled={- Boolean(initialPromptVariant) &&- initialPromptVariant?.type !== PromptType.Chat- }- className="flex-1"- value={PromptType.Chat}- >- {capitalize(PromptType.Chat)}- </TabsTrigger>- </TabsList>+ <Tabs.List layout="full">+ <span className="flex-1">+ <Tabs.Trigger+ disabled={+ Boolean(initialPromptVariant) &&+ initialPromptVariant?.type !== PromptType.Text+ }+ value={PromptType.Text}+ label={capitalize(PromptType.Text)}+ />+ </span>+ <span className="flex-1">+ <Tabs.Trigger+ disabled={+ Boolean(initialPromptVariant) &&+ initialPromptVariant?.type !== PromptType.Chat+ }+ value={PromptType.Chat}+ label={capitalize(PromptType.Chat)}+ />+ </span>+ </Tabs.List>) : null}{hadDraft && (<p@@ -345,41 +340,45 @@ export const NewPromptForm: React.FC<NewPromptFormProps> = (props) => {</button></p>)}- <TabsContent value={PromptType.Text}>- <FormField- control={form.control}- name="textPrompt"- render={({ field }) => (- <>- <FormControl>- <PromptLinkingEditor- value={field.value}- onChange={field.onChange}- onBlur={field.onBlur}- minHeight={200}+ <div className="mt-2">+ <Tabs.Content value={PromptType.Text}>+ <FormField+ control={form.control}+ name="textPrompt"+ render={({ field }) => (+ <>+ <FormControl>+ <PromptLinkingEditor+ value={field.value}+ onChange={field.onChange}+ onBlur={field.onBlur}+ minHeight={200}+ />+ </FormControl>+ <FormMessage />+ </>+ )}+ />+ </Tabs.Content>+ </div>+ <div className="mt-2">+ <Tabs.Content value={PromptType.Chat}>+ <FormField+ control={form.control}+ name="chatPrompt"+ render={({ field }) => (+ <>+ <PromptChatMessages+ {...field}+ initialMessages={initialMessages}+ projectId={projectId}/>- </FormControl>- <FormMessage />- </>- )}- />- </TabsContent>- <TabsContent value={PromptType.Chat}>- <FormField- control={form.control}- name="chatPrompt"- render={({ field }) => (- <>- <PromptChatMessages- {...field}- initialMessages={initialMessages}- projectId={projectId}- />- <FormMessage />- </>- )}- />- </TabsContent>+ <FormMessage />+ </>+ )}+ />+ </Tabs.Content>+ </div></Tabs></FormItem><PromptVariableListPreview variables={currentExtractedVariables} />diff --git a/web/src/features/prompts/components/prompt-detail.tsx b/web/src/features/prompts/components/prompt-detail.tsxindex 7a9b3c9749..aad763bc06 100644--- a/web/src/features/prompts/components/prompt-detail.tsx+++ b/web/src/features/prompts/components/prompt-detail.tsx@@ -14,7 +14,7 @@ import {TabsBarContent,TabsBarTrigger,} from "@/src/components/ui/tabs-bar";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { Badge } from "@/src/components/ui/badge";import { CodeView, JSONView } from "@/src/components/ui/CodeJsonViewer";import { DetailPageNav } from "@/src/features/navigate-detail-pages/DetailPageNav";@@ -578,20 +578,18 @@ export const PromptDetail = ({setResolutionMode(value as "tagged" | "resolved");}}>- <TabsList className="h-auto gap-1">- <TabsTrigger+ <Tabs.List gap="sm" size="auto">+ <Tabs.Triggervalue="resolved"- className="h-fit px-1 text-xs"- >- Resolved prompt- </TabsTrigger>- <TabsTrigger+ size="sm"+ label="Resolved prompt"+ />+ <Tabs.Triggervalue="tagged"- className="h-fit px-1 text-xs"- >- Tagged prompt- </TabsTrigger>- </TabsList>+ size="sm"+ label="Tagged prompt"+ />+ </Tabs.List></Tabs></div>)}diff --git a/web/src/features/public-api/components/CreateLLMApiKeyForm.tsx b/web/src/features/public-api/components/CreateLLMApiKeyForm.tsxindex f99121e6e2..7950154f23 100644--- a/web/src/features/public-api/components/CreateLLMApiKeyForm.tsx+++ b/web/src/features/public-api/components/CreateLLMApiKeyForm.tsx@@ -32,9 +32,8 @@ import {SelectValue,} from "@/src/components/ui/select";import { Switch } from "@/src/components/design-system/Switch/Switch";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { api, reportNonTrpcError, type RouterOutputs } from "@/src/utils/api";-import { cn } from "@/src/utils/tailwind";import { usePostHogClientCapture } from "@/src/features/posthog-analytics";import { type useUiCustomization } from "@/src/ee/features/ui-customization/useUiCustomization";import { DialogFooter, DialogBody } from "@/src/components/ui/dialog";@@ -790,33 +789,27 @@ export function CreateLLMApiKeyForm({Select how Langfuse should authenticate to Bedrock.</FormDescription><FormControl>- <Tabs- value={field.value}- onValueChange={(value) =>- field.onChange(value as BedrockAuthMethod)- }- className="w-full"- >- <TabsList- className={cn(- "grid h-auto w-full gap-1",- "grid-cols-2",- )}+ <div className="w-full">+ <Tabs+ value={field.value}+ onValueChange={(value) =>+ field.onChange(value as BedrockAuthMethod)+ }>- <TabsTrigger- value={AuthMethod.AccessKeys}- className="text-xs"- >- AWS access keys- </TabsTrigger>- <TabsTrigger- value={AuthMethod.ApiKey}- className="text-xs"- >- API key- </TabsTrigger>- </TabsList>- </Tabs>+ <Tabs.List layout="full" gap="sm" size="auto">+ <Tabs.Trigger+ value={AuthMethod.AccessKeys}+ size="sm"+ label="AWS access keys"+ />+ <Tabs.Trigger+ value={AuthMethod.ApiKey}+ size="sm"+ label="API key"+ />+ </Tabs.List>+ </Tabs>+ </div></FormControl><FormMessage /></FormItem>diff --git a/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx b/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsxindex d235d2dacb..c09c3fa1d9 100644--- a/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx+++ b/web/src/features/score-analytics/components/cards/DistributionBooleanCard.tsx@@ -6,7 +6,7 @@ import {CardHeader,CardTitle,} from "@/src/components/ui/card";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { useScoreAnalytics } from "../ScoreAnalyticsProvider";import { ScoreDistributionBooleanChart } from "../charts/ScoreDistributionBooleanChart";import { SamplingDetailsHoverCard } from "../SamplingDetailsHoverCard";@@ -156,12 +156,6 @@ export function DistributionBooleanCard() {const hasData = distribution1Data.length > 0;const showTabs = mode === "two";- // Helper function to truncate tab labels with max character limit- const truncateLabel = (label: string): string => {- if (label.length <= 20) return label;- return label.substring(0, 17) + "...";- };-// Build full tab labels for title attribute (hover tooltip)const score1FullLabel =score1.name === score2?.name@@ -197,28 +191,20 @@ export function DistributionBooleanCard() {value={activeTab}onValueChange={(v) => setActiveTab(v as DistributionTab)}>- <TabsList className="h-7">- <TabsTrigger+ <Tabs.List size="md">+ <Tabs.Triggervalue="score1"- title={score1FullLabel}- className="h-5 px-2 text-xs"- >- {truncateLabel(score1FullLabel)}- </TabsTrigger>- <TabsTrigger+ size="sm"+ label={score1FullLabel}+ />+ <Tabs.Triggervalue="score2"- title={score2FullLabel}- className="h-5 px-2 text-xs"- >- {truncateLabel(score2FullLabel)}- </TabsTrigger>- <TabsTrigger value="all" className="h-5 px-2 text-xs">- all- </TabsTrigger>- <TabsTrigger value="matched" className="h-5 px-2 text-xs">- matched- </TabsTrigger>- </TabsList>+ size="sm"+ label={score2FullLabel}+ />+ <Tabs.Trigger value="all" size="sm" label="all" />+ <Tabs.Trigger value="matched" size="sm" label="matched" />+ </Tabs.List></Tabs>)}</div>diff --git a/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx b/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsxindex da73f3cbe6..acf59d33e5 100644--- a/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx+++ b/web/src/features/score-analytics/components/cards/DistributionCategoricalCard.tsx@@ -6,7 +6,7 @@ import {CardHeader,CardTitle,} from "@/src/components/ui/card";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { useScoreAnalytics } from "../ScoreAnalyticsProvider";import { ScoreDistributionCategoricalChart } from "../charts/ScoreDistributionCategoricalChart";import { getScoreCategoryColors } from "../../lib/color-scales";@@ -247,12 +247,6 @@ export function DistributionCategoricalCard() {(chartData.stackedDistribution && chartData.stackedDistribution.length > 0);const showTabs = mode === "two";- // Helper function to truncate tab labels with max character limit- const truncateLabel = (label: string): string => {- if (label.length <= 20) return label;- return label.substring(0, 17) + "...";- };-// Build full tab labels for title attribute (hover tooltip)const score1FullLabel =score1.name === score2?.name@@ -288,28 +282,20 @@ export function DistributionCategoricalCard() {value={activeTab}onValueChange={(v) => setActiveTab(v as DistributionTab)}>- <TabsList className="h-7">- <TabsTrigger+ <Tabs.List size="md">+ <Tabs.Triggervalue="score1"- title={score1FullLabel}- className="h-5 px-2 text-xs"- >- {truncateLabel(score1FullLabel)}- </TabsTrigger>- <TabsTrigger+ size="sm"+ label={score1FullLabel}+ />+ <Tabs.Triggervalue="score2"- title={score2FullLabel}- className="h-5 px-2 text-xs"- >- {truncateLabel(score2FullLabel)}- </TabsTrigger>- <TabsTrigger value="all" className="h-5 px-2 text-xs">- all- </TabsTrigger>- <TabsTrigger value="matched" className="h-5 px-2 text-xs">- matched- </TabsTrigger>- </TabsList>+ size="sm"+ label={score2FullLabel}+ />+ <Tabs.Trigger value="all" size="sm" label="all" />+ <Tabs.Trigger value="matched" size="sm" label="matched" />+ </Tabs.List></Tabs>)}</div>diff --git a/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx b/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsxindex 2ea6f520c7..11a846b60b 100644--- a/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx+++ b/web/src/features/score-analytics/components/cards/DistributionNumericCard.tsx@@ -6,7 +6,7 @@ import {CardHeader,CardTitle,} from "@/src/components/ui/card";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { useScoreAnalytics } from "../ScoreAnalyticsProvider";import { ScoreDistributionNumericChart } from "../charts/ScoreDistributionNumericChart";import { SamplingDetailsHoverCard } from "../SamplingDetailsHoverCard";@@ -184,12 +184,6 @@ export function DistributionNumericCard() {const hasData = (distribution1Data?.length ?? 0) > 0;const showTabs = mode === "two";- // Helper function to truncate tab labels with max character limit- const truncateLabel = (label: string): string => {- if (label.length <= 20) return label;- return label.substring(0, 17) + "...";- };-// Build full tab labels for title attribute (hover tooltip)const score1FullLabel =score1.name === score2?.name@@ -225,28 +219,20 @@ export function DistributionNumericCard() {value={activeTab}onValueChange={(v) => setActiveTab(v as DistributionTab)}>- <TabsList className="h-7">- <TabsTrigger+ <Tabs.List size="md">+ <Tabs.Triggervalue="score1"- title={score1FullLabel}- className="h-5 px-2 text-xs"- >- {truncateLabel(score1FullLabel)}- </TabsTrigger>- <TabsTrigger+ size="sm"+ label={score1FullLabel}+ />+ <Tabs.Triggervalue="score2"- title={score2FullLabel}- className="h-5 px-2 text-xs"- >- {truncateLabel(score2FullLabel)}- </TabsTrigger>- <TabsTrigger value="all" className="h-5 px-2 text-xs">- all- </TabsTrigger>- <TabsTrigger value="matched" className="h-5 px-2 text-xs">- matched- </TabsTrigger>- </TabsList>+ size="sm"+ label={score2FullLabel}+ />+ <Tabs.Trigger value="all" size="sm" label="all" />+ <Tabs.Trigger value="matched" size="sm" label="matched" />+ </Tabs.List></Tabs>)}</div>diff --git a/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx b/web/src/features/score-analytics/components/cards/TimelineChartCard.tsxindex 32c97266a3..5bd21321f7 100644--- a/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx+++ b/web/src/features/score-analytics/components/cards/TimelineChartCard.tsx@@ -6,7 +6,7 @@ import {CardHeader,CardTitle,} from "@/src/components/ui/card";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { useScoreAnalytics } from "../ScoreAnalyticsProvider";import { ScoreTimeSeriesChart } from "../charts/ScoreTimeSeriesChart";import { SamplingDetailsHoverCard } from "../SamplingDetailsHoverCard";@@ -246,12 +246,6 @@ export function TimelineChartCard() {const hasData = chartData.length > 0;const showTabs = mode === "two";- // Helper function to truncate tab labels with max character limit- const truncateLabel = (label: string): string => {- if (label.length <= 20) return label;- return label.substring(0, 17) + "...";- };-// Build full tab labels for title attribute (hover tooltip)const score1FullLabel =score1.name === score2?.name@@ -287,28 +281,20 @@ export function TimelineChartCard() {value={activeTab}onValueChange={(v) => setActiveTab(v as TimelineTab)}>- <TabsList className="h-7">- <TabsTrigger+ <Tabs.List size="md">+ <Tabs.Triggervalue="score1"- title={score1FullLabel}- className="h-5 px-2 text-xs"- >- {truncateLabel(score1FullLabel)}- </TabsTrigger>- <TabsTrigger+ size="sm"+ label={score1FullLabel}+ />+ <Tabs.Triggervalue="score2"- title={score2FullLabel}- className="h-5 px-2 text-xs"- >- {truncateLabel(score2FullLabel)}- </TabsTrigger>- <TabsTrigger value="all" className="h-5 px-2 text-xs">- all- </TabsTrigger>- <TabsTrigger value="matched" className="h-5 px-2 text-xs">- matched- </TabsTrigger>- </TabsList>+ size="sm"+ label={score2FullLabel}+ />+ <Tabs.Trigger value="all" size="sm" label="all" />+ <Tabs.Trigger value="matched" size="sm" label="matched" />+ </Tabs.List></Tabs>)}</div>diff --git a/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx b/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsxindex 6277620380..ee33bf3d4e 100644--- a/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx+++ b/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx@@ -3,7 +3,7 @@ import { ChevronRight, ChevronDown, Wrench } from "lucide-react";import { Badge } from "@/src/components/ui/badge";import { cn } from "@/src/utils/tailwind";import { PrettyJsonView } from "@/src/components/ui/PrettyJsonView";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import useLocalStorage from "@/src/components/useLocalStorage";import useSessionStorage from "@/src/components/useSessionStorage";import { useMemo, useState } from "react";@@ -369,22 +369,19 @@ function ToolDefinitionRow({{isExpanded && (<div className="border-border bg-muted/30 relative border-t px-4 py-3"><div className="absolute top-1 right-4">- <Tabs- className="h-fit py-0.5"- value={currentView}- onValueChange={(value) =>- setCurrentView(value as "formatted" | "json")- }- >- <TabsList className="h-fit p-0.5">- <TabsTrigger value="formatted" className="h-fit px-1 text-xs">- Formatted- </TabsTrigger>- <TabsTrigger value="json" className="h-fit px-1 text-xs">- JSON- </TabsTrigger>- </TabsList>- </Tabs>+ <div className="h-fit py-0.5">+ <Tabs+ value={currentView}+ onValueChange={(value) =>+ setCurrentView(value as "formatted" | "json")+ }+ >+ <Tabs.List size="sm">+ <Tabs.Trigger value="formatted" size="sm" label="Formatted" />+ <Tabs.Trigger value="json" size="sm" label="JSON" />+ </Tabs.List>+ </Tabs>+ </div></div>{currentView === "formatted" && (diff --git a/web/src/features/traces/components/IOPreview/components/ViewModeToggle.tsx b/web/src/features/traces/components/IOPreview/components/ViewModeToggle.tsxindex 2bb50f9554..915d050c43 100644--- a/web/src/features/traces/components/IOPreview/components/ViewModeToggle.tsx+++ b/web/src/features/traces/components/IOPreview/components/ViewModeToggle.tsx@@ -1,4 +1,4 @@-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import {HoverCard,HoverCardContent,@@ -40,43 +40,41 @@ export function ViewModeToggle({return (<div className="flex w-full flex-row items-center justify-start gap-1.5">- <Tabs- ref={compensateScrollRef}- className="h-fit py-0.5"- value={selectedViewTab}- onValueChange={handleViewTabChange}- >- <TabsList className="h-fit p-0.5">- {showPrettyBeta &&- (prettyBetaDisabled ? (- <HoverCard openDelay={200}>- <HoverCardTrigger asChild>- <TabsTrigger- value="pretty-beta"- className="h-fit px-1 text-xs"- disabled- >- Normalized (beta)- </TabsTrigger>- </HoverCardTrigger>- <HoverCardContent align="start" className="w-64 text-sm">- Shown with the standard parser for now — beta parsing is not- applied to precomputed views yet.- </HoverCardContent>- </HoverCard>- ) : (- <TabsTrigger value="pretty-beta" className="h-fit px-1 text-xs">- Normalized (beta)- </TabsTrigger>- ))}- <TabsTrigger value="pretty" className="h-fit px-1 text-xs">- Formatted- </TabsTrigger>- <TabsTrigger value="json" className="h-fit px-1 text-xs">- JSON- </TabsTrigger>- </TabsList>- </Tabs>+ <div className="h-fit py-0.5">+ <Tabs+ ref={compensateScrollRef}+ value={selectedViewTab}+ onValueChange={handleViewTabChange}+ >+ <Tabs.List size="sm">+ {showPrettyBeta &&+ (prettyBetaDisabled ? (+ <HoverCard openDelay={200}>+ <HoverCardTrigger asChild>+ <Tabs.Trigger+ value="pretty-beta"+ size="sm"+ disabled+ label="Normalized (beta)"+ />+ </HoverCardTrigger>+ <HoverCardContent align="start" className="w-64 text-sm">+ Shown with the standard parser for now — beta parsing is not+ applied to precomputed views yet.+ </HoverCardContent>+ </HoverCard>+ ) : (+ <Tabs.Trigger+ value="pretty-beta"+ size="sm"+ label="Normalized (beta)"+ />+ ))}+ <Tabs.Trigger value="pretty" size="sm" label="Formatted" />+ <Tabs.Trigger value="json" size="sm" label="JSON" />+ </Tabs.List>+ </Tabs>+ </div>{selectedViewTab === "json" && (<div className="flex items-center gap-1.5"><Switchdiff --git a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsxindex b3a8653828..8702713176 100644--- a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx+++ b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx@@ -26,7 +26,7 @@ import {HoverCardContent,HoverCardTrigger,} from "@/src/components/ui/hover-card";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import {TabsBar,TabsBarContent,@@ -371,82 +371,75 @@ export function ConnectedObservationDetailView({{(selectedTab === "log" ||(selectedTab === "preview" && isPrettyViewAvailable)) && (<>- <Tabs- className="ml-auto h-fit px-2 py-0.5"- value={- selectedTab === "log" &&- (isLogViewVirtualized ||- selectedViewTab === "pretty-beta")- ? "pretty"- : selectedViewTab- }- onValueChange={(value) => {- if (+ <div className="ml-auto h-fit px-2 py-0.5">+ <Tabs+ value={selectedTab === "log" &&- isLogViewVirtualized &&- value === "json"- ) {- return;+ (isLogViewVirtualized ||+ selectedViewTab === "pretty-beta")+ ? "pretty"+ : selectedViewTab}- handleViewTabChange(value);- }}- >- <TabsList className="h-fit py-0.5">- {/* Log view never runs the normalized parser, so the+ onValueChange={(value) => {+ if (+ selectedTab === "log" &&+ isLogViewVirtualized &&+ value === "json"+ ) {+ return;+ }+ handleViewTabChange(value);+ }}+ >+ <Tabs.List size="sm">+ {/* Log view never runs the normalized parser, so thebeta tab only renders on the preview tab. */}- {showPrettyBeta && selectedTab !== "log" && (- <TabsTrigger- value="pretty-beta"- className="h-fit px-1 text-xs"- >- Normalized (beta)- </TabsTrigger>- )}- <TabsTrigger- value="pretty"- className="h-fit px-1 text-xs"- >- Formatted- </TabsTrigger>- {selectedTab === "log" && isLogViewVirtualized ? (- <HoverCard openDelay={200}>- <HoverCardTrigger asChild>- <span>- <TabsTrigger- value="json"- className="h-fit px-1 text-xs"- disabled- >- JSON- </TabsTrigger>- </span>- </HoverCardTrigger>- <HoverCardContent- align="end"- className="w-64 text-sm"- sideOffset={8}- >- <p className="font-bold">JSON view unavailable</p>- <p className="text-muted-foreground mt-1">- Disabled for traces with{" "}- {- TRACE_VIEW_CONFIG.logView- .virtualizationThreshold- }- + observations to maintain performance.- </p>- </HoverCardContent>- </HoverCard>- ) : (- <TabsTrigger- value="json"- className="h-fit px-1 text-xs"- >- JSON- </TabsTrigger>- )}- </TabsList>- </Tabs>+ {showPrettyBeta && selectedTab !== "log" && (+ <Tabs.Trigger+ value="pretty-beta"+ size="sm"+ label="Normalized (beta)"+ />+ )}+ <Tabs.Trigger+ value="pretty"+ size="sm"+ label="Formatted"+ />+ {selectedTab === "log" && isLogViewVirtualized ? (+ <HoverCard openDelay={200}>+ <HoverCardTrigger asChild>+ <span>+ <Tabs.Trigger+ value="json"+ size="sm"+ disabled+ label="JSON"+ />+ </span>+ </HoverCardTrigger>+ <HoverCardContent+ align="end"+ className="w-64 text-sm"+ sideOffset={8}+ >+ <p className="font-bold">JSON view unavailable</p>+ <p className="text-muted-foreground mt-1">+ Disabled for traces with{" "}+ {+ TRACE_VIEW_CONFIG.logView+ .virtualizationThreshold+ }+ + observations to maintain performance.+ </p>+ </HoverCardContent>+ </HoverCard>+ ) : (+ <Tabs.Trigger value="json" size="sm" label="JSON" />+ )}+ </Tabs.List>+ </Tabs>+ </div>{selectedViewTab === "json" &&!(selectedTab === "log" && isLogViewVirtualized) && (<div className="mr-1 flex items-center gap-1.5">diff --git a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsxindex 905dc31942..51c0c9d7e7 100644--- a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx+++ b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx@@ -11,7 +11,7 @@ import {TabsBarList,TabsBarTrigger,} from "@/src/components/ui/tabs-bar";-import { Tabs, TabsList, TabsTrigger } from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import { Switch } from "@/src/components/design-system/Switch/Switch";import { useCallback, useMemo, useState } from "react";import { type SelectionData } from "@/src/features/comments/contexts/InlineCommentSelectionContext";@@ -283,81 +283,74 @@ export function TraceDetailView({{(selectedTab === "log" ||(selectedTab === "preview" && isPrettyViewAvailable)) && (<>- <Tabs- className="ml-auto h-fit px-2 py-0.5"- value={- selectedTab === "log" &&- (isLogViewVirtualized ||- selectedViewTab === "pretty-beta")- ? "pretty"- : selectedViewTab- }- onValueChange={(value) => {- // Don't allow JSON views for virtualized log view- if (+ <div className="ml-auto h-fit px-2 py-0.5">+ <Tabs+ value={selectedTab === "log" &&- isLogViewVirtualized &&- value === "json"- ) {- return;+ (isLogViewVirtualized ||+ selectedViewTab === "pretty-beta")+ ? "pretty"+ : selectedViewTab}- handleViewTabChange(value);- }}- >- <TabsList className="h-fit py-0.5">- {/* Log view never runs the normalized parser, so the+ onValueChange={(value) => {+ // Don't allow JSON views for virtualized log view+ if (+ selectedTab === "log" &&+ isLogViewVirtualized &&+ value === "json"+ ) {+ return;+ }+ handleViewTabChange(value);+ }}+ >+ <Tabs.List size="sm">+ {/* Log view never runs the normalized parser, so thebeta tab only renders on the preview tab. */}- {showPrettyBeta && selectedTab !== "log" && (- <TabsTrigger- value="pretty-beta"- className="h-fit px-1 text-xs"- >- Normalized (beta)- </TabsTrigger>- )}- <TabsTrigger- value="pretty"- className="h-fit px-1 text-xs"- >- Formatted- </TabsTrigger>- {selectedTab === "log" && isLogViewVirtualized ? (- <HoverCard openDelay={200}>- <HoverCardTrigger asChild>- <TabsTrigger- value="json"- className="h-fit px-1 text-xs"- disabled+ {showPrettyBeta && selectedTab !== "log" && (+ <Tabs.Trigger+ value="pretty-beta"+ size="sm"+ label="Normalized (beta)"+ />+ )}+ <Tabs.Trigger+ value="pretty"+ size="sm"+ label="Formatted"+ />+ {selectedTab === "log" && isLogViewVirtualized ? (+ <HoverCard openDelay={200}>+ <HoverCardTrigger asChild>+ <Tabs.Trigger+ value="json"+ size="sm"+ disabled+ label="JSON"+ />+ </HoverCardTrigger>+ <HoverCardContent+ align="end"+ className="w-64 text-sm"+ sideOffset={8}>- JSON- </TabsTrigger>- </HoverCardTrigger>- <HoverCardContent- align="end"- className="w-64 text-sm"- sideOffset={8}- >- <p className="font-bold">JSON view unavailable</p>- <p className="text-muted-foreground mt-1">- Disabled for traces with{" "}- {- TRACE_VIEW_CONFIG.logView- .virtualizationThreshold- }- + observations to maintain performance.- </p>- </HoverCardContent>- </HoverCard>- ) : (- <TabsTrigger- value="json"- className="h-fit px-1 text-xs"- >- JSON- </TabsTrigger>- )}- </TabsList>- </Tabs>+ <p className="font-bold">JSON view unavailable</p>+ <p className="text-muted-foreground mt-1">+ Disabled for traces with{" "}+ {+ TRACE_VIEW_CONFIG.logView+ .virtualizationThreshold+ }+ + observations to maintain performance.+ </p>+ </HoverCardContent>+ </HoverCard>+ ) : (+ <Tabs.Trigger value="json" size="sm" label="JSON" />+ )}+ </Tabs.List>+ </Tabs>+ </div>{/* Beta toggle - only show when JSON is selected and not in virtualized log view */}{selectedViewTab === "json" &&!(selectedTab === "log" && isLogViewVirtualized) && (diff --git a/web/src/features/widgets/components/SelectWidgetDialog.tsx b/web/src/features/widgets/components/SelectWidgetDialog.tsxindex e2d5adeaf2..514a353ce3 100644--- a/web/src/features/widgets/components/SelectWidgetDialog.tsx+++ b/web/src/features/widgets/components/SelectWidgetDialog.tsx@@ -11,12 +11,7 @@ import {DialogBody,} from "@/src/components/ui/dialog";import { Button } from "@/src/components/ui/button";-import {- Tabs,- TabsContent,- TabsList,- TabsTrigger,-} from "@/src/components/ui/tabs";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";import startCase from "lodash/startCase";import { getChartTypeDisplayName } from "@/src/features/widgets/chart-library/utils";import { ChartTypeIllustration } from "@/src/features/widgets/components/ChartTypeIllustration";@@ -220,80 +215,86 @@ export function SelectWidgetDialog({capture("dashboard:add_widget_tab_switch", { tab })}>- <TabsList>- <TabsTrigger value="project">- Your widgets ({projectWidgets.length})- </TabsTrigger>+ <Tabs.List>+ <Tabs.Trigger+ value="project"+ label={`Your widgets (${projectWidgets.length})`}+ />{onSelectPreset && (- <TabsTrigger value="home-cards">- Home cards ({suggestedPresetIds.length})- </TabsTrigger>+ <Tabs.Trigger+ value="home-cards"+ label={`Home cards (${suggestedPresetIds.length})`}+ />)}- </TabsList>- <TabsContent value="project">- <div className="flex max-h-[360px] flex-col gap-2 overflow-y-auto p-1">- {projectWidgets.map((widget) => (- <WidgetRow- key={widget.id}- widget={widget as WidgetItem}- onClick={() => selectWidget(widget as WidgetItem)}- />- ))}- {projectWidgets.length === 0 ? (- <div className="text-muted-foreground py-8 text-center text-sm">- {hiddenWidgetsNote ??- "No saved widgets in this project yet — build one with Custom Chart."}- </div>- ) : hiddenWidgetsNote ? (- <div className="text-muted-foreground px-1 py-2 text-xs">- {hiddenWidgetsNote}- </div>- ) : null}- </div>- </TabsContent>- {onSelectPreset && (- <TabsContent value="home-cards">+ </Tabs.List>+ <div className="mt-2">+ <Tabs.Content value="project"><div className="flex max-h-[360px] flex-col gap-2 overflow-y-auto p-1">- {suggestedPresetIds.map((presetId) => {- const meta = HOME_PRESET_METADATA[presetId];- return (- <button- key={presetId}- type="button"- onClick={() => {- capture("dashboard:widget_added", {- kind: "home_preset",- preset_id: presetId,- dashboard_id: dashboardId,- });- onSelectPreset(presetId);- onOpenChange(false);- }}- className={rowClassName}- >- <RowIllustration type={meta.illustration} />- <div className="min-w-0 flex-1">- <div- className="truncate font-bold"- title={meta.name}- >- {meta.name}- </div>- <div- className="text-muted-foreground truncate text-xs"- title={meta.description}- >- {meta.description}- </div>- <div className="text-muted-foreground/80 mt-0.5 text-xs">- Home card · fixed configuration- </div>- </div>- </button>- );- })}+ {projectWidgets.map((widget) => (+ <WidgetRow+ key={widget.id}+ widget={widget as WidgetItem}+ onClick={() => selectWidget(widget as WidgetItem)}+ />+ ))}+ {projectWidgets.length === 0 ? (+ <div className="text-muted-foreground py-8 text-center text-sm">+ {hiddenWidgetsNote ??+ "No saved widgets in this project yet — build one with Custom Chart."}+ </div>+ ) : hiddenWidgetsNote ? (+ <div className="text-muted-foreground px-1 py-2 text-xs">+ {hiddenWidgetsNote}+ </div>+ ) : null}</div>- </TabsContent>+ </Tabs.Content>+ </div>+ {onSelectPreset && (+ <div className="mt-2">+ <Tabs.Content value="home-cards">+ <div className="flex max-h-[360px] flex-col gap-2 overflow-y-auto p-1">+ {suggestedPresetIds.map((presetId) => {+ const meta = HOME_PRESET_METADATA[presetId];+ return (+ <button+ key={presetId}+ type="button"+ onClick={() => {+ capture("dashboard:widget_added", {+ kind: "home_preset",+ preset_id: presetId,+ dashboard_id: dashboardId,+ });+ onSelectPreset(presetId);+ onOpenChange(false);+ }}+ className={rowClassName}+ >+ <RowIllustration type={meta.illustration} />+ <div className="min-w-0 flex-1">+ <div+ className="truncate font-bold"+ title={meta.name}+ >+ {meta.name}+ </div>+ <div+ className="text-muted-foreground truncate text-xs"+ title={meta.description}+ >+ {meta.description}+ </div>+ <div className="text-muted-foreground/80 mt-0.5 text-xs">+ Home card · fixed configuration+ </div>+ </div>+ </button>+ );+ })}+ </div>+ </Tabs.Content>+ </div>)}</Tabs></div>