Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(datasets): escape names in copy and clone name lookups (#19143)

Niklas Semmlera7c216e095bb
diff --git a/web/src/__tests__/server/datasets-trpc.servertest.ts b/web/src/__tests__/server/datasets-trpc.servertest.ts
index 04a0750f33..3b8dd9d746 100644
--- a/web/src/__tests__/server/datasets-trpc.servertest.ts
+++ b/web/src/__tests__/server/datasets-trpc.servertest.ts
@@ -200,6 +200,36 @@ describe("datasets trpc", () => {
});
});
+ describe("datasets.duplicateDataset", () => {
+ it("numbers copies of a dataset whose name contains a backslash", async () => {
+ const { project, caller } = await prepare();
+ const datasetId = v4();
+ await prisma.dataset.create({
+ data: { id: datasetId, name: "team\\a", projectId: project.id },
+ });
+
+ const first = await caller.datasets.duplicateDataset({
+ projectId: project.id,
+ datasetId,
+ });
+ const second = await caller.datasets.duplicateDataset({
+ projectId: project.id,
+ datasetId,
+ });
+
+ expect(second.id).not.toBe(first.id);
+ const names = await prisma.dataset.findMany({
+ where: { projectId: project.id },
+ select: { name: true },
+ });
+ expect(names.map((d) => d.name).sort()).toEqual([
+ "team\\a",
+ "team\\a (copy 1)",
+ "team\\a (copy)",
+ ]);
+ });
+ });
+
describe("datasets.deleteMany", () => {
it("deletes explicitly selected datasets and folder subtrees", async () => {
const { project, caller } = await prepare();
diff --git a/web/src/features/dashboard/server/dashboard-router.ts b/web/src/features/dashboard/server/dashboard-router.ts
index 0503b15dcf..6930b03190 100644
--- a/web/src/features/dashboard/server/dashboard-router.ts
+++ b/web/src/features/dashboard/server/dashboard-router.ts
@@ -20,6 +20,7 @@ import {
getObservationUsageByTypeByTime,
DashboardService,
DashboardDefinitionSchema,
+ escapeSqlLikePattern,
} from "@langfuse/shared/src/server";
import { executeQuery } from "@langfuse/shared/query/server";
import {
@@ -629,7 +630,9 @@ export const dashboardRouter = createTRPCRouter({
const existingClones = await ctx.prisma.dashboard.findMany({
where: {
projectId: input.projectId,
- name: { startsWith: `${sourceDashboard.name} (Clone` },
+ name: {
+ startsWith: `${escapeSqlLikePattern(sourceDashboard.name)} (Clone`,
+ },
},
select: { name: true },
});
diff --git a/web/src/features/datasets/server/dataset-router.ts b/web/src/features/datasets/server/dataset-router.ts
index 4e4b44af7f..fae27cabc4 100644
--- a/web/src/features/datasets/server/dataset-router.ts
+++ b/web/src/features/datasets/server/dataset-router.ts
@@ -1537,7 +1537,7 @@ export const datasetRouter = createTRPCRouter({
where: {
projectId: input.projectId,
name: {
- startsWith: dataset.name + " (copy",
+ startsWith: escapeSqlLikePattern(dataset.name) + " (copy",
},
},
})