Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): session timeline caret size, status icon colors, tool preview overflow (#18620)

Trang Nguyenaa9d7984fcf1
diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.stories.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.stories.tsx
index 3a49f5ade2..9c258a6e7a 100644
--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.stories.tsx
+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.stories.tsx
@@ -1038,11 +1038,29 @@ export const ToolErrorStatus = meta.story({
await waitFor(() =>
expect(overlays.queryByRole("tooltip")).not.toBeInTheDocument(),
);
- await userEvent.click(canvas.getByRole("button", { name: "search" }));
- await expect(canvas.getByRole("button", { name: "search" })).toHaveFocus();
- await expect(indicator).toBeVisible();
- await userEvent.tab();
+ const searchButton = canvas.getByRole("button", { name: "search" });
+ if ("__vitest_browser__" in globalThis) {
+ // Real pointer and keyboard events: a mouse click must not pin the
+ // indicator, while keyboard focus still reaches and reveals it.
+ const { userEvent: browserUserEvent } = await import("vitest/browser");
+ // Earlier synthetic clicks left keyboard-style focus on the button.
+ searchButton.blur();
+ await browserUserEvent.click(searchButton);
+ await browserUserEvent.unhover(searchButton);
+ await expect(searchButton).toHaveFocus();
+ if (message.level === "WARNING" || message.level === "ERROR") {
+ await expect(indicator).toBeVisible();
+ } else {
+ await expect(indicator).not.toBeVisible();
+ }
+ await browserUserEvent.keyboard("{Tab}");
+ } else {
+ await userEvent.click(searchButton);
+ await expect(searchButton).toHaveFocus();
+ await userEvent.tab();
+ }
await expect(indicator).toHaveFocus();
+ await expect(indicator).toBeVisible();
await expect(await overlays.findByRole("tooltip")).toHaveTextContent(
message.statusMessage,
);
diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/SessionTranscriptContent.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/SessionTranscriptContent.tsx
index 993719e5be..05cfc99ecd 100644
--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/SessionTranscriptContent.tsx
+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/SessionTranscriptContent.tsx
@@ -166,7 +166,7 @@ function SessionTranscriptRow({
const isSystem = row.message.role === "system";
const metadata = (isTool || isSystem) &&
(timing || row.message.observationId) && (
- <div className="text-muted-foreground invisible flex items-center gap-3 font-mono text-xs group-focus-within/collapsible-row:visible group-hover/collapsible-row:visible group-data-[expanded=true]/collapsible-row:visible">
+ <div className="text-muted-foreground flex items-center gap-3 font-mono text-xs opacity-0 group-hover/collapsible-row:opacity-100 group-has-[:focus-visible]/collapsible-row:opacity-100 group-data-[expanded=true]/collapsible-row:opacity-100">
{row.message.observationId && (
<button
type="button"
diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/components/SessionTimelineCollapsibleRow/SessionTimelineCollapsibleRow.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/components/SessionTimelineCollapsibleRow/SessionTimelineCollapsibleRow.tsx
index 6bdb10b090..479fc69224 100644
--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/components/SessionTimelineCollapsibleRow/SessionTimelineCollapsibleRow.tsx
+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/components/SessionTimelineCollapsibleRow/SessionTimelineCollapsibleRow.tsx
@@ -87,7 +87,7 @@ export function SessionTimelineCollapsibleRow({
>
<ChevronDown
className={cn(
- "icon-base transition-transform",
+ "icon-sm transition-transform",
!isExpanded && "-rotate-90",
)}
aria-hidden="true"
@@ -98,7 +98,7 @@ export function SessionTimelineCollapsibleRow({
className={cn(
"mx-3 min-w-0 flex-1",
showHoverDivider &&
- "border-border invisible border-t border-dashed group-focus-within/collapsible-row:visible group-hover/collapsible-row:visible",
+ "border-border invisible border-t border-dashed group-hover/collapsible-row:visible group-has-[:focus-visible]/collapsible-row:visible",
)}
aria-hidden="true"
/>
diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/components/SessionTimelineToolRow/SessionTimelineToolRow.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/components/SessionTimelineToolRow/SessionTimelineToolRow.tsx
index 037f740791..9505807dcc 100644
--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/components/SessionTimelineToolRow/SessionTimelineToolRow.tsx
+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/components/SessionTranscriptContent/components/SessionTimelineToolRow/SessionTimelineToolRow.tsx
@@ -72,12 +72,12 @@ export function SessionTimelineToolRow({
"ml-1 flex shrink-0 items-center",
(
{
- ERROR: "text-destructive",
- WARNING: "text-yellow-600 dark:text-yellow-500",
+ ERROR: "dark:text-dark-red/90 text-red-800",
+ WARNING: "dark:text-dark-yellow text-yellow-800",
DEFAULT:
- "text-muted-foreground invisible group-focus-within/collapsible-row:visible group-hover/collapsible-row:visible group-data-[expanded=true]/collapsible-row:visible",
+ "text-muted-foreground opacity-0 group-hover/collapsible-row:opacity-100 group-has-[:focus-visible]/collapsible-row:opacity-100 group-data-[expanded=true]/collapsible-row:opacity-100",
DEBUG:
- "text-muted-foreground invisible group-focus-within/collapsible-row:visible group-hover/collapsible-row:visible group-data-[expanded=true]/collapsible-row:visible",
+ "text-muted-foreground opacity-0 group-hover/collapsible-row:opacity-100 group-has-[:focus-visible]/collapsible-row:opacity-100 group-data-[expanded=true]/collapsible-row:opacity-100",
} satisfies Record<Observation["level"], string>
)[level],
)}
@@ -96,7 +96,7 @@ export function SessionTimelineToolRow({
<span className="text-muted-foreground font-mono text-[10px] font-bold uppercase">
Input
</span>
- <div className="grid max-h-48 min-w-0">
+ <div className="flex max-h-48 min-w-0 flex-col">
<Codeblock label="Tool input" value={input} allowFormatting />
</div>
</div>
@@ -107,7 +107,7 @@ export function SessionTimelineToolRow({
Output
</span>
{outputContent ?? (
- <div className="grid max-h-96 min-w-0">
+ <div className="flex max-h-96 min-w-0 flex-col">
<Codeblock label="Tool output" value={output} allowFormatting />
</div>
)}