🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(sessions): stop preset recovery from looping on unchanged state (#17329)
Nikita Kabardinac06eae9d008
diff --git a/web/src/features/filters/hooks/useKeyedSessionStorageState.ts b/web/src/features/filters/hooks/useKeyedSessionStorageState.tsindex f149252ebd..99ce86937d 100644--- a/web/src/features/filters/hooks/useKeyedSessionStorageState.ts+++ b/web/src/features/filters/hooks/useKeyedSessionStorageState.ts@@ -62,6 +62,13 @@ export function useKeyedSessionStorageState<T>(? (next as (value: T) => T)(baseValue): next;+ if (+ previous.key === storageKey &&+ Object.is(previous.value, resolved)+ ) {+ return previous;+ }+return {key: storageKey,value: resolved,diff --git a/web/src/features/filters/viewStateHistoryWrites.clienttest.tsx b/web/src/features/filters/viewStateHistoryWrites.clienttest.tsxindex 055923122f..2514c83a76 100644--- a/web/src/features/filters/viewStateHistoryWrites.clienttest.tsx+++ b/web/src/features/filters/viewStateHistoryWrites.clienttest.tsx@@ -1,6 +1,17 @@-import { fireEvent, render, screen, waitFor } from "@testing-library/react";+import {+ act,+ fireEvent,+ render,+ screen,+ waitFor,+} from "@testing-library/react";import { TableViewPresetTableName, type FilterState } from "@langfuse/shared";-import { useState } from "react";+import { useEffect, useState } from "react";+import {+ QueryParamProvider,+ type QueryParamAdapterComponent,+ useQueryParam,+} from "use-query-params";import { useSidebarFilterState } from "./hooks/useSidebarFilterState";import type { FilterConfig } from "./lib/filter-config";import { useTableViewManager } from "../../components/table/table-view-presets/hooks/useTableViewManager";@@ -60,12 +71,9 @@ vi.mock("use-query-params", async () => {const React = require("react");const actual = await vi.importActual("use-query-params");- const StringParam = { __type: "string" } as const;-return {...actual,- StringParam,- useQueryParam: (key: string) => {+ useQueryParam: vi.fn(function useMockQueryParam(key: string) {const initialValue = queryParamStore.has(key)? queryParamStore.get(key): null;@@ -96,7 +104,7 @@ vi.mock("use-query-params", async () => {);return [value, setQueryValue];- },+ }),};});@@ -196,6 +204,7 @@ function FilterStateHarness() {describe("view-state URL writes and browser history (LFE-10715)", () => {beforeEach(() => {vi.clearAllMocks();+ vi.mocked(useQueryParam).mockReset();sessionStorage.clear();queryParamStore.clear();urlParamWrites.length = 0;@@ -238,6 +247,76 @@ describe("view-state URL writes and browser history (LFE-10715)", () => {}});+ it("settles session preset recovery while URL updates are batched", async () => {+ const actual = await vi.importActual<{+ useQueryParam: typeof useQueryParam;+ }>("use-query-params");+ const presetId = "__langfuse_with_io__";+ const recoverPreset = vi.fn(() => {+ if (recoverPreset.mock.calls.length > 20) {+ throw new Error("Session preset recovery did not settle");+ }+ });++ const Adapter: QueryParamAdapterComponent = ({ children }) => {+ const [location, setLocation] = useState({+ search: `?viewId=${presetId}`,+ });+ return children({ location, replace: setLocation, push: setLocation });+ };++ function SessionPresetRecoveryHarness() {+ const viewControllers = useTableViewManager({+ tableName: TableViewPresetTableName.SessionDetail,+ projectId: "project-1",+ stateUpdaters: {+ setColumnOrder: () => {},+ setColumnVisibility: () => {},+ },+ });++ // Session detail restores a matching frontend preset after URL stripping.+ useEffect(() => {+ if (viewControllers.isLoading || viewControllers.selectedViewId) return;+ recoverPreset();+ viewControllers.handleSetViewId(presetId, { updateType: "replaceIn" });+ }, [viewControllers]);++ return (+ <div data-testid="recovered-view-id">+ {viewControllers.selectedViewId ?? "null"}+ </div>+ );+ }++ vi.useFakeTimers();+ try {+ await vi+ .mocked(useQueryParam)+ .withImplementation(actual.useQueryParam, () => {+ render(+ <QueryParamProvider+ adapter={Adapter}+ options={{ enableBatching: true }}+ >+ <SessionPresetRecoveryHarness />+ </QueryParamProvider>,+ );++ act(() => vi.runOnlyPendingTimers());+ act(() => vi.runOnlyPendingTimers());++ expect(screen.getByTestId("recovered-view-id").textContent).toBe(+ presetId,+ );+ expect(recoverPreset).toHaveBeenCalled();+ });+ } finally {+ act(() => vi.runOnlyPendingTimers());+ vi.useRealTimers();+ }+ });+it("auto-applies a resolved default view with replacements, not pushes", async () => {// Personal and project defaults have the same resolved client shape. The// manager branches on viewId, not scope, so one regression covers both.