Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): Move tags to trace header. Switch component (use badge instead of button) (#17569)

Trang Nguyenaefcbb103f2b
diff --git a/web/src/features/tag/components/TagButton.tsx b/web/src/features/tag/components/TagButton.tsx
index 5faa389566..5c60ae7bba 100644
--- a/web/src/features/tag/components/TagButton.tsx
+++ b/web/src/features/tag/components/TagButton.tsx
@@ -1,4 +1,5 @@
import { Button } from "@/src/components/ui/button";
+import { BadgeShell } from "@/src/components/design-system/Badge/Badge";
import { cn } from "@/src/utils/tailwind";
import { TagIcon } from "lucide-react";
import React from "react";
@@ -8,25 +9,40 @@ export const TagButton: React.FC<{
loading: boolean;
viewOnly?: boolean;
isTableCell?: boolean;
-}> = React.memo(({ tag, loading, viewOnly = false, isTableCell = false }) => (
- <Button
- key={tag}
- variant="tertiary"
- size="icon-sm"
- disabled={viewOnly}
- className={cn(viewOnly && "cursor-default", "w-fit max-w-40 min-w-16")}
- loading={loading}
- >
- <TagIcon className="mr-1 h-3.5 w-3.5 shrink-0" />
- <span
- className={cn(
- "overflow-hidden text-ellipsis whitespace-nowrap",
- !isTableCell && "text-xs",
- )}
- title={tag}
+}> = React.memo(({ tag, loading, viewOnly = false, isTableCell = false }) => {
+ const label = (
+ <>
+ <TagIcon className="size-3 shrink-0" />
+ <span
+ className={cn(
+ "overflow-hidden text-ellipsis whitespace-nowrap",
+ !isTableCell && "text-xs",
+ )}
+ title={tag}
+ >
+ {tag}
+ </span>
+ </>
+ );
+
+ if (viewOnly) {
+ return (
+ <span className="inline-flex max-w-40 min-w-0">
+ <BadgeShell color="neutral">{label}</BadgeShell>
+ </span>
+ );
+ }
+
+ return (
+ <Button
+ key={tag}
+ variant="tertiary"
+ size="icon-sm"
+ className="w-fit max-w-40 min-w-16 gap-1"
+ loading={loading}
>
- {tag}
- </span>
- </Button>
-));
+ {label}
+ </Button>
+ );
+});
TagButton.displayName = "TagButton";
diff --git a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
index d0f1748b20..6c72281f0c 100644
--- a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
+++ b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
@@ -482,7 +482,6 @@ export function ConnectedObservationDetailView({
>
<ObservationPreview
currentView={currentView}
- tags={isRoot ? observation.traceTags : undefined}
previewKey={observation.id}
onPrettyViewAvailabilityChange={setIsPrettyViewAvailable}
previewProps={{
diff --git a/web/src/features/traces/components/ObservationDetailView/ObservationPreview.stories.tsx b/web/src/features/traces/components/ObservationDetailView/ObservationPreview.stories.tsx
index cb94d5eb0c..b307a0c8c3 100644
--- a/web/src/features/traces/components/ObservationDetailView/ObservationPreview.stories.tsx
+++ b/web/src/features/traces/components/ObservationDetailView/ObservationPreview.stories.tsx
@@ -7,7 +7,6 @@ const meta = preview.meta({
export const Default = meta.story({
args: {
- tags: ["production", "support"],
previewKey: "default-observation",
previewProps: {
input: {
diff --git a/web/src/features/traces/components/ObservationDetailView/ObservationPreview.tsx b/web/src/features/traces/components/ObservationDetailView/ObservationPreview.tsx
index cb5d32cf69..f436a24628 100644
--- a/web/src/features/traces/components/ObservationDetailView/ObservationPreview.tsx
+++ b/web/src/features/traces/components/ObservationDetailView/ObservationPreview.tsx
@@ -1,11 +1,9 @@
import { useState, type ComponentProps, type Key } from "react";
import { IOPreview } from "@/src/features/traces/components/IOPreview/IOPreview";
-import TagList from "@/src/features/tag/components/TagList";
export interface ObservationPreviewProps {
currentView?: ComponentProps<typeof IOPreview>["currentView"];
- tags?: string[] | null;
previewKey: Key;
previewProps: Omit<
ComponentProps<typeof IOPreview>,
@@ -16,7 +14,6 @@ export interface ObservationPreviewProps {
export function ObservationPreview({
currentView,
- tags,
previewKey,
previewProps,
onPrettyViewAvailabilityChange,
@@ -31,20 +28,6 @@ export function ObservationPreview({
: "overflow-auto pb-4"
}`}
>
- {tags && tags.length > 0 ? (
- <>
- <div
- className={`px-2 pt-2 text-sm font-bold ${currentView && currentView !== "pretty" ? "shrink-0" : ""}`}
- >
- Tags
- </div>
- <div
- className={`flex flex-wrap gap-x-1 gap-y-1 px-2 pb-2 ${currentView && currentView !== "pretty" ? "shrink-0" : ""}`}
- >
- <TagList selectedTags={tags} isLoading={false} />
- </div>
- </>
- ) : null}
<IOPreview
key={previewKey}
{...previewProps}
diff --git a/web/src/features/traces/components/Trace.tsx b/web/src/features/traces/components/Trace.tsx
index 2caa65bc68..a4d9e72a56 100644
--- a/web/src/features/traces/components/Trace.tsx
+++ b/web/src/features/traces/components/Trace.tsx
@@ -2,10 +2,7 @@ import { type TraceDomain, type ScoreDomain } from "@langfuse/shared";
import { type ObservationReturnTypeWithMetadata } from "@/src/server/api/routers/traces";
import { type WithStringifiedMetadata } from "@/src/utils/clientSideDomainTypes";
import { TraceDataProvider } from "@/src/features/traces/contexts/TraceDataContext";
-import {
- ViewPreferencesProvider,
- useViewPreferences,
-} from "@/src/features/traces/contexts/ViewPreferencesContext";
+import { ViewPreferencesProvider } from "@/src/features/traces/contexts/ViewPreferencesContext";
import {
SelectionProvider,
useSelection,
@@ -192,12 +189,10 @@ function TraceWithSelection({
*
* Hooks:
* - useIsMobile() - for responsive platform detection
- * - useViewPreferences() - for graph toggle state
* - useTraceGraphData() - for graph availability
*/
function TraceContent({ desktopLayout }: { desktopLayout: DesktopLayout }) {
const isMobile = useIsMobile();
- const { isAnnotationMode } = useViewPreferences();
const { isGraphViewAvailable } = useTraceGraphData();
const panels = isMobile ? (
@@ -206,11 +201,6 @@ function TraceContent({ desktopLayout }: { desktopLayout: DesktopLayout }) {
<DesktopTraceContent desktopLayout={desktopLayout} />
);
- // Annotation mode shows no trace-level metadata.
- if (isAnnotationMode) {
- return panels;
- }
-
return (
<div className="flex h-full flex-col overflow-hidden">
<TraceSummaryStrip />
diff --git a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
index d194d34cab..8f3d4ecb95 100644
--- a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
+++ b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
@@ -104,8 +104,6 @@ export function TraceDetailView({
// Map jsonViewPreference to currentView format expected by child components
const currentView = jsonViewPreference;
- // The Formatted view shares the pretty layout; JSON views differ.
- const isPrettyLikeView = currentView === "pretty";
const selectedViewTab =
jsonViewPreference === "pretty" ? "pretty" : ("json" as const);
@@ -400,22 +398,12 @@ export function TraceDetailView({
: "overflow-auto pb-4"
}`}
>
- {/* Tags Section - scrolls with content except in JSON Beta (virtualized) */}
- {trace.tags.length > 0 && (
- <>
- <div
- className={`px-2 pt-1 text-sm font-bold ${!isPrettyLikeView ? "shrink-0" : ""}`}
- >
- Tags
- </div>
- <div
- className={`flex flex-wrap gap-x-1 gap-y-1 px-2 pb-3 ${!isPrettyLikeView ? "shrink-0" : ""}`}
- >
- <TagList selectedTags={trace.tags} isLoading={false} />
- </div>
- </>
+ {isAnnotationMode && trace.tags.length > 0 && (
+ <div className="space-y-1 px-2 pt-1 pb-2">
+ <div className="text-sm font-bold">Tags</div>
+ <TagList selectedTags={trace.tags} isLoading={false} />
+ </div>
)}
-
{/* I/O Preview (includes metadata in both views) */}
<IOPreview
key={trace.id + "-io"}