Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): score chips stay visible on the selected trace tree row (#18680)

Trang Nguyenb09d36655b57
diff --git a/web/src/components/OverflowCountBadge.tsx b/web/src/components/OverflowCountBadge.tsx
index a3e9cef12f..d00a126cac 100644
--- a/web/src/components/OverflowCountBadge.tsx
+++ b/web/src/components/OverflowCountBadge.tsx
@@ -7,17 +7,20 @@ type OverflowCountBadgeProps = Omit<
"children" | "className" | "type"
> & {
count: number;
+ /** `filledOnMuted` on a muted or accent surface such as a selected row. */
+ color?: "filled" | "filledOnMuted";
ref?: Ref<HTMLButtonElement>;
};
/** The "+N" control after a row of chips; works as a popover trigger via asChild. */
export function OverflowCountBadge({
count,
+ color = "filled",
ref,
...props
}: OverflowCountBadgeProps) {
return (
- <BadgeShell asChild color="filled" font="mono" size="md">
+ <BadgeShell asChild color={color} font="mono" size="md">
<button
ref={ref}
type="button"
diff --git a/web/src/components/ScoreBadge/ScoreBadge.tsx b/web/src/components/ScoreBadge/ScoreBadge.tsx
index 704211dabe..c875fe40d3 100644
--- a/web/src/components/ScoreBadge/ScoreBadge.tsx
+++ b/web/src/components/ScoreBadge/ScoreBadge.tsx
@@ -11,11 +11,14 @@ export const ScoreBadge = <
name,
scores,
showLevels,
+ color = "filled",
}: {
name: string;
scores: T[];
/** Render this group's level tags when the selection mixes score levels. */
showLevels?: boolean;
+ /** `filledOnMuted` on a muted or accent surface such as a selected row. */
+ color?: "filled" | "filledOnMuted";
}) => {
const levels = showLevels
? Array.from(new Set(scores.map((score) => scoreLevelFromScore(score))))
@@ -26,7 +29,7 @@ export const ScoreBadge = <
{levels.map((level) => (
<ScoreTag key={level} level={level} />
))}
- <BadgeShell color="filled" size="md">
+ <BadgeShell color={color} size="md">
<span className="text-muted-foreground flex min-w-0 flex-1 font-mono">
<span className="truncate py-0.5" title={name}>
{name}
diff --git a/web/src/components/design-system/Badge/Badge.stories.tsx b/web/src/components/design-system/Badge/Badge.stories.tsx
index b2daf2c63d..41402eb853 100644
--- a/web/src/components/design-system/Badge/Badge.stories.tsx
+++ b/web/src/components/design-system/Badge/Badge.stories.tsx
@@ -25,6 +25,7 @@ const allColors = Object.keys({
green: true,
ghost: true,
filled: true,
+ filledOnMuted: true,
violetTint: true,
skyTint: true,
emeraldTint: true,
diff --git a/web/src/components/design-system/Badge/Badge.tsx b/web/src/components/design-system/Badge/Badge.tsx
index 3769182c54..372dba48c6 100644
--- a/web/src/components/design-system/Badge/Badge.tsx
+++ b/web/src/components/design-system/Badge/Badge.tsx
@@ -27,6 +27,9 @@ const badgeVariants = cva(
green: "border-transparent bg-light-green text-dark-green",
ghost: "border-0 bg-transparent px-0 text-foreground-secondary",
filled: "border-transparent bg-muted text-foreground-secondary",
+ /** `filled` for a chip on a muted or accent surface, e.g. a selected or hovered row, where `bg-muted` vanishes. */
+ filledOnMuted:
+ "border-transparent bg-background text-foreground-secondary",
violetTint:
"border-category-violet/40 bg-category-violet/10 text-foreground-secondary",
skyTint:
diff --git a/web/src/components/grouped-score-badge.tsx b/web/src/components/grouped-score-badge.tsx
index d02ea3cb36..6039c343c0 100644
--- a/web/src/components/grouped-score-badge.tsx
+++ b/web/src/components/grouped-score-badge.tsx
@@ -81,9 +81,12 @@ const ScoreTable = <T extends ChipScore>({ scores }: { scores: T[] }) => {
export const GroupedScoreBadges = <T extends ChipScore>({
scores,
maxVisible = MAX_VISIBLE_SCORE_GROUPS,
+ color,
}: {
scores: T[];
maxVisible?: number;
+ /** `filledOnMuted` on a muted or accent surface such as a selected row. */
+ color?: "filled" | "filledOnMuted";
}) => {
const groupedScores = groupScoresByName(scores);
@@ -102,6 +105,7 @@ export const GroupedScoreBadges = <T extends ChipScore>({
<Popover>
<PopoverTrigger asChild>
<OverflowCountBadge
+ color={color}
count={hiddenScores.length}
aria-label={`Show all ${Object.keys(groupedScores).length} scores`}
// Chips render inside clickable rows; opening must not select the row.
@@ -126,6 +130,7 @@ export const GroupedScoreBadges = <T extends ChipScore>({
name={name}
scores={scores}
showLevels={showLevels}
+ color={color}
/>
))}
{Boolean(hiddenScores.length) && overflow}
diff --git a/web/src/features/comments/CommentCountIcon.tsx b/web/src/features/comments/CommentCountIcon.tsx
index f8383b185e..a7447e56a9 100644
--- a/web/src/features/comments/CommentCountIcon.tsx
+++ b/web/src/features/comments/CommentCountIcon.tsx
@@ -2,9 +2,16 @@ import { MessageSquareMore } from "lucide-react";
import { BadgeShell } from "@/src/components/design-system/Badge/Badge";
-export function CommentCountIcon({ count }: { count: number }) {
+export function CommentCountIcon({
+ count,
+ color = "filled",
+}: {
+ count: number;
+ /** `filledOnMuted` on a muted or accent surface such as a selected row. */
+ color?: "filled" | "filledOnMuted";
+}) {
return (
- <BadgeShell color="filled" font="mono" size="md">
+ <BadgeShell color={color} font="mono" size="md">
<MessageSquareMore aria-hidden className="icon-sm shrink-0" />
<span data-testid="comment-count">{count > 99 ? "99+" : count}</span>
</BadgeShell>
diff --git a/web/src/features/traces/components/SpanContent.tsx b/web/src/features/traces/components/SpanContent.tsx
index 41150b7268..e4745f5dc6 100644
--- a/web/src/features/traces/components/SpanContent.tsx
+++ b/web/src/features/traces/components/SpanContent.tsx
@@ -40,6 +40,8 @@ interface SpanContentProps {
commentCount?: number;
onSelect?: () => void;
onHover?: () => void;
+ /** The row surface behind the content; chips flip their fill on `muted`. */
+ surface?: "default" | "muted";
className?: string;
}
@@ -73,9 +75,11 @@ function LoadedSpanContent({
commentCount,
onSelect,
onHover,
+ surface = "default",
className,
}: SpanContentProps) {
const { mergedScores } = useTraceData();
+ const chipColor = surface === "muted" ? "filledOnMuted" : "filled";
const { showDuration, showCostTokens, showScores, showComments } =
useViewPreferences();
@@ -139,7 +143,9 @@ function LoadedSpanContent({
{/* Comment count */}
{showComments &&
commentCount !== undefined &&
- commentCount !== 0 && <CommentCountIcon count={commentCount} />}
+ commentCount !== 0 && (
+ <CommentCountIcon count={commentCount} color={chipColor} />
+ )}
{/* Level badge */}
{node.type !== "TRACE" &&
@@ -198,7 +204,11 @@ function LoadedSpanContent({
opens a table of all scores. */}
{shouldRenderScores && (
<span className="flex min-w-0 items-center gap-1">
- <GroupedScoreBadges maxVisible={1} scores={nodeScores} />
+ <GroupedScoreBadges
+ maxVisible={1}
+ scores={nodeScores}
+ color={chipColor}
+ />
</span>
)}
</div>
diff --git a/web/src/features/traces/components/TraceTree.tsx b/web/src/features/traces/components/TraceTree.tsx
index 271a4e2d75..d7b10076df 100644
--- a/web/src/features/traces/components/TraceTree.tsx
+++ b/web/src/features/traces/components/TraceTree.tsx
@@ -1,12 +1,19 @@
+import { useState } from "react";
import { VirtualizedTree } from "./VirtualizedTree";
-import { VirtualizedTreeNodeWrapper } from "./VirtualizedTreeNodeWrapper";
+import {
+ VirtualizedTreeNodeWrapper,
+ type TreeNodeMetadata,
+} from "./VirtualizedTreeNodeWrapper";
import { SpanContent } from "./SpanContent";
import { useTraceData } from "@/src/features/traces/contexts/TraceDataContext";
import { useSelection } from "@/src/features/traces/contexts/SelectionContext";
import { useHandlePrefetchObservation } from "@/src/features/traces/hooks/useHandlePrefetchObservation";
import { useSelectTraceNode } from "@/src/features/traces/hooks/useSelectTraceNode";
import { type TreeNode } from "../types/treeNode";
-import { metricEmphasisFor } from "@/src/features/traces/fns/metricEmphasis";
+import {
+ metricEmphasisFor,
+ type MetricEmphasisContext,
+} from "@/src/features/traces/fns/metricEmphasis";
/**
* TraceTree - Composition of VirtualizedTree + TreeNodeWrapper + SpanContent.
@@ -66,35 +73,65 @@ function LoadedTraceTree() {
selectedNodeId={selectedNodeId}
onToggleCollapse={toggleCollapsed}
onSelectNode={handleSelectNode}
- renderNode={({
- node,
- treeMetadata,
- isSelected,
- isCollapsed,
- onToggleCollapse,
- onSelect,
- }) => {
+ renderNode={({ node, ...row }) => {
const typedNode = node as TreeNode;
return (
- <VirtualizedTreeNodeWrapper
- metadata={treeMetadata}
- nodeType={typedNode.type}
- hasChildren={typedNode.children.length > 0}
- isCollapsed={isCollapsed}
- onToggleCollapse={onToggleCollapse}
- isSelected={isSelected}
- onSelect={onSelect}
- >
- <SpanContent
- node={typedNode}
- emphasis={metricEmphasisFor(typedNode, metricEmphasis)}
- commentCount={comments.get(typedNode.id)}
- onSelect={onSelect}
- onHover={() => handleHover(typedNode)}
- />
- </VirtualizedTreeNodeWrapper>
+ <TraceTreeRow
+ {...row}
+ node={typedNode}
+ emphasis={metricEmphasisFor(typedNode, metricEmphasis)}
+ commentCount={comments.get(typedNode.id)}
+ onHover={() => handleHover(typedNode)}
+ />
);
}}
/>
);
}
+
+/** One row; tracks hover so the content's chips flip with the row surface. */
+function TraceTreeRow({
+ node,
+ treeMetadata,
+ isSelected,
+ isCollapsed,
+ onToggleCollapse,
+ onSelect,
+ emphasis,
+ commentCount,
+ onHover,
+}: {
+ node: TreeNode;
+ treeMetadata: TreeNodeMetadata;
+ isSelected: boolean;
+ isCollapsed: boolean;
+ onToggleCollapse: () => void;
+ onSelect: () => void;
+ emphasis: MetricEmphasisContext | undefined;
+ commentCount: number | undefined;
+ onHover: () => void;
+}) {
+ const [isHovered, setIsHovered] = useState(false);
+
+ return (
+ <VirtualizedTreeNodeWrapper
+ metadata={treeMetadata}
+ nodeType={node.type}
+ hasChildren={node.children.length > 0}
+ isCollapsed={isCollapsed}
+ onToggleCollapse={onToggleCollapse}
+ isSelected={isSelected}
+ onSelect={onSelect}
+ onHoverChange={setIsHovered}
+ >
+ <SpanContent
+ node={node}
+ emphasis={emphasis}
+ commentCount={commentCount}
+ onSelect={onSelect}
+ onHover={onHover}
+ surface={isSelected || isHovered ? "muted" : "default"}
+ />
+ </VirtualizedTreeNodeWrapper>
+ );
+}
diff --git a/web/src/features/traces/components/VirtualizedTreeNodeWrapper.tsx b/web/src/features/traces/components/VirtualizedTreeNodeWrapper.tsx
index baf21097a9..75dcbceb5f 100644
--- a/web/src/features/traces/components/VirtualizedTreeNodeWrapper.tsx
+++ b/web/src/features/traces/components/VirtualizedTreeNodeWrapper.tsx
@@ -48,6 +48,8 @@ interface TreeNodeWrapperProps {
// Selection/interaction
isSelected: boolean;
onSelect: () => void;
+ /** Mirrors the row's `hover:` surface so content can restyle with it. */
+ onHoverChange?: (isHovered: boolean) => void;
// Content to render (fully decoupled from tree structure)
children: ReactNode;
@@ -107,6 +109,8 @@ export function VirtualizedTreeNodeWrapper(
}
: undefined
}
+ onMouseEnter={loaded ? () => loaded.onHoverChange?.(true) : undefined}
+ onMouseLeave={loaded ? () => loaded.onHoverChange?.(false) : undefined}
>
<div className="flex w-full pl-2">
{/* 1. Indents: ancestor level indicators (capped at visualDepth) */}