Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(query-ast): type 64-bit helper results as number (#19037)

Niklas Semmlerb0bcf4ea3b68
diff --git a/packages/shared/src/server/query-ast/extensions.test.ts b/packages/shared/src/server/query-ast/extensions.test.ts
index 26d0252951..4d0505e268 100644
--- a/packages/shared/src/server/query-ast/extensions.test.ts
+++ b/packages/shared/src/server/query-ast/extensions.test.ts
@@ -1,5 +1,5 @@
import { expressionBuilder, sql } from "kysely";
-import { describe, expect, it } from "vitest";
+import { describe, expect, expectTypeOf, it } from "vitest";
import { compileClickhouseQuery, renderClickhouseExpression } from "./compile";
import { getClickhouseKysely } from "./dialect";
@@ -10,13 +10,19 @@ import {
} from "./errors";
import {
arrayExists,
+ arrayLength,
arrayMap,
+ count,
+ countIf,
leftUTF8,
literal,
mapValue,
+ medianExact,
metadataMap,
metadataValue,
traceSessionId,
+ uniq,
+ uniqIf,
} from "./extensions";
import { ArrayIndexNode } from "./nodes";
import type { ClickHouseDatabase } from "./schema";
@@ -266,6 +272,31 @@ describe("renderClickhouseExpression", () => {
});
});
+describe("64-bit results", () => {
+ const eb = expressionBuilder<{ e: ClickHouseDatabase["events_core"] }, "e">();
+ const isError = eb("e.level", "=", literal("ERROR"));
+
+ // ClickHouse 25.8+ (Langfuse v4 needs 25.12) sends (U)Int64 as JSON numbers.
+ it("types count and length results as number", () => {
+ expectTypeOf(count().expressionType).toEqualTypeOf<number | undefined>();
+ expectTypeOf(countIf(isError).expressionType).toEqualTypeOf<
+ number | undefined
+ >();
+ expectTypeOf(uniq(eb.ref("e.trace_id")).expressionType).toEqualTypeOf<
+ number | undefined
+ >();
+ expectTypeOf(
+ uniqIf(eb.ref("e.trace_id"), isError).expressionType,
+ ).toEqualTypeOf<number | undefined>();
+ expectTypeOf(arrayLength(eb.ref("e.tags")).expressionType).toEqualTypeOf<
+ number | undefined
+ >();
+ expectTypeOf(
+ medianExact(eb.ref("e.total_cost")).expressionType,
+ ).toEqualTypeOf<number | undefined>();
+ });
+});
+
describe("literal", () => {
it("inlines a string with its quotes doubled", () => {
expect(renderClickhouseExpression(literal("it's"))).toBe("'it''s'");
diff --git a/packages/shared/src/server/query-ast/extensions.ts b/packages/shared/src/server/query-ast/extensions.ts
index 3236aa8af9..04f651f28a 100644
--- a/packages/shared/src/server/query-ast/extensions.ts
+++ b/packages/shared/src/server/query-ast/extensions.ts
@@ -172,7 +172,7 @@ export function mapValues<V = string>(column: string): Expression<V[]> {
}
/** ClickHouse `uniq(value)`, an approximate distinct count. */
-export function uniq(value: Expression<unknown>): ChExpression<string> {
+export function uniq(value: Expression<unknown>): ChExpression<number> {
return aggregate("uniq", [value]);
}
@@ -180,7 +180,7 @@ export function uniq(value: Expression<unknown>): ChExpression<string> {
export function count(): ExpressionWrapper<
ClickHouseDatabase,
keyof ClickHouseDatabase,
- string
+ number
> {
return new ExpressionWrapper(
AggregateFunctionNode.create("count", []) as unknown as OperationNode,
@@ -190,7 +190,7 @@ export function count(): ExpressionWrapper<
/** ClickHouse `medianExact(expression)`. */
export function medianExact(
expression: Expression<unknown>,
-): ExpressionWrapper<ClickHouseDatabase, keyof ClickHouseDatabase, string> {
+): ExpressionWrapper<ClickHouseDatabase, keyof ClickHouseDatabase, number> {
return new ExpressionWrapper(
AggregateFunctionNode.create("medianExact", [
expression.toOperationNode(),
@@ -392,7 +392,7 @@ export function startsWith(
/** ClickHouse `length(array)`. */
export function arrayLength(
array: Expression<unknown[]>,
-): ChExpression<string> {
+): ChExpression<number> {
return functionCall("length", [array]);
}
@@ -418,7 +418,7 @@ export function anyValue<T>(value: Expression<T>): ChExpression<T> {
}
/** ClickHouse `countIf(condition)`. */
-export function countIf(condition: Expression<SqlBool>): ChExpression<string> {
+export function countIf(condition: Expression<SqlBool>): ChExpression<number> {
return aggregate("countIf", [condition]);
}
@@ -426,7 +426,7 @@ export function countIf(condition: Expression<SqlBool>): ChExpression<string> {
export function uniqIf(
value: Expression<unknown>,
condition: Expression<SqlBool>,
-): ChExpression<string> {
+): ChExpression<number> {
return aggregate("uniqIf", [value, condition]);
}