🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(evals): align evaluator dialog close button (#16704)
Tobias Wochingerb553be5dfe99
diff --git a/web/src/features/evals/v2/AGENTS.md b/web/src/features/evals/v2/AGENTS.mdindex afc15707bf..77a0cdfb34 100644--- a/web/src/features/evals/v2/AGENTS.md+++ b/web/src/features/evals/v2/AGENTS.md@@ -14,3 +14,8 @@ The new data model isTraces captured during the eval executions in the past only captured `job_configuration_id`.Only new runs capture `evaluator_id` and `evaluation_rule_id`.++## Testing++- Do not write tautological React client tests or tests that assert pixel positioning.+- Only add component tests when they enforce meaningful behavior.diff --git a/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialog/EvaluatorSavedDialog.tsx b/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialog/EvaluatorSavedDialog.tsxindex 566e11ca49..a1e2a9d2ed 100644--- a/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialog/EvaluatorSavedDialog.tsx+++ b/web/src/features/evals/v2/components/Evaluators/EvaluatorSavedDialog/EvaluatorSavedDialog.tsx@@ -76,7 +76,7 @@ export function EvaluatorSavedDialog({closeOnInteractionOutsideonCloseAutoFocus={onCloseAnimationEnd}>- <DialogHeader>+ <DialogHeader className="[&>div]:items-start [&>div>button]:-mt-1"><DialogTitle>Evaluator saved</DialogTitle><DialogDescription>Would you like to run this evaluator on incoming observations?