Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(api): bound legacy dataset item responses (#16676)

Tobias Wochingerba2dfc514646
diff --git a/web/src/__tests__/server/dataset-item-media-references.servertest.ts b/web/src/__tests__/server/dataset-item-media-references.servertest.ts
index 77e9d75888..c368532e20 100644
--- a/web/src/__tests__/server/dataset-item-media-references.servertest.ts
+++ b/web/src/__tests__/server/dataset-item-media-references.servertest.ts
@@ -181,7 +181,7 @@ describe("Dataset item media references (public API read path)", () => {
]);
});
- it("resolves media references on embedded items in the dataset endpoint", async () => {
+ it("does not resolve media references on embedded items in the legacy dataset endpoint", async () => {
const media = await createMediaRow();
const { datasetName } = await createDatasetWithItem({
image: media.referenceString,
@@ -194,13 +194,27 @@ describe("Dataset item media references (public API read path)", () => {
const parsed = GetDatasetV1Response.parse(response);
expect(parsed.items).toHaveLength(1);
- expect(parsed.items[0].mediaReferences).toEqual([
- expect.objectContaining({
- field: "input",
- jsonPath: "$['image']",
- media: expect.objectContaining({ mediaId: media.mediaId }),
- }),
- ]);
+ expect(parsed.items[0]).not.toHaveProperty("mediaReferences");
+ });
+
+ it("limits embedded items in the legacy dataset endpoint", async () => {
+ const dataset = await createDataset();
+ const result = await createManyDatasetItems({
+ projectId,
+ items: Array.from({ length: 1_001 }, (_, index) => ({
+ datasetId: dataset.id,
+ id: v4(),
+ input: { index },
+ })),
+ });
+ expect(result.success).toBe(true);
+
+ const response = await getDatasetByNameForApi({
+ projectId,
+ name: dataset.name,
+ });
+
+ expect(response.items).toHaveLength(1_000);
});
it("returns empty mediaReferences for items without media", async () => {
diff --git a/web/src/features/datasets/server/publicDatasetService.ts b/web/src/features/datasets/server/publicDatasetService.ts
index ff3f50a2f1..3f84b46c51 100644
--- a/web/src/features/datasets/server/publicDatasetService.ts
+++ b/web/src/features/datasets/server/publicDatasetService.ts
@@ -151,6 +151,10 @@ type DeleteDatasetRunByIdInput = DatasetAuditScope & {
type DeleteDatasetItemInput = DatasetAuditScope &
z.infer<typeof GetDatasetItemV1Query>;
+// This deprecated endpoint embeds items without pagination. Keep its response
+// bounded while giving existing users room to migrate to GET /dataset-items.
+const LEGACY_DATASET_ITEM_LIMIT = 1_000;
+
const resolveMetadata = (metadata: JSONValue): Record<string, unknown> => {
if (Array.isArray(metadata)) {
return { metadata };
@@ -494,22 +498,15 @@ export const getDatasetByNameForApi = async ({
status: "ACTIVE",
}),
includeDatasetName: true,
+ limit: LEGACY_DATASET_ITEM_LIMIT,
+ page: 0,
});
const { datasetRuns = [], ...params } = dataset;
- const mediaReferences = await resolveDatasetItemMediaReferences({
- projectId,
- items: datasetItems,
- });
-
return {
...transformDbDatasetToAPIDataset(params),
- items: datasetItems.map((item) => ({
- ...transformDbDatasetItemDomainToAPIDatasetItem(item),
- mediaReferences:
- mediaReferences.get(datasetItemMediaReferenceKey(item)) ?? [],
- })),
+ items: datasetItems.map(transformDbDatasetItemDomainToAPIDatasetItem),
runs: datasetRuns.map(({ name }) => name),
};
};
diff --git a/web/src/features/public-api/types/datasets.ts b/web/src/features/public-api/types/datasets.ts
index 90e6c1c90d..dd153c488b 100644
--- a/web/src/features/public-api/types/datasets.ts
+++ b/web/src/features/public-api/types/datasets.ts
@@ -335,7 +335,7 @@ export const GetDatasetV1Query = z.object({
name: queryStringZod,
});
export const GetDatasetV1Response = APIDataset.extend({
- items: z.array(APIDatasetItem),
+ items: z.array(APIDatasetItem.omit({ mediaReferences: true })),
runs: z.array(z.string()), // dataset run names
}).strict();