Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(sessions): Unify sidebar tool status badges (#18603)

Ben Bachembaa79b5b0c6d
diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationSidebar/SessionConversationSidebar.stories.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationSidebar/SessionConversationSidebar.stories.tsx
index eb0da28fde..2ffb4786df 100644
--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationSidebar/SessionConversationSidebar.stories.tsx
+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationSidebar/SessionConversationSidebar.stories.tsx
@@ -126,7 +126,7 @@ export const DarkMode = meta.story({
export const Empty = meta.story({ args: { ...loadedArgs, traces: [] } });
export const GroupedToolStatuses = meta.story({
- name: "(Test) Grouped Tool Status Indicators",
+ name: "(Test) Grouped and Individual Tool Status Indicators",
args: {
...loadedArgs,
traces: [
@@ -177,6 +177,34 @@ export const GroupedToolStatuses = meta.story({
label: "debug",
level: "DEBUG",
},
+ {
+ id: "0:6",
+ observationId: "retry-response",
+ role: "assistant",
+ label: "Retrying the failed search.",
+ },
+ {
+ id: "0:7",
+ observationId: "retry-search",
+ role: "tool",
+ label: "retry_search",
+ level: "ERROR",
+ statusMessage: "Search retry timed out",
+ },
+ {
+ id: "0:8",
+ observationId: "fallback-response",
+ role: "assistant",
+ label: "Checking the cached results instead.",
+ },
+ {
+ id: "0:9",
+ observationId: "cached-search",
+ role: "tool",
+ label: "cached_search",
+ level: "WARNING",
+ statusMessage: "Cached results may be outdated",
+ },
],
},
],
@@ -187,6 +215,8 @@ export const GroupedToolStatuses = meta.story({
const errors = await canvas.findByLabelText("2 tool errors");
await expect(errors).toBeVisible();
await expect(canvas.getByLabelText("2 tool warnings")).toBeVisible();
+ await expect(canvas.getByLabelText("Tool status: ERROR")).toBeVisible();
+ await expect(canvas.getByLabelText("Tool status: WARNING")).toBeVisible();
const button = canvas.getByRole("button", { name: /^Tool:/ });
await userEvent.hover(button);
const tooltip = await within(canvasElement.ownerDocument.body).findByRole(
diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationSidebar/SessionConversationSidebar.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationSidebar/SessionConversationSidebar.tsx
index 2d80314eaa..e70382365a 100644
--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationSidebar/SessionConversationSidebar.tsx
+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationSidebar/SessionConversationSidebar.tsx
@@ -7,7 +7,7 @@ import {
type ReactNode,
} from "react";
import { useVirtualizer } from "@tanstack/react-virtual";
-import { ChevronDown, CircleAlert, Search, TriangleAlert } from "lucide-react";
+import { ChevronDown, Search } from "lucide-react";
import { type Observation } from "@langfuse/shared";
import { Input } from "@/src/components/ui/input";
import { SessionToolTooltip } from "@/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionToolTooltip/SessionToolTooltip";
@@ -688,14 +688,16 @@ export function SessionConversationSidebar(
)}
</span>
{hasError && (
- <CircleAlert
- className="icon-sm text-destructive shrink-0"
+ <SessionToolStatusCountBadge
+ severity="error"
+ variant="sidebar"
aria-label="Tool status: ERROR"
/>
)}
{hasWarning && (
- <TriangleAlert
- className="icon-sm shrink-0 text-yellow-600 dark:text-yellow-500"
+ <SessionToolStatusCountBadge
+ severity="warning"
+ variant="sidebar"
aria-label="Tool status: WARNING"
/>
)}
diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionToolStatusCountBadge/SessionToolStatusCountBadge.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionToolStatusCountBadge/SessionToolStatusCountBadge.tsx
index f375b8f5a0..ade849fc44 100644
--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionToolStatusCountBadge/SessionToolStatusCountBadge.tsx
+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionToolStatusCountBadge/SessionToolStatusCountBadge.tsx
@@ -3,11 +3,13 @@ import { CircleAlert, TriangleAlert } from "lucide-react";
import { BadgeShell } from "@/src/components/design-system/Badge/Badge";
type SessionToolStatusCountBadgeProps = {
- count: number;
severity: "error" | "warning";
- variant: "timeline" | "sidebar";
ref?: ComponentProps<"span">["ref"];
-} & Pick<ComponentProps<typeof BadgeShell>, "aria-label" | "tabIndex">;
+} & Pick<ComponentProps<typeof BadgeShell>, "aria-label" | "tabIndex"> &
+ (
+ | { variant: "timeline"; count: number }
+ | { variant: "sidebar"; count?: number }
+ );
export function SessionToolStatusCountBadge({
count,