🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): toggle column visibility from label clicks (#16276)
Nikita Kabardinbff47a066d24
diff --git a/web/src/components/table/data-table-column-visibility-filter.clienttest.tsx b/web/src/components/table/data-table-column-visibility-filter.clienttest.tsxnew file mode 100644index 0000000000..c23ce76491--- /dev/null+++ b/web/src/components/table/data-table-column-visibility-filter.clienttest.tsx@@ -0,0 +1,98 @@+import { useState } from "react";+import { fireEvent, render, screen } from "@testing-library/react";+import { type VisibilityState } from "@tanstack/react-table";+import { DataTableColumnVisibilityFilter } from "@/src/components/table/data-table-column-visibility-filter";+import { LAYER_ORDER } from "@/src/components/ui/layer";+import { type LangfuseColumnDef } from "@/src/components/table/types";++vi.mock("@/src/features/posthog-analytics/usePostHogClientCapture", () => ({+ usePostHogClientCapture: () => vi.fn(),+}));++const columns: LangfuseColumnDef<{ id: string }>[] = [+ {+ accessorKey: "startTime",+ header: "Start Time",+ enableHiding: false,+ },+ {+ accessorKey: "input",+ header: "Input",+ enableHiding: true,+ },+];++function ColumnVisibilityFilterHarness() {+ const [columnVisibility, setColumnVisibility] = useState<VisibilityState>({+ startTime: true,+ input: true,+ });++ return (+ <DataTableColumnVisibilityFilter+ columns={columns}+ columnVisibility={columnVisibility}+ setColumnVisibility={setColumnVisibility}+ />+ );+}++function installOverlayLayers() {+ const overlayRoot = document.createElement("div");+ overlayRoot.setAttribute("data-overlay-root", "");+ for (const layer of LAYER_ORDER) {+ const layerNode = document.createElement("div");+ layerNode.setAttribute("data-layer", layer);+ overlayRoot.appendChild(layerNode);+ }+ document.body.appendChild(overlayRoot);+ return overlayRoot;+}++describe("DataTableColumnVisibilityFilter", () => {+ beforeAll(() => {+ vi.stubGlobal(+ "ResizeObserver",+ class {+ observe() {}+ unobserve() {}+ disconnect() {}+ },+ );+ vi.stubGlobal(+ "matchMedia",+ (query: string) =>+ ({+ matches: query.includes("min-width"),+ media: query,+ onchange: null,+ addListener: vi.fn(),+ removeListener: vi.fn(),+ addEventListener: vi.fn(),+ removeEventListener: vi.fn(),+ dispatchEvent: vi.fn(),+ }) satisfies MediaQueryList,+ );+ });++ beforeEach(() => {+ installOverlayLayers();+ });++ afterEach(() => {+ document.querySelector("[data-overlay-root]")?.remove();+ });++ it("toggles a hideable column when its label is clicked", () => {+ render(<ColumnVisibilityFilterHarness />);++ fireEvent.click(screen.getByRole("button", { name: /columns/i }));++ const inputCheckbox = screen.getByRole("checkbox", { name: "Input" });+ expect(inputCheckbox).toBeChecked();++ fireEvent.click(screen.getByText("Input"));++ expect(screen.getByRole("checkbox", { name: "Input" })).not.toBeChecked();+ });+});diff --git a/web/src/components/table/data-table-column-visibility-filter.tsx b/web/src/components/table/data-table-column-visibility-filter.tsxindex 28e3df133e..2d230e4137 100644--- a/web/src/components/table/data-table-column-visibility-filter.tsx+++ b/web/src/components/table/data-table-column-visibility-filter.tsx@@ -106,6 +106,8 @@ function ColumnVisibilityListItem<TData, TValue>({});const isChecked = columnVisibility[column.accessorKey] && column.enableHiding;+ const isLocked = !column.enableHiding || isFixedPosition;+ const checkboxId = `col-${column.accessorKey}`;return (<div@@ -125,18 +127,18 @@ function ColumnVisibilityListItem<TData, TValue>({><div className="flex items-center gap-2"><Checkbox- id={`col-${column.accessorKey}`}- checked={isChecked || !column.enableHiding || isFixedPosition}+ id={checkboxId}+ checked={isChecked || isLocked}onCheckedChange={() => {- if (column.enableHiding && !isFixedPosition)- toggleColumn(column.accessorKey);+ if (!isLocked) toggleColumn(column.accessorKey);}}- disabled={!column.enableHiding || isFixedPosition}+ disabled={isLocked}/>- <span+ <label+ htmlFor={checkboxId}className={cn("text-sm capitalize",- (!column.enableHiding || isFixedPosition) && "opacity-50",+ isLocked ? "opacity-50" : "cursor-pointer",)}title={!column.enableHiding@@ -149,7 +151,7 @@ function ColumnVisibilityListItem<TData, TValue>({{column.header && typeof column.header === "string"? column.header: column.accessorKey}- </span>+ </label>{column.headerTooltip && (<DocPopupdescription={column.headerTooltip.description}