🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): return conflict for duplicate LLM providers (#18708)
Tobias Wochingerc519661b655a
diff --git a/web/src/__tests__/server/llm-api-key.servertest.ts b/web/src/__tests__/server/llm-api-key.servertest.tsindex 1fe1135fe1..99aed01ad3 100644--- a/web/src/__tests__/server/llm-api-key.servertest.ts+++ b/web/src/__tests__/server/llm-api-key.servertest.ts@@ -152,6 +152,29 @@ describe("llmApiKey.all RPC", () => {expect(llmApiKeys[0].displaySecretKey).toMatch(/^...[a-zA-Z0-9]{4}$/);});+ it("returns CONFLICT when creating a key for an existing provider", async () => {+ const provider = `duplicate-provider-${randomUUID()}`;+ const input = {+ projectId,+ secretKey: "test-secret",+ provider,+ adapter: LLMAdapter.OpenAI,+ customModels: [],+ withDefaultModels: true,+ };++ await caller.llmApiKey.create(input);++ await expect(caller.llmApiKey.create(input)).rejects.toMatchObject({+ code: "CONFLICT",+ message: "There already exists an API key for this provider.",+ });++ await expect(+ prisma.llmApiKeys.count({ where: { projectId, provider } }),+ ).resolves.toBe(1);+ });+it("should create a Bedrock llm api key with a Bedrock API key", async () => {const secret = "bedrock-api-key-1234";diff --git a/web/src/features/llm-api-key/server/router.ts b/web/src/features/llm-api-key/server/router.tsindex 81bf910f0c..1fa37b64e9 100644--- a/web/src/features/llm-api-key/server/router.ts+++ b/web/src/features/llm-api-key/server/router.ts@@ -32,6 +32,7 @@ import {} from "@langfuse/shared";import { encrypt, decrypt } from "@langfuse/shared/encryption";+import { Prisma } from "@langfuse/shared/src/db";import {ChatMessageType,createTypeSafeDecisionModelClient,@@ -402,6 +403,15 @@ export const llmApiKeyRouter = createTRPCRouter({action: "create",});} catch (e) {+ if (+ e instanceof Prisma.PrismaClientKnownRequestError &&+ e.code === "P2002"+ ) {+ throw new TRPCError({+ code: "CONFLICT",+ message: "There already exists an API key for this provider.",+ });+ }logger.error(e);throw e;}