Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Extract `createFolderKeyTableColumn` (#16690)

Ben Bachemc6a74249c283
diff --git a/web/src/components/design-system/Table/columns/createFolderKeyTableColumn.stories.tsx b/web/src/components/design-system/Table/columns/createFolderKeyTableColumn.stories.tsx
new file mode 100644
index 0000000000..c8afa2ea8f
--- /dev/null
+++ b/web/src/components/design-system/Table/columns/createFolderKeyTableColumn.stories.tsx
@@ -0,0 +1,84 @@
+import preview from "../../../../../.storybook/preview";
+
+import {
+ DataTable,
+ type AsyncTableData,
+} from "@/src/components/table/data-table";
+import { createFolderKeyTableColumn } from "./createFolderKeyTableColumn";
+
+type Row = {
+ id: string;
+ name: string | null;
+ type: "folder" | "item";
+};
+
+const columns = [
+ createFolderKeyTableColumn<Row>({
+ accessorKey: "name",
+ header: "Name",
+ getCell: (name, { row }) => {
+ if (!name) return undefined;
+
+ if (row.original.type === "folder") {
+ return { type: "folder", name, onClick: () => undefined };
+ }
+
+ return {
+ type: "link",
+ props: { path: `/items/${row.original.id}`, value: name },
+ };
+ },
+ }),
+];
+
+function FolderKeyTableColumnStory({ data }: { data: AsyncTableData<Row[]> }) {
+ return (
+ <DataTable
+ tableName="folder-key-column-story"
+ columns={columns}
+ data={data}
+ hidePagination
+ cellPadding="comfortable"
+ />
+ );
+}
+
+const meta = preview.meta({
+ component: FolderKeyTableColumnStory,
+ parameters: {
+ layout: "fullscreen",
+ },
+});
+
+export const Default = meta.story({
+ args: {
+ data: {
+ isLoading: false,
+ isError: false,
+ data: [
+ { id: "folder-1", name: "Production", type: "folder" },
+ { id: "item-1", name: "Generation prompt", type: "item" },
+ ],
+ },
+ },
+});
+
+export const EmptyValue = meta.story({
+ name: "Empty Value",
+ args: {
+ data: {
+ isLoading: false,
+ isError: false,
+ data: [{ id: "item-1", name: null, type: "item" }],
+ },
+ },
+});
+
+export const Loading = meta.story({
+ args: {
+ data: {
+ isLoading: true,
+ isError: false,
+ },
+ },
+});
diff --git a/web/src/components/design-system/Table/columns/createFolderKeyTableColumn.tsx b/web/src/components/design-system/Table/columns/createFolderKeyTableColumn.tsx
new file mode 100644
index 0000000000..1b1a697022
--- /dev/null
+++ b/web/src/components/design-system/Table/columns/createFolderKeyTableColumn.tsx
@@ -0,0 +1,57 @@
+import { type CellContext, type RowData } from "@tanstack/react-table";
+import { Folder } from "lucide-react";
+
+import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import TableLink, {
+ type TableLinkProps,
+} from "@/src/components/table/table-link";
+import {
+ createTableColumn,
+ type TableColumnOptions,
+} from "./utils/createTableColumn";
+
+type LinkProps = Pick<TableLinkProps, "path" | "value" | "title" | "onClick">;
+
+export function createFolderKeyTableColumn<
+ TData extends RowData,
+ TValue = string,
+>({
+ getCell,
+ ...options
+}: TableColumnOptions<TData, TValue> & {
+ getCell: (
+ value: TValue | null | undefined,
+ context: CellContext<TData, TValue | null | undefined>,
+ ) =>
+ | { type: "folder"; name: string; onClick: () => void }
+ | { type: "link"; props: LinkProps }
+ | undefined;
+}) {
+ return createTableColumn<TData, TValue>({
+ ...options,
+ loadingCell: <TableTextLoadingCell />,
+ renderCell: (value, context) => {
+ const cell = getCell(value, context);
+ if (!cell) return null;
+
+ if (cell.type === "folder") {
+ return (
+ <TableLink
+ path=""
+ value={cell.name}
+ icon={
+ <div className="flex flex-row items-center gap-1">
+ <Folder className="h-3.5 w-3.5 shrink-0" />
+ {cell.name}
+ </div>
+ }
+ onClick={cell.onClick}
+ title={cell.name}
+ />
+ );
+ }
+
+ return <TableLink {...cell.props} />;
+ },
+ });
+}
diff --git a/web/src/components/table/DataTable.stories.tsx b/web/src/components/table/DataTable.stories.tsx
index 7924e4c9cb..861c17f8b6 100644
--- a/web/src/components/table/DataTable.stories.tsx
+++ b/web/src/components/table/DataTable.stories.tsx
@@ -20,6 +20,7 @@ import { Button } from "@/src/components/ui/button";
import { Checkbox } from "@/src/components/design-system/Checkbox/Checkbox";
import { createTagsTableColumn } from "@/src/components/design-system/Table/columns/createTagsTableColumn";
import { createDateTableColumn } from "@/src/components/design-system/Table/columns/createDateTableColumn";
+import { createFolderKeyTableColumn } from "@/src/components/design-system/Table/columns/createFolderKeyTableColumn";
import { createIdTableColumn } from "@/src/components/design-system/Table/columns/createIdTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/Table/columns/createNumberTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/Table/columns/createTextTableColumn";
@@ -35,7 +36,6 @@ import {
} from "@/src/components/level-counts-display";
import { formatAsLabel, LevelSymbols } from "@/src/components/level-colors";
import TagList from "@/src/features/tag/components/TagList";
-import { FolderBreadcrumbLink } from "@/src/features/folders/components/FolderBreadcrumbLink";
import { BreakdownTooltip } from "@/src/features/traces/components/BreakdownTooltip";
import {
TableBadgeLoadingCell,
@@ -51,6 +51,7 @@ import { formatIntervalSeconds } from "@/src/utils/dates";
import { numberFormatter, usdFormatter } from "@/src/utils/numbers";
import {
Copy,
+ Folder,
InfoIcon,
ListTree,
MoreVertical,
@@ -85,7 +86,7 @@ import {
// - actions: real DropdownMenu + ghost MoreVertical, with a plain menu item
// instead of the tRPC-bound DeleteTraceButton / DeletePrompt.
// Everything else (TableLink, Badge, IOTableCell, LocalIsoDate, TableIdOrName,
-// TokenUsageBadge, LevelCountsDisplay, FolderBreadcrumbLink, Skeleton, the
+// TokenUsageBadge, LevelCountsDisplay, folder links, Skeleton, the
// loading cells) is the actual production component.
//
// The IOTableCell relies on MarkdownContext; that is provided globally in
@@ -1133,8 +1134,8 @@ export const WithGroupedHeaders = meta.story({
// -----------------------------------------------------------------------------
// Reproduces features/prompts/components/prompts-table.tsx cell-for-cell:
// - cellPadding="comfortable" (the Prompts one-off override at prompts-table.tsx:482)
-// - Name column: folder rows use the real FolderBreadcrumbLink (TableLink +
-// Folder icon); prompt rows use TableLink to the prompt.
+// - Name column: folder rows use the folder key column (TableLink + Folder
+// icon); prompt rows use TableLink to the prompt.
// - Versions/Type: folder rows render null -> empty cells (column rhythm
// visibly breaks between folder and prompt rows, as in production).
// - "Latest Version Created At": LocalIsoDate, null on folder rows.
@@ -1212,27 +1213,28 @@ const PROMPT_ROWS: PromptRow[] = [
];
const promptColumns: LangfuseColumnDef<PromptRow>[] = [
- {
+ createFolderKeyTableColumn<PromptRow>({
accessorKey: "name",
header: "Name",
- id: "name",
enableSorting: true,
size: 250,
- cell: ({ row }) => {
- const { name, type, fullPath } = row.original;
+ getCell: (name, { row }) => {
+ if (!name) return undefined;
+ const { type, fullPath } = row.original;
if (type === "folder") {
- // Real folder cell: FolderBreadcrumbLink (TableLink + Folder icon).
- return <FolderBreadcrumbLink name={name} onClick={() => {}} />;
+ return { type: "folder", name, onClick: () => undefined };
}
- return name ? (
- <TableLink
- path={`/prompts/${encodeURIComponent(fullPath)}`}
- value={name}
- title={fullPath}
- />
- ) : undefined;
+
+ return {
+ type: "link",
+ props: {
+ path: `/prompts/${encodeURIComponent(fullPath)}`,
+ value: name,
+ title: fullPath,
+ },
+ };
},
- },
+ }),
{
accessorKey: "version",
header: "Versions",
@@ -1372,7 +1374,7 @@ export const WithFolderRows = meta.story({
// with the icon as a `shrink-0` adornment, so it lands on the same baseline
// as the no-icon rows.
// - TableLink with a leading icon (ListTree)
-// - FolderBreadcrumbLink (Folder icon)
+// - Folder link (Folder icon)
// A second plain-text column shows the row stays aligned across the table.
type IconCellRow = {
@@ -1442,7 +1444,19 @@ const iconCellColumns: LangfuseColumnDef<IconCellRow>[] = [
/>
);
case "folder":
- return <FolderBreadcrumbLink name={name} onClick={() => {}} />;
+ return (
+ <TableLink
+ path=""
+ value={name}
+ icon={
+ <span className="flex flex-row items-center gap-1">
+ <Folder className="h-3.5 w-3.5 shrink-0" />
+ {name}
+ </span>
+ }
+ onClick={() => undefined}
+ />
+ );
case "plain":
default:
return (
diff --git a/web/src/features/datasets/components/DatasetsTable.tsx b/web/src/features/datasets/components/DatasetsTable.tsx
index 3076a4489e..186418e4f8 100644
--- a/web/src/features/datasets/components/DatasetsTable.tsx
+++ b/web/src/features/datasets/components/DatasetsTable.tsx
@@ -1,6 +1,5 @@
import { IconOnlyButton } from "@/src/components/IconOnlyButton";
import { DataTable } from "@/src/components/table/data-table";
-import TableLink from "@/src/components/table/table-link";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import { DeleteDatasetDialogController } from "@/src/features/datasets/components/DeleteDatasetDialogController";
import { DatasetSchemaHoverCard } from "@/src/features/datasets/components/DatasetSchemaHoverCard";
@@ -24,12 +23,12 @@ import { IOTableCell } from "@/src/components/ui/IOTableCell";
import { useRowHeightLocalStorage } from "@/src/components/table/data-table-row-height-switch";
import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrder";
import { createDateTableColumn } from "@/src/components/design-system/Table/columns/createDateTableColumn";
+import { createFolderKeyTableColumn } from "@/src/components/design-system/Table/columns/createFolderKeyTableColumn";
import { joinTableCoreAndMetrics } from "@/src/components/table/utils/joinTableCoreAndMetrics";
import { useTableViewManager } from "@/src/components/table/table-view-presets/hooks/useTableViewManager";
import { useFolderPagination } from "@/src/features/folders/hooks/useFolderPagination";
import { FolderBreadcrumb } from "@/src/features/folders/components/FolderBreadcrumb";
import { buildFullPath } from "@/src/features/folders/utils";
-import { FolderBreadcrumbLink } from "@/src/features/folders/components/FolderBreadcrumbLink";
import { usePostHogClientCapture } from "@/src/features/posthog-analytics/usePostHogClientCapture";
import {
createDatasetsTableStore,
@@ -316,33 +315,32 @@ export function DatasetsTable(props: { projectId: string }) {
const columns: LangfuseColumnDef<DatasetTableRow>[] = [
selectActionColumn,
- {
+ createFolderKeyTableColumn<DatasetTableRow, DatasetTableRow["key"]>({
accessorKey: "key",
header: "Name",
- id: "key",
size: 150,
isFixedPosition: true,
- cell: ({ row }) => {
- const key: DatasetTableRow["key"] = row.getValue("key");
+ getCell: (key, { row }) => {
+ if (!key) return undefined;
const rowData = row.original;
if (rowData.isFolder) {
- return (
- <FolderBreadcrumbLink
- name={key.name}
- onClick={() => navigateToFolder(rowData.folderPath)}
- />
- );
+ return {
+ type: "folder",
+ name: key.name,
+ onClick: () => navigateToFolder(rowData.folderPath),
+ };
}
- return (
- <TableLink
- path={`/project/${props.projectId}/datasets/${encodeURIComponent(key.id)}/items`}
- value={key.name}
- />
- );
+ return {
+ type: "link",
+ props: {
+ path: `/project/${props.projectId}/datasets/${encodeURIComponent(key.id)}/items`,
+ value: key.name,
+ },
+ };
},
- },
+ }),
{
accessorKey: "description",
header: "Description",
diff --git a/web/src/features/folders/components/FolderBreadcrumbLink.tsx b/web/src/features/folders/components/FolderBreadcrumbLink.tsx
deleted file mode 100644
index 74c0459dba..0000000000
--- a/web/src/features/folders/components/FolderBreadcrumbLink.tsx
+++ /dev/null
@@ -1,25 +0,0 @@
-import TableLink from "@/src/components/table/table-link";
-import { Folder } from "lucide-react";
-
-export const FolderBreadcrumbLink = ({
- name,
- onClick,
-}: {
- name: string;
- onClick: () => void;
-}) => {
- return (
- <TableLink
- path=""
- value={name} // To satisfy table-link, fallback
- icon={
- <div className="flex flex-row items-center gap-1">
- <Folder className="h-3.5 w-3.5 shrink-0" />
- {name}
- </div>
- }
- onClick={onClick}
- title={name || ""}
- />
- );
-};
diff --git a/web/src/features/prompts/components/prompts-table.tsx b/web/src/features/prompts/components/prompts-table.tsx
index da72e9692b..912a758c9f 100644
--- a/web/src/features/prompts/components/prompts-table.tsx
+++ b/web/src/features/prompts/components/prompts-table.tsx
@@ -6,6 +6,7 @@ import {
} from "@/src/components/table/data-table-controls";
import { ResizableFilterLayout } from "@/src/components/table/resizable-filter-layout";
import TableLink from "@/src/components/table/table-link";
+import { createFolderKeyTableColumn } from "@/src/components/design-system/Table/columns/createFolderKeyTableColumn";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import { useDetailPageLists } from "@/src/features/navigate-detail-pages/context";
import { DeletePrompt } from "@/src/features/prompts/components/delete-prompt";
@@ -28,7 +29,6 @@ import { useFullTextSearch } from "@/src/components/table/use-cases/useFullTextS
import { useFolderPagination } from "@/src/features/folders/hooks/useFolderPagination";
import { buildFullPath } from "@/src/features/folders/utils";
import { FolderBreadcrumb } from "@/src/features/folders/components/FolderBreadcrumb";
-import { FolderBreadcrumbLink } from "@/src/features/folders/components/FolderBreadcrumbLink";
type PromptTableRow = {
id: string;
@@ -267,34 +267,33 @@ export function PromptTable() {
}, [prompts.isSuccess, prompts.data]);
const promptColumns: LangfuseColumnDef<PromptTableRow>[] = [
- {
+ createFolderKeyTableColumn<PromptTableRow>({
accessorKey: "name",
header: "Name",
- id: "name",
enableSorting: true,
size: 250,
- cell: ({ getValue, row }) => {
- const name = getValue<string>();
+ getCell: (name, { row }) => {
+ if (!name) return undefined;
const rowData = row.original;
if (rowData.type === "folder") {
- return (
- <FolderBreadcrumbLink
- name={name}
- onClick={() => navigateToFolder(rowData.fullPath)}
- />
- );
+ return {
+ type: "folder",
+ name,
+ onClick: () => navigateToFolder(rowData.fullPath),
+ };
}
- return name ? (
- <TableLink
- path={`/project/${projectId}/prompts/${encodeURIComponent(rowData.fullPath)}`}
- value={name}
- title={rowData.fullPath} // Show full prompt path on hover
- />
- ) : undefined;
+ return {
+ type: "link",
+ props: {
+ path: `/project/${projectId}/prompts/${encodeURIComponent(rowData.fullPath)}`,
+ value: name,
+ title: rowData.fullPath,
+ },
+ };
},
- },
+ }),
{
accessorKey: "version",
header: "Versions",