Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(worker): preserve deprecated API usage rows (#16718)

Hassieb Pakzadcd4ca316475e
diff --git a/worker/src/features/v4/__tests__/handleV4LegacyApiUsageJob.test.ts b/worker/src/features/v4/__tests__/handleV4LegacyApiUsageJob.test.ts
index e792baeeef..3f0c6e58d0 100644
--- a/worker/src/features/v4/__tests__/handleV4LegacyApiUsageJob.test.ts
+++ b/worker/src/features/v4/__tests__/handleV4LegacyApiUsageJob.test.ts
@@ -330,7 +330,7 @@ describe("handleV4LegacyApiUsageJob", () => {
expect(query).toContain(
"topK(20)(tuple(sdk_name, sdk_version, user_agent))",
);
- expect(query).toContain("ANY INNER JOIN caller_candidates");
+ expect(query).toContain("ALL INNER JOIN caller_candidates");
expect(query).toContain(
"GROUP BY hourStart, projectId, route, sdkName, sdkVersion, userAgent, isOther",
);
diff --git a/worker/src/features/v4/handleV4LegacyApiUsageJob.ts b/worker/src/features/v4/handleV4LegacyApiUsageJob.ts
index 29ca0d5c9c..e502f8946f 100644
--- a/worker/src/features/v4/handleV4LegacyApiUsageJob.ts
+++ b/worker/src/features/v4/handleV4LegacyApiUsageJob.ts
@@ -230,7 +230,9 @@ bounded AS (
classified.*,
has(caller_candidates.caller_keys, tuple(sdk_name, sdk_version, user_agent)) AS retain_caller
FROM classified
- ANY INNER JOIN caller_candidates
+ -- Preserve every classified query row. caller_candidates is unique per join key,
+ -- so ALL cannot multiply matches.
+ ALL INNER JOIN caller_candidates
ON classified.project_id = caller_candidates.project_id
AND classified.legacy_route = caller_candidates.legacy_route
WHERE classified.legacy_route IS NOT NULL