Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Fix no-null-render: PromptBadge.tsx (#18223)

Ben Bachemcf976fdaeae1
diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx
index defab43934..90b93e8937 100644
--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx
+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader/ObservationDetailViewHeader.tsx
@@ -118,6 +118,10 @@ export const ObservationDetailViewHeader = memo(
scores: serverScores.filter((score) => !score.observationId),
}
: undefined;
+ const prompt = api.prompts.byId.useQuery(
+ { id: observation.promptId ?? "", projectId },
+ { enabled: Boolean(observation.promptId) },
+ );
// Format cost and usage values
const totalCost = observation.totalCost;
@@ -523,9 +527,10 @@ export const ObservationDetailViewHeader = memo(
{observation.level !== "DEFAULT" && (
<ObservationLevelBadge level={observation.level} />
)}
- {observation.promptId && (
+ {observation.promptId && !prompt.isLoading && prompt.data && (
<PromptBadge
- promptId={observation.promptId}
+ promptName={prompt.data.name}
+ promptVersion={prompt.data.version}
projectId={projectId}
/>
)}
diff --git a/web/src/features/traces/components/PromptBadge.tsx b/web/src/features/traces/components/PromptBadge.tsx
index a1a7c8e15f..5dbedb6f27 100644
--- a/web/src/features/traces/components/PromptBadge.tsx
+++ b/web/src/features/traces/components/PromptBadge.tsx
@@ -1,22 +1,16 @@
-/* eslint-disable @repo/no-null-render */
import Link from "next/link";
import { ExternalLinkIcon } from "lucide-react";
import { Badge } from "@/src/components/design-system/Badge/Badge";
-import { api } from "@/src/utils/api";
-
-export const PromptBadge = (props: { promptId: string; projectId: string }) => {
- const prompt = api.prompts.byId.useQuery({
- id: props.promptId,
- projectId: props.projectId,
- });
-
- if (prompt.isLoading || !prompt.data) return null;
-
- const text = `Prompt: ${prompt.data.name} - v${prompt.data.version}`;
+export const PromptBadge = (props: {
+ promptName: string;
+ promptVersion: number;
+ projectId: string;
+}) => {
+ const text = `Prompt: ${props.promptName} - v${props.promptVersion}`;
return (
<Link
- href={`/project/${props.projectId}/prompts/${encodeURIComponent(prompt.data.name)}?version=${prompt.data.version}`}
+ href={`/project/${props.projectId}/prompts/${encodeURIComponent(props.promptName)}?version=${props.promptVersion}`}
className="inline-flex"
>
<Badge text={text} trailingIcon={ExternalLinkIcon} />