Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(media): treat Azure Blob 201 Created as a completed upload (#18300)

Hassieb Pakzadd148a1937d65
diff --git a/packages/shared/src/server/repositories/dataset-item-media.ts b/packages/shared/src/server/repositories/dataset-item-media.ts
index bd898ea3ba..71e8656585 100644
--- a/packages/shared/src/server/repositories/dataset-item-media.ts
+++ b/packages/shared/src/server/repositories/dataset-item-media.ts
@@ -135,8 +135,7 @@ export async function markDatasetMediaUploadComplete(props: {
data: {
uploadedAt: props.uploadedAt,
uploadHttpStatus: props.uploadHttpStatus,
- uploadHttpError:
- props.uploadHttpStatus === 200 ? null : props.uploadHttpError,
+ uploadHttpError: isCompletingUpload ? null : props.uploadHttpError,
},
});
diff --git a/web/src/__tests__/server/media.servertest.ts b/web/src/__tests__/server/media.servertest.ts
index 1974bc48b1..10b7908372 100644
--- a/web/src/__tests__/server/media.servertest.ts
+++ b/web/src/__tests__/server/media.servertest.ts
@@ -8,10 +8,13 @@ import { z } from "zod";
import { makeZodVerifiedAPICallSilent } from "@/src/__tests__/test-utils";
import { env } from "@/src/env.mjs";
import {
+ createMediaUploadUrl,
type GetMediaResponse,
GetMediaResponseSchema,
type GetMediaUploadUrlResponse,
GetMediaUploadUrlResponseSchema,
+ MediaContentType,
+ updateMediaUploadStatus,
} from "@/src/features/media/server";
import { appRouter } from "@/src/server/api/root";
import { createInnerTRPCContext } from "@/src/server/api/trpc";
@@ -802,6 +805,49 @@ describe("Media Upload API", () => {
}, 10_000);
});
+ // Azure Blob Storage answers a successful Put Blob with 201 Created.
+ describe("Azure Blob upload status", () => {
+ it("treats a 201 upload as completed and reuses the media", async () => {
+ const uploadRequest = {
+ contentType: MediaContentType.PNG,
+ contentLength: validPNG.contentLength,
+ sha256Hash: validPNG.sha256Hash,
+ traceId: `trace-${crypto.randomUUID()}`,
+ field: "input",
+ };
+
+ const first = await createMediaUploadUrl({
+ projectId,
+ body: uploadRequest,
+ });
+ expect(first.uploadUrl).toEqual(expect.any(String));
+
+ await updateMediaUploadStatus({
+ projectId,
+ mediaId: first.mediaId,
+ body: {
+ uploadedAt: new Date(),
+ uploadHttpStatus: 201,
+ uploadHttpError: "",
+ },
+ });
+
+ const media = await prisma.media.findUnique({
+ where: { projectId_id: { projectId, id: first.mediaId } },
+ });
+ expect(media).toMatchObject({
+ uploadHttpStatus: 201,
+ uploadHttpError: null,
+ });
+
+ const second = await createMediaUploadUrl({
+ projectId,
+ body: { ...uploadRequest, traceId: `trace-${crypto.randomUUID()}` },
+ });
+ expect(second).toEqual({ mediaId: first.mediaId, uploadUrl: null });
+ });
+ });
+
describe("tRPC media reader", () => {
it("ignores media link rows without a media parent", async () => {
const traceId = `trace-${crypto.randomUUID()}`;
diff --git a/web/src/features/media/server/mediaService.ts b/web/src/features/media/server/mediaService.ts
index e7bbc8d0cc..be6ec49a4f 100644
--- a/web/src/features/media/server/mediaService.ts
+++ b/web/src/features/media/server/mediaService.ts
@@ -80,7 +80,8 @@ export async function createMediaUploadUrl(params: {
if (
existingMedia &&
- existingMedia.uploadHttpStatus === 200 &&
+ (existingMedia.uploadHttpStatus === 200 ||
+ existingMedia.uploadHttpStatus === 201) &&
existingMedia.contentType === contentType
) {
await linkUploadedMedia(mediaId);
@@ -193,7 +194,10 @@ export async function updateMediaUploadStatus(params: {
data: {
uploadedAt,
uploadHttpStatus,
- uploadHttpError: uploadHttpStatus === 200 ? null : uploadHttpError,
+ uploadHttpError:
+ uploadHttpStatus === 200 || uploadHttpStatus === 201
+ ? null
+ : uploadHttpError,
},
});