🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
refactor(web): Clean up `DetailHeaderActionsMenu` (#16591)
Ben Bachemd1e43fd2559b
diff --git a/web/src/features/traces/components/DetailHeaderActionsMenu.tsx b/web/src/features/traces/components/DetailHeaderActionsMenu.tsxdeleted file mode 100644index f193071e17..0000000000--- a/web/src/features/traces/components/DetailHeaderActionsMenu.tsx+++ /dev/null@@ -1,146 +0,0 @@-/* eslint-disable @repo/no-abstracted-overlay-trigger */-import { useRouter } from "next/router";-import { CheckIcon, CopyIcon, EllipsisVertical } from "lucide-react";-import { useState } from "react";-import { Button } from "@/src/components/ui/button";-import {- DropdownMenu,- DropdownMenuContent,- DropdownMenuItem,- DropdownMenuSeparator,- DropdownMenuTrigger,-} from "@/src/components/ui/dropdown-menu";-import {- buildEventsTablePathForObservationType,- buildEventsTablePathForSpanName,-} from "@/src/features/events/lib/eventsTablePaths";-import { copyTextToClipboard } from "@/src/utils/clipboard";-import { type ObservationType } from "@langfuse/shared";-import { WebCalloutMenuItem } from "@/src/features/web-callouts/components/WebCalloutMenuItem";--type IdItem = {- name: string;- id: string;-};--type DetailHeaderActionsMenuProps = {- idItems: IdItem[];- observationType?: ObservationType;- projectId: string;- spanName?: string;- webCallout?: {- traceId: string | null;- observationId?: string | null;- sessionId?: string | null;- };-};--export function DetailHeaderActionsMenu({- idItems,- observationType,- projectId,- spanName,- webCallout,-}: DetailHeaderActionsMenuProps) {- const router = useRouter();- const [copiedId, setCopiedId] = useState<string | null>(null);-- const handleCopy = (textToCopy: string) => {- copyTextToClipboard(textToCopy);- setCopiedId(textToCopy);- setTimeout(() => setCopiedId(null), 1500);- };-- const shouldShowFilterItem = Boolean(spanName?.trim());-- const href = shouldShowFilterItem- ? buildEventsTablePathForSpanName({- currentPath: router.asPath,- projectId,- spanName: spanName ?? "",- })- : null;-- const typeHref = observationType- ? buildEventsTablePathForObservationType({- currentPath: router.asPath,- projectId,- observationType,- })- : null;-- const filterTypeLabel = observationType ? `type:${observationType}` : null;-- return (- <DropdownMenu>- <DropdownMenuTrigger asChild>- <Button- aria-label="Options"- className="mt-0.5 shrink-0"- size="icon-xs"- title="Options"- variant="ghost"- >- <EllipsisVertical className="h-4 w-4" />- </Button>- </DropdownMenuTrigger>- <DropdownMenuContent align="start">- {webCallout && (- <>- <WebCalloutMenuItem- projectId={projectId}- traceId={webCallout.traceId}- observationId={webCallout.observationId}- sessionId={webCallout.sessionId}- withSeparator- />- </>- )}- {(href || typeHref) && (- <>- {href && (- <DropdownMenuItem- className="text-xs"- onSelect={() => router.push(href)}- >- <span className="max-w-[260px] truncate" title={spanName}>- filter by <span className="font-bold">name:{spanName}</span>- </span>- </DropdownMenuItem>- )}- {typeHref && filterTypeLabel && (- <DropdownMenuItem- className="text-xs"- onSelect={() => router.push(typeHref)}- >- <span- className="max-w-[260px] truncate"- title={filterTypeLabel}- >- filter by <span className="font-bold">{filterTypeLabel}</span>- </span>- </DropdownMenuItem>- )}- <DropdownMenuSeparator />- </>- )}- {idItems.map((item) => (- <DropdownMenuItem- key={item.id}- className="text-xs"- onSelect={() => handleCopy(item.id)}- >- {copiedId === item.id ? (- <CheckIcon className="text-muted-green mr-2 h-4 w-4" />- ) : (- <CopyIcon className="mr-2 h-4 w-4" />- )}- <span className="max-w-[260px] truncate" title={item.id}>- Copy {item.name}- </span>- </DropdownMenuItem>- ))}- </DropdownMenuContent>- </DropdownMenu>- );-}diff --git a/web/src/features/traces/components/DetailHeaderActionsMenuController.stories.tsx b/web/src/features/traces/components/DetailHeaderActionsMenuController.stories.tsxnew file mode 100644index 0000000000..c0a7ce652b--- /dev/null+++ b/web/src/features/traces/components/DetailHeaderActionsMenuController.stories.tsx@@ -0,0 +1,41 @@+import { EllipsisVertical } from "lucide-react";++import { Button } from "@/src/components/ui/button";+import { DetailHeaderActionsMenuController } from "./DetailHeaderActionsMenuController";+import preview from "../../../../.storybook/preview";++function DetailHeaderActionsMenuStory() {+ return (+ <DetailHeaderActionsMenuController+ idItems={[{ id: "storybook-trace", name: "Trace ID" }]}+ projectId="storybook-project"+ >+ {({ Trigger }) => (+ <Trigger asChild>+ <Button+ aria-label="Options"+ size="icon-xs"+ title="Options"+ variant="ghost"+ >+ <EllipsisVertical className="h-4 w-4" />+ </Button>+ </Trigger>+ )}+ </DetailHeaderActionsMenuController>+ );+}++const meta = preview.meta({+ component: DetailHeaderActionsMenuStory,+ parameters: {+ layout: "centered",+ nextjs: {+ router: {+ asPath: "/project/storybook-project/traces/storybook-trace",+ },+ },+ },+});++export const Default = meta.story({});diff --git a/web/src/features/traces/components/DetailHeaderActionsMenuController.tsx b/web/src/features/traces/components/DetailHeaderActionsMenuController.tsxnew file mode 100644index 0000000000..0ddf932da4--- /dev/null+++ b/web/src/features/traces/components/DetailHeaderActionsMenuController.tsx@@ -0,0 +1,137 @@+import { useRouter } from "next/router";+import { CheckIcon, CopyIcon } from "lucide-react";+import { useState, type ComponentProps } from "react";+import {+ DropdownMenuItem,+ DropdownMenuSeparator,+ DropdownMenuController,+} from "@/src/components/ui/dropdown-menu";+import {+ buildEventsTablePathForObservationType,+ buildEventsTablePathForSpanName,+} from "@/src/features/events/lib/eventsTablePaths";+import { copyTextToClipboard } from "@/src/utils/clipboard";+import { type ObservationType } from "@langfuse/shared";+import { WebCalloutMenuItem } from "@/src/features/web-callouts/components/WebCalloutMenuItem";++type IdItem = {+ name: string;+ id: string;+};++type DetailHeaderActionsMenuControllerProps = {+ idItems: IdItem[];+ observationType?: ObservationType;+ projectId: string;+ spanName?: string;+ webCallout?: {+ traceId: string | null;+ observationId?: string | null;+ sessionId?: string | null;+ };+ children: ComponentProps<typeof DropdownMenuController>["children"];+};++export function DetailHeaderActionsMenuController({+ idItems,+ observationType,+ projectId,+ spanName,+ webCallout,+ children,+}: DetailHeaderActionsMenuControllerProps) {+ const router = useRouter();+ const [copiedId, setCopiedId] = useState<string | null>(null);++ const handleCopy = (textToCopy: string) => {+ copyTextToClipboard(textToCopy);+ setCopiedId(textToCopy);+ setTimeout(() => setCopiedId(null), 1500);+ };++ const shouldShowFilterItem = Boolean(spanName?.trim());++ const href = shouldShowFilterItem+ ? buildEventsTablePathForSpanName({+ currentPath: router.asPath,+ projectId,+ spanName: spanName ?? "",+ })+ : null;++ const typeHref = observationType+ ? buildEventsTablePathForObservationType({+ currentPath: router.asPath,+ projectId,+ observationType,+ })+ : null;++ const filterTypeLabel = observationType ? `type:${observationType}` : null;++ return (+ <DropdownMenuController+ align="start"+ renderMenu={() => (+ <>+ {webCallout && (+ <WebCalloutMenuItem+ projectId={projectId}+ traceId={webCallout.traceId}+ observationId={webCallout.observationId}+ sessionId={webCallout.sessionId}+ withSeparator+ />+ )}+ {(href || typeHref) && (+ <>+ {href && (+ <DropdownMenuItem+ className="text-xs"+ onSelect={() => router.push(href)}+ >+ <span className="max-w-[260px] truncate" title={spanName}>+ filter by <span className="font-bold">name:{spanName}</span>+ </span>+ </DropdownMenuItem>+ )}+ {typeHref && filterTypeLabel && (+ <DropdownMenuItem+ className="text-xs"+ onSelect={() => router.push(typeHref)}+ >+ <span+ className="max-w-[260px] truncate"+ title={filterTypeLabel}+ >+ filter by{" "}+ <span className="font-bold">{filterTypeLabel}</span>+ </span>+ </DropdownMenuItem>+ )}+ <DropdownMenuSeparator />+ </>+ )}+ {idItems.map((item) => (+ <DropdownMenuItem+ key={item.id}+ className="text-xs"+ onSelect={() => handleCopy(item.id)}+ >+ {copiedId === item.id ? (+ <CheckIcon className="text-muted-green mr-2 h-4 w-4" />+ ) : (+ <CopyIcon className="mr-2 h-4 w-4" />+ )}+ <span className="max-w-[260px] truncate" title={item.id}>+ Copy {item.name}+ </span>+ </DropdownMenuItem>+ ))}+ </>+ )}+ >+ {children}+ </DropdownMenuController>+ );+}diff --git a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsxindex 974be85f27..db04387d2f 100644--- a/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx+++ b/web/src/features/traces/components/ObservationDetailView/components/ObservationDetailViewHeader.tsx@@ -46,13 +46,14 @@ import {} from "@/src/utils/clientSideDomainTypes";import { type AggregatedTraceMetrics } from "@/src/features/traces/fns/traceAggregation";import type Decimal from "decimal.js";-import { DetailHeaderActionsMenu } from "@/src/features/traces/components/DetailHeaderActionsMenu";+import { DetailHeaderActionsMenuController } from "@/src/features/traces/components/DetailHeaderActionsMenuController";import { useViewPreferences } from "@/src/features/traces/contexts/ViewPreferencesContext";import { useV4Beta } from "@/src/features/events/hooks/useV4Beta";import { useTraceData } from "@/src/features/traces/contexts/TraceDataContext";import { Button } from "@/src/components/ui/button";import {ChevronDown,+ EllipsisVertical,ListPlus,LockIcon,MoreHorizontal,@@ -151,7 +152,7 @@ export const ObservationDetailViewHeader = memo(>{observation.name || observation.id}</span>- <DetailHeaderActionsMenu+ <DetailHeaderActionsMenuControlleridItems={[{ id: traceId, name: "Trace ID" },{ id: observation.id, name: "Observation ID" },@@ -164,7 +165,21 @@ export const ObservationDetailViewHeader = memo(observationId: observation.id,sessionId: observation.sessionId ?? null,}}- />+ >+ {({ Trigger }) => (+ <Trigger asChild>+ <Button+ aria-label="Options"+ className="mt-0.5 shrink-0"+ size="icon-xs"+ title="Options"+ variant="ghost"+ >+ <EllipsisVertical className="h-4 w-4" />+ </Button>+ </Trigger>+ )}+ </DetailHeaderActionsMenuController>{/* Mobile: collapse the action-button cluster into a `⋯` overflow offull-width labeled rows, next to the `⋮` utility menu. */}{isMobile && (diff --git a/web/src/features/traces/components/TraceDetailView/components/TraceDetailViewHeader.tsx b/web/src/features/traces/components/TraceDetailView/components/TraceDetailViewHeader.tsxindex b16a68a4aa..b5a5ef43a3 100644--- a/web/src/features/traces/components/TraceDetailView/components/TraceDetailViewHeader.tsx+++ b/web/src/features/traces/components/TraceDetailView/components/TraceDetailViewHeader.tsx@@ -21,7 +21,7 @@ import { type WithStringifiedMetadata } from "@/src/utils/clientSideDomainTypes"import { type ObservationReturnTypeWithMetadata } from "@/src/server/api/routers/traces";import { ItemBadge } from "@/src/components/ItemBadge";import { LocalIsoDate } from "@/src/components/LocalIsoDate";-import { DetailHeaderActionsMenu } from "@/src/features/traces/components/DetailHeaderActionsMenu";+import { DetailHeaderActionsMenuController } from "@/src/features/traces/components/DetailHeaderActionsMenuController";import { NewDatasetItemFromExistingObject } from "@/src/features/datasets/components/NewDatasetItemFromExistingObject";import { AnnotateDrawer } from "@/src/features/scores/components/AnnotateDrawer";import { AnnotationQueueItemDropdownMenuController } from "@/src/features/annotation-queues/components/AnnotationQueueItemDropdownMenuController";@@ -43,7 +43,12 @@ import { useViewPreferences } from "@/src/features/traces/contexts/ViewPreferencimport { CollapsibleBadgeRow } from "@/src/features/traces/components/CollapsibleBadgeRow";import { useIsMobile } from "@/src/hooks/use-mobile";import { Button } from "@/src/components/ui/button";-import { ChevronDown, ListPlus, MoreHorizontal } from "lucide-react";+import {+ ChevronDown,+ EllipsisVertical,+ ListPlus,+ MoreHorizontal,+} from "lucide-react";import {Popover,PopoverContent,@@ -107,14 +112,28 @@ export const TraceDetailViewHeader = memo(function TraceDetailViewHeader({>{trace.name || trace.id}</span>- <DetailHeaderActionsMenu+ <DetailHeaderActionsMenuControlleridItems={[{ id: trace.id, name: "Trace ID" }]}projectId={projectId}webCallout={{traceId: trace.id,sessionId: trace.sessionId ?? null,}}- />+ >+ {({ Trigger }) => (+ <Trigger asChild>+ <Button+ aria-label="Options"+ className="mt-0.5 shrink-0"+ size="icon-xs"+ title="Options"+ variant="ghost"+ >+ <EllipsisVertical className="h-4 w-4" />+ </Button>+ </Trigger>+ )}+ </DetailHeaderActionsMenuController>{/* Mobile: collapse the action-button cluster into a `⋯` overflow offull-width labeled rows, next to the `⋮` utility menu. */}{isMobile && (