🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(sessions): Allow collapsing traces (#19218)
Ben Bachemd36a7ac35950
diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/SessionConversationalView.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/SessionConversationalView.tsxindex bf42273dfb..41b4bc2880 100644--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/SessionConversationalView.tsx+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/SessionConversationalView.tsx@@ -1,4 +1,10 @@-import { type ComponentProps, useLayoutEffect, useId, useRef } from "react";+import {+ type ComponentProps,+ useLayoutEffect,+ useId,+ useRef,+ useState,+} from "react";import { Search } from "@langfuse/icons";import { Input } from "@/src/components/ui/input";import {@@ -45,6 +51,9 @@ export function SessionConversationalView(},) {const transcriptRef = useRef<HTMLDivElement>(null);+ const [collapsedTraceIds, setCollapsedTraceIds] = useState<Set<string>>(+ new Set(),+ );const [workspaceRef, workspaceSize] = useElementSize<HTMLDivElement>();const showSidebar = (workspaceSize?.width ?? 0) >= 768;const { defaultLayout, onLayoutChanged } = useDefaultLayout({@@ -137,6 +146,15 @@ export function SessionConversationalView(return {...item,...entry,+ isCollapsed: collapsedTraceIds.has(item.trace.id),+ onToggleCollapsed: () => {+ setCollapsedTraceIds((current) => {+ const next = new Set(current);+ if (next.has(item.trace.id)) next.delete(item.trace.id);+ else next.add(item.trace.id);+ return next;+ });+ },scrollTarget:item.scrollTarget?.itemId && item.scrollTarget.itemId !== entry.itemId? null@@ -247,6 +265,18 @@ export function SessionConversationalView(...props,traces: sidebarTraces,activeTraceId: props.controller.activeItemId ?? undefined,+ onSelect: (...args: Parameters<typeof props.onSelect>) => {+ const item = timelineItems[args[0]];+ if (item) {+ setCollapsedTraceIds((current) => {+ if (!current.has(item.trace.id)) return current;+ const next = new Set(current);+ next.delete(item.trace.id);+ return next;+ });+ }+ props.onSelect(...args);+ },};return (<divdiff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/SessionConversationTimeline.stories.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/SessionConversationTimeline.stories.tsxindex e5f4d7f189..78f5deac85 100644--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/SessionConversationTimeline.stories.tsx+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/SessionConversationTimeline.stories.tsx@@ -171,7 +171,7 @@ export const TimelineNavigation = meta.story({"href",args.navigation?.previousTrace?.href,);- const firstHeader = canvas.getByRole("button", { name: "1 Turn 1" });+ const firstHeader = canvas.getByRole("button", { name: "Turn 1" });expect(previous.compareDocumentPosition(firstHeader)).toBe(Node.DOCUMENT_POSITION_FOLLOWING,);@@ -182,7 +182,7 @@ export const TimelineNavigation = meta.story({});await expect(next).toBeVisible();expect(next).toHaveAttribute("href", args.navigation?.nextTrace?.href);- const lastHeader = canvas.getByRole("button", { name: "3 Turn 3" });+ const lastHeader = canvas.getByRole("button", { name: "Turn 3" });expect(lastHeader.compareDocumentPosition(next)).toBe(Node.DOCUMENT_POSITION_FOLLOWING,);diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/SessionConversationTimeline.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/SessionConversationTimeline.tsxindex 347c521d7d..d7589618b7 100644--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/SessionConversationTimeline.tsx+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/SessionConversationTimeline.tsx@@ -88,7 +88,12 @@ export function SessionConversationTimeline({</div>)}<div className={isSingleTraceView ? "flex-1" : undefined}>- <SessionConversationTimelineTrace {...traceProps} />+ {(!traceProps.isCollapsed ||+ traces.findIndex(+ (item) => item.trace.id === traceProps.trace.id,+ ) === virtualItem.index) && (+ <SessionConversationTimelineTrace {...traceProps} />+ )}</div>{virtualItem.index === traces.length - 1 &&navigation?.nextTrace && (diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.stories.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.stories.tsxindex 28f1c44fd1..afee3d7104 100644--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.stories.tsx+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.stories.tsx@@ -1,6 +1,6 @@import type { JsonValue } from "@langfuse/shared/src/utils/normalized-io";import preview from "@/.storybook/preview";-import { type ComponentProps } from "react";+import { type ComponentProps, useState } from "react";import { expect, fn, userEvent, waitFor, within } from "storybook/test";import { SessionConversationTimelineTrace } from "@/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace";import { type EventSessionTrace } from "@/src/features/sessions/sessionDetailPageTypes";@@ -153,6 +153,39 @@ const weatherState = transcriptState({history: result.transcript?.threads[0]?.conversationHistory ?? [],});+export const CollapsibleTrace = meta.story({+ name: "(Test) Collapsible Trace",+ args: { ...commonArgs, state: { type: "empty" } },+ render: function Render(args) {+ const [isCollapsed, setIsCollapsed] = useState(false);+ return (+ <SessionConversationTimelineTrace+ {...args}+ isCollapsed={isCollapsed}+ onToggleCollapsed={() => setIsCollapsed((current) => !current)}+ />+ );+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ const toggle = canvas.getByRole("button", {+ name: "Collapse trace Weather assistant",+ });+ await expect(toggle).toHaveAttribute("aria-expanded", "true");+ await userEvent.click(toggle);+ await expect(+ canvas.queryByText("This trace has no messages."),+ ).not.toBeInTheDocument();+ await expect(canvas.getByText("Weather assistant")).toBeInTheDocument();+ await userEvent.click(+ canvas.getByRole("button", { name: "Expand trace Weather assistant" }),+ );+ await expect(+ canvas.getByText("This trace has no messages."),+ ).toBeInTheDocument();+ },+});+function toolPreviewState(previews: {name: string;@@ -269,7 +302,7 @@ export const FirstThreadHeader = meta.story({play: async ({ canvasElement }) => {const canvas = within(canvasElement);await expect(- canvas.getByRole("button", { name: `1 ${trace.name}` }),+ canvas.getByRole("button", { name: trace.name ?? "Trace" }),).toBeInTheDocument();await expect(canvas.getByRole("heading", { name: "Thread 1" }),@@ -332,7 +365,7 @@ export const SingleThreadHeader = meta.story({play: async ({ canvasElement }) => {const canvas = within(canvasElement);await expect(- canvas.getByRole("button", { name: `1 ${trace.name}` }),+ canvas.getByRole("button", { name: trace.name ?? "Trace" }),).toBeInTheDocument();await expect(canvas.queryByRole("heading")).not.toBeInTheDocument();},@@ -904,11 +937,9 @@ export const KeepDifferentToolData = meta.story({});export const SystemPromptHistory = meta.story({- name: "(Test) System Prompt Navigation",+ name: "System Prompt History",args: {...commonArgs,- onOpenTrace: fn(),- onOpenObservation: fn(),state: transcriptState({history: [{@@ -945,27 +976,6 @@ export const SystemPromptHistory = meta.story({],}),},- play: async ({ args, canvasElement }) => {- const canvas = within(canvasElement);- await expect(- canvas.queryByText("Inspect representative failures."),- ).not.toBeInTheDocument();- await userEvent.click(- canvas.getByRole("button", { name: `1 ${trace.name}` }),- );- await expect(args.onOpenTrace).toHaveBeenCalledTimes(1);- const prompt = canvas.getByRole("button", { name: "System prompt" });- await userEvent.click(prompt);- await expect(canvas.getByText("Current system instructions")).toBeVisible();- const systemMessage = canvasElement.querySelector<HTMLElement>(- "[data-session-system-row]",- )!;- await userEvent.click(- within(systemMessage).getByRole("button", { name: "Open observation" }),- );- await expect(args.onOpenObservation).toHaveBeenCalledTimes(1);- await expect(args.onOpenObservation).toHaveBeenCalledWith("generation-1");- },});export const ToolFailure = meta.story({diff --git a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsxindex 6b6bb97764..71c0b5d3cd 100644--- a/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx+++ b/web/src/features/sessions/components/ConnectedModernSessionBodyTimeline/components/ConnectedSessionConversationTimeline/components/SessionConversationalView/components/SessionConversationTimeline/components/SessionConversationTimelineTrace/SessionConversationTimelineTrace.tsx@@ -1,4 +1,9 @@-import { GitBranch, MessageSquareOff } from "@langfuse/icons";+import {+ ChevronDown,+ ChevronRight,+ GitBranch,+ MessageSquareOff,+} from "@langfuse/icons";import { type EventSessionTrace } from "@/src/features/sessions/sessionDetailPageTypes";import { Skeleton } from "@/src/components/ui/skeleton";import { Tooltip } from "@/src/components/design-system/Tooltip/Tooltip";@@ -29,7 +34,11 @@ export function SessionConversationTimelineTrace({threadCount,variant = "session",includeNestedThreads = false,+ isCollapsed = false,+ onToggleCollapsed,}: {+ isCollapsed?: boolean;+ onToggleCollapsed?: () => void;includeNestedThreads?: boolean;variant?: "session" | "single-trace";itemId?: string;@@ -68,7 +77,8 @@ export function SessionConversationTimelineTrace({return (<divclassName={cn(- variant === "single-trace" ? "p-0" : "px-4 pb-8 sm:px-6 lg:px-10",+ variant === "single-trace" ? "p-0" : "px-4 sm:px-6 lg:px-10",+ variant === "session" && !isCollapsed && "pb-8",)}data-session-trace-id={trace.id}data-session-item-id={itemId}@@ -77,24 +87,51 @@ export function SessionConversationTimelineTrace({<divclassName={cn("group/trace-header flex items-center gap-3 pt-4",- showThreadHeader ? "mb-3" : "mb-6",+ isCollapsed && "pb-1",+ !isCollapsed && (showThreadHeader ? "mb-3" : "mb-6"),)}>- <button- type="button"- className="text-foreground hover:text-primary ph-no-capture flex min-w-0 items-center gap-2 text-sm font-bold transition-colors"- onClick={onOpenTrace}- title={`${trace.name ?? "Trace"} (${trace.id})`}- >- <span className="border-border bg-tertiary text-foreground flex h-4 min-w-4 shrink-0 items-center justify-center rounded-sm border px-0.5 font-mono text-[10px]">- {variant === "session"- ? turnNumber- : (displayNumber ?? turnNumber)}- </span>- <span className="truncate" title={trace.name ?? "Trace"}>- <span data-session-search-content>{trace.name ?? "Trace"}</span>- </span>- </button>+ <div className="flex min-w-0 items-center gap-2">+ <div className="relative shrink-0">+ <span+ className={cn(+ "border-border bg-tertiary text-foreground flex h-4 min-w-4 items-center justify-center rounded-sm border px-0.5 font-mono text-[10px]",+ variant === "session" &&+ onToggleCollapsed &&+ "group-focus-within/trace-header:invisible group-hover/trace-header:invisible",+ )}+ >+ {variant === "session"+ ? turnNumber+ : (displayNumber ?? turnNumber)}+ </span>+ {variant === "session" && onToggleCollapsed && (+ <button+ type="button"+ onClick={onToggleCollapsed}+ aria-expanded={!isCollapsed}+ aria-label={`${isCollapsed ? "Expand" : "Collapse"} trace ${trace.name ?? "Trace"}`}+ className="text-muted-foreground hover:text-foreground ph-no-capture absolute -inset-1 flex items-center justify-center opacity-0 group-focus-within/trace-header:opacity-100 group-hover/trace-header:opacity-100"+ >+ {isCollapsed ? (+ <ChevronRight size="base" />+ ) : (+ <ChevronDown size="base" />+ )}+ </button>+ )}+ </div>+ <button+ type="button"+ className="text-foreground hover:text-primary ph-no-capture flex min-w-0 items-center gap-2 text-sm font-bold transition-colors"+ onClick={onOpenTrace}+ title={`${trace.name ?? "Trace"} (${trace.id})`}+ >+ <span className="truncate" title={trace.name ?? "Trace"}>+ <span data-session-search-content>{trace.name ?? "Trace"}</span>+ </span>+ </button>+ </div><div className="border-border min-w-0 flex-1 border-t border-dashed" /><buttontype="button"@@ -136,85 +173,89 @@ export function SessionConversationTimelineTrace({</div>)}- {showThreadHeader && (- <div- className={cn(- "group/thread-header text-muted-foreground mb-5 flex items-center gap-2 text-xs",- !showHeader && "pt-3",- )}- >- <span className="bg-muted text-muted-foreground flex h-4 min-w-4 shrink-0 items-center justify-center rounded-sm px-1 font-mono text-[10px]">- {displayNumber ?? `${turnNumber}.${visibleThreadIndex + 1}`}- </span>- <h3>Thread {visibleThreadIndex + 1}</h3>- {visibleThreadIndex > 0 && (- <>- <div className="border-border min-w-0 flex-1 border-t border-dashed" />- <button- type="button"- className="text-muted-foreground hover:text-foreground shrink-0 font-mono text-xs opacity-0 group-focus-within/thread-header:opacity-100 group-hover/thread-header:opacity-100 hover:underline focus-visible:opacity-100"- onClick={onOpenTrace}- >- Open trace- </button>- </>- )}- </div>- )}-- {state.type === "loading" && (- <div- role="status"- aria-label="Loading messages"- className="flex flex-col gap-5 py-2"- >- <div className="flex items-center gap-2 py-1">- <Skeleton className="h-3.5 w-3.5 shrink-0 rounded-full" />- <Skeleton className="h-3 w-28" />- <Skeleton className="h-3 w-3 shrink-0" />- </div>- {(["user", "assistant"] as const).map((role) => (+ {!isCollapsed && (+ <>+ {showThreadHeader && (<div- key={role}className={cn(- "flex w-full",- role === "user" ? "justify-end" : "justify-start",+ "group/thread-header text-muted-foreground mb-5 flex items-center gap-2 text-xs",+ !showHeader && "pt-3",)}>- <Skeleton- className={cn(- "max-w-[min(85%,48rem)] rounded-2xl",- role === "user" ? "h-20 w-3/5" : "h-24 w-4/5",- )}- />+ <span className="bg-muted text-muted-foreground flex h-4 min-w-4 shrink-0 items-center justify-center rounded-sm px-1 font-mono text-[10px]">+ {displayNumber ?? `${turnNumber}.${visibleThreadIndex + 1}`}+ </span>+ <h3>Thread {visibleThreadIndex + 1}</h3>+ {visibleThreadIndex > 0 && (+ <>+ <div className="border-border min-w-0 flex-1 border-t border-dashed" />+ <button+ type="button"+ className="text-muted-foreground hover:text-foreground shrink-0 font-mono text-xs opacity-0 group-focus-within/thread-header:opacity-100 group-hover/thread-header:opacity-100 hover:underline focus-visible:opacity-100"+ onClick={onOpenTrace}+ >+ Open trace+ </button>+ </>+ )}</div>- ))}- <div className="flex items-center gap-2 py-1">- <Skeleton className="h-3.5 w-3.5 shrink-0 rounded-full" />- <Skeleton className="h-3 w-24" />- <Skeleton className="h-3 w-3 shrink-0" />- </div>- </div>- )}- {state.type === "error" && (- <div className="border-destructive/40 bg-destructive/5 text-foreground rounded-lg border p-4 text-xs">- Failed to load messages.- </div>- )}- {state.type === "empty" && (- <div className="text-muted-foreground flex items-center justify-between gap-4 rounded-lg border border-dashed p-4 text-xs">- <span>This trace has no messages.</span>- </div>- )}- {state.type === "transcript" && (- <SessionTranscriptContent- includeNestedThreads={includeNestedThreads}- variant={variant}- {...state}- onOpenObservation={onOpenObservation}- scrollTarget={scrollTarget}- threadIndex={threadIndex}- />+ )}++ {state.type === "loading" && (+ <div+ role="status"+ aria-label="Loading messages"+ className="flex flex-col gap-5 py-2"+ >+ <div className="flex items-center gap-2 py-1">+ <Skeleton className="h-3.5 w-3.5 shrink-0 rounded-full" />+ <Skeleton className="h-3 w-28" />+ <Skeleton className="h-3 w-3 shrink-0" />+ </div>+ {(["user", "assistant"] as const).map((role) => (+ <div+ key={role}+ className={cn(+ "flex w-full",+ role === "user" ? "justify-end" : "justify-start",+ )}+ >+ <Skeleton+ className={cn(+ "max-w-[min(85%,48rem)] rounded-2xl",+ role === "user" ? "h-20 w-3/5" : "h-24 w-4/5",+ )}+ />+ </div>+ ))}+ <div className="flex items-center gap-2 py-1">+ <Skeleton className="h-3.5 w-3.5 shrink-0 rounded-full" />+ <Skeleton className="h-3 w-24" />+ <Skeleton className="h-3 w-3 shrink-0" />+ </div>+ </div>+ )}+ {state.type === "error" && (+ <div className="border-destructive/40 bg-destructive/5 text-foreground rounded-lg border p-4 text-xs">+ Failed to load messages.+ </div>+ )}+ {state.type === "empty" && (+ <div className="text-muted-foreground flex items-center justify-between gap-4 rounded-lg border border-dashed p-4 text-xs">+ <span>This trace has no messages.</span>+ </div>+ )}+ {state.type === "transcript" && (+ <SessionTranscriptContent+ includeNestedThreads={includeNestedThreads}+ variant={variant}+ {...state}+ onOpenObservation={onOpenObservation}+ scrollTarget={scrollTarget}+ threadIndex={threadIndex}+ />+ )}+ </>)}</div>);