Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Use `createNumberTableColumn` more (#16950)

Ben Bachemd66162f38ffe
diff --git a/web/src/features/datasets/components/DatasetRunItemsByItemTable.tsx b/web/src/features/datasets/components/DatasetRunItemsByItemTable.tsx
index c5fce63ba9..2a2851c5d0 100644
--- a/web/src/features/datasets/components/DatasetRunItemsByItemTable.tsx
+++ b/web/src/features/datasets/components/DatasetRunItemsByItemTable.tsx
@@ -3,6 +3,7 @@ import { type LangfuseColumnDef } from "@/src/components/table/types";
import { createLinkTableColumn } from "@/src/components/design-system/table/columns/createLinkTableColumn";
import { api } from "@/src/utils/api";
import { formatIntervalSeconds } from "@/src/utils/dates";
+import { usdFormatter } from "@/src/utils/numbers";
import { useQueryParams, withDefault, NumberParam } from "use-query-params";
import useColumnVisibility from "@/src/features/column-visibility/hooks/useColumnVisibility";
import { DataTableToolbar } from "@/src/components/table/data-table-toolbar";
@@ -14,6 +15,7 @@ import { useScoreColumns } from "@/src/features/scores/hooks/useScoreColumns";
import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrder";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createIdTableColumn } from "@/src/components/design-system/table/columns/createIdTableColumn";
+import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { Skeleton } from "@/src/components/ui/skeleton";
import { scoreFilters } from "@/src/features/scores/lib/scoreColumns";
import { convertRunItemToItemsByItemUiTableRow } from "@/src/features/datasets/lib/convertRunItemDataToUiTableRow";
@@ -183,18 +185,13 @@ export function DatasetRunItemsByItemTable(props: {
return <>{!!latency ? formatIntervalSeconds(latency) : null}</>;
},
},
- {
+ createNumberTableColumn<DatasetRunItemByItemRowData>({
accessorKey: "totalCost",
header: "Cost",
- id: "totalCost",
size: 60,
enableHiding: true,
- cell: ({ row }) => {
- const totalCost: DatasetRunItemByItemRowData["totalCost"] =
- row.getValue("totalCost");
- return totalCost ?? undefined;
- },
- },
+ formatter: (value) => usdFormatter(value),
+ }),
{
accessorKey: "scores",
header: "Scores",
diff --git a/web/src/features/datasets/components/DatasetRunItemsByRunTable.tsx b/web/src/features/datasets/components/DatasetRunItemsByRunTable.tsx
index 6270299a9e..267530264b 100644
--- a/web/src/features/datasets/components/DatasetRunItemsByRunTable.tsx
+++ b/web/src/features/datasets/components/DatasetRunItemsByRunTable.tsx
@@ -3,6 +3,7 @@ import { type LangfuseColumnDef } from "@/src/components/table/types";
import { createLinkTableColumn } from "@/src/components/design-system/table/columns/createLinkTableColumn";
import { api } from "@/src/utils/api";
import { formatIntervalSeconds } from "@/src/utils/dates";
+import { usdFormatter } from "@/src/utils/numbers";
import { useQueryParams, withDefault, NumberParam } from "use-query-params";
import useColumnVisibility from "@/src/features/column-visibility/hooks/useColumnVisibility";
import { DataTableToolbar } from "@/src/components/table/data-table-toolbar";
@@ -22,6 +23,7 @@ import { datasetRunItemsTableColsWithOptions } from "@langfuse/shared";
import { convertRunItemToItemsByRunUiTableRow } from "@/src/features/datasets/lib/convertRunItemDataToUiTableRow";
import { type DatasetRunItemByRunRowData } from "@/src/features/datasets/lib/types";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
+import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { useQueryFilterState } from "@/src/features/filters/hooks/useFilterState";
import { useDebounce } from "@/src/hooks/useDebounce";
@@ -164,18 +166,13 @@ export function DatasetRunItemsByRunTable(props: {
return <>{!!latency ? formatIntervalSeconds(latency) : null}</>;
},
},
- {
+ createNumberTableColumn<DatasetRunItemByRunRowData>({
accessorKey: "totalCost",
header: "Cost",
- id: "totalCost",
size: 60,
enableHiding: true,
- cell: ({ row }) => {
- const totalCost: DatasetRunItemByRunRowData["totalCost"] =
- row.getValue("totalCost");
- return totalCost ?? undefined;
- },
- },
+ formatter: (value) => usdFormatter(value),
+ }),
{
accessorKey: "scores",
header: "Scores",
diff --git a/web/src/features/datasets/components/DatasetsTable.tsx b/web/src/features/datasets/components/DatasetsTable.tsx
index 5fd1f8a302..04cc54b059 100644
--- a/web/src/features/datasets/components/DatasetsTable.tsx
+++ b/web/src/features/datasets/components/DatasetsTable.tsx
@@ -24,6 +24,7 @@ import { useRowHeightLocalStorage } from "@/src/components/table/data-table-row-
import useColumnOrder from "@/src/features/column-visibility/hooks/useColumnOrder";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createFolderKeyTableColumn } from "@/src/components/design-system/table/columns/createFolderKeyTableColumn";
+import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
import { joinTableCoreAndMetrics } from "@/src/components/table/utils/joinTableCoreAndMetrics";
import { useTableViewManager } from "@/src/components/table/table-view-presets/hooks/useTableViewManager";
@@ -348,20 +349,20 @@ export function DatasetsTable(props: { projectId: string }) {
enableHiding: true,
size: 200,
}),
- {
+ createNumberTableColumn<DatasetTableRow>({
accessorKey: "countItems",
header: "Items",
- id: "countItems",
enableHiding: true,
size: 60,
- },
- {
+ formatter: (value) => String(value),
+ }),
+ createNumberTableColumn<DatasetTableRow>({
accessorKey: "countRuns",
header: "Experiments",
- id: "countRuns",
enableHiding: true,
size: 60,
- },
+ formatter: (value) => String(value),
+ }),
createDateTableColumn<DatasetTableRow>({
accessorKey: "createdAt",
header: "Created",
diff --git a/web/src/features/datasets/lib/convertRunItemDataToUiTableRow.ts b/web/src/features/datasets/lib/convertRunItemDataToUiTableRow.ts
index e0c9145458..d02104e4a2 100644
--- a/web/src/features/datasets/lib/convertRunItemDataToUiTableRow.ts
+++ b/web/src/features/datasets/lib/convertRunItemDataToUiTableRow.ts
@@ -1,4 +1,3 @@
-import { usdFormatter } from "@/src/utils/numbers";
import {
type DatasetRunItemByRunRowData,
type DatasetRunItemByItemRowData,
@@ -6,6 +5,19 @@ import {
import { type EnrichedDatasetRunItem } from "@langfuse/shared/src/server";
import { isPresent } from "@langfuse/shared";
+const getRunItemTotalCost = (
+ item: EnrichedDatasetRunItem,
+): number | undefined => {
+ const observationCost = item.observation?.calculatedTotalCost;
+ if (isPresent(observationCost)) {
+ return observationCost.toNumber();
+ }
+ if (isPresent(item.trace?.totalCost)) {
+ return item.trace.totalCost;
+ }
+ return undefined;
+};
+
export const convertRunItemToItemsByItemUiTableRow = (
item: EnrichedDatasetRunItem,
): DatasetRunItemByItemRowData => {
@@ -20,11 +32,7 @@ export const convertRunItemToItemsByItemUiTableRow = (
}
: undefined,
scores: item.scores,
- totalCost: isPresent(item.observation?.calculatedTotalCost)
- ? usdFormatter(item.observation.calculatedTotalCost.toNumber())
- : isPresent(item.trace?.totalCost)
- ? usdFormatter(item.trace.totalCost)
- : undefined,
+ totalCost: getRunItemTotalCost(item),
latency: item.observation?.latency ?? item.trace?.duration ?? undefined,
};
};
@@ -44,11 +52,7 @@ export const convertRunItemToItemsByRunUiTableRow = (
}
: undefined,
scores: item.scores,
- totalCost: isPresent(item.observation?.calculatedTotalCost)
- ? usdFormatter(item.observation.calculatedTotalCost.toNumber())
- : isPresent(item.trace?.totalCost)
- ? usdFormatter(item.trace.totalCost)
- : undefined,
+ totalCost: getRunItemTotalCost(item),
latency: item.observation?.latency ?? item.trace?.duration ?? undefined,
};
};
diff --git a/web/src/features/datasets/lib/types.ts b/web/src/features/datasets/lib/types.ts
index 051c01b826..504b450db8 100644
--- a/web/src/features/datasets/lib/types.ts
+++ b/web/src/features/datasets/lib/types.ts
@@ -16,7 +16,7 @@ export type DatasetRunItemByItemRowData = {
// scores holds grouped column with individual scores
scores: ScoreAggregate;
latency?: number;
- totalCost?: string;
+ totalCost?: number;
};
export type DatasetRunItemByRunRowData = {
@@ -36,5 +36,5 @@ export type DatasetRunItemByRunRowData = {
// scores holds grouped column with individual scores
scores: ScoreAggregate;
latency?: number;
- totalCost?: string;
+ totalCost?: number;
};
diff --git a/web/src/features/evals/v2/components/Rules/RulesTable/RulesTable.tsx b/web/src/features/evals/v2/components/Rules/RulesTable/RulesTable.tsx
index 6a7360b64f..e7ead8a2a1 100644
--- a/web/src/features/evals/v2/components/Rules/RulesTable/RulesTable.tsx
+++ b/web/src/features/evals/v2/components/Rules/RulesTable/RulesTable.tsx
@@ -354,15 +354,14 @@ export function RulesTable({
<RuleFilterPills filter={row.original.filter} />
),
},
- {
+ createNumberTableColumn<RuleTableRow>({
accessorKey: "sampling",
- id: "sampling",
header: "Sampling",
size: 100,
enableHiding: true,
enableSorting: true,
- cell: ({ row }) => `${Math.round(row.original.sampling * 100)}%`,
- },
+ formatter: (value) => `${Math.round(value * 100)}%`,
+ }),
createUserTableColumn<RuleTableRow>({
accessorKey: "createdByUser",
header: "Created by",
diff --git a/web/src/features/prompts/components/prompts-table.tsx b/web/src/features/prompts/components/prompts-table.tsx
index 3bc8583c24..7947b42471 100644
--- a/web/src/features/prompts/components/prompts-table.tsx
+++ b/web/src/features/prompts/components/prompts-table.tsx
@@ -29,6 +29,7 @@ import { useFolderPagination } from "@/src/features/folders/hooks/useFolderPagin
import { buildFullPath } from "@/src/features/folders/utils";
import { FolderBreadcrumb } from "@/src/features/folders/components/FolderBreadcrumb";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
+import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
import { createTextTableColumn } from "@/src/components/design-system/table/columns/createTextTableColumn";
type PromptTableRow = {
@@ -295,17 +296,17 @@ export function PromptTable() {
};
},
}),
- {
+ createNumberTableColumn<PromptTableRow>({
accessorKey: "version",
header: "Versions",
- id: "version",
enableSorting: true,
size: 70,
- cell: ({ getValue, row }) => {
- if (row.original.type === "folder") return null;
- return getValue<number | undefined>();
+ formatter: (value) => String(value),
+ getValue: (value, { row }) => {
+ if (row.original.type === "folder") return undefined;
+ return value ?? undefined;
},
- },
+ }),
createTextTableColumn<PromptTableRow>({
accessorKey: "type",
header: "Type",