🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(datasets): preserve falsy scalar values in item fields (#17483)
marliessophied697caa1aa3b
diff --git a/web/src/features/datasets/utils/datasetItemUtils.ts b/web/src/features/datasets/utils/datasetItemUtils.tsindex 5c17e003ed..048a2f3e78 100644--- a/web/src/features/datasets/utils/datasetItemUtils.ts+++ b/web/src/features/datasets/utils/datasetItemUtils.ts@@ -6,7 +6,7 @@ import type { Prisma } from "@langfuse/shared";* Returns empty string for null/undefined values.*/export const stringifyDatasetItemData = (data: unknown): string => {- if (!data) return "";+ if (data === null || data === undefined) return "";try {return JSON.stringify(data, null, 2);diff --git a/web/src/features/datasets/utils/parseDatasetJson.clienttest.ts b/web/src/features/datasets/utils/parseDatasetJson.clienttest.tsindex 1ce5700cef..85b4801b30 100644--- a/web/src/features/datasets/utils/parseDatasetJson.clienttest.ts+++ b/web/src/features/datasets/utils/parseDatasetJson.clienttest.ts@@ -1,12 +1,25 @@// @vitest-environment node-import { describe, expect, it } from "vitest";+import { describe, expect, it, vi } from "vitest";+import { stringifyDatasetItemData } from "./datasetItemUtils";import {isDatasetJsonParseFailure,isValidDatasetJson,parseDatasetJson,} from "./parseDatasetJson";+vi.mock("@/src/features/notifications", () => ({ showErrorToast: vi.fn() }));++describe("dataset item JSON round trip", () => {+ it.each([0, false, ""])("preserves the scalar %j", (value) => {+ expect(parseDatasetJson(stringifyDatasetItemData(value))).toEqual(value);+ });++ it.each([null, undefined])("leaves %s empty", (value) => {+ expect(stringifyDatasetItemData(value)).toBe("");+ });+});+describe("parseDatasetJson", () => {it("preserves unsafe JSON numbers as strings", () => {expect(parseDatasetJson("107505301260286111")).toBe("107505301260286111");