Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

chore(design-sync): apply fixes from the daily design-system sync (#19634)

Mark Salpeterd93ab2329bf4
diff --git a/.design-sync/NOTES.md b/.design-sync/NOTES.md
index 15e5a3b504..34f7940ec1 100644
--- a/.design-sync/NOTES.md
+++ b/.design-sync/NOTES.md
@@ -65,7 +65,8 @@
## Known validate warnings (expected)
-- `[TOKENS_MISSING]` 7 vars (`--col-scoreName-size`, `--emoji-hover-color`, `--sdm-tbg`, `--peek-max-width`, `--tw`, `--streamdown-caret`, `--radix-accordion-content-height`): all set at runtime by inline styles/JS or vendored libs - ignorable. Any other warning is new.
+- `[TOKENS_MISSING]` 8 vars (`--col-scoreName-size`, `--emoji-hover-color`, `--sdm-tbg`, `--peek-max-width`, `--tw`, `--bar-height` (inline style in `features/topics/TopicGrid.tsx`, 2026-11-03), `--streamdown-caret`, `--radix-accordion-content-height`): all set at runtime by inline styles/JS or vendored libs - ignorable. Any other warning is new.
+- `[RENDER] ... root empty` on `Table` and/or `DataTable` (2026-11-03): false positive, but it fails validate and so blocks upload. `package-validate.mjs` reads the root right after `networkidle`; on a cold load the two largest previews (`_preview/Table.js` ~5.3 MB) have not mounted yet (probe: root 0 bytes at networkidle -> 8 KB / 60 KB 1.5s later; warm reloads and the validator's own screenshot show the full table). Which of the two trips varies per run. Unresolved: needs a validator wait-for-mount (staged script, not repo config) or a smaller Table preview (it carries ~90 absorbed column stories).
## Re-sync risks (check these first when a re-sync diverges)
@@ -77,6 +78,8 @@
- Shared app components: a new kebab-named (or otherwise export-mismatched) module a story imports must join `cfg.storyImports.shim`, or its preview bundles a second copy and loses provider contexts. New shared components also need a line in gen-entry.sh's heredoc. MediaTag's Wikimedia story stays unverified while capture runs sandboxed.
- Owned previews: `previews/Avatar.tsx` and `previews/MobilePageActionsContent.tsx` shadow the generated ones - re-check them when those stories change (`[STORY_CHANGED]`).
- DateRangeInput (added 2026-10-22): all four `(Test)` stories open the popover in play() -> skipped by id; the three `features-evaluations-...-daterangeinput--*` stories (an out-of-scope `web/src/features` component of the same name, whose props differ -> `Cannot read properties of undefined (reading 'find')`) are skipped by id too. Only `Default` (closed trigger) is graded; popover content is unverified.
+- `ui/MarkdownViewer.tsx` was renamed to `ui/MarkdownView.tsx` upstream (story title now `Playground/MarkdownView`); gen-entry.sh points at the new path (2026-11-03). The `titleMap {MarkdownViewer: ...}` and `storyImports.shim` `/components/ui/MarkdownViewer.tsx` entries now match nothing; the shim one is in the global grade key, so drop both only during a global re-grade.
+- Skill updates can re-key every component (2026-11-03): with config, forks and story files byte-stable since 10-25, the staged scripts' `scriptsSha` moved and all 85 `sourceKeys` stopped matching the anchor while `keyRecipe` stayed 7. The driver then lists every component under `changed` (full re-grade) instead of a `[SPOT_CHECK]` canary. Recomputing a known-stable key (`Spinner`) under the new lib reproduces the new value, not the anchored one.
- Upstream file renames break gen-entry.sh's explicit shared list first (`[UNRESOLVED_IMPORT] ... missing from node_modules` from `ds-package/index.ts`): update the module path there and re-run gen-entry.sh - the driver does NOT run `buildCmd`.
- Story `beforeEach` runs in the preview shim (see Build fixes); a story relying on Storybook loaders, `mount`, or async `beforeEach` work will still diverge.
- Late mount (2026-10-19): `_preview/Table.js` and `_preview/DataTable.js` are ~4.8MB (zod, `@langfuse/shared` dist, posthog, next) and finish executing ~1s after `networkidle`. Validate then fails `[RENDER] ... root empty` and compare reports every story `unpaired`, although the cards render fine. The fix is a local wait in the staged harness (lost on every restage - re-apply after the `cp -r`): in `.ds-sync/package-validate.mjs` before the big `page.evaluate`, `await page.waitForFunction(() => [...document.querySelectorAll('#root, [id^="r"]')].some((r) => r.innerHTML.trim().length), null, { timeout: 15_000 }).catch(() => {})`; in `.ds-sync/storybook/compare.mjs` wait for `Array.isArray(window.__dsCells)` before the pairing `evaluate`, and for `#r0` content in `storyShot` before `settleRender`. Better long-term: shrink those previews (they pull the server-side shared barrel). Still required on 2026-10-29 (previews now ~5.4MB; without the waits validate failed on Table in 3 of 3 runs).
diff --git a/.design-sync/ds-package/gen-entry.sh b/.design-sync/ds-package/gen-entry.sh
index d8a44ea929..b895eb3d23 100755
--- a/.design-sync/ds-package/gen-entry.sh
+++ b/.design-sync/ds-package/gen-entry.sh
@@ -95,7 +95,7 @@ table/FacetHeader FacetHeader
table/KeyValueFilterBuilder KeyValueFilterBuilder
table/OverviewSelectionBar/OverviewSelectionBar OverviewSelectionBar
table/table-view-presets/components/TableViewPresetsButton TableViewPresetsButton
-ui/MarkdownViewer MarkdownView
+ui/MarkdownView MarkdownView
ui/StatusBadge/StatusBadge StatusBadge
ui/AIAssistedInput AIAssistedInput
ui/drawer Drawer, DrawerController, DrawerTrigger, DrawerClose, DrawerContent, DrawerHeader, DrawerTitle, DrawerDescription