Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(web): tracing page header and search row spacing (#18352)

Trang Nguyendb10040cf295
diff --git a/web/src/components/BatchExportTableButton.tsx b/web/src/components/BatchExportTableButton.tsx
index cf21a3874d..33039be930 100644
--- a/web/src/components/BatchExportTableButton.tsx
+++ b/web/src/components/BatchExportTableButton.tsx
@@ -92,7 +92,7 @@ export const BatchExportTableButton: React.FC<BatchExportTableButtonProps> = (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
- variant="outline"
+ variant="ghost"
size="icon"
title="Export"
className="hidden md:inline-flex"
diff --git a/web/src/components/layouts/mobile-page-title.tsx b/web/src/components/layouts/mobile-page-title.tsx
index 82f408b6e2..84944f6a44 100644
--- a/web/src/components/layouts/mobile-page-title.tsx
+++ b/web/src/components/layouts/mobile-page-title.tsx
@@ -68,7 +68,8 @@ export const MobilePageTitle = ({
<div
className={cn(
"bg-background px-3 pt-2",
- tabsProps ? "pb-0" : "border-b pb-3",
+ tabsProps ? "pb-0" : "pb-3",
+ !tabsProps && headerProps.divider !== false && "border-b",
)}
>
{/* Context line: org / project switcher plus any page-supplied
diff --git a/web/src/components/table/data-table-column-visibility-filter.tsx b/web/src/components/table/data-table-column-visibility-filter.tsx
index 100f2a327e..54ee62d308 100644
--- a/web/src/components/table/data-table-column-visibility-filter.tsx
+++ b/web/src/components/table/data-table-column-visibility-filter.tsx
@@ -582,11 +582,7 @@ export function DataTableColumnVisibilityFilter<TData, TValue>({
>
{({ Trigger }) => (
<Trigger asChild>
- <Button
- variant="outline"
- size={triggerSize}
- title="Show/hide columns"
- >
+ <Button variant="ghost" size={triggerSize} title="Show/hide columns">
<span>Columns</span>
<div className="bg-input ml-1 rounded-sm px-1 text-xs">{`${count}/${total}`}</div>
</Button>
diff --git a/web/src/components/table/data-table-row-height-switch.tsx b/web/src/components/table/data-table-row-height-switch.tsx
index 73c82bfcef..929d48c75e 100644
--- a/web/src/components/table/data-table-row-height-switch.tsx
+++ b/web/src/components/table/data-table-row-height-switch.tsx
@@ -481,7 +481,7 @@ export const DataTableRowHeightSwitch = ({
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
- variant="outline"
+ variant="ghost"
size="icon"
title={customActive ? "Row height: Custom" : "Row height"}
>
diff --git a/web/src/features/events/EventsPage.tsx b/web/src/features/events/EventsPage.tsx
index ba91beb780..a612a28760 100644
--- a/web/src/features/events/EventsPage.tsx
+++ b/web/src/features/events/EventsPage.tsx
@@ -36,6 +36,7 @@ export default function EventsPage() {
<Page
headerProps={{
title: "Tracing - Events Table (New)",
+ divider: false,
help: {
description:
"An observation captures a single function call in an application. This view uses the new ClickHouse events table.",
diff --git a/web/src/features/events/components/EventsTable.tsx b/web/src/features/events/components/EventsTable.tsx
index c4bc8e9342..fbbee2dc68 100644
--- a/web/src/features/events/components/EventsTable.tsx
+++ b/web/src/features/events/components/EventsTable.tsx
@@ -2022,8 +2022,8 @@ export default function ObservationsEventsTable({
// This is a table-internal sticky band below PageHeader. Using
// top-banner-offset here pushes the band down by the viewport
// header/banner offset and leaves a large blank gap above it.
- // pb-1.5 gives the band a bit more breathing room above the table.
- searchBarMode && "bg-background sticky top-0 z-30 pb-1.5",
+ // pb-3 gives the band breathing room above the table.
+ searchBarMode && "bg-background sticky top-0 z-30 pb-3",
)}
>
{/* Search bar row: full-width query composer. In bar mode it sticks
@@ -2059,6 +2059,7 @@ export default function ObservationsEventsTable({
onRequestColumns={requestColumns}
aiDataContext={aiDataContext}
aiScoreNames={aiScoreNames}
+ className="px-3 pt-3"
/>
</div>
</div>
@@ -2066,6 +2067,7 @@ export default function ObservationsEventsTable({
{/* Toolbar spanning full width */}
<DataTableToolbar
columns={columns}
+ className={searchBarMode ? "px-3" : undefined}
rowClassName={searchBarMode ? "my-1" : undefined}
filterState={queryFilter.explicitFilterState}
tableName={eventsFilterConfig.tableName}
diff --git a/web/src/features/traces/TracesPage.tsx b/web/src/features/traces/TracesPage.tsx
index 7a585722be..1c90004b3b 100644
--- a/web/src/features/traces/TracesPage.tsx
+++ b/web/src/features/traces/TracesPage.tsx
@@ -41,6 +41,7 @@ export default function TracesPage() {
<Page
headerProps={{
title: "Tracing",
+ divider: false,
help: {
description:
"A trace represents a single function/api invocation. Traces contain observations. See [docs](https://langfuse.com/docs/observability/data-model) to learn more.",
@@ -58,6 +59,7 @@ export default function TracesPage() {
<Page
headerProps={{
title: "Tracing",
+ divider: false,
titleBadges: <V4MigrationDelayBadge page="traces" />,
help: {
description: (
diff --git a/web/src/features/tracing-tables/observations/ObservationsPage.tsx b/web/src/features/tracing-tables/observations/ObservationsPage.tsx
index f84bd1f824..4fd0d7c39a 100644
--- a/web/src/features/tracing-tables/observations/ObservationsPage.tsx
+++ b/web/src/features/tracing-tables/observations/ObservationsPage.tsx
@@ -40,6 +40,7 @@ export default function ObservationsPage() {
<Page
headerProps={{
title: "Tracing",
+ divider: false,
// Match traces/index.tsx: no delay badge while onboarding tells the
// user to set up tracing for the first time.
titleBadges: showOnboarding ? undefined : (