Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(search): escape LIKE wildcards in remaining Prisma substring and filter queries (#19024)

Aditya Kumar Yadave4358d26655e
diff --git a/packages/shared/src/server/prismaFilter.test.ts b/packages/shared/src/server/prismaFilter.test.ts
index aee014f30b..7e04f53dfe 100644
--- a/packages/shared/src/server/prismaFilter.test.ts
+++ b/packages/shared/src/server/prismaFilter.test.ts
@@ -65,6 +65,58 @@ describe("compilePrismaFilters", () => {
});
});
+ it("escapes LIKE wildcards in stringFilterToPrisma", () => {
+ expect(
+ stringFilterToPrisma({
+ column: "name",
+ type: "string",
+ operator: "contains",
+ value: "gpt_4%test\\",
+ }),
+ ).toEqual({
+ contains: "gpt\\_4\\%test\\\\",
+ mode: "insensitive",
+ });
+
+ expect(
+ stringFilterToPrisma({
+ column: "name",
+ type: "string",
+ operator: "does not contain",
+ value: "100%",
+ }),
+ ).toEqual({
+ not: {
+ contains: "100\\%",
+ mode: "insensitive",
+ },
+ });
+
+ expect(
+ stringFilterToPrisma({
+ column: "name",
+ type: "string",
+ operator: "starts with",
+ value: "prefix_name",
+ }),
+ ).toEqual({
+ startsWith: "prefix\\_name",
+ mode: "insensitive",
+ });
+
+ expect(
+ stringFilterToPrisma({
+ column: "name",
+ type: "string",
+ operator: "ends with",
+ value: "_suffix",
+ }),
+ ).toEqual({
+ endsWith: "\\_suffix",
+ mode: "insensitive",
+ });
+ });
+
it("rejects filters without an explicit handler", () => {
expect(() =>
compilePrismaFilters<TestWhere>(
diff --git a/packages/shared/src/server/prismaFilter.ts b/packages/shared/src/server/prismaFilter.ts
index 89dbdb30d6..b70b9527bb 100644
--- a/packages/shared/src/server/prismaFilter.ts
+++ b/packages/shared/src/server/prismaFilter.ts
@@ -1,6 +1,7 @@
import type { Prisma } from "@prisma/client";
import { InvalidRequestError } from "../errors";
import type { FilterState } from "../types";
+import { escapeSqlLikePattern } from "./utils/sqlLike";
type PrismaFilter = FilterState[number];
type PrismaFilterType = PrismaFilter["type"];
@@ -34,18 +35,19 @@ export function stringFilterToPrisma(
filter: StringFilter,
): Prisma.StringFilter {
const insensitive = { mode: "insensitive" as const };
+ const escapedValue = escapeSqlLikePattern(filter.value);
switch (filter.operator) {
case "=":
return { equals: filter.value, ...insensitive };
case "contains":
- return { contains: filter.value, ...insensitive };
+ return { contains: escapedValue, ...insensitive };
case "does not contain":
- return { not: { contains: filter.value, ...insensitive } };
+ return { not: { contains: escapedValue, ...insensitive } };
case "starts with":
- return { startsWith: filter.value, ...insensitive };
+ return { startsWith: escapedValue, ...insensitive };
case "ends with":
- return { endsWith: filter.value, ...insensitive };
+ return { endsWith: escapedValue, ...insensitive };
case "is not empty":
return { not: "" };
}
diff --git a/packages/shared/src/server/repositories/comments.ts b/packages/shared/src/server/repositories/comments.ts
index e456505500..b819a0d006 100644
--- a/packages/shared/src/server/repositories/comments.ts
+++ b/packages/shared/src/server/repositories/comments.ts
@@ -1,6 +1,7 @@
import type { PrismaClient } from "../../db";
import { Prisma } from "../../db";
import { filterOperators } from "../../interfaces/filters";
+import { escapeSqlLikePattern } from "../utils/sqlLike";
/**
* Supported object types for comment filtering
@@ -123,6 +124,7 @@ export async function getObjectIdsByCommentContent({
// For other operators, use Prisma's query builder with ILIKE
let whereCondition: Prisma.CommentWhereInput;
+ const escapedQuery = escapeSqlLikePattern(searchQuery);
if (operator === "does not contain") {
whereCondition = {
@@ -130,7 +132,7 @@ export async function getObjectIdsByCommentContent({
objectType,
NOT: {
content: {
- contains: searchQuery,
+ contains: escapedQuery,
mode: "insensitive",
},
},
@@ -140,7 +142,7 @@ export async function getObjectIdsByCommentContent({
projectId,
objectType,
content: {
- startsWith: searchQuery,
+ startsWith: escapedQuery,
mode: "insensitive",
},
};
@@ -149,7 +151,7 @@ export async function getObjectIdsByCommentContent({
projectId,
objectType,
content: {
- endsWith: searchQuery,
+ endsWith: escapedQuery,
mode: "insensitive",
},
};
@@ -159,7 +161,7 @@ export async function getObjectIdsByCommentContent({
projectId,
objectType,
content: {
- contains: searchQuery,
+ contains: escapedQuery,
mode: "insensitive",
},
};
diff --git a/web/src/__tests__/server/evaluation-rule-v2-repository.servertest.ts b/web/src/__tests__/server/evaluation-rule-v2-repository.servertest.ts
index a0d647d2f2..0ab1a7d364 100644
--- a/web/src/__tests__/server/evaluation-rule-v2-repository.servertest.ts
+++ b/web/src/__tests__/server/evaluation-rule-v2-repository.servertest.ts
@@ -200,6 +200,31 @@ describe("evaluation rule v2 repository", () => {
});
});
+ it("matches LIKE wildcards literally in rule search", async () => {
+ await Promise.all([
+ createRule({ name: "gpt_4-rule" }),
+ createRule({ name: "gpt-4-rule" }),
+ createRule({ name: "save 100% now" }),
+ createRule({ name: "save 1000 now" }),
+ ]);
+
+ const searchNames = async (search: string) => {
+ const res = await ruleRepository.listRules({
+ prisma,
+ input: {
+ projectId,
+ page: 1,
+ limit: 50,
+ search,
+ },
+ });
+ return res.rules.map((r) => r.name);
+ };
+
+ expect(await searchNames("gpt_4")).toEqual(["gpt_4-rule"]);
+ expect(await searchNames("100%")).toEqual(["save 100% now"]);
+ });
+
it("uses stable creation order by default and supports explicit sorting", async () => {
const [older, newer] = await Promise.all([
createRule({ name: "Older" }),
diff --git a/web/src/__tests__/server/evaluator-v2-repository.servertest.ts b/web/src/__tests__/server/evaluator-v2-repository.servertest.ts
index 6d1ce5c99e..3d1d5c9bab 100644
--- a/web/src/__tests__/server/evaluator-v2-repository.servertest.ts
+++ b/web/src/__tests__/server/evaluator-v2-repository.servertest.ts
@@ -259,6 +259,29 @@ describe("evaluator v2 repository", () => {
});
});
+ it("matches LIKE wildcards literally in evaluator search", async () => {
+ await Promise.all([
+ createEvaluator({ name: "gpt_4-evaluator" }),
+ createEvaluator({ name: "gpt-4-evaluator" }),
+ createEvaluator({ name: "save 100% now" }),
+ createEvaluator({ name: "save 1000 now" }),
+ ]);
+
+ const searchNames = async (search: string) => {
+ const res = await evaluatorRepository.listEvaluators({
+ prisma,
+ projectId,
+ page: 1,
+ limit: 50,
+ search,
+ });
+ return res.evaluators.map((e) => e.name);
+ };
+
+ expect(await searchNames("gpt_4")).toEqual(["gpt_4-evaluator"]);
+ expect(await searchNames("100%")).toEqual(["save 100% now"]);
+ });
+
it("preserves default update order and supports explicit creation order", async () => {
const [recentlyUpdated, newerButUnchanged] = await Promise.all([
createEvaluator(),
diff --git a/web/src/features/datasets/server/publicDatasetService.ts b/web/src/features/datasets/server/publicDatasetService.ts
index 901bada9b7..96cc63c26c 100644
--- a/web/src/features/datasets/server/publicDatasetService.ts
+++ b/web/src/features/datasets/server/publicDatasetService.ts
@@ -44,6 +44,7 @@ import {
createDatasetItemFilterState,
createUnknownSdkIngestionAttribution,
deleteDatasetItem,
+ escapeSqlLikePattern,
eventTypes,
getDatasetItemById,
getDatasetItems,
@@ -330,7 +331,9 @@ export const listDatasetsForApi = async ({
}: ListDatasetsInput) => {
const where: Prisma.DatasetWhereInput = {
projectId,
- ...(name ? { name: { contains: name, mode: "insensitive" } } : {}),
+ ...(name
+ ? { name: { contains: escapeSqlLikePattern(name), mode: "insensitive" } }
+ : {}),
};
const [datasets, totalItems] = await Promise.all([
diff --git a/web/src/features/evals/v2/server/evaluators/evaluatorRepository.ts b/web/src/features/evals/v2/server/evaluators/evaluatorRepository.ts
index 60bc265154..f16ffce881 100644
--- a/web/src/features/evals/v2/server/evaluators/evaluatorRepository.ts
+++ b/web/src/features/evals/v2/server/evaluators/evaluatorRepository.ts
@@ -19,6 +19,7 @@ import {
} from "@langfuse/shared";
import {
compilePrismaFilters,
+ escapeSqlLikePattern,
stringFilterToPrisma,
stringOptionsFilterToPrisma,
type PrismaFilterColumnHandlers,
@@ -281,7 +282,12 @@ async function evaluatorWhere(params: {
...visibleEvaluatorWhere,
...(modelEvaluatorIds ? { id: { in: modelEvaluatorIds } } : {}),
...(params.search
- ? { name: { contains: params.search, mode: "insensitive" as const } }
+ ? {
+ name: {
+ contains: escapeSqlLikePattern(params.search),
+ mode: "insensitive" as const,
+ },
+ }
: {}),
AND: compilePrismaFilters<Prisma.EvaluatorWhereInput>(
otherFilters ?? [],
@@ -507,7 +513,12 @@ export async function listEvaluatorOptions(params: {
projectId: params.projectId,
...visibleEvaluatorWhere,
...(params.search
- ? { name: { contains: params.search, mode: "insensitive" } }
+ ? {
+ name: {
+ contains: escapeSqlLikePattern(params.search),
+ mode: "insensitive",
+ },
+ }
: {}),
...(params.excludeLegacyEvaluators ? batchEligibleEvaluatorWhere : {}),
},
diff --git a/web/src/features/evals/v2/server/rules/ruleRepository.ts b/web/src/features/evals/v2/server/rules/ruleRepository.ts
index 8acd59cff6..ab828d406b 100644
--- a/web/src/features/evals/v2/server/rules/ruleRepository.ts
+++ b/web/src/features/evals/v2/server/rules/ruleRepository.ts
@@ -12,6 +12,7 @@ import {
} from "@langfuse/shared";
import {
compilePrismaFilters,
+ escapeSqlLikePattern,
stringFilterToPrisma,
stringOptionsFilterToPrisma,
type PrismaFilterColumnHandlers,
@@ -117,7 +118,12 @@ function ruleWhere(params: {
projectId: params.projectId,
...visibleRuleWhere,
...(params.search
- ? { name: { contains: params.search, mode: "insensitive" as const } }
+ ? {
+ name: {
+ contains: escapeSqlLikePattern(params.search),
+ mode: "insensitive" as const,
+ },
+ }
: {}),
...(params.enabled === undefined
? {}
diff --git a/web/src/features/skills/server/skill-service.ts b/web/src/features/skills/server/skill-service.ts
index 8c80cbcdb8..a2f01cb429 100644
--- a/web/src/features/skills/server/skill-service.ts
+++ b/web/src/features/skills/server/skill-service.ts
@@ -19,7 +19,11 @@ import {
type SkillSelector,
} from "@langfuse/shared";
import type { Prisma, PrismaClient, SkillBlob } from "@langfuse/shared/src/db";
-import { SkillCacheService, redis } from "@langfuse/shared/src/server";
+import {
+ SkillCacheService,
+ escapeSqlLikePattern,
+ redis,
+} from "@langfuse/shared/src/server";
import type { ProjectAuthedContext } from "@/src/server/api/trpc";
import type { AuthorizationContext } from "@/src/features/auth/policy/types";
import { auditLog } from "@/src/features/audit-logs/server";
@@ -349,13 +353,13 @@ export class SkillService {
OR: [
{
name: {
- contains: params.input.search,
+ contains: escapeSqlLikePattern(params.input.search),
mode: "insensitive" as const,
},
},
{
description: {
- contains: params.input.search,
+ contains: escapeSqlLikePattern(params.input.search),
mode: "insensitive" as const,
},
},