Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Inline table loading cell components (#16785)

Ben Bacheme61fdaa9aab0
diff --git a/web/src/components/design-system/table/columns/README.md b/web/src/components/design-system/table/columns/README.md
index d846b8679d..e5c73a6207 100644
--- a/web/src/components/design-system/table/columns/README.md
+++ b/web/src/components/design-system/table/columns/README.md
@@ -39,7 +39,7 @@ export function createExampleTableColumn<TData extends RowData>(
) {
return createTableColumn<TData, string>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value) => (value ? <Example value={value} /> : null),
});
}
diff --git a/web/src/components/design-system/table/columns/createBadgeTableColumn.tsx b/web/src/components/design-system/table/columns/createBadgeTableColumn.tsx
index f6c52bebd8..020fa83c6c 100644
--- a/web/src/components/design-system/table/columns/createBadgeTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createBadgeTableColumn.tsx
@@ -1,7 +1,7 @@
import { type RowData } from "@tanstack/react-table";
-import { TableBadgeLoadingCell } from "@/src/components/table/loading-cells";
import { Badge } from "@/src/components/ui/badge";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
type TableColumnOptions,
@@ -12,7 +12,7 @@ export function createBadgeTableColumn<TData extends RowData>(
) {
return createTableColumn<TData, string>({
...options,
- loadingCell: <TableBadgeLoadingCell />,
+ loadingCell: <Skeleton className="h-5 w-16 shrink-0 rounded-sm" />,
renderCell: (value) =>
value ? (
<Badge
diff --git a/web/src/components/design-system/table/columns/createDateTableColumn.tsx b/web/src/components/design-system/table/columns/createDateTableColumn.tsx
index 5ed086b2fb..594f0a5b04 100644
--- a/web/src/components/design-system/table/columns/createDateTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createDateTableColumn.tsx
@@ -1,7 +1,7 @@
import { type RowData } from "@tanstack/react-table";
import { LocalIsoDate } from "@/src/components/LocalIsoDate";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
type TableColumnOptions,
@@ -12,7 +12,7 @@ export function createDateTableColumn<TData extends RowData>(
) {
return createTableColumn<TData, Date>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value) => (value ? <LocalIsoDate date={value} /> : null),
});
}
diff --git a/web/src/components/design-system/table/columns/createDurationTableColumn.tsx b/web/src/components/design-system/table/columns/createDurationTableColumn.tsx
index d36870577c..01cf28631e 100644
--- a/web/src/components/design-system/table/columns/createDurationTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createDurationTableColumn.tsx
@@ -1,6 +1,6 @@
import { type RowData } from "@tanstack/react-table";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import { formatIntervalSeconds } from "@/src/utils/dates";
import {
createTableColumn,
@@ -12,7 +12,7 @@ export function createDurationTableColumn<TData extends RowData>(
) {
return createTableColumn<TData, number>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value) =>
value === null || value === undefined ? null : (
<span>{formatIntervalSeconds(value)}</span>
diff --git a/web/src/components/design-system/table/columns/createFolderKeyTableColumn.tsx b/web/src/components/design-system/table/columns/createFolderKeyTableColumn.tsx
index 444332c318..26d4744e45 100644
--- a/web/src/components/design-system/table/columns/createFolderKeyTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createFolderKeyTableColumn.tsx
@@ -1,8 +1,8 @@
import { type CellContext, type RowData } from "@tanstack/react-table";
import { Folder } from "lucide-react";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
import { TextLink } from "@/src/components/design-system/TextLink/TextLink";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
type TableColumnOptions,
@@ -30,7 +30,7 @@ export function createFolderKeyTableColumn<
}) {
return createTableColumn<TData, TValue>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value, context) => {
const cell = getCell(value, context);
if (!cell) return null;
diff --git a/web/src/components/design-system/table/columns/createIdTableColumn.tsx b/web/src/components/design-system/table/columns/createIdTableColumn.tsx
index 3a5336abf0..d06bf9219c 100644
--- a/web/src/components/design-system/table/columns/createIdTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createIdTableColumn.tsx
@@ -1,7 +1,7 @@
import { type RowData } from "@tanstack/react-table";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
import TableIdOrName from "@/src/components/table/table-id";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
type TableColumnOptions,
@@ -12,7 +12,7 @@ export function createIdTableColumn<TData extends RowData>(
) {
return createTableColumn<TData, string>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value) => (value ? <TableIdOrName value={value} /> : null),
});
}
diff --git a/web/src/components/design-system/table/columns/createItemBadgeTableColumn.tsx b/web/src/components/design-system/table/columns/createItemBadgeTableColumn.tsx
index af28b94362..e5c3c9a85d 100644
--- a/web/src/components/design-system/table/columns/createItemBadgeTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createItemBadgeTableColumn.tsx
@@ -1,7 +1,7 @@
import { type RowData } from "@tanstack/react-table";
import { ItemBadge, type LangfuseItemType } from "@/src/components/ItemBadge";
-import { TableIconBadgeLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
type TableColumnOptions,
@@ -12,7 +12,7 @@ export function createItemBadgeTableColumn<TData extends RowData>(
) {
return createTableColumn<TData, LangfuseItemType>({
...options,
- loadingCell: <TableIconBadgeLoadingCell />,
+ loadingCell: <Skeleton className="h-5 w-6 shrink-0 rounded-md" />,
renderCell: (value) =>
value ? (
<div className="flex items-center gap-1">
diff --git a/web/src/components/design-system/table/columns/createLinkListTableColumn.tsx b/web/src/components/design-system/table/columns/createLinkListTableColumn.tsx
index 5cbade38f4..b30ba3cda4 100644
--- a/web/src/components/design-system/table/columns/createLinkListTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createLinkListTableColumn.tsx
@@ -1,7 +1,7 @@
import { type CellContext, type RowData } from "@tanstack/react-table";
import { TextLink } from "@/src/components/design-system/TextLink/TextLink";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
type TableColumnOptions,
@@ -23,11 +23,11 @@ export function createLinkListTableColumn<TData extends RowData>({
}) {
return createTableColumn<TData, string[]>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value, context) => {
const cell = getCell(value, context);
if (!cell) return null;
- if (!Array.isArray(cell)) return <TableTextLoadingCell />;
+ if (!Array.isArray(cell)) return <Skeleton className="h-4 w-1/2" />;
return (
<div className="flex gap-1">
diff --git a/web/src/components/design-system/table/columns/createLinkTableColumn.tsx b/web/src/components/design-system/table/columns/createLinkTableColumn.tsx
index 676c408448..fdca652d2d 100644
--- a/web/src/components/design-system/table/columns/createLinkTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createLinkTableColumn.tsx
@@ -1,8 +1,8 @@
import { type CellContext, type RowData } from "@tanstack/react-table";
import { type LucideIcon } from "lucide-react";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
import { TextLink } from "@/src/components/design-system/TextLink/TextLink";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
type TableColumnOptions,
@@ -29,11 +29,11 @@ export function createLinkTableColumn<TData extends RowData, TValue = string>({
}) {
return createTableColumn<TData, TValue>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value, context) => {
const cell = getCell(value, context);
if (!cell) return null;
- if (cell.type === "loading") return <TableTextLoadingCell />;
+ if (cell.type === "loading") return <Skeleton className="h-4 w-1/2" />;
const { icon: Icon, path, value: linkValue, title, onClick } = cell.props;
return (
diff --git a/web/src/components/design-system/table/columns/createNumberTableColumn.tsx b/web/src/components/design-system/table/columns/createNumberTableColumn.tsx
index 6fb144141a..8231721cf3 100644
--- a/web/src/components/design-system/table/columns/createNumberTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createNumberTableColumn.tsx
@@ -1,6 +1,6 @@
import { type CellContext, type RowData } from "@tanstack/react-table";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import { numberFormatter } from "@/src/utils/numbers";
import {
createTableColumn,
@@ -22,7 +22,7 @@ export function createNumberTableColumn<TData extends RowData>({
}) {
return createTableColumn<TData, number>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value, context) => {
if (!getValue) {
if (value === null || value === undefined) return emptyValue ?? null;
@@ -32,7 +32,9 @@ export function createNumberTableColumn<TData extends RowData>({
const resolvedValue = getValue(value, context);
if (resolvedValue === undefined) return emptyValue ?? null;
- if (typeof resolvedValue !== "number") return <TableTextLoadingCell />;
+ if (typeof resolvedValue !== "number") {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
return <span>{formatter(resolvedValue)}</span>;
},
diff --git a/web/src/components/design-system/table/columns/createStatusTableColumn.tsx b/web/src/components/design-system/table/columns/createStatusTableColumn.tsx
index caa76dc84a..cce5ff1202 100644
--- a/web/src/components/design-system/table/columns/createStatusTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createStatusTableColumn.tsx
@@ -1,6 +1,6 @@
import { type CellContext, type RowData } from "@tanstack/react-table";
-import { TableBadgeLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
type Status,
StatusBadge,
@@ -26,7 +26,7 @@ export function createStatusTableColumn<
}) {
return createTableColumn<TData, TValue>({
...options,
- loadingCell: <TableBadgeLoadingCell />,
+ loadingCell: <Skeleton className="h-5 w-16 shrink-0 rounded-sm" />,
renderCell: (value, context) => {
const status = getStatus(value, context);
return status ? <StatusBadge type={status} isLive={isLive} /> : null;
diff --git a/web/src/components/design-system/table/columns/createTagsTableColumn.tsx b/web/src/components/design-system/table/columns/createTagsTableColumn.tsx
index fc005bdae3..bb18005700 100644
--- a/web/src/components/design-system/table/columns/createTagsTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createTagsTableColumn.tsx
@@ -1,6 +1,6 @@
import { type RowData } from "@tanstack/react-table";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import TagList from "@/src/features/tag/components/TagList";
import { cn } from "@/src/utils/tailwind";
import {
@@ -16,7 +16,7 @@ export function createTagsTableColumn<TData extends RowData>({
}) {
return createTableColumn<TData, string[]>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (tags) =>
tags && tags.length > 0 ? (
<div className={cn("flex gap-x-2 gap-y-1", shouldWrap && "flex-wrap")}>
diff --git a/web/src/components/design-system/table/columns/createTextTableColumn.tsx b/web/src/components/design-system/table/columns/createTextTableColumn.tsx
index c47d299148..b1c8601ecb 100644
--- a/web/src/components/design-system/table/columns/createTextTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createTextTableColumn.tsx
@@ -1,6 +1,6 @@
import { type RowData } from "@tanstack/react-table";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
createTableColumn,
type TableColumnOptions,
@@ -11,7 +11,7 @@ export function createTextTableColumn<TData extends RowData>(
) {
return createTableColumn<TData, string>({
...options,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
renderCell: (value) => value ?? null,
});
}
diff --git a/web/src/components/design-system/table/columns/createUserTableColumn.tsx b/web/src/components/design-system/table/columns/createUserTableColumn.tsx
index ff14ef6179..f3ed1ff809 100644
--- a/web/src/components/design-system/table/columns/createUserTableColumn.tsx
+++ b/web/src/components/design-system/table/columns/createUserTableColumn.tsx
@@ -1,6 +1,5 @@
import { type CellContext, type RowData } from "@tanstack/react-table";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
import {
Avatar,
AvatarFallback,
@@ -48,10 +47,10 @@ export function createUserTableColumn<
variant === "avatar" ? (
<div className="flex items-center space-x-2">
<Skeleton className="h-7 w-7 shrink-0 rounded-full" />
- <TableTextLoadingCell />
+ <Skeleton className="h-4 w-1/2" />
</div>
) : (
- <TableTextLoadingCell />
+ <Skeleton className="h-4 w-1/2" />
);
return createTableColumn<TData, TValue>({
diff --git a/web/src/components/table/DataTable.stories.tsx b/web/src/components/table/DataTable.stories.tsx
index dd4d1e6083..6efb5e3ff2 100644
--- a/web/src/components/table/DataTable.stories.tsx
+++ b/web/src/components/table/DataTable.stories.tsx
@@ -40,10 +40,6 @@ import {
import { formatAsLabel, LevelSymbols } from "@/src/components/level-colors";
import TagList from "@/src/features/tag/components/TagList";
import { BreakdownTooltip } from "@/src/features/traces/components/BreakdownTooltip";
-import {
- TableBadgeLoadingCell,
- TableTextLoadingCell,
-} from "@/src/components/table/loading-cells";
import {
DropdownMenu,
DropdownMenuContent,
@@ -321,7 +317,7 @@ function buildTraceColumns(
id: "levelCounts",
header: "Observation Levels",
size: 150,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value = row.original.levelCounts;
const counts: LevelCount[] = Object.entries(value).map(
@@ -340,7 +336,7 @@ function buildTraceColumns(
header: "Latency",
size: 100,
enableSorting: true,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value = row.original.latency;
return value !== undefined ? (
@@ -353,7 +349,7 @@ function buildTraceColumns(
header: "Tokens",
id: "tokens",
size: 180,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value = row.original.usage;
if (!value.inputUsage && !value.outputUsage && !value.totalUsage) {
@@ -380,7 +376,7 @@ function buildTraceColumns(
id: "totalCost",
header: "Total Cost",
size: 130,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const cost = row.original.totalCost;
return cost != null ? (
@@ -403,7 +399,7 @@ function buildTraceColumns(
header: "Environment",
id: "environment",
size: 150,
- loadingCell: <TableBadgeLoadingCell />,
+ loadingCell: <Skeleton className="h-5 w-16 shrink-0 rounded-sm" />,
cell: ({ row }) => {
const value = row.original.environment;
return value ? (
diff --git a/web/src/components/table/data-table.tsx b/web/src/components/table/data-table.tsx
index 302d6b93df..a614449e83 100644
--- a/web/src/components/table/data-table.tsx
+++ b/web/src/components/table/data-table.tsx
@@ -18,7 +18,7 @@ import {
type RowHeight,
getRowHeightTailwindClass,
} from "@/src/components/table/data-table-row-height-switch";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
type DataTableCellBackground,
type DataTableCellPadding,
@@ -885,8 +885,9 @@ function TableBodyComponent<TData>({
}
return (
- <TableTextLoadingCell
+ <Skeleton
className={cn(
+ "h-4 w-1/2",
"min-w-[3rem]",
(rowIndex + columnIndex) % 4 === 0 && "w-3/4",
(rowIndex + columnIndex) % 4 === 1 && "w-1/2",
diff --git a/web/src/components/table/loading-cells.tsx b/web/src/components/table/loading-cells.tsx
deleted file mode 100644
index 7ac76cf66f..0000000000
--- a/web/src/components/table/loading-cells.tsx
+++ /dev/null
@@ -1,45 +0,0 @@
-/* eslint-disable @repo/no-style-props */
-import { Skeleton } from "@/src/components/ui/skeleton";
-import { cn } from "@/src/utils/tailwind";
-
-export function TableCheckboxLoadingCell({
- className,
-}: {
- className?: string;
-}) {
- return <Skeleton className={cn("h-4 w-4 shrink-0 rounded-sm", className)} />;
-}
-
-export function TableIconButtonLoadingCell({
- className,
- size = "xs",
-}: {
- className?: string;
- size?: "xs" | "default";
-}) {
- return (
- <Skeleton
- className={cn(
- "shrink-0 rounded-full",
- size === "xs" ? "h-5 w-5" : "h-7 w-7",
- className,
- )}
- />
- );
-}
-
-export function TableIconBadgeLoadingCell({
- className,
-}: {
- className?: string;
-}) {
- return <Skeleton className={cn("h-5 w-6 shrink-0 rounded-md", className)} />;
-}
-
-export function TableBadgeLoadingCell({ className }: { className?: string }) {
- return <Skeleton className={cn("h-5 w-16 shrink-0 rounded-sm", className)} />;
-}
-
-export function TableTextLoadingCell({ className }: { className?: string }) {
- return <Skeleton className={cn("h-4 w-1/2", className)} />;
-}
diff --git a/web/src/components/table/use-cases/observations.tsx b/web/src/components/table/use-cases/observations.tsx
index 00f672da55..77146404b8 100644
--- a/web/src/components/table/use-cases/observations.tsx
+++ b/web/src/components/table/use-cases/observations.tsx
@@ -48,7 +48,7 @@ import { transformFiltersForBackend } from "@/src/features/filters/lib/filter-tr
import { sortOptionValues } from "@/src/features/filters/lib/option-sort";
import { formatIntervalSeconds } from "@/src/utils/dates";
import useColumnVisibility from "@/src/features/column-visibility/hooks/useColumnVisibility";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import { cn } from "@/src/utils/tailwind";
import { getLevelColors } from "@/src/components/level-colors";
@@ -999,7 +999,7 @@ export default function ObservationsTable({
enableHiding: true,
defaultHidden: true,
cell: () => {
- return isColumnLoading ? <TableTextLoadingCell /> : null;
+ return isColumnLoading ? <Skeleton className="h-4 w-1/2" /> : null;
},
columns: scoreColumns,
},
@@ -1072,7 +1072,9 @@ export default function ObservationsTable({
enableHiding: true,
defaultHidden: true,
cell: () => {
- return generations.isPending ? <TableTextLoadingCell /> : null;
+ return generations.isPending ? (
+ <Skeleton className="h-4 w-1/2" />
+ ) : null;
},
columns: [
createNumberTableColumn<ObservationsTableRow>({
@@ -1127,7 +1129,9 @@ export default function ObservationsTable({
enableHiding: true,
defaultHidden: true,
cell: () => {
- return generations.isPending ? <TableTextLoadingCell /> : null;
+ return generations.isPending ? (
+ <Skeleton className="h-4 w-1/2" />
+ ) : null;
},
columns: [
{
@@ -1135,7 +1139,7 @@ export default function ObservationsTable({
id: "inputCost",
header: "Input Cost",
size: 120,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: {
inputCost: number | undefined;
@@ -1157,7 +1161,7 @@ export default function ObservationsTable({
id: "outputCost",
header: "Output Cost",
size: 120,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: {
inputCost: number | undefined;
diff --git a/web/src/components/table/use-cases/scores.tsx b/web/src/components/table/use-cases/scores.tsx
index 290adc1d70..36f4a3c41b 100644
--- a/web/src/components/table/use-cases/scores.tsx
+++ b/web/src/components/table/use-cases/scores.tsx
@@ -6,7 +6,7 @@ import {
DataTableControlsProvider,
DataTableControls,
} from "@/src/components/table/data-table-controls";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import { createBadgeTableColumn } from "@/src/components/design-system/table/columns/createBadgeTableColumn";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createLinkTableColumn } from "@/src/components/design-system/table/columns/createLinkTableColumn";
@@ -673,10 +673,11 @@ export default function ScoresTable({
size: 250,
enableHiding: true,
defaultHidden: true,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
- if (isBetaEnabled && !scoreMetrics.data)
- return <TableTextLoadingCell />;
+ if (isBetaEnabled && !scoreMetrics.data) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
const traceTags: string[] | undefined = row.getValue("traceTags");
return (
traceTags &&
diff --git a/web/src/components/table/use-cases/sessions.tsx b/web/src/components/table/use-cases/sessions.tsx
index 65f97de2cf..89c650faf0 100644
--- a/web/src/components/table/use-cases/sessions.tsx
+++ b/web/src/components/table/use-cases/sessions.tsx
@@ -4,7 +4,7 @@ import {
DataTableControlsProvider,
DataTableControls,
} from "@/src/components/table/data-table-controls";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import { createBadgeTableColumn } from "@/src/components/design-system/table/columns/createBadgeTableColumn";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createLinkTableColumn } from "@/src/components/design-system/table/columns/createLinkTableColumn";
@@ -549,7 +549,7 @@ export default function SessionsTable({
enableHiding: true,
defaultHidden: true,
cell: () => {
- return isColumnLoading ? <TableTextLoadingCell /> : null;
+ return isColumnLoading ? <Skeleton className="h-4 w-1/2" /> : null;
},
columns: scoreColumns,
},
@@ -685,7 +685,7 @@ export default function SessionsTable({
size: 220,
enableHiding: true,
enableSorting: true,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const promptTokens: SessionTableRow["inputTokens"] =
row.getValue("inputTokens");
@@ -694,7 +694,7 @@ export default function SessionsTable({
const totalTokens: SessionTableRow["totalTokens"] =
row.getValue("totalTokens");
if (!sessionMetrics.isSuccess) {
- return <TableTextLoadingCell />;
+ return <Skeleton className="h-4 w-1/2" />;
}
return (
<TokenUsageBadge
@@ -713,11 +713,11 @@ export default function SessionsTable({
size: 250,
enableHiding: true,
defaultHidden: true,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: SessionTableRow["traceTags"] = row.getValue("traceTags");
if (!sessionMetrics.isSuccess) {
- return <TableTextLoadingCell />;
+ return <Skeleton className="h-4 w-1/2" />;
}
return (
value &&
diff --git a/web/src/components/table/use-cases/traces.tsx b/web/src/components/table/use-cases/traces.tsx
index 41f1e50402..0c95b16b81 100644
--- a/web/src/components/table/use-cases/traces.tsx
+++ b/web/src/components/table/use-cases/traces.tsx
@@ -4,7 +4,7 @@ import {
DataTableControlsProvider,
DataTableControls,
} from "@/src/components/table/data-table-controls";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import { createBadgeTableColumn } from "@/src/components/design-system/table/columns/createBadgeTableColumn";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createNumberTableColumn } from "@/src/components/design-system/table/columns/createNumberTableColumn";
@@ -744,11 +744,13 @@ export default function TracesTable({
id: "levelCounts",
header: "Observation Levels",
size: 150,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: TracesTableRow["levelCounts"] =
row.getValue("levelCounts");
- if (isMetricPending(row.original.id)) return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
const counts: LevelCount[] = Object.entries(value).map(
([level, count]) => ({
@@ -768,10 +770,12 @@ export default function TracesTable({
header: "Latency",
size: 100,
// add seconds to the end of the latency
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: TracesTableRow["latency"] = row.getValue("latency");
- if (isMetricPending(row.original.id)) return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
return value !== undefined ? (
<span className="text-nowrap">{formatIntervalSeconds(value)}</span>
) : undefined;
@@ -785,10 +789,12 @@ export default function TracesTable({
header: "Tokens",
id: "tokens",
size: 180,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: TracesTableRow["usage"] = row.getValue("usage");
- if (isMetricPending(row.original.id)) return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
if (!value.inputUsage && !value.outputUsage && !value.totalUsage) {
return null;
}
@@ -815,10 +821,12 @@ export default function TracesTable({
id: "totalCost",
header: "Total Cost",
size: 130,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const cost: TracesTableRow["totalCost"] = row.getValue("totalCost");
- if (isMetricPending(row.original.id)) return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
return cost != null ? (
<BreakdownTooltip details={row.original.costDetails ?? []} isCost>
<div className="flex items-center gap-1">
@@ -918,7 +926,9 @@ export default function TracesTable({
enableHiding: true,
defaultHidden: true,
cell: () => {
- return isColumnLoading ? <TableTextLoadingCell /> : null;
+ return isColumnLoading ? (
+ <Skeleton className="h-4 w-1/2" />
+ ) : null;
},
columns: scoreColumns,
},
@@ -1002,11 +1012,13 @@ export default function TracesTable({
},
enableHiding: true,
defaultHidden: true,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: TracesTableRow["observationCount"] =
row.getValue("observationCount");
- if (isMetricPending(row.original.id)) return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
return <span>{numberFormatter(value, 0)}</span>;
},
},
@@ -1015,10 +1027,12 @@ export default function TracesTable({
id: "level",
header: "Status",
size: 75,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: TracesTableRow["level"] = row.getValue("level");
- if (isMetricPending(row.original.id)) return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
return value ? (
<span
className={cn(
@@ -1115,7 +1129,9 @@ export default function TracesTable({
enableHiding: true,
defaultHidden: true,
cell: () => {
- return traceMetrics.isPending ? <TableTextLoadingCell /> : null;
+ return traceMetrics.isPending ? (
+ <Skeleton className="h-4 w-1/2" />
+ ) : null;
},
columns: [
createNumberTableColumn<TracesTableRow>({
@@ -1157,7 +1173,9 @@ export default function TracesTable({
enableHiding: true,
defaultHidden: true,
cell: () => {
- return traceMetrics.isPending ? <TableTextLoadingCell /> : null;
+ return traceMetrics.isPending ? (
+ <Skeleton className="h-4 w-1/2" />
+ ) : null;
},
columns: [
{
@@ -1165,11 +1183,12 @@ export default function TracesTable({
id: "inputTokens",
header: "Input Tokens",
size: 110,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: TracesTableRow["usage"] = row.getValue("usage");
- if (isMetricPending(row.original.id))
- return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
return <span>{numberFormatter(value.inputUsage, 0)}</span>;
},
enableHiding: true,
@@ -1181,11 +1200,12 @@ export default function TracesTable({
id: "outputTokens",
header: "Output Tokens",
size: 110,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: TracesTableRow["usage"] = row.getValue("usage");
- if (isMetricPending(row.original.id))
- return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
return <span>{numberFormatter(value.outputUsage, 0)}</span>;
},
enableHiding: true,
@@ -1197,11 +1217,12 @@ export default function TracesTable({
id: "totalTokens",
header: "Total Tokens",
size: 110,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: TracesTableRow["usage"] = row.getValue("usage");
- if (isMetricPending(row.original.id))
- return <TableTextLoadingCell />;
+ if (isMetricPending(row.original.id)) {
+ return <Skeleton className="h-4 w-1/2" />;
+ }
return <span>{numberFormatter(value.totalUsage, 0)}</span>;
},
enableHiding: true,
diff --git a/web/src/features/evals/components/evaluator-table.tsx b/web/src/features/evals/components/evaluator-table.tsx
index 3c17e38cc8..bfd2cfacf9 100644
--- a/web/src/features/evals/components/evaluator-table.tsx
+++ b/web/src/features/evals/components/evaluator-table.tsx
@@ -52,11 +52,6 @@ import {
useEvaluatorTableData,
} from "@/src/features/evals/hooks/useEvaluatorTableData";
import Spinner from "@/src/components/design-system/Spinner/Spinner";
-import {
- TableBadgeLoadingCell,
- TableIconButtonLoadingCell,
- TableTextLoadingCell,
-} from "@/src/components/table/loading-cells";
import { usePostHogClientCapture } from "@/src/features/posthog-analytics/usePostHogClientCapture";
import { useV4UpgradeUiEnabled } from "@/src/features/v4-migration/useV4UpgradeUiEnabled";
import { V4MigrationBadgeContent } from "@/src/features/v4-migration/V4MigrationBadgeContent";
@@ -215,7 +210,7 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
id: "status",
enableSorting: true,
size: 80,
- loadingCell: <TableBadgeLoadingCell />,
+ loadingCell: <Skeleton className="h-5 w-16 shrink-0 rounded-sm" />,
cell: (row) => {
const status = row.getValue();
return (
@@ -287,8 +282,8 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
size: 200,
loadingCell: (
<div className="flex items-center gap-2">
- <TableTextLoadingCell className="w-32" />
- <TableBadgeLoadingCell className="w-6" />
+ <Skeleton className="h-4 w-32" />
+ <Skeleton className="h-5 w-6 shrink-0 rounded-sm" />
</div>
),
cell: ({ row }) => {
@@ -373,7 +368,7 @@ export default function EvaluatorTable({ projectId }: { projectId: string }) {
id: "actions",
enableSorting: false,
size: 100,
- loadingCell: <TableIconButtonLoadingCell />,
+ loadingCell: <Skeleton className="h-5 w-5 shrink-0 rounded-full" />,
cell: ({ row }) => {
const id = row.original.id;
return (
diff --git a/web/src/features/events/components/EventsTable.tsx b/web/src/features/events/components/EventsTable.tsx
index 17bc015c31..007a941524 100644
--- a/web/src/features/events/components/EventsTable.tsx
+++ b/web/src/features/events/components/EventsTable.tsx
@@ -36,7 +36,7 @@ import {
buildTracePath,
} from "@langfuse/shared";
import { formatIntervalSeconds } from "@/src/utils/dates";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import { createBadgeTableColumn } from "@/src/components/design-system/table/columns/createBadgeTableColumn";
import { createDateTableColumn } from "@/src/components/design-system/table/columns/createDateTableColumn";
import { createDurationTableColumn } from "@/src/components/design-system/table/columns/createDurationTableColumn";
@@ -1275,7 +1275,7 @@ export default function ObservationsEventsTable({
defaultHidden: true,
cell: () => {
return observations.status === "loading" ? (
- <TableTextLoadingCell />
+ <Skeleton className="h-4 w-1/2" />
) : null;
},
columns: [
@@ -1284,7 +1284,7 @@ export default function ObservationsEventsTable({
id: "inputCost",
header: getEventsColumnName("inputCost"),
size: 120,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value = row.getValue("cost") as {
inputCost: number | undefined;
@@ -1306,7 +1306,7 @@ export default function ObservationsEventsTable({
id: "outputCost",
header: getEventsColumnName("outputCost"),
size: 120,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value = row.getValue("cost") as {
inputCost: number | undefined;
@@ -1369,7 +1369,7 @@ export default function ObservationsEventsTable({
defaultHidden: true,
cell: () => {
return observations.status === "loading" ? (
- <TableTextLoadingCell />
+ <Skeleton className="h-4 w-1/2" />
) : null;
},
columns: [
@@ -1482,7 +1482,7 @@ export default function ObservationsEventsTable({
enableHiding: true,
defaultHidden: true,
cell: () => {
- return isColumnLoading ? <TableTextLoadingCell /> : null;
+ return isColumnLoading ? <Skeleton className="h-4 w-1/2" /> : null;
},
columns: scoreColumns,
},
diff --git a/web/src/features/monitors/components/MonitorsTable.tsx b/web/src/features/monitors/components/MonitorsTable.tsx
index 4bdd7bf072..ba2a109894 100644
--- a/web/src/features/monitors/components/MonitorsTable.tsx
+++ b/web/src/features/monitors/components/MonitorsTable.tsx
@@ -8,10 +8,10 @@ import { useMediaQuery } from "react-responsive";
import { DeleteMonitorButton } from "@/src/components/deleteButton";
import { DataTable } from "@/src/components/table/data-table";
import { DataTableControls } from "@/src/components/table/data-table-controls";
-import { TableBadgeLoadingCell } from "@/src/components/table/loading-cells";
import { ResizableFilterLayout } from "@/src/components/table/resizable-filter-layout";
import { type LangfuseColumnDef } from "@/src/components/table/types";
import { Button } from "@/src/components/ui/button";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
DropdownMenu,
DropdownMenuContent,
@@ -166,7 +166,7 @@ export function MonitorsTable() {
size: 100,
minSize: 100,
maxSize: 100,
- loadingCell: <TableBadgeLoadingCell className="h-6 w-20" />,
+ loadingCell: <Skeleton className="h-6 w-20 shrink-0 rounded-sm" />,
cell: ({ row }) => (
<MonitorSeverityBadge severity={row.original.severity} />
),
diff --git a/web/src/features/table/components/TableSelectionManager.tsx b/web/src/features/table/components/TableSelectionManager.tsx
index 2760a4b6fb..07e010a541 100644
--- a/web/src/features/table/components/TableSelectionManager.tsx
+++ b/web/src/features/table/components/TableSelectionManager.tsx
@@ -1,6 +1,6 @@
import { useRef, type RefObject } from "react";
-import { TableCheckboxLoadingCell } from "@/src/components/table/loading-cells";
import { Checkbox } from "@/src/components/design-system/Checkbox/Checkbox";
+import { Skeleton } from "@/src/components/ui/skeleton";
import {
type TableSelectionStoreLike,
useTableRowIsSelected,
@@ -206,7 +206,7 @@ export function TableSelectionManager<TData>({
size: 35,
isFixedPosition: true,
isPinnedLeft: true,
- loadingCell: <TableCheckboxLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-4 shrink-0 rounded-sm" />,
header: ({ table }: { table: Table<TData> }) => (
<SelectionHeaderCheckbox
table={table}
diff --git a/web/src/pages/project/[projectId]/users/index.tsx b/web/src/pages/project/[projectId]/users/index.tsx
index 77496eb8b5..b2db0c7f9c 100644
--- a/web/src/pages/project/[projectId]/users/index.tsx
+++ b/web/src/pages/project/[projectId]/users/index.tsx
@@ -9,7 +9,7 @@ import {
} from "use-query-params";
import { DataTableToolbar } from "@/src/components/table/data-table-toolbar";
import { DataTable } from "@/src/components/table/data-table";
-import { TableTextLoadingCell } from "@/src/components/table/loading-cells";
+import { Skeleton } from "@/src/components/ui/skeleton";
import { createBadgeTableColumn } from "@/src/components/design-system/table/columns/createBadgeTableColumn";
import { createLinkTableColumn } from "@/src/components/design-system/table/columns/createLinkTableColumn";
import { type LangfuseColumnDef } from "@/src/components/table/types";
@@ -325,11 +325,11 @@ const UsersTable = ({
description: "The earliest trace recorded for this user.",
},
size: 150,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: RowData["firstEvent"] = row.getValue("firstEvent");
if (!userMetrics.isSuccess) {
- return <TableTextLoadingCell />;
+ return <Skeleton className="h-4 w-1/2" />;
}
return typeof value === "string" ? value : undefined;
},
@@ -341,11 +341,11 @@ const UsersTable = ({
description: "The latest trace recorded for this user.",
},
size: 150,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: RowData["lastEvent"] = row.getValue("lastEvent");
if (!userMetrics.isSuccess) {
- return <TableTextLoadingCell />;
+ return <Skeleton className="h-4 w-1/2" />;
}
return typeof value === "string" ? value : undefined;
},
@@ -359,11 +359,11 @@ const UsersTable = ({
href: "https://langfuse.com/docs/observability/data-model",
},
size: 120,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: RowData["totalEvents"] = row.getValue("totalEvents");
if (!userMetrics.isSuccess) {
- return <TableTextLoadingCell />;
+ return <Skeleton className="h-4 w-1/2" />;
}
return typeof value === "string" ? value : undefined;
},
@@ -377,11 +377,11 @@ const UsersTable = ({
href: "https://langfuse.com/docs/model-usage-and-cost",
},
size: 120,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: RowData["totalTokens"] = row.getValue("totalTokens");
if (!userMetrics.isSuccess) {
- return <TableTextLoadingCell />;
+ return <Skeleton className="h-4 w-1/2" />;
}
return typeof value === "string" ? value : undefined;
},
@@ -394,11 +394,11 @@ const UsersTable = ({
href: "https://langfuse.com/docs/model-usage-and-cost",
},
size: 120,
- loadingCell: <TableTextLoadingCell />,
+ loadingCell: <Skeleton className="h-4 w-1/2" />,
cell: ({ row }) => {
const value: RowData["totalCost"] = row.getValue("totalCost");
if (!userMetrics.isSuccess) {
- return <TableTextLoadingCell />;
+ return <Skeleton className="h-4 w-1/2" />;
}
return typeof value === "string" ? value : undefined;
},