🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): remap leaked tracing orderBy on prompts list (#16986)
cursor[bot]e663c869eca5
diff --git a/web/src/__tests__/server/orderByToPrisma.servertest.ts b/web/src/__tests__/server/orderByToPrisma.servertest.tsindex af624b383e..af46581901 100644--- a/web/src/__tests__/server/orderByToPrisma.servertest.ts+++ b/web/src/__tests__/server/orderByToPrisma.servertest.ts@@ -10,6 +10,7 @@ import {import {InvalidRequestError,normalizeOrderByForTable,+ promptsTableCols,scoresTableCols,tracesTableCols,} from "@langfuse/shared";@@ -56,6 +57,30 @@ describe("orderByToPrisma (Convert orderBy to Prisma.sql)", () => {).toEqual({ column: "createdAt", order: "ASC" });});+ test("prompts list remaps leaked startTime orderBy onto createdAt", () => {+ expect(() =>+ orderByToPrismaSql(+ { column: "startTime", order: "DESC" },+ promptsTableCols,+ ),+ ).toThrow(InvalidRequestError);++ expect(+ orderByToPrismaSql(+ normalizeOrderByForTable({+ orderBy: { column: "startTime", order: "DESC" },+ expectedTimeColumn: "createdAt",+ }),+ promptsTableCols,+ ),+ ).toEqual(+ orderByToPrismaSql(+ { column: "createdAt", order: "DESC" },+ promptsTableCols,+ ),+ );+ });+test("orderByToClickhouseSql throws InvalidRequestError for invalid columns", () => {expect(() =>orderByToClickhouseSql(diff --git a/web/src/__tests__/server/prompts-trpc.servertest.ts b/web/src/__tests__/server/prompts-trpc.servertest.tsindex c23e1bed3c..93f10ccf9b 100644--- a/web/src/__tests__/server/prompts-trpc.servertest.ts+++ b/web/src/__tests__/server/prompts-trpc.servertest.ts@@ -170,6 +170,20 @@ describe("prompts trpc", () => {});},);++ it("accepts leaked tracing time-column orderBy aliases", async () => {+ const { project, caller } = await prepare();++ await expect(+ caller.prompts.all({+ projectId: project.id,+ page: 0,+ limit: 10,+ filter: [],+ orderBy: { column: "startTime", order: "DESC" },+ }),+ ).resolves.toMatchObject({ prompts: [], totalCount: 0 });+ });});describe("prompts.importBulk", () => {diff --git a/web/src/features/prompts/components/prompts-table.tsx b/web/src/features/prompts/components/prompts-table.tsxindex cc818fb764..de57a48146 100644--- a/web/src/features/prompts/components/prompts-table.tsx+++ b/web/src/features/prompts/components/prompts-table.tsx@@ -1,4 +1,5 @@import { useEffect, useMemo } from "react";+import { normalizeOrderByForTable } from "@langfuse/shared";import { DataTable } from "@/src/components/table/data-table";import {DataTableControlsProvider,@@ -85,6 +86,10 @@ export function PromptTable() {column: "createdAt",order: "DESC",});+ const orderBy = normalizeOrderByForTable({+ orderBy: orderByState,+ expectedTimeColumn: "createdAt",+ });const {paginationState,@@ -109,7 +114,7 @@ export function PromptTable() {limit: paginationState.pageSize,projectId,filter: filterState,- orderBy: orderByState,+ orderBy,pathPrefix: currentFolderPath,searchQuery: searchQuery || undefined,searchType: searchType,@@ -377,7 +382,7 @@ export function PromptTable() {limit: 50,projectId,filter: filterState,- orderBy: orderByState,+ orderBy,}}/>);@@ -478,7 +483,7 @@ export function PromptTable() {})),}}- orderBy={orderByState}+ orderBy={orderBy}setOrderBy={setOrderByState}pagination={{totalCount,diff --git a/web/src/features/prompts/server/routers/promptRouter.ts b/web/src/features/prompts/server/routers/promptRouter.tsindex abd04fc24c..cc0c8025b7 100644--- a/web/src/features/prompts/server/routers/promptRouter.ts+++ b/web/src/features/prompts/server/routers/promptRouter.ts@@ -31,6 +31,7 @@ import {TracingSearchType,orderBy,singleFilter,+ normalizeOrderByForTable,} from "@langfuse/shared";import {orderByToPrismaSql,@@ -117,7 +118,10 @@ export const promptRouter = createTRPCRouter({});const orderByCondition = orderByToPrismaSql(- input.orderBy,+ normalizeOrderByForTable({+ orderBy: input.orderBy,+ expectedTimeColumn: "createdAt",+ }),promptsTableCols,);