Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(experiments): read non-propagated experiment attribute from experiment root span (#17473)

marliessophieecb58a305f61
diff --git a/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.test.ts b/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.test.ts
index f64a6dc46e..5159b3166e 100644
--- a/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.test.ts
+++ b/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.test.ts
@@ -5,6 +5,7 @@ import {
EventsAggregationQueryBuilder,
EventsQueryBuilder,
EventsSessionAggregationQueryBuilder,
+ ExperimentsAggregationQueryBuilder,
} from "./event-query-builder";
describe("EventsQueryBuilder public API v2 field groups", () => {
@@ -221,3 +222,17 @@ describe("buildEventsFullTableSplitQuery", () => {
);
});
});
+
+describe("ExperimentsAggregationQueryBuilder", () => {
+ it("reads non propagated experiment-level attributes from experiment item root spans", () => {
+ const { query } = new ExperimentsAggregationQueryBuilder({
+ projectId: "test-project",
+ })
+ .selectFieldSet("base")
+ .buildWithParams();
+
+ expect(query).toContain(
+ "anyIf(e.experiment_description, e.span_id = e.experiment_item_root_span_id) AS experiment_description",
+ );
+ });
+});
diff --git a/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.ts b/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.ts
index b62dbf5643..5849a558cc 100644
--- a/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.ts
+++ b/packages/shared/src/server/queries/clickhouse-sql/event-query-builder.ts
@@ -1963,7 +1963,7 @@ const EXPERIMENTS_AGGREGATION_FIELDS = {
experimentId: "e.experiment_id AS experiment_id",
experimentName: "any(e.experiment_name) AS experiment_name",
experimentDescription:
- "any(e.experiment_description) AS experiment_description",
+ "anyIf(e.experiment_description, e.span_id = e.experiment_item_root_span_id) AS experiment_description",
experimentDatasetId:
"nullIf(any(e.experiment_dataset_id), '') AS experiment_dataset_id",
startTime: "min(e.start_time) AS start_time",
diff --git a/web/src/__tests__/server/repositories/experiment-repository.servertest.ts b/web/src/__tests__/server/repositories/experiment-repository.servertest.ts
index c1526bf98f..d8c9b19ac1 100644
--- a/web/src/__tests__/server/repositories/experiment-repository.servertest.ts
+++ b/web/src/__tests__/server/repositories/experiment-repository.servertest.ts
@@ -280,6 +280,68 @@ describe("Clickhouse Experiment Repository Test", () => {
expect(experiment?.errorCount).toBe(1);
});
+ it("should read description from experiment item root spans", async () => {
+ const experimentId = randomUUID();
+ const experimentName = "root-attributes-experiment-" + randomUUID();
+ const experimentDescription = "root-description-" + randomUUID();
+ const experimentDatasetId = randomUUID();
+ const experimentItemId = randomUUID();
+ const traceId = randomUUID();
+ const rootSpanId = randomUUID();
+
+ const childEvent = createEvent({
+ id: randomUUID(),
+ span_id: randomUUID(),
+ project_id: projectId,
+ trace_id: traceId,
+ type: "SPAN",
+ name: "child-span-without-optional-experiment-attributes",
+ experiment_id: experimentId,
+ experiment_name: experimentName,
+ experiment_metadata_names: ["application", "source"],
+ experiment_metadata_values: ["example-agent", "remote-trigger"],
+ experiment_description: null,
+ experiment_dataset_id: experimentDatasetId,
+ experiment_item_id: experimentItemId,
+ experiment_item_version: null,
+ experiment_item_metadata_names: [],
+ experiment_item_metadata_values: [],
+ experiment_item_root_span_id: rootSpanId,
+ });
+
+ const rootEvent = createEvent({
+ id: rootSpanId,
+ span_id: rootSpanId,
+ project_id: projectId,
+ trace_id: traceId,
+ type: "SPAN",
+ name: "experiment-item-root-span",
+ experiment_id: experimentId,
+ experiment_name: experimentName,
+ experiment_metadata_names: ["application", "source"],
+ experiment_metadata_values: ["example-agent", "remote-trigger"],
+ experiment_description: experimentDescription,
+ experiment_dataset_id: experimentDatasetId,
+ experiment_item_id: experimentItemId,
+ experiment_item_version: null,
+ experiment_item_metadata_names: [],
+ experiment_item_metadata_values: [],
+ experiment_item_root_span_id: rootSpanId,
+ });
+
+ await createEventsCh([childEvent, rootEvent]);
+
+ const result = await getExperimentsFromEvents({
+ projectId,
+ filter: [],
+ limit: 1000,
+ page: 0,
+ });
+
+ const experiment = result.find((entry) => entry.id === experimentId);
+ expect(experiment?.description).toBe(experimentDescription);
+ });
+
it("should order by startTime DESC", async () => {
const experimentId1 = randomUUID();
const experimentName1 = "experiment-1-" + randomUUID();